From d4e1ac708e0ccec3a363f8471f4069de48d4f9bf Mon Sep 17 00:00:00 2001 From: mgroves <mgroves@telligent.com> Date: Tue, 12 Apr 2011 21:54:21 -0400 Subject: [PATCH] issue from Amazon AppStore team - casing in ticker could cause duplicate tickers (and crashing), fixed to always uppercase tickers when saving & checking for duplication --- .../PortfolioRepositories/AndroidSqlitePortfolioRepository.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MonoStockPortfolio.Core/PortfolioRepositories/AndroidSqlitePortfolioRepository.cs b/MonoStockPortfolio.Core/PortfolioRepositories/AndroidSqlitePortfolioRepository.cs index 1b98fbf..187b8af 100644 --- a/MonoStockPortfolio.Core/PortfolioRepositories/AndroidSqlitePortfolioRepository.cs +++ b/MonoStockPortfolio.Core/PortfolioRepositories/AndroidSqlitePortfolioRepository.cs @@ -118,7 +118,7 @@ namespace MonoStockPortfolio.Core.PortfolioRepositories public bool IsTickerAlreadyBeingTracked(string ticker, long portfolioId) { var cursor = Db.RawQuery("SELECT 1 FROM " + POSITION_TABLE_NAME + " WHERE Ticker = ? AND ContainingPortfolioID = ?", - new[] { ticker, portfolioId.ToString() }); + new[] { ticker.ToUpper(), portfolioId.ToString() }); var result = cursor.Count > 0; if(!cursor.IsClosed) cursor.Close(); return result; @@ -189,7 +189,7 @@ namespace MonoStockPortfolio.Core.PortfolioRepositories { var positionValues = new ContentValues(); positionValues.Put("PricePerShare", (double)position.PricePerShare); - positionValues.Put("Ticker", position.Ticker); + positionValues.Put("Ticker", position.Ticker.ToUpper()); positionValues.Put("Shares", (double)position.Shares); positionValues.Put("ContainingPortfolioID", position.ContainingPortfolioID); return positionValues;