fixed presence['type'] w/ show value bug and added test to prove

This commit is contained in:
Nathan Fritz 2010-01-23 01:08:21 -08:00
parent 65dd83d4e1
commit 3dbd496de8
2 changed files with 14 additions and 12 deletions

View file

@ -15,7 +15,6 @@ class Presence(RootStanza):
return self.xml.find("{%s}show" % self.namespace) return self.xml.find("{%s}show" % self.namespace)
def setType(self, value): def setType(self, value):
if value in self.types:
show = self.getShowElement() show = self.getShowElement()
if value in self.types: if value in self.types:
if show is not None: if show is not None:
@ -26,6 +25,7 @@ class Presence(RootStanza):
elif value in self.showtypes: elif value in self.showtypes:
if show is None: if show is None:
show = ET.Element("{%s}show" % self.namespace) show = ET.Element("{%s}show" % self.namespace)
self.xml.append(show)
show.text = value show.text = value
return self return self

View file

@ -16,6 +16,7 @@ class testoverall(unittest.TestCase):
"""Invoking the tabnanny""" """Invoking the tabnanny"""
import tabnanny import tabnanny
self.failIf(tabnanny.check("." + os.sep + 'sleekxmpp')) self.failIf(tabnanny.check("." + os.sep + 'sleekxmpp'))
#raise "Help!"
def testMethodLength(self): def testMethodLength(self):
"""Testing for excessive method lengths""" """Testing for excessive method lengths"""
@ -62,4 +63,5 @@ if __name__ == '__main__':
#sys.modules[modname].config = moduleconfig #sys.modules[modname].config = moduleconfig
alltests.append(sys.modules[modname].suite) alltests.append(sys.modules[modname].suite)
alltests_suite = unittest.TestSuite(alltests) alltests_suite = unittest.TestSuite(alltests)
unittest.TextTestRunner(verbosity=2).run(alltests_suite) result = unittest.TextTestRunner(verbosity=2).run(alltests_suite)
print("""<tests xmlns='http://andyet.net/protocol/tests' ran='%s' errors='%s' fails='%s' success='%s' />""" % (result.testsRun, len(result.errors), len(result.failures), result.wasSuccessful()))