github/codereview
1
0
Fork 0
mirror of https://github.com/correl/codereview.git synced 2024-12-26 19:16:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

Ensured comments are displayed only on the lines they were created for

Browse source
This commit is contained in:
Correl Roush 2010-12-17 13:29:27 -05:00
parent 247888aff0
commit 0c29fa19fe
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
templates/components/diff.html
View file

@ -19,17 +19,16 @@
<td class="text">{{ change.text }}</td>
</tr>
{# TODO: Load in annotations somehow #}
{% if review %}
{% for comment in review.comment_set.all %}
{% if change.type != '+' and change.line_a == comment.line_a or change_type != '-' and change.line_b == comment.line_b %}
<tr class="annotation">
<td colspan="3">
{% include "components/comment.html" %}
</td>
</tr>
{% endif %}
{% endfor %}
{% for comment in review.comment_set.all %}
{% if change.type == '+' and change.line_b == comment.line_b or change.type == '-' and change.line_a == comment.line_a or change.line_a == comment.line_a and change.line_b == comment.line_b %}
<tr class="annotation">
<td colspan="3">
{% include "components/comment.html" %}
</td>
</tr>
{% endif %}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}