Adding unit testing for the poker app

git-svn-id: file:///srv/svn/euler@2 e5f4c3ec-3c0c-11df-b522-21efaa4426b5

054/e054.py

@@ -1,5 +1,10 @@
 import operator
 
+class InvalidCard(Exception):
+    pass
+class InvalidHand(Exception):
+    pass
+
 class PokerCard:
     values = {'T': 10, 'J': 11, 'Q': 12, 'K': 13, 'A': 14}
     def __init__(self, string):
@@ -7,8 +12,13 @@ class PokerCard:
         if self.value in '23456789':
             self.value = int(self.value)
         else:
-            self.value = PokerCard.values[self.value]
+            try:
+                self.value = PokerCard.values[self.value]
+            except KeyError as e:
+                raise InvalidCard
         self.suit = string[1]
+        if not self.suit in ['H', 'C', 'S', 'D']:
+            raise InvalidCard
     @staticmethod
     def compare(a, b):
         if a.value > b.value:
@@ -118,28 +128,29 @@ class PokerHand:
                     return result
         return result
 
-wins = 0
+if __name__ == '__main__':
-counter = 0
+    wins = 0
-with open('poker.txt', 'r') as f:
+    counter = 0
-    while True:
+    with open('poker.txt', 'r') as f:
-        line = f.readline()
+        while True:
-        if not line:
+            line = f.readline()
-            break
+            if not line:
-        counter = counter + 1
+                break
-        cards = line.strip().split()
+            counter = counter + 1
-        one = PokerHand(cards[:5])
+            cards = line.strip().split()
-        two = PokerHand(cards[-5:])
+            one = PokerHand(cards[:5])
-        result = PokerHand.compare(one, two)
+            two = PokerHand(cards[-5:])
-        if result > 0:
+            result = PokerHand.compare(one, two)
-            wins = wins + 1
+            if result > 0:
-            outcome = 'Player One wins'
+                wins = wins + 1
-        elif result == 0:
+                outcome = 'Player One wins'
-            outcome = 'Tie'
+            elif result == 0:
-        else:
+                outcome = 'Tie'
-            outcome = 'Player Two wins'
+            else:
-        print "Hand #{0}: {1}\n {2}\n {3}".format(
+                outcome = 'Player Two wins'
-            counter,
+            print "Hand #{0}: {1}\n {2}\n {3}".format(
-            outcome,
+                counter,
-            one,
+                outcome,
-            two)
+                one,
-print "Player one won {0} hands".format(wins)
+                two)
+    print "Player one won {0} hands".format(wins)

054/test.py

@@ -0,0 +1,28 @@
+from e054 import *
+import unittest
+
+class TestCards(unittest.TestCase):
+    def setUp(self):
+        pass
+    def test_valid_number_card(self):
+        card = PokerCard('9D')
+        self.assertEqual(card.value, 9)
+    def test_valid_face_card(self):
+        card = PokerCard('QH')
+        self.assertEqual(card.value, 12)
+    def test_invalid_card_value(self):
+        self.assertRaises(InvalidCard, PokerCard, 'ZH')
+    def test_invalid_card_suit(self):
+        self.assertRaises(InvalidCard, PokerCard, '9Z')
+    def test_compare(self):
+        cards = ['QH', '9D', 'JS']
+        cards_sorted = sorted([PokerCard(c) for c in cards], cmp=PokerCard.compare, reverse=True)
+        self.assertEqual([c.value for c in cards_sorted], [12, 11, 9])
+
+class TestHands(unittest.TestCase):
+    def setUp(self):
+        pass
+    
+
+if __name__ == '__main__':
+    unittest.main()