github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2024-11-14 19:19:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

More sensible parameter ordering

Browse source
This commit is contained in:
xenohedron 2023-05-20 23:56:49 -04:00
parent 0bc473f4b2
commit 26a95eed51
5 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Mage.Sets/src/mage/cards/c/ChimericMass.java
View file

@ -38,7 +38,7 @@ public final class ChimericMass extends CardImpl {
.withType(CardType.ARTIFACT)
.withSubType(SubType.CONSTRUCT)
.withAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new SetBasePowerToughnessSourceEffect(new CountersSourceCount(CounterType.CHARGE)))),
"", Duration.EndOfTurn, false, true, false), new GenericManaCost(1)));
"", Duration.EndOfTurn, false, false, true), new GenericManaCost(1)));
}
private ChimericMass(final ChimericMass card) {

2
Mage.Sets/src/mage/cards/c/ChromiumTheMutable.java
View file

@ -47,7 +47,7 @@ public final class ChromiumTheMutable extends CardImpl {
Ability ability = new SimpleActivatedAbility(
new BecomesCreatureSourceEffect(
new ChromiumTheMutableToken(), null, Duration.EndOfTurn,
false, false, true
false, true, false
).setText("Until end of turn, {this} becomes "
+ "a Human with base power and toughness 1/1, "
+ "loses all abilities, and gains hexproof"),

2
Mage.Sets/src/mage/cards/m/MonumentToPerfection.java
View file

@ -63,7 +63,7 @@ public final class MonumentToPerfection extends CardImpl {
.withAbility(IndestructibleAbility.getInstance())
.withAbility(new ToxicAbility(9)),
null, Duration.Custom, true,
false, true
true, false
), new GenericManaCost(3), MonumentToPerfectionCondition.instance
).addHint(MonumentToPerfectionValue.getHint()));
}

2
Mage.Sets/src/mage/cards/s/SvogthosTheRestlessTomb.java
View file

@ -33,7 +33,7 @@ public final class SvogthosTheRestlessTomb extends CardImpl {
this.addAbility(new ColorlessManaAbility());
// {3}{B}{G}: Until end of turn, Svogthos, the Restless Tomb becomes a black and green Plant Zombie creature with "This creature's power and toughness are each equal to the number of creature cards in your graveyard." It's still a land.
// set to character defining to prevent setting P/T again to 0 becuase already set by CDA of the token
Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new BecomesCreatureSourceEffect(new SvogthosToken(), "land", Duration.EndOfTurn, false, true, false), new ManaCostsImpl<>("{3}{B}{G}"));
Ability ability = new SimpleActivatedAbility(Zone.BATTLEFIELD, new BecomesCreatureSourceEffect(new SvogthosToken(), "land", Duration.EndOfTurn, false, false, true), new ManaCostsImpl<>("{3}{B}{G}"));
this.addAbility(ability);
}

14
Mage/src/main/java/mage/abilities/effects/common/continuous/BecomesCreatureSourceEffect.java
View file

@ -42,14 +42,14 @@ public class BecomesCreatureSourceEffect extends ContinuousEffectImpl implements
}
/**
@param token Token as blueprint for creature to become
@param theyAreStillType String for rules text generation
@param duration Duration for the effect
@param losePreviousTypes if true, permanent loses its previous types
@param characterDefining if true, effect applies on layer 7a (it probably shouldn't)
@param loseAbilities if true, permanent loses its other abilities
* @param token Token as blueprint for creature to become
* @param theyAreStillType String for rules text generation
* @param duration Duration for the effect
* @param losePreviousTypes if true, permanent loses its previous types
* @param loseAbilities if true, permanent loses its other abilities
* @param characterDefining if true, effect applies on layer 7a (it probably shouldn't)
*/
public BecomesCreatureSourceEffect(Token token, String theyAreStillType, Duration duration, boolean losePreviousTypes, boolean characterDefining, boolean loseAbilities) {
public BecomesCreatureSourceEffect(Token token, String theyAreStillType, Duration duration, boolean losePreviousTypes, boolean loseAbilities, boolean characterDefining) {
super(duration, Outcome.BecomeCreature);
this.characterDefining = characterDefining;
this.token = token;