github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2024-11-24 19:19:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Some improvements to verify test

Browse source
This commit is contained in:
xenohedron 2023-05-23 23:02:07 -04:00
parent c7994cb3ac
commit 36b1c56543
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -500,7 +500,9 @@ public class VerifyCardDataTest {
if (mageSet == null) { if (mageSet == null) {
missingSets = missingSets + 1; missingSets = missingSets + 1;
missingCards = missingCards + refSet.cards.size(); missingCards = missingCards + refSet.cards.size();
info.add("Warning: missing set " + refSet.code + " - " + refSet.name + " (cards: " + refSet.cards.size() + ", date: " + refSet.releaseDate + ")"); if (!CHECK_ONLY_ABILITIES_TEXT) {
info.add("Warning: missing set " + refSet.code + " - " + refSet.name + " (cards: " + refSet.cards.size() + ", date: " + refSet.releaseDate + ")");
}
continue; continue;
} }
@ -1563,7 +1565,7 @@ public class VerifyCardDataTest {
MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber()); MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber());
if (ref != null) { if (ref != null) {
checkAll(card, ref, cardIndex); checkAll(card, ref, cardIndex);
} else { } else if (!CHECK_ONLY_ABILITIES_TEXT) {
warn(card, "Can't find card in mtgjson to verify"); warn(card, "Can't find card in mtgjson to verify");
} }
} }
@ -1574,9 +1576,6 @@ public class VerifyCardDataTest {
private static boolean wasCheckedByAbilityText(MtgJsonCard ref) { private static boolean wasCheckedByAbilityText(MtgJsonCard ref) {
// ignore already checked cards, so no bloated logs from duplicated cards // ignore already checked cards, so no bloated logs from duplicated cards
if (CHECK_ONLY_ABILITIES_TEXT) {
return true;
}
if (checkedNames.contains(ref.getNameAsFace())) { if (checkedNames.contains(ref.getNameAsFace())) {
return true; return true;
} }
@ -1941,13 +1940,13 @@ public class VerifyCardDataTest {
} }
}*/ }*/
private static final boolean compareText(String cardText, String refText, String name) { private static boolean compareText(String cardText, String refText, String name) {
return cardText.equals(refText) return cardText.equals(refText)
|| cardText.replace(name, name.split(", ")[0]).equals(refText) || cardText.replace(name, name.split(", ")[0]).equals(refText)
|| cardText.replace(name, name.split(" ")[0]).equals(refText); || cardText.replace(name, name.split(" ")[0]).equals(refText);
} }
private static final boolean checkForEffect(Card card, Class<? extends Effect> effectClazz) { private static boolean checkForEffect(Card card, Class<? extends Effect> effectClazz) {
return card.getAbilities() return card.getAbilities()
.stream() .stream()
.map(Ability::getModes) .map(Ability::getModes)
@ -1968,10 +1967,9 @@ public class VerifyCardDataTest {
private void checkWrongAbilitiesTextEnd() { private void checkWrongAbilitiesTextEnd() {
// TODO: implement tests result/stats by github actions to show in check message compared to prev version // TODO: implement tests result/stats by github actions to show in check message compared to prev version
System.out.println(String.format("")); System.out.println(String.format(""));
System.out.println(String.format("Ability text checks ends with stats:")); System.out.println(String.format("Stats for %d cards checked for abilities text:", wrongAbilityStatsTotal));
System.out.println(String.format(" - total: %d (%.2f)", wrongAbilityStatsTotal, 100.0)); System.out.println(String.format(" - Cards with correct text: %5d (%.2f)", wrongAbilityStatsGood, wrongAbilityStatsGood * 100.0 / wrongAbilityStatsTotal));
System.out.println(String.format(" - good: %d (%.2f)", wrongAbilityStatsGood, wrongAbilityStatsGood * 100.0 / wrongAbilityStatsTotal)); System.out.println(String.format(" - Cards with text errors: %5d (%.2f)", wrongAbilityStatsBad, wrongAbilityStatsBad * 100.0 / wrongAbilityStatsTotal));
System.out.println(String.format(" - bad: %d (%.2f)", wrongAbilityStatsBad, wrongAbilityStatsBad * 100.0 / wrongAbilityStatsTotal));
System.out.println(String.format("")); System.out.println(String.format(""));
} }