github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2025-01-11 19:13:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't call setText() on the popup text component until it is shown

Browse source 
Performance improvement, impacts profiles.
This commit is contained in:
draxdyn 2016-06-01 16:44:35 +02:00
parent 9513b5bf74
commit 415c8cce7e
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Mage.Client/src/main/java/mage/client/plugins/adapters/MageActionCallback.java
View file

@ -155,6 +155,7 @@ public class MageActionCallback implements ActionCallback {
}
data.locationOnScreen = data.component.getLocationOnScreen();
}
data.popupText.updateText();
tooltipPopup = factory.getPopup(data.component, data.popupText, (int) data.locationOnScreen.getX() + data.popupOffsetX, (int) data.locationOnScreen.getY() + data.popupOffsetY + 40);
tooltipPopup.show();
// hack to get popup to resize to fit text

14
Mage.Common/src/mage/cards/TextPopup.java
View file

@ -39,6 +39,8 @@ package mage.cards;
* @author BetaSteward_at_googlemail.com
*/
public class TextPopup extends javax.swing.JPanel {
private String text;
private boolean needsUpdate;
/** Creates new form TextPopup */
public TextPopup() {
@ -46,7 +48,17 @@ public class TextPopup extends javax.swing.JPanel {
}
public void setText(String text) {
popupText.setText(text);
if(!text.equals(this.text)) {
this.text = text;
this.needsUpdate = true;
}
}
public void updateText() {
if(this.needsUpdate) {
popupText.setText(this.text);
this.needsUpdate = false;
}
}
/** This method is called from within the constructor to