github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2025-01-12 03:00:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

* GUI: improved ability picker dialog for double sides, split and adventure cards (if one side is playable then you can see ability name before play/cast it, see #7361);

Browse source
This commit is contained in:
Oleg Agafonov 2021-02-03 08:52:31 +04:00
parent cc03cbbb67
commit 5077a82585
1 changed files with 26 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
Mage.Server.Plugins/Mage.Player.Human/src/mage/player/human/HumanPlayer.java
View file

@ -11,9 +11,7 @@ import mage.abilities.effects.RequirementEffect;
import mage.abilities.hint.HintUtils;
import mage.abilities.mana.ActivatedManaAbilityImpl;
import mage.abilities.mana.ManaAbility;
import mage.cards.Card;
import mage.cards.Cards;
import mage.cards.ModalDoubleFacesCardHalf;
import mage.cards.*;
import mage.cards.decks.Deck;
import mage.choices.Choice;
import mage.choices.ChoiceImpl;
@ -43,6 +41,7 @@ import mage.target.TargetPermanent;
import mage.target.common.TargetAnyTarget;
import mage.target.common.TargetAttackingCreature;
import mage.target.common.TargetDefender;
import mage.util.CardUtil;
import mage.util.GameLog;
import mage.util.ManaUtil;
import mage.util.MessageToClient;
@ -1992,15 +1991,39 @@ public class HumanPlayer extends PlayerImpl {
}
}
/**
* Hide ability picker dialog on one available ability to activate
*
* @param ability
* @param game
* @return
*/
private boolean suppressAbilityPicker(ActivatedAbility ability, Game game) {
if (getControllingPlayersUserData(game).isShowAbilityPickerForced()) {
// user activated an ability picker in preferences
// force to show ability picker for double faces cards in hand/commander/exile and other zones
Card mainCard = game.getCard(CardUtil.getMainCardId(game, ability.getSourceId()));
if (mainCard != null && !Zone.BATTLEFIELD.equals(game.getState().getZone(mainCard.getId()))) {
if (mainCard instanceof SplitCard
|| mainCard instanceof AdventureCard
|| mainCard instanceof ModalDoubleFacesCard) {
return false;
}
}
// hide on land play
if (ability instanceof PlayLandAbility) {
return true;
}
// hide on alternative cost activated
if (!getCastSourceIdWithAlternateMana().contains(ability.getSourceId())
&& ability.getManaCostsToPay().convertedManaCost() > 0) {
return true;
}
// hide on mana activate and show all other
return ability instanceof ActivatedManaAbilityImpl;
}
return true;