github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2024-11-28 19:19:55 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Some minor fixed and log changes.

Browse source
This commit is contained in:
LevelX2 2017-04-25 17:37:38 +02:00
parent 9a21b55d39
commit 60cc3a7622
9 changed files with 90 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Mage.Server/src/main/java/mage/server/MageServerImpl.java
View file

@ -636,7 +636,8 @@ public class MageServerImpl implements MageServer {
}
});
} else {
logger.error("table not found : " + tableId);
// this can happen if a game ends and a player quits XMage or a match nearly at the same time as the game ends
logger.trace("table not found : " + tableId);
}
return true;
}

20
Mage.Server/src/main/java/mage/server/Session.java
View file

@ -27,6 +27,11 @@
*/
package mage.server;
import java.util.*;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantLock;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import mage.MageException;
import mage.constants.Constants;
import mage.interfaces.callback.ClientCallback;
@ -44,12 +49,6 @@ import org.jboss.remoting.callback.Callback;
import org.jboss.remoting.callback.HandleCallbackException;
import org.jboss.remoting.callback.InvokerCallbackHandler;
import java.util.*;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.ReentrantLock;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/**
* @author BetaSteward_at_googlemail.com
*/
@ -218,8 +217,8 @@ public class Session {
if (authorizedUser.lockedUntil.compareTo(Calendar.getInstance().getTime()) > 0) {
return "Your profile is deactivated until " + SystemUtil.dateFormat.format(authorizedUser.lockedUntil);
} else {
UserManager.instance.createUser(userName, host, authorizedUser).ifPresent(user ->
user.setLockedUntil(null)
UserManager.instance.createUser(userName, host, authorizedUser).ifPresent(user
-> user.setLockedUntil(null)
);
}
@ -263,7 +262,6 @@ public class Session {
ChatManager.instance.sendReconnectMessage(userId);
}
return null;
}
@ -337,7 +335,7 @@ public class Session {
lockSet = true;
logger.debug("SESSION LOCK SET sessionId: " + sessionId);
} else {
logger.error("CAN'T GET LOCK - userId: " + userId + " hold count: " + lock.getHoldCount());
logger.warn("CAN'T GET LOCK - userId: " + userId + " hold count: " + lock.getHoldCount());
}
Optional<User> _user = UserManager.instance.getUser(userId);
if (!_user.isPresent()) {
@ -393,7 +391,7 @@ public class Session {
call.setMessageId(messageId++);
callbackHandler.handleCallbackOneway(new Callback(call));
} catch (HandleCallbackException ex) {
ex.printStackTrace();
// ex.printStackTrace();
UserManager.instance.getUser(userId).ifPresent(user -> {
logger.warn("SESSION CALLBACK EXCEPTION - " + user.getName() + " userId " + userId);
logger.warn(" - method: " + call.getMethod());

4
Mage.Server/src/main/java/mage/server/SessionManager.java
View file

@ -144,8 +144,10 @@ public enum SessionManager {
case LostConnection: // user lost connection - session expires countdaoun starts
session.userLostConnection();
break;
case ConnectingOtherInstance:
break;
default:
logger.error("endSession: unexpected reason " + reason.toString() + " - sessionId: " + sessionId);
logger.trace("endSession: unexpected reason " + reason.toString() + " - sessionId: " + sessionId);
}
} else {
sessions.remove(sessionId);

6
Mage.Sets/src/mage/cards/t/TorrentialGearhulk.java
View file

@ -50,6 +50,7 @@ import mage.game.events.ZoneChangeEvent;
import mage.players.Player;
import mage.target.common.TargetCardInYourGraveyard;
import mage.target.targetpointer.FixedTarget;
import org.apache.log4j.Logger;
/**
*
@ -111,7 +112,7 @@ class TorrentialGearhulkEffect extends OneShotEffect {
Player controller = game.getPlayer(source.getControllerId());
if (controller != null) {
Card card = game.getCard(this.getTargetPointer().getFirst(game, source));
if (card != null) {
if (card != null && card.getSpellAbility() != null) {
if (controller.chooseUse(outcome, "Cast " + card.getLogName() + '?', source, game)) {
if (controller.cast(card.getSpellAbility(), game, true)) {
ContinuousEffect effect = new TorrentialGearhulkReplacementEffect(card.getId());
@ -119,6 +120,9 @@ class TorrentialGearhulkEffect extends OneShotEffect {
game.addEffect(effect, source);
}
}
} else {
Logger.getLogger(TorrentialGearhulkEffect.class).error("Torrential Gearhulk - Instant card without spellAbility : " + card.getName());
return false;
}
return true;
}

33
Mage.Tests/src/test/java/org/mage/test/cards/abilities/other/EndTurnEffectTest.java
View file

@ -108,4 +108,37 @@ public class EndTurnEffectTest extends CardTestPlayerBase {
assertHandCount(playerB, 0);
}
/**
* Test to remove a Aftermath card from spell
*/
@Test
public void testSpellAftermath() {
addCard(Zone.BATTLEFIELD, playerA, "Mountain", 2);
// Insult Sorcery {2}{R}
// Damage can't be prevented this turn. If a source you control would deal damage this turn, it deals double that damage instead.
// Injury Sorcery {2}{R}
// Aftermath (Cast this spell only from your graveyard. Then exile it.)
// Injury deals 2 damage to target creature and 2 damage to target player.
addCard(Zone.GRAVEYARD, playerA, "Insult // Injury");
addCard(Zone.BATTLEFIELD, playerB, "Mountain", 3);
// End the turn.
// At the beginning of your next end step, you lose the game.
addCard(Zone.HAND, playerB, "Glorious End"); //Instant {2}{R}
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Injury", "Silvercoat Lion");
addTarget(playerA, playerB);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Glorious End", NO_TARGET, "Injury");
setStopAt(1, PhaseStep.BEGIN_COMBAT);
execute();
assertExileCount(playerA, "Insult // Injury", 1);
assertGraveyardCount(playerB, "Glorious End", 0);
assertHandCount(playerA, 0);
assertHandCount(playerB, 0);
}
}

5
Mage/src/main/java/mage/abilities/common/LicidAbility.java
View file

@ -27,6 +27,7 @@
*/
package mage.abilities.common;
import java.util.ArrayList;
import java.util.UUID;
import mage.abilities.Ability;
import mage.abilities.ActivatedAbilityImpl;
@ -144,14 +145,16 @@ class LicidContinuousEffect extends ContinuousEffectImpl {
licid.getSubtype(game).add("Aura");
break;
case AbilityAddingRemovingEffects_6:
ArrayList<Ability> toRemove = new ArrayList<>();
for (Ability ability : licid.getAbilities(game)) {
for (Effect effect : ability.getEffects()) {
if (effect instanceof LicidEffect) {
licid.getAbilities(game).remove(ability);
toRemove.add(ability);
break;
}
}
}
licid.getAbilities(game).removeAll(toRemove);
Ability ability = new EnchantAbility("creature");
ability.setRuleAtTheTop(true);
licid.addAbility(ability, source.getSourceId(), game);

3
Mage/src/main/java/mage/abilities/effects/ContinuousEffects.java
View file

@ -1218,9 +1218,12 @@ public class ContinuousEffects implements Serializable {
}
}
} else {
if (!(entry.getKey() instanceof AuraReplacementEffect)
&& !(entry.getKey() instanceof PlaneswalkerRedirectionEffect)) {
logger.error("Replacement effect without ability: " + entry.getKey().toString());
}
}
}
return texts;
}

14
Mage/src/main/java/mage/abilities/effects/common/counter/RemoveCounterTargetEffect.java
View file

@ -25,7 +25,6 @@
* authors and should not be interpreted as representing official policies, either expressed
* or implied, of BetaSteward_at_googlemail.com.
*/
package mage.abilities.effects.common.counter;
import java.util.HashSet;
@ -47,8 +46,8 @@ import mage.util.CardUtil;
*
* @author LevelX2
*/
public class RemoveCounterTargetEffect extends OneShotEffect {
private final Counter counter;
public RemoveCounterTargetEffect() {
@ -73,19 +72,21 @@ public class RemoveCounterTargetEffect extends OneShotEffect {
Counter toRemove = (counter == null ? selectCounterType(game, source, p) : counter);
if (toRemove != null && p.getCounters(game).getCount(toRemove.getName()) >= toRemove.getCount()) {
p.removeCounters(toRemove.getName(), toRemove.getCount(), game);
if(!game.isSimulation())
if (!game.isSimulation()) {
game.informPlayers("Removed " + toRemove.getCount() + ' ' + toRemove.getName()
+ " counter from " + p.getName());
}
return true;
}
}
Card c = game.getCard(targetPointer.getFirst(game, source));
if (c != null && counter != null && c.getCounters(game).getCount(counter.getName()) >= counter.getCount()) {
c.removeCounters(counter.getName(), counter.getCount(), game);
if (!game.isSimulation())
if (!game.isSimulation()) {
game.informPlayers(new StringBuilder("Removed ").append(counter.getCount()).append(' ').append(counter.getName())
.append(" counter from ").append(c.getName())
.append(" (").append(c.getCounters(game).getCount(counter.getName())).append(" left)").toString());
}
return true;
}
return false;
@ -133,12 +134,11 @@ public class RemoveCounterTargetEffect extends OneShotEffect {
String text = "remove ";
if (counter == null) {
text += "a counter";
}
else {
} else {
text += CardUtil.numberToText(counter.getCount(), "a") + ' ' + counter.getName();
text += counter.getCount() > 1 ? " counters" : " counter";
}
text += " from target " + mode.getTargets().get(0).getTargetName();
text += " from target " + (mode.getTargets().isEmpty() ? " object" : mode.getTargets().get(0).getTargetName());
return text;
}
}

2
Mage/src/main/java/mage/game/turn/Turn.java
View file

@ -276,7 +276,7 @@ public class Turn implements Serializable {
setEndTurnRequested(true);
// 1) All spells and abilities on the stack are exiled. This includes Time Stop, though it will continue to resolve.
// 1) All spells and abilities on the stack are exiled. This includes (e.g.) Time Stop, though it will continue to resolve.
// It also includes spells and abilities that can't be countered.
while (!game.getStack().isEmpty()) {
StackObject stackObject = game.getStack().peekFirst();