Moved effect from framework to card implementation

(only one card used it and very few cards can use it)
Also some small refactoring.
This commit is contained in:
North 2011-06-24 23:42:03 +03:00
parent 92e9d94c33
commit 84c1fbccdc
5 changed files with 65 additions and 99 deletions

View file

@ -32,21 +32,26 @@ import java.util.UUID;
import mage.Constants;
import mage.Constants.CardType;
import mage.Constants.Duration;
import mage.Constants.Rarity;
import mage.abilities.effects.common.continious.GainProtectionFromColorOrArtifactsTargetEffect;
import mage.abilities.Ability;
import mage.abilities.effects.common.continious.GainAbilityTargetEffect;
import mage.abilities.keyword.ProtectionAbility;
import mage.cards.CardImpl;
import mage.choices.ChoiceColorOrArtifact;
import mage.filter.FilterPermanent;
import mage.filter.Filter.ComparisonScope;
import mage.filter.FilterCard;
import mage.filter.common.FilterControlledPermanent;
import mage.game.Game;
import mage.game.permanent.Permanent;
import mage.target.common.TargetControlledPermanent;
import org.apache.log4j.spi.Filter;
/**
*
* @author Loki
*/
public class ApostlesBlessing extends CardImpl<ApostlesBlessing> {
private static FilterControlledPermanent filter = new FilterControlledPermanent("artifact or creature you control");
private static final FilterControlledPermanent filter = new FilterControlledPermanent("artifact or creature you control");
static {
filter.getCardType().add(CardType.ARTIFACT);
@ -58,7 +63,7 @@ public class ApostlesBlessing extends CardImpl<ApostlesBlessing> {
super(ownerId, 2, "Apostle's Blessing", Rarity.COMMON, new CardType[]{CardType.INSTANT}, "{1}{WP}");
this.expansionSetCode = "NPH";
this.color.setWhite(true);
this.getSpellAbility().addEffect(new GainProtectionFromColorOrArtifactsTargetEffect(Constants.Duration.EndOfTurn));
this.getSpellAbility().addEffect(new ApostlesBlessingEffect(Duration.EndOfTurn));
this.getSpellAbility().addTarget(new TargetControlledPermanent(filter));
this.getSpellAbility().addChoice(new ChoiceColorOrArtifact());
}
@ -73,3 +78,51 @@ public class ApostlesBlessing extends CardImpl<ApostlesBlessing> {
}
}
class ApostlesBlessingEffect extends GainAbilityTargetEffect {
FilterCard protectionFilter;
public ApostlesBlessingEffect(Duration duration) {
super(new ProtectionAbility(new FilterCard()), duration);
protectionFilter = (FilterCard)((ProtectionAbility)ability).getFilter();
}
public ApostlesBlessingEffect(final ApostlesBlessingEffect effect) {
super(effect);
this.protectionFilter = effect.protectionFilter.copy();
}
@Override
public ApostlesBlessingEffect copy() {
return new ApostlesBlessingEffect(this);
}
@Override
public boolean apply(Game game, Ability source) {
ChoiceColorOrArtifact choice = (ChoiceColorOrArtifact) source.getChoices().get(0);
if (choice.isArtifactSelected()) {
protectionFilter.getCardType().add(Constants.CardType.ARTIFACT);
protectionFilter.setScopeCardType(ComparisonScope.Any);
} else {
protectionFilter.setColor(choice.getColor());
protectionFilter.setUseColor(true);
protectionFilter.setScopeColor(ComparisonScope.Any);
}
protectionFilter.setMessage(choice.getChoice());
Permanent creature = game.getPermanent(source.getFirstTarget());
if (creature != null) {
creature.addAbility(ability);
return true;
}
return false;
}
@Override
public String getText(Ability source) {
return "target " + source.getTargets().get(0).getTargetName() + " gains protection from artifacts or from the color of your choice " + duration.toString();
}
}

View file

@ -92,6 +92,7 @@ public abstract class EffectImpl<T extends Effect<T>> implements Effect<T> {
return effectType;
}
@Override
public void setTargetPointer(TargetPointer targetPointer) {
this.targetPointer = targetPointer;
}

View file

@ -28,6 +28,7 @@
package mage.abilities.effects.common;
import java.util.List;
import mage.Constants.Outcome;
import mage.abilities.Ability;
import mage.abilities.dynamicvalue.DynamicValue;
@ -68,7 +69,8 @@ public class DamageAllEffect extends OneShotEffect<DamageAllEffect> {
@Override
public boolean apply(Game game, Ability source) {
for (Permanent permanent: game.getBattlefield().getActivePermanents(filter, source.getControllerId(), game)) {
List<Permanent> permanents = game.getBattlefield().getActivePermanents(filter, source.getControllerId(), game);
for (Permanent permanent: permanents) {
permanent.damage(amount.calculate(game, source), source.getId(), game, true, false);
}
return true;

View file

@ -28,6 +28,7 @@
package mage.abilities.effects.common;
import java.util.List;
import java.util.UUID;
import mage.Constants.Outcome;
import mage.abilities.Ability;
@ -62,7 +63,8 @@ public class DamageEverythingEffect extends OneShotEffect<DamageEverythingEffect
@Override
public boolean apply(Game game, Ability source) {
for (Permanent permanent: game.getBattlefield().getActivePermanents(new FilterCreaturePermanent(), source.getControllerId(), game)) {
List<Permanent> permanents = game.getBattlefield().getActivePermanents(new FilterCreaturePermanent(), source.getControllerId(), game);
for (Permanent permanent: permanents) {
permanent.damage(amount, source.getId(), game, true, false);
}
for (UUID playerId: game.getPlayer(source.getControllerId()).getInRange()) {

View file

@ -1,92 +0,0 @@
/*
* Copyright 2010 BetaSteward_at_googlemail.com. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without modification, are
* permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice, this list of
* conditions and the following disclaimer.
*
* 2. Redistributions in binary form must reproduce the above copyright notice, this list
* of conditions and the following disclaimer in the documentation and/or other materials
* provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY BetaSteward_at_googlemail.com ``AS IS'' AND ANY EXPRESS OR IMPLIED
* WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
* FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL BetaSteward_at_googlemail.com OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
* ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* The views and conclusions contained in the software and documentation are those of the
* authors and should not be interpreted as representing official policies, either expressed
* or implied, of BetaSteward_at_googlemail.com.
*/
package mage.abilities.effects.common.continious;
import mage.Constants;
import mage.Constants.Duration;
import mage.abilities.Ability;
import mage.abilities.keyword.ProtectionAbility;
import mage.choices.ChoiceColor;
import mage.choices.ChoiceColorOrArtifact;
import mage.filter.Filter.ComparisonScope;
import mage.filter.FilterCard;
import mage.game.Game;
import mage.game.permanent.Permanent;
/**
*
* @author BetaSteward_at_googlemail.com
*/
public class GainProtectionFromColorOrArtifactsTargetEffect extends GainAbilityTargetEffect {
FilterCard protectionFilter;
public GainProtectionFromColorOrArtifactsTargetEffect(Duration duration) {
super(new ProtectionAbility(new FilterCard()), duration);
protectionFilter = (FilterCard)((ProtectionAbility)ability).getFilter();
}
public GainProtectionFromColorOrArtifactsTargetEffect(final GainProtectionFromColorOrArtifactsTargetEffect effect) {
super(effect);
this.protectionFilter = effect.protectionFilter.copy();
}
@Override
public GainProtectionFromColorOrArtifactsTargetEffect copy() {
return new GainProtectionFromColorOrArtifactsTargetEffect(this);
}
@Override
public boolean apply(Game game, Ability source) {
ChoiceColorOrArtifact choice = (ChoiceColorOrArtifact) source.getChoices().get(0);
if (choice.isArtifactSelected()) {
protectionFilter.getCardType().add(Constants.CardType.ARTIFACT);
protectionFilter.setScopeCardType(ComparisonScope.Any);
} else {
protectionFilter.setColor(choice.getColor());
protectionFilter.setUseColor(true);
protectionFilter.setScopeColor(ComparisonScope.Any);
}
protectionFilter.setMessage(choice.getChoice());
Permanent creature = game.getPermanent(source.getFirstTarget());
if (creature != null) {
creature.addAbility(ability);
return true;
}
return false;
}
@Override
public String getText(Ability source) {
return "target " + source.getTargets().get(0).getTargetName() + " gains protection from artifacts or from the color of your choice " + duration.toString();
}
}