github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2024-11-15 19:19:33 +00:00
Code Issues Projects Releases Packages Wiki Activity

* Flashback - Fixed that spells without mana costs (e.g. Ancestral Vision) wrongly could be cast by flashback (fixes #1510).

Browse source
This commit is contained in:
LevelX2 2016-02-03 00:22:29 +01:00
parent b4d1607568
commit a796fe5adb
2 changed files with 40 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
Mage.Tests/src/test/java/org/mage/test/cards/abilities/keywords/FlashbackTest.java
View file

@ -178,4 +178,40 @@ public class FlashbackTest extends CardTestPlayerBase {
assertExileCount("Conflagrate", 1);
}
/**
* Ancestral Vision has no casting cost (this is different to a casting cost
* of {0}). Snapcaster Mage, for example, is able to give it flashback
* whilst it is in the graveyard.
*
* However the controller should not be able to cast Ancestral Visions from
* the graveyard for {0} mana.
*/
@Test
public void testFlashbackAncestralVision() {
// Suspend 4-{U}
// Target player draws three cards.
addCard(Zone.GRAVEYARD, playerA, "Ancestral Vision", 1);
// Flash
// When Snapcaster Mage enters the battlefield, target instant or sorcery card in your graveyard gains flashback until end of turn. The flashback cost is equal to its mana cost.
addCard(Zone.HAND, playerA, "Snapcaster Mage", 1);
addCard(Zone.BATTLEFIELD, playerA, "Island", 2);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Snapcaster Mage");
addTarget(playerA, "Ancestral Vision");
activateAbility(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Flashback");
addTarget(playerA, playerA);
setStopAt(1, PhaseStep.BEGIN_COMBAT);
execute();
assertHandCount(playerA, "Snapcaster Mage", 0);
assertPermanentCount(playerA, "Snapcaster Mage", 1);
assertGraveyardCount(playerA, "Ancestral Vision", 1);
assertHandCount(playerA, 0);
}
}

4
Mage/src/main/java/mage/abilities/keyword/FlashbackAbility.java
View file

@ -86,6 +86,10 @@ public class FlashbackAbility extends SpellAbility {
if (super.canActivate(playerId, game)) {
Card card = game.getCard(getSourceId());
if (card != null) {
// Cards with no Mana Costs cant't be flashbacked (e.g. Ancestral Vision)
if (card.getManaCost().isEmpty()) {
return false;
}
// Flashback can never cast a split card by Fuse, because Fuse only works from hand
if (card.isSplitCard()) {
if (((SplitCard) card).getLeftHalfCard().getName().equals(abilityName)) {