Oleg Agafonov
169d9bf761
* Non basic mana abilities - fixed rollback errors in AI games ( #6300 );
2020-02-25 12:41:45 +04:00
Ingmar Goudt
ae7919cd07
program towards Interface rather than implementations
2020-02-10 10:40:06 +01:00
Oleg Agafonov
46d5b228cf
Tests: migrate to new mtgjson version
2020-01-22 01:32:03 +04:00
Oleg Agafonov
5157a88dba
Tests: improved logs in verify tests;
2020-01-18 11:00:13 +04:00
Oleg Agafonov
4a004a27b3
Refactor damage with power effect, added checking for wrong targets;
2020-01-13 13:49:40 +04:00
Evan Kranzler
48822c94b8
some oracle updates
2020-01-10 12:33:19 -05:00
Evan Kranzler
81ce0ad1df
temporary test fix
2020-01-07 23:09:57 -05:00
Oleg Agafonov
85e65c8f44
Code cleanup
2020-01-08 05:19:52 +04:00
Oleg Agafonov
ddff795bf8
Tests: added verify test to check double rare cards in new sets;
2020-01-07 20:36:29 +04:00
Oleg Agafonov
0930bdd016
Merge pull request #5690 from magefree/copy_constructor_watchers
...
refactor the copy functionality for no-args watchers
2020-01-02 18:51:37 +01:00
Oleg Agafonov
ed8c3276e1
Tests: add new verify test to check wrong symbols in rules/names;
2020-01-01 14:24:52 +04:00
Ingmar Goudt
ce23f6900d
fix conflicts
2019-12-29 19:28:20 +01:00
Ingmar Goudt
702a1f2498
remove all copy constructors and copy methods for all watchers
2019-12-29 19:18:20 +01:00
Oleg Agafonov
0885a01849
Fixed that TargetCard ignore filter in some calls
2019-12-16 02:55:13 +04:00
Evan Kranzler
c0344015bb
removed test skip for Noble and Warlock creature types
2019-09-30 17:43:10 -04:00
Evan Kranzler
12d8e40368
added additional subtype verification skips
2019-09-27 19:11:45 -04:00
Evan Kranzler
a99afc763d
updated Dread Warlock creature type
2019-09-24 20:07:12 -04:00
Oleg Agafonov
2de535feb2
Tests: improved verify checks for missing/wrong abilities
2019-06-30 22:48:36 +04:00
Oleg Agafonov
77e92d9186
* Fixed that snow lands can be added in draft and sealed modes ( #5831 );
2019-06-06 22:50:16 +04:00
Evan Kranzler
e6396798aa
temporary test skip until mtgjson updates its data
2019-05-29 23:26:54 -04:00
Oleg Agafonov
e80ba6383f
Added verify tests for watchers copy;
2019-05-18 10:58:30 +04:00
Oleg Agafonov
b9b8415c99
Extra tests to catch card creation errors;
2019-05-06 17:03:56 +04:00
Oleg Agafonov
00633ce055
Fixed mtgjson compatibility
2019-04-28 19:08:13 +04:00
Oleg Agafonov
5f07a9aff2
Tests: enable warnings for wrong card texts in WAR set
2019-04-19 08:05:31 +04:00
Thomas Winwood
d28ea98dff
Exempt Thingamajig from mana cost verification
2019-04-12 06:54:10 +01:00
Thomas Winwood
83234762f6
Implement Everythingamajig
2019-04-12 05:56:04 +01:00
Thomas Winwood
5a83b27271
Fix verify bug
2019-04-09 01:13:56 +01:00
Oleg Agafonov
b8782d572d
Tests: added test to check copy() methods removes;
2019-03-30 20:26:35 +04:00
Oleg Agafonov
3454ffbe01
Fixed merge
2019-03-27 16:53:09 +04:00
Oleg Agafonov
490d207efe
Tests: added checks that planeswalkers must be legendary;
2019-03-19 06:27:55 +04:00
Oleg Agafonov
fa75ac2727
Typo fix
2019-03-07 12:14:27 +04:00
Oleg Agafonov
e68b79336a
Typo fix
2019-03-06 14:06:47 +04:00
Oleg Agafonov
29993ebd21
Fixed mtgjson compatibility
2019-02-01 18:59:01 +04:00
Oleg Agafonov
7eba755666
Refactor card ratings, fixed rare error exception "comparison method violates its general contract" (different ratings in same card);
2019-02-01 17:41:29 +04:00
Ingmar Goudt
5b38f4168f
apply try-with for MtgJson
2019-01-19 23:18:16 +01:00
Oleg Agafonov
727165dd3a
Improved verify tests (wip) and showCardInfo for realtime texts test.
2019-01-14 11:01:42 +04:00
Oleg Agafonov
b0e2845b59
Fixed verify tests to ignore mtgjson updates
2019-01-14 06:19:39 +04:00
Oleg Agafonov
5d1289a66e
Merge pull request #5465 from magefree/ui-new-download-window
...
UI: added new download images window
2018-12-21 18:03:55 +04:00
John Hitchings
3d15325448
buildfix for VerifyCardDataTest. mtgjson file was moved, added a few fields, and requires adding a User-Agent to the request.
2018-12-20 17:02:48 -08:00
Oleg Agafonov
4495d75d8a
Fixed NPE error on AI calcs
2018-12-18 17:17:10 +04:00
Oleg Agafonov
d6569b88a6
Updated MtgJson
2018-12-11 16:55:48 +04:00
Oleg Agafonov
a4d797e473
Fixed mtgjson data;
2018-12-07 07:34:38 +04:00
Oleg Agafonov
41a2573319
Fixed wrong MtgJsonV4 data format ( #5415 );
2018-12-07 02:55:27 +04:00
LevelX2
09a5ece9f3
Fixed color check and added missing attribute to verify.
2018-11-27 16:09:43 +01:00
LevelX2
b7ebff4fa1
Fixed verify color check.
2018-11-26 19:01:18 +01:00
Ingmar Goudt
d9b25cbac1
suppert mtgjson v4
2018-11-23 19:22:27 +01:00
Oleg Agafonov
fe3eda4944
* Spell Contortion, Warleader's Helix - fixed wrong card text;
...
Removed unused getRules in cards code;
2018-11-11 22:54:49 +04:00
Oleg Agafonov
8fd6eb6313
Fix merge
2018-10-03 22:43:13 +04:00
Oleg Agafonov
6bb478c342
Tests: added many verify tests for sets and cards, e.g.:
...
* check set's class name/file (source code style);
* check set's hasBasicLands settings (missing lands in deck generation bug);
* check card's UsesVariousArt settings (same image for multi-images card bug);
* check card's missing abilities (forgot addAbility call bug);
* improved output messages;
2018-10-03 22:32:52 +04:00
Oleg Agafonov
69546c82ce
* Added missing images for WPN and Gateway Promos (GRC) set in scryfall source;
2018-10-03 20:32:58 +04:00
Evan Kranzler
11e1d9df38
removed outdated verification skips
2018-09-09 14:07:59 -04:00
Oleg Agafonov
747f3030e2
Added test to check missing abilities
2018-09-05 02:45:01 +04:00
Noah Gleason
8ee7965580
Fix tests
2018-07-07 11:52:38 -04:00
Oleg Agafonov
fb36f329f9
Fixed Dragon Egg tests
2018-06-23 01:19:54 +04:00
Evan Kranzler
ab3cd76d3e
Fixed various potential null pointer exceptions
2018-05-31 21:03:40 -04:00
Evan Kranzler
c3d0297045
Updated Mage Verify test
2018-05-20 21:00:09 -04:00
Oleg Agafonov
4851ba9e84
Test framework: added commands for real time checks/assertions:
...
* new checks: color, subtype, ability, PT, permanent and hand count;
* more info in #4936 ;
2018-05-14 02:31:19 +04:00
Oleg Agafonov
f021951578
Tests: added tokens tests in mage-verify (ignored until massive fixes, run it manually):
...
* check token class name convention (must ends with Token);
* check token package (must be in mage.game.permanent.token);
* check private tokens (must be replaced with CreateToken);
* check missing data from tok-file;
2018-05-11 22:22:02 +04:00
ArcadeMode
5ac975c52e
Blocker and Critical level bugfixes throughout the project ( #4648 )
...
* fixed https://sonarcloud.io/project/issues?id=org.xmage%3Amage-root&issues=AWIlv32RgrzAwlaaQ7rP&open=AWIlv32RgrzAwlaaQ7rP
* ensure closing of scanner if it was opened
* Refactored method in EmpyrialArchAngel to not always return same value.
* Refactored method in FalkenrathAristocrat to not always return same value.
* Refactored method in GilderBairn to not always return the same value.
* fixed left open resources, ensured quiet closing of the streams
* Refactored method in IceCave to not always return same value.
* Refactored method in KjeldoranRoyalGuard to not always return same value.
* Refactored method in LegionsInitiative to not always return same value.
* Refactored method in NaturesWill to not always return same value.
* added quiet closing method in new streamutils class, used to clean up the connectdialog
* Fix small typo
* added quiet closing to saveobjectutil
* closed resources in savegame method of gamecontroller
* properly close resources in loadGame method of GameReplay class
* further proper resource closing in ServerMessagesUtil
* fixed unclosed resources in copy method in mage framework Copier
* closed unclosed resources in copyCompressed method in Copier
* ensure closing of filewriter in manasymbols
* ensure proper closing of Stream in arcane UI
* ensure closing of datagram socket in arcane Util
* ensure resource closing in deckimport from clipboard
* ensure closing of plugin classloader
* ensured closing of zipinputstream resource
* ensure closing of fileoutputstream in ScryfallSymbolsSource
* ensure closing resources after finishing/canceling download of pictures
* remove commented code
* move locks to try block to ensure unlocking along all execution paths
* remove dangerous instance of double-checked locking
* removed dangerous instance of double checked locking in settingsmanager
* Removed dangerous instance of double-checked locking in ThemePluginImpl
* close resource which did not happen certainly
* close another stream
* ensure closing of inputstream
2018-03-22 08:13:13 -05:00
LevelX2
b073ce1c42
* Added to all toUpperCase/toLowerCase calls the Locale.ENGLISH to prevent problems with some languages (e.g. Turkish). Removed some unused import statements. ( #4634 ).
2018-03-18 18:18:54 +01:00
Oleg Agafonov
bc3274b144
Test: fixed mage-verify tests
2018-01-15 07:46:31 +04:00
Oleg Agafonov
4771ad2c63
Fixed UGL test, rename new token
2018-01-13 02:27:16 +04:00
Oleg Agafonov
0ba2375ac1
Tests:
...
* added new checks for basic land types/rarity in mage-verify;
* fixed tests for UGL cards in mage-verify (wrong json data)
2018-01-11 20:37:38 +04:00
Oleg Agafonov
60443cdbfe
Updated readme with actual card stats, added stats printing on mage-verify tests
2017-12-29 17:53:12 +04:00
Oleg Agafonov
c4fe9e3121
Tests: added mage-verify warning test for missing sets in xmage (current missing sets: 34 with 1689 cards)
2017-12-29 17:15:00 +04:00
Zzooouhh
6fae8ef606
Merge branch 'master' into master
2017-12-22 23:17:20 +01:00
Oleg Agafonov
a24c61079b
Added new set Pro Tour Promos
2017-12-20 20:14:04 +04:00
Oleg Agafonov
6c86856933
Added tests to verify DB for card numbers typos, duplicate and wrong classes
2017-12-20 16:42:02 +04:00
Zzooouhh
eae526e3b3
Added Verify exception for Infinity Elemental
2017-12-18 22:16:14 +01:00
Oleg Agafonov
36055178bd
- fixed UST - Sword of Dungeons card name;
...
- fixed mage-verify tests for UST set;
2017-12-16 19:58:11 +04:00
Evan Kranzler
0ebe09d468
Reenabled Mage Verify, reverted Ripscale Predator to lizard (for now)
2017-10-04 12:13:22 -04:00
Evan Kranzler
a110b54d91
Setting Mage Verify to ignore until mtgjson is updated with the latest oracle text
2017-10-02 21:26:20 -04:00
ingmargoudt
09f0c9ad97
huge rework on subtypes ( #3668 )
...
* huge rework on subtypes
* update for coat of arms
* fix test
2017-07-16 16:57:39 -05:00
igoudt
11f040b884
use more staticfilters, fix jsoncard class
2017-07-10 12:25:33 +02:00
Timothy Rice
89ee5eeeae
fixed Mistform creature types and verify test for phyrexian mana
2017-04-11 13:58:01 -05:00
fireshoes
55b433ae36
[AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards.
2017-03-28 22:25:29 -05:00
vraskulin
ad7d3c8078
equals "" should be replaced with isEmpty
2017-02-28 11:45:15 +03:00
vraskulin
498c8cf60c
Made utility classes final to explicitly forbid it's inheritance
2017-02-27 17:03:38 +03:00
vraskulin
f60ebfbb1f
All 1-character strings converted to primitives
...
"b" + "r" now changed to 'b' + 'w'. It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
LevelX2
97b872d926
* Fixed that a spell that becomes a permanent didn't had the colors of the spell (e.g. ERsatz Gnomes).
2016-10-22 10:38:10 +02:00
Neil Gentleman
2779f81764
remove tests without assertions
...
- source token checking is very noisy, so disabled it for now
- set verification wasn't showing anything interesting
2016-10-16 12:02:13 -07:00
Neil Gentleman
335950ee8f
actually fail the test on errors
...
explicitly ignoring the one known error in gatherer and all custom sets
2016-10-16 11:57:31 -07:00
Neil Gentleman
510f7a86b6
download the json at runtime
2016-10-16 11:57:26 -07:00
Neil Gentleman
26b8b88963
update verification
...
now using java types instead of Map<String, Object>
2016-10-16 11:56:43 -07:00
Neil Gentleman
584b532598
check card source for unexpected types
...
needs more tuning - very noisy right now
2016-10-16 11:52:10 -07:00
Neil Gentleman
5ad58f59c1
compare cards with mtgjson
2016-10-16 11:49:49 -07:00