Commit graph

95 commits

Author SHA1 Message Date
Oleg Agafonov
a4d797e473 Fixed mtgjson data; 2018-12-07 07:34:38 +04:00
Oleg Agafonov
41a2573319 Fixed wrong MtgJsonV4 data format (#5415); 2018-12-07 02:55:27 +04:00
LevelX2
09a5ece9f3 Fixed color check and added missing attribute to verify. 2018-11-27 16:09:43 +01:00
LevelX2
b7ebff4fa1 Fixed verify color check. 2018-11-26 19:01:18 +01:00
Ingmar Goudt
d9b25cbac1 suppert mtgjson v4 2018-11-23 19:22:27 +01:00
Oleg Agafonov
fe3eda4944 * Spell Contortion, Warleader's Helix - fixed wrong card text;
Removed unused getRules in cards code;
2018-11-11 22:54:49 +04:00
Oleg Agafonov
8fd6eb6313 Fix merge 2018-10-03 22:43:13 +04:00
Oleg Agafonov
6bb478c342 Tests: added many verify tests for sets and cards, e.g.:
* check set's class name/file (source code style);
  * check set's hasBasicLands settings (missing lands in deck generation bug);
  * check card's UsesVariousArt settings (same image for multi-images card bug);
  * check card's missing abilities (forgot addAbility call bug);
  * improved output messages;
2018-10-03 22:32:52 +04:00
Oleg Agafonov
69546c82ce * Added missing images for WPN and Gateway Promos (GRC) set in scryfall source; 2018-10-03 20:32:58 +04:00
Evan Kranzler
11e1d9df38 removed outdated verification skips 2018-09-09 14:07:59 -04:00
Oleg Agafonov
747f3030e2 Added test to check missing abilities 2018-09-05 02:45:01 +04:00
Noah Gleason
8ee7965580
Fix tests 2018-07-07 11:52:38 -04:00
Oleg Agafonov
fb36f329f9 Fixed Dragon Egg tests 2018-06-23 01:19:54 +04:00
Evan Kranzler
ab3cd76d3e Fixed various potential null pointer exceptions 2018-05-31 21:03:40 -04:00
Evan Kranzler
c3d0297045 Updated Mage Verify test 2018-05-20 21:00:09 -04:00
Oleg Agafonov
4851ba9e84 Test framework: added commands for real time checks/assertions:
* new checks: color, subtype, ability, PT, permanent and hand count;
 * more info in #4936;
2018-05-14 02:31:19 +04:00
Oleg Agafonov
f021951578 Tests: added tokens tests in mage-verify (ignored until massive fixes, run it manually):
* check token class name convention (must ends with Token);
 * check token package (must be in mage.game.permanent.token);
 * check private tokens (must be replaced with CreateToken);
 * check missing data from tok-file;
2018-05-11 22:22:02 +04:00
ArcadeMode
5ac975c52e Blocker and Critical level bugfixes throughout the project (#4648)
* fixed https://sonarcloud.io/project/issues?id=org.xmage%3Amage-root&issues=AWIlv32RgrzAwlaaQ7rP&open=AWIlv32RgrzAwlaaQ7rP

* ensure closing of scanner if it was opened

* Refactored method in EmpyrialArchAngel to not always return same value.

* Refactored method in FalkenrathAristocrat to not always return same value.

* Refactored method in GilderBairn to not always return the same value.

* fixed left open resources, ensured quiet closing of the streams

* Refactored method in IceCave to not always return same value.

* Refactored method in KjeldoranRoyalGuard to not always return same value.

* Refactored method in LegionsInitiative to not always return same value.

* Refactored method in NaturesWill to not always return same value.

* added quiet closing method in new streamutils class, used to clean up the connectdialog

* Fix small typo

* added quiet closing to saveobjectutil

* closed resources in savegame method of gamecontroller

* properly close resources in loadGame method of GameReplay class

* further proper resource closing in ServerMessagesUtil

* fixed unclosed resources in copy method in mage framework Copier

* closed unclosed resources in copyCompressed method in Copier

* ensure closing of filewriter in manasymbols

* ensure proper closing of Stream in arcane UI

* ensure closing of datagram socket in arcane Util

* ensure resource closing in deckimport from clipboard

* ensure closing of plugin classloader

* ensured closing of zipinputstream resource

* ensure closing of fileoutputstream in ScryfallSymbolsSource

* ensure closing resources after finishing/canceling download of pictures

* remove commented code

* move locks to try block to ensure unlocking along all execution paths

* remove dangerous instance of double-checked locking

* removed dangerous instance of double checked locking in settingsmanager

* Removed dangerous instance of double-checked locking in ThemePluginImpl

* close resource which did not happen certainly

* close another stream

* ensure closing of inputstream
2018-03-22 08:13:13 -05:00
LevelX2
b073ce1c42 * Added to all toUpperCase/toLowerCase calls the Locale.ENGLISH to prevent problems with some languages (e.g. Turkish). Removed some unused import statements. (#4634). 2018-03-18 18:18:54 +01:00
Oleg Agafonov
bc3274b144 Test: fixed mage-verify tests 2018-01-15 07:46:31 +04:00
Oleg Agafonov
4771ad2c63 Fixed UGL test, rename new token 2018-01-13 02:27:16 +04:00
Oleg Agafonov
0ba2375ac1 Tests:
* added new checks for basic land types/rarity in mage-verify;
 * fixed tests for UGL cards in mage-verify (wrong json data)
2018-01-11 20:37:38 +04:00
Oleg Agafonov
60443cdbfe Updated readme with actual card stats, added stats printing on mage-verify tests 2017-12-29 17:53:12 +04:00
Oleg Agafonov
c4fe9e3121 Tests: added mage-verify warning test for missing sets in xmage (current missing sets: 34 with 1689 cards) 2017-12-29 17:15:00 +04:00
Zzooouhh
6fae8ef606
Merge branch 'master' into master 2017-12-22 23:17:20 +01:00
Oleg Agafonov
a24c61079b Added new set Pro Tour Promos 2017-12-20 20:14:04 +04:00
Oleg Agafonov
6c86856933 Added tests to verify DB for card numbers typos, duplicate and wrong classes 2017-12-20 16:42:02 +04:00
Zzooouhh
eae526e3b3
Added Verify exception for Infinity Elemental 2017-12-18 22:16:14 +01:00
Oleg Agafonov
36055178bd - fixed UST - Sword of Dungeons card name;
- fixed mage-verify tests for UST set;
2017-12-16 19:58:11 +04:00
Evan Kranzler
0ebe09d468 Reenabled Mage Verify, reverted Ripscale Predator to lizard (for now) 2017-10-04 12:13:22 -04:00
Evan Kranzler
a110b54d91 Setting Mage Verify to ignore until mtgjson is updated with the latest oracle text 2017-10-02 21:26:20 -04:00
ingmargoudt
09f0c9ad97 huge rework on subtypes (#3668)
* huge rework on subtypes

* update for coat of arms

* fix test
2017-07-16 16:57:39 -05:00
igoudt
11f040b884 use more staticfilters, fix jsoncard class 2017-07-10 12:25:33 +02:00
Timothy Rice
89ee5eeeae fixed Mistform creature types and verify test for phyrexian mana 2017-04-11 13:58:01 -05:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
vraskulin
ad7d3c8078 equals "" should be replaced with isEmpty 2017-02-28 11:45:15 +03:00
vraskulin
498c8cf60c Made utility classes final to explicitly forbid it's inheritance 2017-02-27 17:03:38 +03:00
vraskulin
f60ebfbb1f All 1-character strings converted to primitives
"b" + "r" now changed to 'b' + 'w'.  It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
LevelX2
97b872d926 * Fixed that a spell that becomes a permanent didn't had the colors of the spell (e.g. ERsatz Gnomes). 2016-10-22 10:38:10 +02:00
Neil Gentleman
2779f81764 remove tests without assertions
- source token checking is very noisy, so disabled it for now
- set verification wasn't showing anything interesting
2016-10-16 12:02:13 -07:00
Neil Gentleman
335950ee8f actually fail the test on errors
explicitly ignoring the one known error in gatherer and all custom sets
2016-10-16 11:57:31 -07:00
Neil Gentleman
510f7a86b6 download the json at runtime 2016-10-16 11:57:26 -07:00
Neil Gentleman
26b8b88963 update verification
now using java types instead of Map<String, Object>
2016-10-16 11:56:43 -07:00
Neil Gentleman
584b532598 check card source for unexpected types
needs more tuning - very noisy right now
2016-10-16 11:52:10 -07:00
Neil Gentleman
5ad58f59c1 compare cards with mtgjson 2016-10-16 11:49:49 -07:00