Commit graph

289 commits

Author SHA1 Message Date
Oleg Agafonov
c2487aec7d [C20] tokens support and fixes:
* Added tokens for C20;
* Added tokens images download for C20;
* Fixed that some tokens uses wrong images or images from wrong set (example: Elemental);
2020-06-15 20:29:52 +04:00
Oleg Agafonov
b5f45f395f Tests: improved showCardInfo to show texts from multiple card names 2020-06-14 04:32:10 +04:00
Evan Kranzler
74b6626020 changed Hound to Dog 2020-06-05 20:17:41 -04:00
Oleg Agafonov
48049dbfc9 Tests: improved verify test for token's constructor; 2020-05-07 20:50:15 +04:00
Evan Kranzler
ce7df21792 removed verify skips 2020-04-23 17:33:12 -04:00
Evan Kranzler
332da23746 removed temporary verify skips 2020-04-20 22:37:58 -04:00
Evan Kranzler
ee7d271cb4 updated creature types 2020-04-13 18:27:58 -04:00
Oleg Agafonov
861c3bc425 Planechase: added tests to check plane classes; 2020-04-13 22:01:27 +04:00
Evan Kranzler
526f2301d7 updated IKO spoiler 2020-04-10 22:30:28 -04:00
Evan Kranzler
e4cc991b72 fixed test failure 2020-04-10 18:10:49 -04:00
Evan Kranzler
10ec7035fd updated test exemptions 2020-04-08 18:07:59 -04:00
Thomas Hess
7fb56aafda
mage.verify.VerifyCardDataTest: Skip known not-implemented sets.
Skipped are:
- Pure token sets
- Commander set oversized cards
- Non-English-only sets
- Non-traditional cards used for casual PvE modes
- Planechase Planes
- Archenemy Schemes
- Modern Horizons artwork cards
- Some other misc sets with non-traditional cards
2020-03-24 17:32:07 +01:00
Thomas Hess
da98ac82ed
Aligned Guru Set code with Scryfall (GUR → PGRU). 2020-03-24 17:32:06 +01:00
Thomas Hess
d9803dcd87
Updated the VerifyCardDataTest
Added newly added Silver bordered cards that need to be skipped during tests.
Added temporary skips for Chicken -> Bird errata.
2020-03-24 17:32:06 +01:00
Thomas Hess
529552dd2c
Fixed set codes for the Duel Deck Anthology deck sets.
The decks now use the set codes from Scryfall.
2020-03-24 17:32:06 +01:00
Thomas Hess
71bdc431db
Aligned Grand Prix Promos set code with Scryfall.
(GPX → PGPX)
2020-03-24 17:31:57 +01:00
Thomas Hess
443bc95a63
Split the Magic Player Rewards (MPRP) promotional set into the individual sets.
- Removed Magic Player Rewards (MPRP)
- Added MPR sets 2001 (MPR), 2003-2011 (P03 - P11)
2020-03-24 17:31:54 +01:00
Thomas Hess
e76b8d1a19
Skip failing card cost verification during tests. Affected: "Erase", "Shrine Keeper".
This allows all tests to pass.
2020-03-24 17:31:54 +01:00
Thomas Hess
d628303f3a
Fix set code clash with the old PrereleaseEvents set and the new Pro Tour Collector set (PTC).
Set the PrereleaseEvents code to PPRE, as listed on Scryfall.
2020-03-19 11:09:48 +01:00
Thomas Hess
aab0b2e2fa
Split the cummulative Arena League set into the individual sets.
- Removed set ARENA
- Added sets PARL, PAL99, PAL00, PAL01, PAL02, PAL03, PAL04, PAL05, PAL06
2020-03-19 11:09:48 +01:00
Thomas Hess
b56882091e
Adjust European Land Program set abbreviation to match Scryfall. 2020-03-19 11:09:47 +01:00
Thomas Hess
4d3e41fa35
Adjust Asia Pacific Land Program set abbreviation to match Scryfall. 2020-03-19 11:09:46 +01:00
Oleg Agafonov
cb8d4dc340 * Non creature tokens - fixed rollback errors in AI games (example: Food token, see #6331);
Fixed other potentially NPE errors with rarity;
2020-03-06 03:27:46 +04:00
Oleg Agafonov
169d9bf761 * Non basic mana abilities - fixed rollback errors in AI games (#6300); 2020-02-25 12:41:45 +04:00
Ingmar Goudt
ae7919cd07 program towards Interface rather than implementations 2020-02-10 10:40:06 +01:00
Oleg Agafonov
46d5b228cf Tests: migrate to new mtgjson version 2020-01-22 01:32:03 +04:00
Oleg Agafonov
5157a88dba Tests: improved logs in verify tests; 2020-01-18 11:00:13 +04:00
Oleg Agafonov
4a004a27b3 Refactor damage with power effect, added checking for wrong targets; 2020-01-13 13:49:40 +04:00
Evan Kranzler
48822c94b8 some oracle updates 2020-01-10 12:33:19 -05:00
Oleg Agafonov
b366a83a45 Prepare new release 2020-01-09 08:55:26 +04:00
Evan Kranzler
81ce0ad1df temporary test fix 2020-01-07 23:09:57 -05:00
Oleg Agafonov
85e65c8f44 Code cleanup 2020-01-08 05:19:52 +04:00
Oleg Agafonov
ddff795bf8 Tests: added verify test to check double rare cards in new sets; 2020-01-07 20:36:29 +04:00
Oleg Agafonov
0930bdd016
Merge pull request #5690 from magefree/copy_constructor_watchers
refactor the copy functionality for no-args watchers
2020-01-02 18:51:37 +01:00
Oleg Agafonov
ed8c3276e1 Tests: add new verify test to check wrong symbols in rules/names; 2020-01-01 14:24:52 +04:00
Ingmar Goudt
ce23f6900d fix conflicts 2019-12-29 19:28:20 +01:00
Ingmar Goudt
702a1f2498 remove all copy constructors and copy methods for all watchers 2019-12-29 19:18:20 +01:00
Oleg Agafonov
d26fde8dbc Prepare new release 2019-12-21 18:23:15 +04:00
Oleg Agafonov
0885a01849 Fixed that TargetCard ignore filter in some calls 2019-12-16 02:55:13 +04:00
Oleg Agafonov
7469d59eee Prepare new release 2019-11-30 01:32:54 +04:00
Evan Kranzler
c0344015bb removed test skip for Noble and Warlock creature types 2019-09-30 17:43:10 -04:00
Evan Kranzler
12d8e40368 added additional subtype verification skips 2019-09-27 19:11:45 -04:00
Oleg Agafonov
f719503a89 Prepare new release 2019-09-27 21:19:03 +04:00
Evan Kranzler
a99afc763d updated Dread Warlock creature type 2019-09-24 20:07:12 -04:00
Oleg Agafonov
8dc6e152af Prepare next release 2019-09-10 00:33:47 +04:00
Evan Kranzler
8a381b6a28 fixed a potential security vulnerability 2019-07-22 17:47:23 -04:00
Oleg Agafonov
2de535feb2 Tests: improved verify checks for missing/wrong abilities 2019-06-30 22:48:36 +04:00
Oleg Agafonov
716b929877 Prepare new release 2019-06-30 18:33:29 +04:00
Oleg Agafonov
55bc61000a Prepare new release 2019-06-06 23:03:38 +04:00
Oleg Agafonov
77e92d9186 * Fixed that snow lands can be added in draft and sealed modes (#5831); 2019-06-06 22:50:16 +04:00
Evan Kranzler
e6396798aa temporary test skip until mtgjson updates its data 2019-05-29 23:26:54 -04:00
Evan Kranzler
1456ad7019 updated dependency based on security recommendation 2019-05-25 11:07:25 -04:00
Oleg Agafonov
e80ba6383f Added verify tests for watchers copy; 2019-05-18 10:58:30 +04:00
Oleg Agafonov
b9b8415c99 Extra tests to catch card creation errors; 2019-05-06 17:03:56 +04:00
Oleg Agafonov
00633ce055 Fixed mtgjson compatibility 2019-04-28 19:08:13 +04:00
Oleg Agafonov
bbf1c1343a Prepare release 1.4.35 2019-04-23 23:32:54 +04:00
Oleg Agafonov
5f07a9aff2 Tests: enable warnings for wrong card texts in WAR set 2019-04-19 08:05:31 +04:00
Thomas Winwood
d28ea98dff Exempt Thingamajig from mana cost verification 2019-04-12 06:54:10 +01:00
Thomas Winwood
83234762f6 Implement Everythingamajig 2019-04-12 05:56:04 +01:00
Thomas Winwood
5a83b27271 Fix verify bug 2019-04-09 01:13:56 +01:00
Oleg Agafonov
b8782d572d Tests: added test to check copy() methods removes; 2019-03-30 20:26:35 +04:00
Oleg Agafonov
65bb9b2161 Prepare new release 1.4.34 2019-03-29 18:31:00 +04:00
Oleg Agafonov
3454ffbe01 Fixed merge 2019-03-27 16:53:09 +04:00
Oleg Agafonov
490d207efe Tests: added checks that planeswalkers must be legendary; 2019-03-19 06:27:55 +04:00
Oleg Agafonov
fa75ac2727 Typo fix 2019-03-07 12:14:27 +04:00
Oleg Agafonov
e68b79336a Typo fix 2019-03-06 14:06:47 +04:00
Oleg Agafonov
29993ebd21 Fixed mtgjson compatibility 2019-02-01 18:59:01 +04:00
Oleg Agafonov
7eba755666 Refactor card ratings, fixed rare error exception "comparison method violates its general contract" (different ratings in same card); 2019-02-01 17:41:29 +04:00
Ingmar Goudt
5b38f4168f apply try-with for MtgJson 2019-01-19 23:18:16 +01:00
Oleg Agafonov
14f66029f8 Missing v33 commit 2019-01-16 20:59:45 +04:00
Oleg Agafonov
727165dd3a Improved verify tests (wip) and showCardInfo for realtime texts test. 2019-01-14 11:01:42 +04:00
Oleg Agafonov
b0e2845b59 Fixed verify tests to ignore mtgjson updates 2019-01-14 06:19:39 +04:00
LevelX2
a61af9f098 Updated Mage Verify pom.xml ref to com.fasterxml.jackson.core to newer version. 2019-01-04 21:34:54 +01:00
Oleg Agafonov
5d1289a66e
Merge pull request #5465 from magefree/ui-new-download-window
UI: added new download images window
2018-12-21 18:03:55 +04:00
John Hitchings
3d15325448 buildfix for VerifyCardDataTest. mtgjson file was moved, added a few fields, and requires adding a User-Agent to the request. 2018-12-20 17:02:48 -08:00
Oleg Agafonov
4495d75d8a Fixed NPE error on AI calcs 2018-12-18 17:17:10 +04:00
Oleg Agafonov
d6569b88a6 Updated MtgJson 2018-12-11 16:55:48 +04:00
Oleg Agafonov
a4d797e473 Fixed mtgjson data; 2018-12-07 07:34:38 +04:00
Oleg Agafonov
41a2573319 Fixed wrong MtgJsonV4 data format (#5415); 2018-12-07 02:55:27 +04:00
LevelX2
09a5ece9f3 Fixed color check and added missing attribute to verify. 2018-11-27 16:09:43 +01:00
LevelX2
e6ce58d6bf XMage 1.4.32V0 2018-11-26 19:30:22 +01:00
LevelX2
b7ebff4fa1 Fixed verify color check. 2018-11-26 19:01:18 +01:00
Ingmar Goudt
d9b25cbac1 suppert mtgjson v4 2018-11-23 19:22:27 +01:00
Oleg Agafonov
fe3eda4944 * Spell Contortion, Warleader's Helix - fixed wrong card text;
Removed unused getRules in cards code;
2018-11-11 22:54:49 +04:00
LevelX2
e6b78d7a2e Updated some libs to newer versions. 2018-10-21 21:36:53 +02:00
Oleg Agafonov
8fd6eb6313 Fix merge 2018-10-03 22:43:13 +04:00
Oleg Agafonov
6bb478c342 Tests: added many verify tests for sets and cards, e.g.:
* check set's class name/file (source code style);
  * check set's hasBasicLands settings (missing lands in deck generation bug);
  * check card's UsesVariousArt settings (same image for multi-images card bug);
  * check card's missing abilities (forgot addAbility call bug);
  * improved output messages;
2018-10-03 22:32:52 +04:00
Oleg Agafonov
69546c82ce * Added missing images for WPN and Gateway Promos (GRC) set in scryfall source; 2018-10-03 20:32:58 +04:00
Evan Kranzler
11e1d9df38 removed outdated verification skips 2018-09-09 14:07:59 -04:00
Oleg Agafonov
747f3030e2 Added test to check missing abilities 2018-09-05 02:45:01 +04:00
LevelX2
deb675a74a Xmage 1.4.30V0 2018-08-15 11:35:40 +02:00
Noah Gleason
8ee7965580
Fix tests 2018-07-07 11:52:38 -04:00
Oleg Agafonov
fb36f329f9 Fixed Dragon Egg tests 2018-06-23 01:19:54 +04:00
Evan Kranzler
ab3cd76d3e Fixed various potential null pointer exceptions 2018-05-31 21:03:40 -04:00
LevelX2
a19c257e50 XMage 1.4.30V0 2018-05-27 01:28:42 +02:00
Evan Kranzler
c3d0297045 Updated Mage Verify test 2018-05-20 21:00:09 -04:00
Oleg Agafonov
4851ba9e84 Test framework: added commands for real time checks/assertions:
* new checks: color, subtype, ability, PT, permanent and hand count;
 * more info in #4936;
2018-05-14 02:31:19 +04:00
Oleg Agafonov
f021951578 Tests: added tokens tests in mage-verify (ignored until massive fixes, run it manually):
* check token class name convention (must ends with Token);
 * check token package (must be in mage.game.permanent.token);
 * check private tokens (must be replaced with CreateToken);
 * check missing data from tok-file;
2018-05-11 22:22:02 +04:00
LevelX2
fe2220e19e Xmage 1.4.29V0 2018-04-19 21:07:14 +02:00
ArcadeMode
5ac975c52e Blocker and Critical level bugfixes throughout the project (#4648)
* fixed https://sonarcloud.io/project/issues?id=org.xmage%3Amage-root&issues=AWIlv32RgrzAwlaaQ7rP&open=AWIlv32RgrzAwlaaQ7rP

* ensure closing of scanner if it was opened

* Refactored method in EmpyrialArchAngel to not always return same value.

* Refactored method in FalkenrathAristocrat to not always return same value.

* Refactored method in GilderBairn to not always return the same value.

* fixed left open resources, ensured quiet closing of the streams

* Refactored method in IceCave to not always return same value.

* Refactored method in KjeldoranRoyalGuard to not always return same value.

* Refactored method in LegionsInitiative to not always return same value.

* Refactored method in NaturesWill to not always return same value.

* added quiet closing method in new streamutils class, used to clean up the connectdialog

* Fix small typo

* added quiet closing to saveobjectutil

* closed resources in savegame method of gamecontroller

* properly close resources in loadGame method of GameReplay class

* further proper resource closing in ServerMessagesUtil

* fixed unclosed resources in copy method in mage framework Copier

* closed unclosed resources in copyCompressed method in Copier

* ensure closing of filewriter in manasymbols

* ensure proper closing of Stream in arcane UI

* ensure closing of datagram socket in arcane Util

* ensure resource closing in deckimport from clipboard

* ensure closing of plugin classloader

* ensured closing of zipinputstream resource

* ensure closing of fileoutputstream in ScryfallSymbolsSource

* ensure closing resources after finishing/canceling download of pictures

* remove commented code

* move locks to try block to ensure unlocking along all execution paths

* remove dangerous instance of double-checked locking

* removed dangerous instance of double checked locking in settingsmanager

* Removed dangerous instance of double-checked locking in ThemePluginImpl

* close resource which did not happen certainly

* close another stream

* ensure closing of inputstream
2018-03-22 08:13:13 -05:00
LevelX2
b073ce1c42 * Added to all toUpperCase/toLowerCase calls the Locale.ENGLISH to prevent problems with some languages (e.g. Turkish). Removed some unused import statements. (#4634). 2018-03-18 18:18:54 +01:00
LevelX2
fed2d1a259 XMage 1.4.28V0 2018-03-10 20:42:29 +01:00
Oleg Agafonov
bc3274b144 Test: fixed mage-verify tests 2018-01-15 07:46:31 +04:00
LevelX2
40afa04b24 xmage 1.4.27V0 2018-01-13 22:54:53 +01:00
Oleg Agafonov
4771ad2c63 Fixed UGL test, rename new token 2018-01-13 02:27:16 +04:00
Oleg Agafonov
0ba2375ac1 Tests:
* added new checks for basic land types/rarity in mage-verify;
 * fixed tests for UGL cards in mage-verify (wrong json data)
2018-01-11 20:37:38 +04:00
Oleg Agafonov
60443cdbfe Updated readme with actual card stats, added stats printing on mage-verify tests 2017-12-29 17:53:12 +04:00
Oleg Agafonov
c4fe9e3121 Tests: added mage-verify warning test for missing sets in xmage (current missing sets: 34 with 1689 cards) 2017-12-29 17:15:00 +04:00
Zzooouhh
6fae8ef606
Merge branch 'master' into master 2017-12-22 23:17:20 +01:00
Oleg Agafonov
a24c61079b Added new set Pro Tour Promos 2017-12-20 20:14:04 +04:00
Oleg Agafonov
6c86856933 Added tests to verify DB for card numbers typos, duplicate and wrong classes 2017-12-20 16:42:02 +04:00
Zzooouhh
eae526e3b3
Added Verify exception for Infinity Elemental 2017-12-18 22:16:14 +01:00
Oleg Agafonov
36055178bd - fixed UST - Sword of Dungeons card name;
- fixed mage-verify tests for UST set;
2017-12-16 19:58:11 +04:00
Evan Kranzler
0ebe09d468 Reenabled Mage Verify, reverted Ripscale Predator to lizard (for now) 2017-10-04 12:13:22 -04:00
Evan Kranzler
a110b54d91 Setting Mage Verify to ignore until mtgjson is updated with the latest oracle text 2017-10-02 21:26:20 -04:00
LevelX2
1fb24116ae xmage 1.4.26V0 2017-08-15 01:27:06 +02:00
LevelX2
fe2ee5dfec Xmage 1.4.25V0 2017-07-29 20:35:16 +02:00
ingmargoudt
09f0c9ad97 huge rework on subtypes (#3668)
* huge rework on subtypes

* update for coat of arms

* fix test
2017-07-16 16:57:39 -05:00
igoudt
11f040b884 use more staticfilters, fix jsoncard class 2017-07-10 12:25:33 +02:00
LevelX2
7d911ae803 XMage 1.4.24V0 2017-07-08 16:33:09 +02:00
LevelX2
ef4cf90a0f Release 1.4.23V0 2017-04-17 10:53:59 +02:00
Timothy Rice
89ee5eeeae fixed Mistform creature types and verify test for phyrexian mana 2017-04-11 13:58:01 -05:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
LevelX2
9d8a8a33f1 Xmage 1.4.22V0 2017-03-11 13:38:55 +01:00
vraskulin
ad7d3c8078 equals "" should be replaced with isEmpty 2017-02-28 11:45:15 +03:00
vraskulin
498c8cf60c Made utility classes final to explicitly forbid it's inheritance 2017-02-27 17:03:38 +03:00
vraskulin
f60ebfbb1f All 1-character strings converted to primitives
"b" + "r" now changed to 'b' + 'w'.  It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
LevelX2
6625bf86be Xmage 1.4.21V0 2017-01-15 17:44:02 +01:00
LevelX2
ee203cf981 Xmage Release 1.4.20V0 2017-01-08 01:36:05 +01:00
LevelX2
b62ca1ed1f Xmage 1.4.19 2016-11-27 19:59:42 +01:00
LevelX2
c9e1b415e2 Xmage 1.4.18V0 2016-11-06 18:11:19 +01:00
LevelX2
8b62eece68 XMage 1.4.17V0 2016-10-23 10:03:01 +02:00
LevelX2
97b872d926 * Fixed that a spell that becomes a permanent didn't had the colors of the spell (e.g. ERsatz Gnomes). 2016-10-22 10:38:10 +02:00
Neil Gentleman
2779f81764 remove tests without assertions
- source token checking is very noisy, so disabled it for now
- set verification wasn't showing anything interesting
2016-10-16 12:02:13 -07:00
Neil Gentleman
335950ee8f actually fail the test on errors
explicitly ignoring the one known error in gatherer and all custom sets
2016-10-16 11:57:31 -07:00
Neil Gentleman
510f7a86b6 download the json at runtime 2016-10-16 11:57:26 -07:00
Neil Gentleman
26b8b88963 update verification
now using java types instead of Map<String, Object>
2016-10-16 11:56:43 -07:00
Neil Gentleman
584b532598 check card source for unexpected types
needs more tuning - very noisy right now
2016-10-16 11:52:10 -07:00
Neil Gentleman
5ad58f59c1 compare cards with mtgjson 2016-10-16 11:49:49 -07:00