Evan Kranzler
572104b8fc
Reworking card types in preparation for implementing Grist, the Hunger Tide ( #7899 )
...
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-07-09 07:28:43 +04:00
Evan Kranzler
07e1dff10c
added an additional subtype verification test
2021-07-08 18:46:42 -04:00
Evan Kranzler
9072abbbcc
added temporary verify fix
2021-07-08 08:51:21 -04:00
Evan Kranzler
f17b8e4b86
removed verify skip, fixed verify error
2021-07-05 20:30:26 -04:00
Oleg Agafonov
9eea77f815
Fixed verify test
2021-07-04 23:29:38 +04:00
Evan Kranzler
daf77b2ee8
[MH2] various text fixes
2021-06-22 09:20:05 -04:00
Evan Kranzler
3158621a87
fixed another verify bug
2021-06-21 21:08:48 -04:00
Evan Kranzler
ef0b4bdf58
fixed another verify bug
2021-06-18 20:00:44 -04:00
Evan Kranzler
949b2671e0
fixed an issue with verify
2021-06-18 18:26:09 -04:00
Evan Kranzler
9fd29bae06
[MH1] various text fixes
2021-06-12 19:26:02 -04:00
Evan Kranzler
5f8d746fc0
updated tokens with phyrexian subtype
2021-06-10 20:29:07 -04:00
Evan Kranzler
65b34ac6b4
removed temporary test skips
2021-05-31 15:38:49 -04:00
Evan Kranzler
beada7d3be
fixed verify failure
2021-05-28 21:59:59 -04:00
Evan Kranzler
6ffc59d760
[MH2] fixed verify failures
2021-05-25 09:20:04 -04:00
Evan Kranzler
690d640a05
simplified a test
2021-05-07 09:15:12 -04:00
Evan Kranzler
8104cdb7a5
fixed another test failure
2021-05-07 08:59:54 -04:00
Evan Kranzler
95bfcb5ef8
added some options to mage verify for text verification
2021-05-04 08:00:03 -04:00
Evan Kranzler
c1f1ceb9e7
fixed unnecessary verify warnings for split cards
2021-04-30 09:16:27 -04:00
Evan Kranzler
0297a00156
all text and no fix makes elk a dull boy
2021-04-29 19:43:44 -04:00
Evan Kranzler
731e948841
[C21] various text fixes
2021-04-28 21:00:36 -04:00
Evan Kranzler
efb2a7f3de
[STX] more text fixes
2021-04-17 21:56:26 -04:00
Evan Kranzler
ef8ee52b94
added MTGJSON metadata to verify test
2021-04-17 21:15:42 -04:00
Evan Kranzler
326c17fe4d
[STX] various text fixes
2021-04-17 18:22:43 -04:00
Evan Kranzler
cb0df438dd
[STA] text fixes
2021-04-17 16:34:21 -04:00
Evan Kranzler
298315309b
removed temporary test skips
2021-04-10 21:04:59 -04:00
Evan Kranzler
61c7723e3b
additional test fix
2021-04-08 21:34:27 -04:00
Evan Kranzler
79b23d3292
fixed a test failure
2021-04-08 18:35:38 -04:00
Oleg Agafonov
f307bffcda
Tests: added verify test to check wrong expansionSetCode usage in cards (see da6acafef2
);
2021-04-02 11:36:59 +04:00
Evan Kranzler
9cfeee9b8c
fixed a test failure
2021-03-29 21:49:59 -04:00
Evan Kranzler
93c9b2770a
fixed a test failure
2021-03-09 20:27:05 -05:00
Evan Kranzler
6894ad96bc
[TSR] various text fixes
2021-03-05 19:10:29 -05:00
Evan Kranzler
afcdc0f23a
simplified and consolidated werewolf triggered abilities
2021-03-03 22:13:16 -05:00
Oleg Agafonov
2accab79c5
* Spark Double - fixed duplicated counters on copying of another Spark Double ( #7553 );
2021-02-22 21:22:31 +04:00
Oleg Agafonov
10e557b873
* Performance: memory usage optimization for deck editor (part 2 of removed bloated usage of ManaCosts -> ManaColor objects, see #7515 );
2021-02-12 22:12:18 +04:00
Oleg Agafonov
275e996c08
* Performance: memory usage optimization for deck editor (removed bloated usage of ManaCosts -> ManaColor objects, see #7515 );
2021-02-12 22:00:16 +04:00
Evan Kranzler
18c8a8539e
[KHM] fixed The Bears of Littjara not sacrificing after chapter 3 ( fixes #7527 )
2021-02-08 18:02:44 -05:00
Oleg Agafonov
cf216c6802
Prepare new release
2021-02-07 22:24:40 +04:00
Evan Kranzler
cda79866ad
[ZNR] a few text fixes
2021-02-02 10:24:54 -05:00
Evan Kranzler
16450f9952
[ZNC] some text fixes
2021-02-02 10:14:44 -05:00
Evan Kranzler
6ed259941a
[KHC] more text fixes
2021-02-01 22:47:36 -05:00
Evan Kranzler
599309c980
[KHM] a few more text fixes
2021-02-01 22:47:36 -05:00
Evan Kranzler
df38d7213e
[KHC] text fixes
2021-01-31 15:01:02 -05:00
Evan Kranzler
f9dfb56d4e
[KHM] more text fixes
2021-01-31 11:28:44 -05:00
Evan Kranzler
d5822a7246
[KHM] various text fixes
2021-01-29 17:37:56 -05:00
Oleg Agafonov
6f2ce47885
Tests: added verify test for wrong mdash usage and fixed related cards ( #7457 ), added tests for ( #7460 );
2021-01-29 11:35:13 +04:00
Evan Kranzler
a535cb5adc
Refactoring methods which add counters to track which player adds the counters (ready for review) ( #7448 )
...
* added parameter for player adding counters to players
* added parameter for player adding counters to cards/permanents
* updated methods to use new parameter
* fixed a few initial errors
* refactored instances of cards that add counters by a player other than the controller
* fixed some instances of incorrect arguments
* refactored abilities that trigger off of a particular player adding counters
* a few more cards that were missed
* [KHM] Implemented Vorinclex, Monstrous Raider
* added test for Vorinclex, Monstrous Raider
* fixed a test failure
2021-01-26 19:06:13 -05:00
Evan Kranzler
dacf30f4b9
Refactoring subtypes to make Maskwood Nexus work (ready for review) ( #7432 )
...
* removed and renamed SubTypeList
* updated subtype test
* refactored Changeling to be an ability that actually does something
* moved isAllCreatureTypes into SubTypes class
* renamed copyTo method to copyFrom
* added removeAllCreatureTypes where usable
* replaced some subtype methods
* replaced some more subtype methods
* replaced subtype mass add/remove methods
* updated more subtype methods
* fixed some errors
* made common shared creature type predicate
* refactored another card involving subtypes
* Added usage of object attribute in subTypes's write operations;
* Refactor: use same param styles in subtype methods
* Refactor: simplified usage of copy appliers;
* Refactor: fixed code usage in CopyApplier
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-01-26 08:52:35 -05:00
Evan Kranzler
eaf29da63f
fixed verify sample deck test failing locally on macOS
2021-01-24 15:02:25 -05:00
Evan Kranzler
227295ea41
[KHM] removed test skip
2021-01-23 22:25:13 -05:00
Oleg Agafonov
c3b391b42f
Fixed verify tests config
2021-01-23 09:45:25 +04:00
Oleg Agafonov
f1e9c49195
Fixed test
2021-01-23 07:34:26 +04:00
Oleg Agafonov
abc36ba607
Tests: improved output to show verify errors at the end (after warnings);
2021-01-23 07:28:01 +04:00
Oleg Agafonov
06174c4da3
Tests: added verify test to check wrong cards in the cubes;
2021-01-23 06:29:02 +04:00
Evan Kranzler
188dbc9528
removed temporary test fix
2021-01-18 20:39:50 -05:00
Evan Kranzler
b9932ad66f
[KHM] temporary test fix
2021-01-16 21:30:23 -05:00
Evan Kranzler
0943ae1bb7
Revert "added test to check for changeling cards having isAllCreatureTypes set to true"
...
This reverts commit 6d91ee69d4
.
2021-01-10 19:38:48 -05:00
Evan Kranzler
6d91ee69d4
added test to check for changeling cards having isAllCreatureTypes set to true
2021-01-10 19:24:29 -05:00
Evan Kranzler
f6c70d5d4a
[KHM] fixed verify error
2021-01-07 22:02:26 -05:00
Oleg Agafonov
dd7c1939d3
* Game: fixed that Snow-Covered lands can be added to auto-generated or submitted/timeout decks ( #7222 );
2020-12-23 10:26:49 +04:00
Oleg Agafonov
cc5fce4256
Prepare new release
2020-12-19 23:59:44 +04:00
Oleg Agafonov
49bd6fe90d
Tests: improved verify tests for full art settings
2020-11-29 01:03:55 +04:00
Evan Kranzler
35902ee84a
[CMR] more text fixes
2020-11-11 20:37:42 -05:00
Oleg Agafonov
ea46afbe62
Prepare new release
2020-11-10 13:11:45 +04:00
Oleg Agafonov
a73c9bddae
[ZNR] Added all modal double faces cards ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
8ac78b4b9e
Added modal double faces cards implementation (MDF cards, #7012 )
2020-11-01 10:03:09 +01:00
Evan Kranzler
8617bc128e
Fixing issues with Changelings and general problems with creature types (ready to merge) ( #7098 )
...
* updated Changelings to use setIsAllCreatureTypes
* updated Dr Julius Jumblemorph and Mistform Ultimus to not use changeling
* added test for Mistform Ultimus
* updated effects which give all creature types to controlled creatures
* updated effects which give all creature types to targeted creatures
* Update LoseAllCreatureTypesTargetEffect.java
* updated effects which give all creature types to attached creatures
* Update EgoErasure.java
* added another test for changelings
* updated two tokens I left out before
* updated hasSubtype
* updated shareCreatureTypes
* fixed an incorrect test
* cleaned up some cards which check for shared creature types
* added new changeling test
* fixed issue with shareCreatureTypes
* fixed a text issue
* added new tests for subtype effects
* various individual card fixes and cleanups
* fixed and updated various effects
* many more fixes
* a few more fixes
* added test for One with the Stars
* added changeling verify test
* updated effects which add additional subtypes
* more miscellaneous fixes
* added additional test
* some fixes for card type checks
* updated methods for adding types to make it easier to avoid duplicates and illegal additions
* small test update
* fixed a recursive loop issue
* fixed another error
* fixed it for real this time
* streamlined type removal process
* streamlined subtype set generation
2020-10-30 22:32:59 -04:00
Evan Kranzler
8c7d7f0b77
[M20] various text fixes
2020-10-08 09:15:38 -04:00
Evan Kranzler
50a0954606
[ELD] various text fixes
2020-10-07 20:57:43 -04:00
Evan Kranzler
6a3240fad3
[ZNR] various text fixes
2020-10-07 20:04:34 -04:00
Evan Kranzler
9a140a19a2
updated verify check to better handle line breaks
2020-10-07 09:19:39 -04:00
Evan Kranzler
a2ae0bc9b8
updated verify check to handle mana abilities being split
2020-10-06 23:21:00 -04:00
Evan Kranzler
524b9fcd44
[M21] various text fixes
2020-10-06 21:12:07 -04:00
Evan Kranzler
44b44f4103
[IKO] various text fixes
2020-10-06 21:01:17 -04:00
Evan Kranzler
9ab01e5512
updated verify check to handle modal spells correctly
2020-10-06 20:57:13 -04:00
Evan Kranzler
5187636672
[THB] various text fixes
2020-10-06 20:12:06 -04:00
Evan Kranzler
f83b427e63
updated verify check to ignore legendary creature text shortening
2020-10-06 19:48:54 -04:00
Evan Kranzler
e43da063ef
updated verify check to ignore evergreen keywords
2020-10-06 19:33:39 -04:00
Evan Kranzler
9909cc39bd
fixed a verify failure
2020-09-09 12:27:11 -04:00
Oleg Agafonov
233e12873e
Fixed verify test
2020-09-09 16:42:19 +04:00
Oleg Agafonov
a3564e55e8
Fixed test
2020-09-07 00:41:31 +04:00
Oleg Agafonov
95b61c081a
Fixed wrong card numbers in SLD
2020-08-27 15:52:32 +04:00
Oleg Agafonov
6fa4c0b8f2
Fixed NPE on playerList.getNext usage
2020-08-25 23:38:51 +04:00
Oleg Agafonov
920697d2e5
Prepare new release
2020-08-23 01:52:55 +04:00
Oleg Agafonov
1b430e5d99
Added verify test to check missing second face cards in sets, fixed missing cards;
2020-08-22 18:48:15 +04:00
Oleg Agafonov
7aac355f4a
Tests: added many verify checks for missing cards, names, numbers, download settings:
...
* check wrong card numbers in sets;
* check missing cards from set;
* check wrong full art settings;
* check missing and unknown sets in scryfall download settings;
* check missing and unknown direct download links in scryfall download settings;
* improved ability text check results;
* removed unused tests for word checks;
2020-08-22 15:16:30 +04:00
LevelX2
c16fb75668
* replaces all [source} by {this}. ATTENTION !!!: Only supporting [this} from now on in rule text.
2020-08-22 12:52:49 +02:00
Oleg Agafonov
ca254c6562
Tests: migrating to mtgjson v5 ( #6808 );
2020-08-15 14:21:38 +04:00
Oleg Agafonov
e1806f808c
Tests: simplify mtgjson code in verify test;
2020-08-15 14:17:19 +04:00
Oleg Agafonov
61bfdf8108
Tests: added verify check for wrong optional settings on DoIfCostPaid usage;
2020-08-14 16:22:34 +04:00
Oleg Agafonov
b89c1c03ca
* Dire Fleet Warmonger - fixed that it asks user two times, fixed text ( #6643 );
2020-08-14 15:12:59 +04:00
Oleg Agafonov
8b2bc064cd
Fixed test and sample decks
2020-08-10 18:24:21 +04:00
Oleg Agafonov
3a1b741509
Fixed test
2020-08-08 23:38:47 +04:00
Oleg Agafonov
ad6797d3c0
GUI: added more error checks while import/load deck file;
2020-08-08 23:12:06 +04:00
Oleg Agafonov
c5d7a3e9f9
* GUI: added auto-fix for deck files on usage (if deck contains wrong card numbers then it will be fixed and saved automaticity);
2020-08-08 21:27:20 +04:00
Oleg Agafonov
9652d83aec
Fixed tests
2020-08-08 19:08:38 +04:00
Oleg Agafonov
025ba9bb47
Tests: added non-ascii symbols checks in card numbers and names;
2020-08-08 18:53:00 +04:00
Oleg Agafonov
66a8994318
Tests: added sets implementation statistics in test_checkMissingSets
2020-08-08 14:02:28 +04:00
Oleg Agafonov
735588cc0d
Sets refactor:
...
* Duels of the Planeswalkers Promos set split to multiple sets (scryfall style);
* Fixed Masterpiece Series sets name;
2020-08-08 13:17:49 +04:00
Oleg Agafonov
7599acf1c8
Removed duplicated sets that was split into multiple (Champs, Game Day, Launch Party, Media Inserts, Super Series)
2020-08-08 11:00:07 +04:00
Oleg Agafonov
fbcdeeb2a8
Tests: added verify test to check wrong scryfall download settings;
2020-08-08 10:08:22 +04:00
Oleg Agafonov
9e6a348cb1
Merge branch 'master' into refactor_promo_sets
2020-08-07 02:48:40 +02:00
Oleg Agafonov
97556c917c
Tests: added verify test to check all sample decks
2020-08-07 03:59:14 +04:00
dependabot[bot]
21d4a4b6a8
Bump reflections from 0.9.11 to 0.9.12
...
Bumps [reflections](https://github.com/ronmamo/reflections ) from 0.9.11 to 0.9.12.
- [Release notes](https://github.com/ronmamo/reflections/releases )
- [Commits](https://github.com/ronmamo/reflections/compare/0.9.11...0.9.12 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-07-27 06:44:03 +00:00
Oleg Agafonov
c4f028ffa0
Prepare new release
2020-07-10 16:50:38 +04:00
Evan Kranzler
e8649a226f
removed temporary test skips
2020-07-08 10:03:30 -04:00
Oleg Agafonov
e69a021c71
Fixed missing locale param in string operations ( #4634 )
2020-07-03 02:00:58 +04:00
Oleg Agafonov
f19c929229
Verify tests: added checks for wrong ability/effect hint description in card text;
2020-06-26 10:15:22 +04:00
Oleg Agafonov
9e8a5131ae
Test helper for #6684 (uncomment and run checkMissingCardData)
2020-06-21 21:22:19 +04:00
Oleg Agafonov
3f2a5fc362
Prepare new release
2020-06-20 11:36:13 +04:00
Oleg Agafonov
ff91ffe1a7
Removed unnecessary custom text from some cards (opponent loses life and you gain life)
2020-06-20 03:04:33 +04:00
htrajan
6804216ddc
Implement garruk cards ( #6650 )
...
* Implement Garruk's Harbinger
* inline ability
* Implement Garruk's Uprising
* Implement Garruk, Unleashed
* fix Garruk, Unleashed
2020-06-16 21:09:26 -04:00
Oleg Agafonov
c2487aec7d
[C20] tokens support and fixes:
...
* Added tokens for C20;
* Added tokens images download for C20;
* Fixed that some tokens uses wrong images or images from wrong set (example: Elemental);
2020-06-15 20:29:52 +04:00
Oleg Agafonov
b5f45f395f
Tests: improved showCardInfo to show texts from multiple card names
2020-06-14 04:32:10 +04:00
Evan Kranzler
74b6626020
changed Hound to Dog
2020-06-05 20:17:41 -04:00
Oleg Agafonov
48049dbfc9
Tests: improved verify test for token's constructor;
2020-05-07 20:50:15 +04:00
Evan Kranzler
ce7df21792
removed verify skips
2020-04-23 17:33:12 -04:00
Evan Kranzler
332da23746
removed temporary verify skips
2020-04-20 22:37:58 -04:00
Evan Kranzler
ee7d271cb4
updated creature types
2020-04-13 18:27:58 -04:00
Oleg Agafonov
861c3bc425
Planechase: added tests to check plane classes;
2020-04-13 22:01:27 +04:00
Evan Kranzler
526f2301d7
updated IKO spoiler
2020-04-10 22:30:28 -04:00
Evan Kranzler
e4cc991b72
fixed test failure
2020-04-10 18:10:49 -04:00
Evan Kranzler
10ec7035fd
updated test exemptions
2020-04-08 18:07:59 -04:00
Thomas Hess
7fb56aafda
mage.verify.VerifyCardDataTest: Skip known not-implemented sets.
...
Skipped are:
- Pure token sets
- Commander set oversized cards
- Non-English-only sets
- Non-traditional cards used for casual PvE modes
- Planechase Planes
- Archenemy Schemes
- Modern Horizons artwork cards
- Some other misc sets with non-traditional cards
2020-03-24 17:32:07 +01:00
Thomas Hess
da98ac82ed
Aligned Guru Set code with Scryfall (GUR → PGRU).
2020-03-24 17:32:06 +01:00
Thomas Hess
d9803dcd87
Updated the VerifyCardDataTest
...
Added newly added Silver bordered cards that need to be skipped during tests.
Added temporary skips for Chicken -> Bird errata.
2020-03-24 17:32:06 +01:00
Thomas Hess
529552dd2c
Fixed set codes for the Duel Deck Anthology deck sets.
...
The decks now use the set codes from Scryfall.
2020-03-24 17:32:06 +01:00
Thomas Hess
71bdc431db
Aligned Grand Prix Promos set code with Scryfall.
...
(GPX → PGPX)
2020-03-24 17:31:57 +01:00
Thomas Hess
443bc95a63
Split the Magic Player Rewards (MPRP) promotional set into the individual sets.
...
- Removed Magic Player Rewards (MPRP)
- Added MPR sets 2001 (MPR), 2003-2011 (P03 - P11)
2020-03-24 17:31:54 +01:00
Thomas Hess
e76b8d1a19
Skip failing card cost verification during tests. Affected: "Erase", "Shrine Keeper".
...
This allows all tests to pass.
2020-03-24 17:31:54 +01:00
Thomas Hess
d628303f3a
Fix set code clash with the old PrereleaseEvents set and the new Pro Tour Collector set (PTC).
...
Set the PrereleaseEvents code to PPRE, as listed on Scryfall.
2020-03-19 11:09:48 +01:00
Thomas Hess
aab0b2e2fa
Split the cummulative Arena League set into the individual sets.
...
- Removed set ARENA
- Added sets PARL, PAL99, PAL00, PAL01, PAL02, PAL03, PAL04, PAL05, PAL06
2020-03-19 11:09:48 +01:00
Thomas Hess
b56882091e
Adjust European Land Program set abbreviation to match Scryfall.
2020-03-19 11:09:47 +01:00
Thomas Hess
4d3e41fa35
Adjust Asia Pacific Land Program set abbreviation to match Scryfall.
2020-03-19 11:09:46 +01:00
Oleg Agafonov
cb8d4dc340
* Non creature tokens - fixed rollback errors in AI games (example: Food token, see #6331 );
...
Fixed other potentially NPE errors with rarity;
2020-03-06 03:27:46 +04:00
Oleg Agafonov
169d9bf761
* Non basic mana abilities - fixed rollback errors in AI games ( #6300 );
2020-02-25 12:41:45 +04:00
Ingmar Goudt
ae7919cd07
program towards Interface rather than implementations
2020-02-10 10:40:06 +01:00
Oleg Agafonov
46d5b228cf
Tests: migrate to new mtgjson version
2020-01-22 01:32:03 +04:00
Oleg Agafonov
5157a88dba
Tests: improved logs in verify tests;
2020-01-18 11:00:13 +04:00
Oleg Agafonov
4a004a27b3
Refactor damage with power effect, added checking for wrong targets;
2020-01-13 13:49:40 +04:00
Evan Kranzler
48822c94b8
some oracle updates
2020-01-10 12:33:19 -05:00
Oleg Agafonov
b366a83a45
Prepare new release
2020-01-09 08:55:26 +04:00
Evan Kranzler
81ce0ad1df
temporary test fix
2020-01-07 23:09:57 -05:00
Oleg Agafonov
85e65c8f44
Code cleanup
2020-01-08 05:19:52 +04:00
Oleg Agafonov
ddff795bf8
Tests: added verify test to check double rare cards in new sets;
2020-01-07 20:36:29 +04:00
Oleg Agafonov
0930bdd016
Merge pull request #5690 from magefree/copy_constructor_watchers
...
refactor the copy functionality for no-args watchers
2020-01-02 18:51:37 +01:00
Oleg Agafonov
ed8c3276e1
Tests: add new verify test to check wrong symbols in rules/names;
2020-01-01 14:24:52 +04:00
Ingmar Goudt
ce23f6900d
fix conflicts
2019-12-29 19:28:20 +01:00
Ingmar Goudt
702a1f2498
remove all copy constructors and copy methods for all watchers
2019-12-29 19:18:20 +01:00
Oleg Agafonov
d26fde8dbc
Prepare new release
2019-12-21 18:23:15 +04:00
Oleg Agafonov
0885a01849
Fixed that TargetCard ignore filter in some calls
2019-12-16 02:55:13 +04:00