Commit graph

20502 commits

Author SHA1 Message Date
Erik
3d989b24ac
Text corrections from issue #6654 (WIP) (#6707)
* Collective restraint typo fix

* set text for EndlessSwarm. Add starts with vowel cond case to CountersSourceEffect

* Teferi's Curse, added text option to GainAbilityAttachEffect

* added set text to several cards. Implement reviewer suggestions in GainAbilityAttachedEffect

* Remove period from rule text (undo my lazy coding fix)
2020-08-16 00:55:59 +04:00
Oleg Agafonov
7f02a37dbb Fixed test 2020-08-16 00:37:29 +04:00
Thomas Winwood
98e2d9b7aa Revert changes to Wildwood Scourge
The Oracle text for this card *does* have "on it"; this was a small
errata to the printed card.
2020-08-15 23:56:53 +04:00
Thomas Winwood
81e348360c Fix a bunch of card text errors (magefree#6643) 2020-08-15 23:56:53 +04:00
Evan Kranzler
8240e956dc updated historic legality implementation 2020-08-15 14:03:11 -04:00
Oleg Agafonov
b7c84c9342 [AKR] fixed card numbers, fixed booster generation; 2020-08-15 21:11:17 +04:00
htrajan
30348908dc fix tests 2020-08-15 00:50:46 -07:00
htrajan
6bfa212bf3 add Amonkhet Remastered 2020-08-15 00:27:09 -07:00
jeffwadsworth
bdac0b3d72 - used the correct method for checking the source permanent in the last commit 2020-08-14 19:52:38 -05:00
jeffwadsworth
012558b3ae - Fixed #6965 2020-08-14 19:35:25 -05:00
jeffwadsworth
ea72e3c8cb - More fixes related to #6851 2020-08-14 19:19:01 -05:00
Oleg Agafonov
d8c9d10066 * Do if cost paid - fixed that some cards asks player about pay two times (fixed ~30 cards); 2020-08-14 16:36:00 +04:00
Oleg Agafonov
b89c1c03ca * Dire Fleet Warmonger - fixed that it asks user two times, fixed text (#6643); 2020-08-14 15:12:59 +04:00
jeffwadsworth
66ae54d2f0 - Fixed #6851 2020-08-12 16:35:10 -05:00
jeffwadsworth
79592d2b0a - Fixed #6861 2020-08-12 09:24:40 -05:00
jeffwadsworth
674fd6b1a5 - Fixed #6905 2020-08-11 22:21:15 -05:00
jeffwadsworth
36468044f4 - Fixed #6946 2020-08-11 21:56:49 -05:00
jeffwadsworth
f0149c6a19 - Added Pretender's Claim and Unnatural Hunger 2020-08-11 18:13:30 -05:00
jeffwadsworth
3d0cd99655 - Refactor EnchantedCreatureBlockedTriggeredAbility to BecomesBlockedAttachedTriggeredAbility 2020-08-11 08:26:47 -05:00
LevelX2
0d83a8e09a * Once Upon A Time - Added test (#6954). 2020-08-11 15:15:08 +02:00
jeffwadsworth
d3ba7d4dd5 - Added Righteous Indignation and Insubordination 2020-08-10 17:13:00 -05:00
Ingmar Goudt
33b6bd0e21 DireFleetWarmonger triggered ability is optional 2020-08-10 23:20:48 +02:00
Ingmar Goudt
452ba945e0 add some m21 tests 2020-08-10 23:03:12 +02:00
LevelX2
072e3e40c7 * Once Upon A Time - Reverted change (#6954). 2020-08-10 21:41:08 +02:00
jeffwadsworth
3b90c48c75 - Refactored BlocksTriggeredAbility to BlocksSourceTriggeredAbility 2020-08-10 11:49:03 -05:00
Oleg Agafonov
b16d30b79b
Merge pull request #6190 from luziferius/refactor_promo_sets
[RFC] Refactor promo sets, add missing sets as listed on Scryfall
2020-08-10 16:57:00 +02:00
jeffwadsworth
3f4475a136 - Fixed #6943 2020-08-10 09:11:30 -05:00
LevelX2
82e560f2ff * Once Upon A Time - Fixed that it was not always possible to cast it for free if allowed (fixes #6954). 2020-08-10 14:55:33 +02:00
LevelX2
300bb550df * Some code clean up. 2020-08-10 14:48:04 +02:00
LevelX2
2ce1a488f6 * Haldan Avid Arcanist - Fixed that the spend mana effect as was applied unconditionied to all players. 2020-08-10 14:47:50 +02:00
LevelX2
8bb6d1201f * Chromatic Orrey - Fixed that the spend mana effect was applied to all players (fixes #6950). 2020-08-10 14:46:36 +02:00
Evan Kranzler
113121d3e1 added Double Masters 2020-08-08 21:53:31 -04:00
Oleg Agafonov
9652d83aec Fixed tests 2020-08-08 19:08:38 +04:00
Oleg Agafonov
712af3152a Images download:
* Fixed broken direct links download;
* Fixed outdated card numbers in some sets;
* Fixed all non-downloadable images from scryfall source;
2020-08-08 18:55:10 +04:00
Oleg Agafonov
66a8994318 Tests: added sets implementation statistics in test_checkMissingSets 2020-08-08 14:02:28 +04:00
Oleg Agafonov
735588cc0d Sets refactor:
* Duels of the Planeswalkers Promos set split to multiple sets (scryfall style);
* Fixed Masterpiece Series sets name;
2020-08-08 13:17:49 +04:00
Oleg Agafonov
7599acf1c8 Removed duplicated sets that was split into multiple (Champs, Game Day, Launch Party, Media Inserts, Super Series) 2020-08-08 11:00:07 +04:00
Oleg Agafonov
f746d4d8d2 Images download:
* removed duplicated set (Clash Pack);
* added images download for Eighth Edition Box, Ninth Edition Box;
2020-08-08 10:14:17 +04:00
jeffwadsworth
5b9e871d8e - Resolved test issue. 2020-08-07 21:13:13 -05:00
jeffwadsworth
e9930504f6 - Fixed Fractured Loyalty. Related to Bug #6236 2020-08-07 16:22:35 -05:00
jeffwadsworth
f320b5507b - Fixed Followed Footsteps. Related to Bug #6236 2020-08-07 16:00:08 -05:00
jeffwadsworth
2abeb43449 - Added Port Inspector and Robber Fly 2020-08-07 15:36:43 -05:00
jeffwadsworth
5b84462eff - Added Chameleon Spirit 2020-08-07 14:05:44 -05:00
LevelX2
457557852e * Benthic Explorer - Fixed mana type calculation.
* DynamicManaEffect - Fixed mana type calculation.
Some code clean up.
2020-08-07 17:15:06 +02:00
Oleg Agafonov
9e6a348cb1
Merge branch 'master' into refactor_promo_sets 2020-08-07 02:48:40 +02:00
jeffwadsworth
97d1418ea4 - Added Cornered Market. 2020-08-06 16:49:41 -05:00
jeffwadsworth
bfa54c3418 - Fixed #6872. ¯\_(ツ)_/¯ 2020-08-06 16:06:48 -05:00
Oleg Agafonov
83f7ae377a Refactored restore state code, added additional error check for mana undo param; 2020-08-06 22:17:37 +04:00
Oleg Agafonov
2eeefd91ef Added additional test for prevent damage effects, improved 3358e2da80 (#6915) 2020-08-06 21:16:59 +04:00
jeffwadsworth
3358e2da80 - Fixed #6915. Please test if able. It works as far as I can tell. 2020-08-04 17:27:31 -05:00
jeffwadsworth
d945f95324 - Fixed #6922 2020-08-04 16:19:42 -05:00
jeffwadsworth
b17150188f - Fixed #6930 2020-08-04 15:19:11 -05:00
jeffwadsworth
c3de6bf8a0 - Fixed #6919. Fixed other cards with the same issue. 2020-08-04 14:15:50 -05:00
LevelX2
de110a92dd * Thermopod, Ashnods Altar, EverythingamagigE, Phyrexian Altar - Fixed available mana generation (#6698). 2020-08-03 21:53:36 +02:00
LevelX2
985d4205bf * Harvest Mage - Fixed available mana generation (#6698). 2020-08-03 21:26:47 +02:00
LevelX2
9dfc6eed69 * Squandered Resources - Fixed available mana calculation (#6698). 2020-08-02 22:47:03 +02:00
Oleg Agafonov
00411b4a9b * Regeneration abilities improved:
* Fixed that regeneration shield isn't added to permanent on aura sacrifice cost (example: Stamina, Carapace, see #2221);
 * Fixed that regeneration shields accumulated in attached aura instead permanent (bug example: re-attached aura gives old shields to new permanent, see #6846);
 * Added card hint with regeneration shields amount (#6846);
2020-08-02 14:01:58 +04:00
LevelX2
516a4104f1 * Treasonous Ogre - Fixed available mana generation (#6698). 2020-08-02 11:34:19 +02:00
LevelX2
67dd45c1c7 * Added getProducableManaTypes method for mana effects to handle Squandered Resources or Reflecting Pool like abilities.
* Fixes to Soldevi Adnate, Skirge Familiar, Mana Web.
2020-08-02 10:51:22 +02:00
Oleg Agafonov
c7595ca476 * Regeneration abilities - added card hint about activated and used regeneration; 2020-08-01 21:29:08 +04:00
LevelX2
c343767e8e * Fixed available mana generation of Jungle Patrol (was no mana ability) and Priest of Yawgmoth (#6698). 2020-07-31 13:53:07 +02:00
LevelX2
2fb8f627c2 * Trial of Ambition - Fixed typo in "sacrifices a creature" effect (fixes #6913). 2020-07-31 11:41:16 +02:00
Evan Kranzler
1ed9c09266 reimplemented Oubliette to use new errata 2020-07-30 18:27:50 -04:00
Oleg Agafonov
8e929d4e9d Fixed not working cost modification effects in get playable calcs from some cards (#6684):
* Kasmina, Enigmatic Mentor
* Kopala, Warden of Waves
* Monastery Siege
* Senator Lott Dod
* Terror of the Peaks
2020-07-30 22:06:12 +04:00
LevelX2
8f2c08efd3 * Highcliff Felidar - Fixed a problem that not always all players were handled (fixes #6826). 2020-07-30 10:29:13 +02:00
Oleg Agafonov
0824d2901a * Transform abilities - fixed duplicated triggered abilities from transformed permanents;
* Accursed Witch // Infectious Curse - fixed wrong cost modification effect (#6684);
2020-07-30 12:13:32 +04:00
LevelX2
7cfe39ae21 * Fixed that not all Equip abilities were correctly identified for abilities that changed Equip timig (e.g. Leonin Shikari - fixes #6907). 2020-07-29 16:16:47 +02:00
LevelX2
ffa837ae95 * Angel of Jubilation - Fixed that it did not only prevent life payment from casting spells or activating abilities (fixes #3663). 2020-07-29 14:48:14 +02:00
LevelX2
57de10d609 * Fixed failing M21 Tests (related to 51af4e7e1d). 2020-07-29 11:49:54 +02:00
jeffwadsworth
0385d9a653 - Removed some test code 2020-07-28 18:01:12 -05:00
jeffwadsworth
92580e480b - More fixes related to #6855 2020-07-28 17:58:43 -05:00
LevelX2
307d4a6283 Merge origin/master 2020-07-28 16:31:46 +02:00
LevelX2
9903944804 * Reworked retrieving spell characteristics (related to 98ebcc07ca). 2020-07-28 16:29:44 +02:00
LevelX2
c1ac2ac6ae * Conduit of Ruin - Fixed a problem with the spell cost reduction not working (#6698). 2020-07-28 16:28:23 +02:00
Oleg Agafonov
a5a5256cff Code cleanup 2020-07-28 18:15:32 +04:00
LevelX2
af5a0bb405 * Fixed available mana generation of Jungle Patrol, Kydele Chosen of Kruphix, Kykar Winds Fury and Mana Cache (#6698). 2020-07-28 14:41:49 +02:00
LevelX2
0458778c44 * Fixed bug of Druids Repository (related to b5c93cf2da), 2020-07-28 13:28:24 +02:00
jeffwadsworth
2665cf2eb6 - Fixed #6855. There are other examples of this issue that will be fixed as well. 2020-07-27 20:52:31 -05:00
jeffwadsworth
72b1cb549e - Fixed #6855. There are other examples of this issue that will be fixed as well. 2020-07-27 20:50:40 -05:00
Oleg Agafonov
93182913d0
Merge pull request #6902 from ketsuban/unesh
Fix Unesh, Criosphinx Sovereign
2020-07-28 03:21:45 +02:00
Thomas Winwood
2d8853b977 Address review comments 2020-07-28 02:06:50 +01:00
Oleg Agafonov
fdc32f891e * Raid abilities - added card hints about raid condition, fixed missing ability words; 2020-07-28 04:25:43 +04:00
LevelX2
b5c93cf2da * Fixed available mana generation of Druids Repository, Workhouse, Iceberg, Krak Clan Ironworks, Rasputin Dreamweaver and Sirk Prospector (#6698). 2020-07-28 01:03:33 +02:00
LevelX2
82a9726a35 * Fixed available mana generation of Virdian Joiner (#6698). 2020-07-27 23:50:07 +02:00
LevelX2
8e27ca31cd * Fixed available mana generation of Gemstone Array, Pentad Prism and
Utopia Mycon (#6698).
2020-07-27 23:00:39 +02:00
Thomas Winwood
a2fbfa87bc Fix Unesh, Criosphinx Sovereign
Unesh incorrectly defaulted to the first opponent in multiplayer rather
than letting the player choose an opponent.
2020-07-27 21:33:58 +01:00
LevelX2
82dfd76ee3 * Fervent Champion - Fixed that it's possible to equip the Champion also without having the regular mana (#6698). 2020-07-27 22:27:11 +02:00
LevelX2
6e68e038b6 * Bartered Cow - Fixed that it does nothing when discarded (fixes #6884). 2020-07-27 21:47:31 +02:00
LevelX2
7d7defe2c3 * Obosh, the Preypiercer - Fixed that the damage doubling was always done (fixes #6871). 2020-07-27 16:46:52 +02:00
LevelX2
7a78be8c6a * Some target pointer changes and code clean up. 2020-07-26 00:16:14 +02:00
jeffwadsworth
202e25208e - Fixed text Feedback. 2020-07-25 10:11:42 -05:00
Oleg Agafonov
3abe5e796a Server: removed unnecessary logs, extra comments 2020-07-25 19:06:38 +04:00
Oleg Agafonov
848c5b6052 Fixed missing watchers from DelayedTriggeredAbility:
* Planeswalkers Mischief - fixed rollback error on play;
* Psychic Theft - fixed rollback error on play;
2020-07-25 19:01:49 +04:00
Oleg Agafonov
32b7c592c8 * Sanguine Indulgence - fixed rollback error on play, fixed card text (#6643); 2020-07-25 17:26:10 +04:00
Oleg Agafonov
06e22a211d * Alpine Houndmaster - fixed that it boost until attack ends instead until end turn, fixed text (#6643); 2020-07-25 13:48:31 +04:00
Oleg Agafonov
043785b1d1 * Metalcraft abilities - added card hints about artifacts count, fixed missing ability word; 2020-07-25 05:40:59 +04:00
Oleg Agafonov
97c427375d Fixed face down cost modification (related to 653a2dd7b2) 2020-07-24 21:30:03 +04:00
Oleg Agafonov
dfaf09e76c * Hamletback Goliath - fixed rollback error (#6882); 2020-07-24 20:02:15 +04:00
senft
855e09810a Fix FilterCard name of TrinketMage
The cardinality is added via the TargetCardInLibrary.
2020-07-24 17:46:52 +02:00
LevelX2
4d43914673 * Morselhoarder - Fixed calculation of available mana and some cleanup to other mana abilities (#6698). 2020-07-24 16:41:36 +02:00