github/melpa
1
0
Fork 0
mirror of https://github.com/correl/melpa.git synced 2024-12-23 11:14:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

Prefer ng-if to ng-show where applicable

Browse source
This commit is contained in:
Steve Purcell 2013-08-24 17:17:19 +01:00
parent 9b50b9d464
commit 479251acab
4 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
html/index.html
View file

@ -29,7 +29,7 @@
</div>
</header>
<main class="container">
<div ng-show="showSplash">
<div ng-if="showSplash">
<!-- This content is handled separately from the main view for the benefit of bots and initial page load -->
<section class="page-header">
<h1>MELPA <small>(Milkypostman’s Emacs Lisp Package Archive)</small></h1>

2
html/js/melpa.js
View file

@ -154,7 +154,7 @@
app.directive("viewOrError", function($rootScope) {
return {
template: '<div>' +
'<div class="alert alert-danger" ng-show="routeError"><strong>Error: </strong>{{routeError}}</div>' +
'<div class="alert alert-danger" ng-if="routeError"><strong>Error: </strong>{{routeError}}</div>' +
'<div ng-if="!routeError" ng-view><ng-transclude></ng-transclude></div>'+'</div>',
transclude: true,
link: function(scope) {

4
html/partials/list.html
View file

@ -25,8 +25,8 @@
<td class="version"><a href="{{package.packageURL}}">{{package.version}} <span class="glyphicon glyphicon-download"></span></a></td>
<td class="recipe"><a href="{{package.recipeURL}}"><span class="glyphicon glyphicon-cutlery"></span></a></td>
<td class="source">
<a ng-show="package.sourceURL" href="{{package.sourceURL}}">{{package.source}}</a>
<span ng-show="!package.sourceURL">{{package.source}}</span>
<a ng-if="package.sourceURL" href="{{package.sourceURL}}">{{package.source}}</a>
<span ng-if="!package.sourceURL">{{package.source}}</span>
</td>
<td>{{package.downloads}}</td>
</tr>

14
html/partials/package.html
View file

@ -6,7 +6,7 @@
<p>
<a href="{{pkg.recipeURL}}" class="btn btn-default"><span class="glyphicon glyphicon-cutlery"> Recipe</a>
<a href="{{pkg.packageURL}}" class="btn btn-default"><span class="glyphicon glyphicon-download"> Download</a>
<a ng-show="pkg.sourceURL" href="{{pkg.sourceURL}}" class="btn btn-default"><span class="glyphicon glyphicon-home"> Homepage</a>
<a ng-if="pkg.sourceURL" href="{{pkg.sourceURL}}" class="btn btn-default"><span class="glyphicon glyphicon-home"> Homepage</a>
</p>
<section>
<div class="well">
@ -15,21 +15,21 @@
<dd>{{pkg.downloads}} <span class="muted">(all versions)</span></dd>
<dt>Source</dt>
<dd>
<a ng-show="pkg.sourceURL" href="{{pkg.sourceURL}}">{{pkg.source}}</a>
<span ng-show="!pkg.sourceURL">{{pkg.source}}</span>
<a ng-if="pkg.sourceURL" href="{{pkg.sourceURL}}">{{pkg.source}}</a>
<span ng-if="!pkg.sourceURL">{{pkg.source}}</span>
</dd>
<dt>Dependencies</dt>
<dd><span ng-show="pkg.dependencies.length > 0" ng-repeat="dep in pkg.dependencies">
<dd><span ng-if="pkg.dependencies.length" ng-repeat="dep in pkg.dependencies">
<a ng-if="havePackage(dep.name)" href="#/{{dep.name}}">{{dep.name}} {{dep.version}}</a>
<span ng-if="!havePackage(dep.name)">{{dep.name}} {{dep.version}}</span>
&nbsp;</span>
<span class="muted" ng-show="pkg.dependencies.length == 0">-</span>
<span class="muted" ng-if="!pkg.dependencies.length">-</span>
</dd>
<dt>Needed by</dt>
<dd><span ng-show="reverseDependencies.length > 0" ng-repeat="dep in reverseDependencies | orderBy:'name'">
<dd><span ng-if="reverseDependencies.length" ng-repeat="dep in reverseDependencies | orderBy:'name'">
<a href="#/{{dep.name}}">{{dep.name}}</a>
&nbsp;</span>
<span class="muted" ng-show="reverseDependencies.length == 0">-</span>
<span class="muted" ng-if="reverseDependencies.length == 0">-</span>
</dd>
</dl>
</div>