Merge pull request #170 from p1c2u/fix/validation-schema-errors-iter-fix

Validation schema errors iter fix
This commit is contained in:
A 2019-10-23 09:28:17 +01:00 committed by GitHub
commit cabe512fb0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 6 deletions

View file

@ -48,13 +48,19 @@ class UnmarshalValueError(UnmarshalError):
class InvalidSchemaValue(ValidateError): class InvalidSchemaValue(ValidateError):
value = attr.ib() value = attr.ib()
type = attr.ib() type = attr.ib()
schema_errors = attr.ib() _schema_errors = attr.ib(default=None)
_schema_errors_iter = attr.ib(factory=list)
@property
def schema_errors(self):
if self._schema_errors is None:
self._schema_errors = list(self._schema_errors_iter)
return self._schema_errors
def __str__(self): def __str__(self):
errors = list(self.schema_errors)
return ( return (
"Value {value} not valid for schema of type {type}: {errors}" "Value {value} not valid for schema of type {type}: {errors}"
).format(value=self.value, type=self.type, errors=errors) ).format(value=self.value, type=self.type, errors=self.schema_errors)
class UnmarshallerError(UnmarshalError): class UnmarshallerError(UnmarshalError):

View file

@ -194,7 +194,8 @@ class Schema(object):
return validator.validate(value) return validator.validate(value)
except ValidationError: except ValidationError:
errors_iter = validator.iter_errors(value) errors_iter = validator.iter_errors(value)
raise InvalidSchemaValue(value, self.type, errors_iter) raise InvalidSchemaValue(
value, self.type, schema_errors_iter=errors_iter)
def unmarshal(self, value, custom_formatters=None, strict=True): def unmarshal(self, value, custom_formatters=None, strict=True):
"""Unmarshal parameter from the value.""" """Unmarshal parameter from the value."""

View file

@ -175,13 +175,14 @@ class TestPetstore(object):
response_result = response_validator.validate(request, response) response_result = response_validator.validate(request, response)
errors = response_result.errors[0].original_exception.schema_errors original_exc = response_result.errors[0].original_exception
assert response_result.errors == [ assert response_result.errors == [
InvalidMediaTypeValue( InvalidMediaTypeValue(
original_exception=InvalidSchemaValue( original_exception=InvalidSchemaValue(
type=SchemaType.OBJECT, type=SchemaType.OBJECT,
value=data_json, value=data_json,
schema_errors=errors, schema_errors=original_exc.schema_errors,
schema_errors_iter=original_exc._schema_errors_iter,
), ),
), ),
] ]