github/rebar
1
0
Fork 0
mirror of https://github.com/correl/rebar.git synced 2024-12-18 03:00:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix handling of {already_started,Pid} from cover:start

Browse source 
Previous patch erroneously assumed that cover:start() returned
{already_started,Pid} in the cases where cover was already started. We
now turn {error,{already_started,Pid}} into {ok, Pid} and return
{error, Reason} if we encounter an error we do not know about, this
will cause a nice and violent badmatch to stop everything.
This commit is contained in:
David Reid 2011-08-08 09:46:58 -07:00 committed by Tuncer Ayaz
parent 2911d48fb1
commit 6736e3147e
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/rebar_eunit.erl
View file

@ -288,8 +288,16 @@ cover_init(false, _BeamFiles) ->
cover_init(true, BeamFiles) -> cover_init(true, BeamFiles) ->
%% Attempt to start the cover server, then set it's group leader to %% Attempt to start the cover server, then set it's group leader to
%% .eunit/cover.log, so all cover log messages will go there instead of %% .eunit/cover.log, so all cover log messages will go there instead of
%% to stdout. %% to stdout. If the cover server is already started we'll reuse that
{_,CoverPid} = cover:start(), %% pid.
{ok, CoverPid} = case cover:start() of
{ok, P} ->
{ok, P};
{error,{already_started, P}} ->
{ok, P};
{error, Reason} ->
{error, Reason}
end,
{ok, F} = file:open( {ok, F} = file:open(
filename:join([?EUNIT_DIR, "cover.log"]), filename:join([?EUNIT_DIR, "cover.log"]),