github/rebar
1
0
Fork 0
mirror of https://github.com/correl/rebar.git synced 2024-11-14 19:19:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

deps: fix delete-deps if deps_dir ends with dot

Browse source 
Remove possible last dot from deps dir path by calling
dirname on base_dir, deps_dir and dummy path part.
With this fix delete-deps command deletes dependencies
properly in case of deps dir path ended with dot.
Examples of deps_dir config value that triggers error:
".", "some/path/.".
Code that triggers error: rebar_deps:'delete-deps'/2,
code line lists:prefix(DepsDir, D#dep.dir).
If deps_dir = ".", cwd = "/root", dependency name = "app"
then DepsDir = "/root/." and D#dep.dir = "/root/app" so
prefix fun returns false but should be true.
Dependency app will not be removed because of this.
This commit is contained in:
Pavel Baturko 2014-10-24 09:46:17 +04:00
parent c051530b3c
commit 703a9dae9e
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/rebar_deps.erl
View file

@ -307,8 +307,9 @@ get_deps_dir(Config) ->
get_deps_dir(Config, App) ->
BaseDir = rebar_utils:base_dir(Config),
DepsDir = get_shared_deps_dir(Config, "deps"),
{true, filename:join([BaseDir, DepsDir, App])}.
DepsDir0 = get_shared_deps_dir(Config, "deps"),
DepsDir = filename:dirname(filename:join([BaseDir, DepsDir0, "dummy"])),
{true, filename:join([DepsDir, App])}.
dep_dirs(Deps) ->
[D#dep.dir || D <- Deps].