github/sprockets-postgres
1
0
Fork 0
mirror of https://github.com/sprockets/sprockets-postgres.git synced 2024-11-14 11:19:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2 from cknave/fix-record-timing-args

Browse source 
Fix argument order for record_timing()
This commit is contained in:
Gavin M. Roy 2020-07-30 15:11:27 -04:00 committed by GitHub
commit f95e40ef7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
VERSION
View file

@ -1 +1 @@
1.3.2 1.3.3

2
sprockets_postgres.py
View file

@ -709,7 +709,7 @@ class RequestHandlerMixin:
if hasattr(self, 'influxdb'): # sprockets-influxdb if hasattr(self, 'influxdb'): # sprockets-influxdb
self.influxdb.set_field(metric_name, duration) self.influxdb.set_field(metric_name, duration)
elif hasattr(self, 'record_timing'): # sprockets.mixins.metrics elif hasattr(self, 'record_timing'): # sprockets.mixins.metrics
self.record_timing(metric_name, duration) self.record_timing(duration, metric_name)
else: else:
LOGGER.debug('Postgres query %s duration: %s', LOGGER.debug('Postgres query %s duration: %s',
metric_name, duration) metric_name, duration)

3
tests.py
View file

@ -344,6 +344,9 @@ class RequestHandlerMixinTestCase(TestCase):
self.assertEqual(response.code, 200) self.assertEqual(response.code, 200)
self.assertEqual(json.loads(response.body)['value'], expectation) self.assertEqual(json.loads(response.body)['value'], expectation)
self.app.record_timing.assert_called_once() self.app.record_timing.assert_called_once()
duration, metric_name = self.app.record_timing.call_args[0]
self.assertGreater(duration, 0.0)
self.assertEqual('', metric_name)
def test_postgres_multirow_get(self): def test_postgres_multirow_get(self):
response = self.fetch('/multi-row') response = self.fetch('/multi-row')