From c7a3a834c028648e32b0e77b49611d7ae26b3bb5 Mon Sep 17 00:00:00 2001 From: Dave Shawley Date: Mon, 10 May 2021 07:47:56 -0400 Subject: [PATCH] Remove explicit sonar scan of PR. I cannot for the life of me figure out how to get the sonar token to be available in the PR. Setting it in the project doesn't work for PRs since tokens are not available to PRs run from forks. Setting it in my fork didn't work either. It is available via codecov so /shrug --- .github/workflows/run-tests.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index e749d7d..bf21fd4 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -15,8 +15,6 @@ jobs: python-version: [3.7, 3.8, 3.9] steps: - uses: actions/checkout@v2 - with: - fetch-depth: 0 # sonar wants a "deep" clone - name: Install python ${{ matrix.python-version }} uses: actions/setup-python@v2 with: @@ -44,12 +42,6 @@ jobs: file: ./coverage.xml flags: unittests fail_ci_if_error: true - - name: Run sonarqube scan - if: ${{ matrix.python-version == '3.9' }} - uses: SonarSource/sonarcloud-github-action@v1.3 - env: - GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} - SONAR_TOKEN: ${{secrets.SONAR_TOKEN}} - name: Save coverage report if: ${{ matrix.python-version == '3.9' }} uses: actions/upload-artifact@v2