PR feedback

This commit is contained in:
Robin Klingsberg 2019-03-19 19:18:06 -04:00
parent 4c26834f04
commit 183eb3269e
5 changed files with 6 additions and 5 deletions

View file

@ -1,5 +1,6 @@
-r requires/installation.txt -r requires/installation.txt
-r requires/testing.txt -r requires/testing.txt
-e .
flake8 flake8
sphinx>=1.2,<2 sphinx>=1.2,<2

View file

@ -1 +1 @@
tornado>=4.0,<6.1 tornado>=4.3,<7

View file

@ -46,7 +46,7 @@ class HandlerMixin(object):
# one exists. We also want to set it in the outgoing response # one exists. We also want to set it in the outgoing response
# which the property setter does for us. # which the property setter does for us.
maybe_future = super(HandlerMixin, self).prepare() maybe_future = super(HandlerMixin, self).prepare()
if concurrent.is_future(maybe_future): # pragma: nocover if concurrent.is_future(maybe_future):
await maybe_future await maybe_future
correlation_id = self.get_request_header(self.__header_name, None) correlation_id = self.get_request_header(self.__header_name, None)

View file

@ -57,11 +57,11 @@ class CorrelationIDLoggerTests(testing.AsyncHTTPTestCase):
self.patcher = unittest.mock.patch( self.patcher = unittest.mock.patch(
'sprockets.mixins.correlation.mixins.log.access_log') 'sprockets.mixins.correlation.mixins.log.access_log')
self.access_logger = self.patcher.start() self.access_logger = self.patcher.start()
super(CorrelationIDLoggerTests, self).setUp() super().setUp()
def tearDown(self): def tearDown(self):
self.patcher.stop() self.patcher.stop()
super(CorrelationIDLoggerTests, self).tearDown() super().tearDown()
def test_lt_400_logs_info(self): def test_lt_400_logs_info(self):
for status in (200, 202): for status in (200, 202):

View file

@ -22,4 +22,4 @@ deps =
[testenv:tornado6] [testenv:tornado6]
deps = deps =
-r requires/testing.txt -r requires/testing.txt
tornado>=6,<6.1 tornado>=6,<7