github/sprockets.mixins.mediatype
1
0
Fork 0
mirror of https://github.com/sprockets/sprockets.mixins.mediatype.git synced 2024-11-21 19:28:38 +00:00
Code Issues Projects Releases Packages Wiki Activity

Optimize the URL encoding inner loop.

Browse source 
I rearranged the _encode method branching a bit.  This resulted in a
little more than a 12% gain.  Still slower than JSON or msgpack but it's
in python instead of C.
This commit is contained in:
Dave Shawley 2021-10-13 06:49:07 -04:00
parent 25ec09972c
commit ee66c5cadb
No known key found for this signature in database
GPG key ID: F41A8A99298F8EED
1 changed files with 17 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
sprockets/mixins/mediatype/transcoders.py
View file

@ -394,25 +394,23 @@ class FormUrlEncodedTranscoder:
def _encode(self, datum: typing.Union[bool, None, float, int, str,
type_info.DefinesIsoFormat],
char_map: typing.Mapping[int, str], encoding: str) -> str:
try:
datum = self.options.literal_mapping[datum] # type: ignore
except (KeyError, TypeError):
if isinstance(datum, (bytearray, bytes, memoryview)):
return ''.join(char_map[c] for c in datum)
if datum is None or isinstance(datum, bool):
raise TypeError(
f'{datum.__class__.__name__} is not serializable'
) from None
if isinstance(datum, (float, int, str, uuid.UUID)):
datum = str(datum)
elif datum is not None and hasattr(datum, 'isoformat'):
datum = datum.isoformat()
else:
raise TypeError(
f'{datum.__class__.__name__} is not serializable'
) from None
if isinstance(datum, str):
pass # optimization: skip additional checks for strings
elif datum in self.options.literal_mapping:
datum = self.options.literal_mapping[datum]
elif isinstance(datum, (bytearray, bytes, memoryview)):
return ''.join(char_map[c] for c in datum)
elif datum is None or isinstance(datum, bool):
# This could happen if the user modifies the literal mapping
# and MUST be before the isinstance(datum, int) check since
# Boolean literals are integers instances
raise TypeError(f'{datum.__class__.__name__} is not serializable')
elif isinstance(datum, (float, int, str, uuid.UUID)):
datum = str(datum)
elif hasattr(datum, 'isoformat'):
datum = datum.isoformat()
else:
raise TypeError(f'{datum.__class__.__name__} is not serializable')
return ''.join(char_map[c] for c in datum.encode(encoding))