github/sprockets.mixins.metrics
1
0
Fork 0
mirror of https://github.com/sprockets/sprockets.mixins.metrics.git synced 2024-11-25 03:00:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use ephemeral port in tests for statsd

Browse source
This commit is contained in:
Ryan Mclean 2016-08-02 17:41:32 -04:00
parent af62789a96
commit 1fb1f46bc1
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sprockets/mixins/metrics/testing.py
View file

@ -33,7 +33,7 @@ class FakeStatsdServer(object):
def __init__(self, iol): def __init__(self, iol):
self.socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, self.socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM,
socket.IPPROTO_UDP) socket.IPPROTO_UDP)
self.socket.bind(('127.0.0.1', 8125)) self.socket.bind(('127.0.0.1', 0))
self.sockaddr = self.socket.getsockname() self.sockaddr = self.socket.getsockname()
self.datagrams = [] self.datagrams = []

13
tests.py
View file

@ -41,13 +41,15 @@ class StatsdMetricCollectionTests(testing.AsyncHTTPTestCase):
web.url('/', examples.statsd.SimpleHandler), web.url('/', examples.statsd.SimpleHandler),
web.url('/counters/(.*)/([.0-9]*)', CounterBumper), web.url('/counters/(.*)/([.0-9]*)', CounterBumper),
]) ])
statsd.install(self.application, **{'namespace': 'testing'})
return self.application return self.application
def setUp(self): def setUp(self):
self.application = None self.application = None
super(StatsdMetricCollectionTests, self).setUp() super(StatsdMetricCollectionTests, self).setUp()
self.statsd = FakeStatsdServer(self.io_loop) self.statsd = FakeStatsdServer(self.io_loop)
statsd.install(self.application, **{'namespace': 'testing',
'host': self.statsd.sockaddr[0],
'port': self.statsd.sockaddr[1]})
def tearDown(self): def tearDown(self):
self.statsd.close() self.statsd.close()
@ -102,9 +104,6 @@ class StatsdConfigurationTests(testing.AsyncHTTPTestCase):
web.url('/', examples.statsd.SimpleHandler), web.url('/', examples.statsd.SimpleHandler),
web.url('/counters/(.*)/([.0-9]*)', CounterBumper), web.url('/counters/(.*)/([.0-9]*)', CounterBumper),
]) ])
statsd.install(self.application, **{'namespace': 'testing',
'prepend_metric_type': False,
'prepend_hostname': False})
return self.application return self.application
def setUp(self): def setUp(self):
@ -112,6 +111,12 @@ class StatsdConfigurationTests(testing.AsyncHTTPTestCase):
super(StatsdConfigurationTests, self).setUp() super(StatsdConfigurationTests, self).setUp()
self.statsd = FakeStatsdServer(self.io_loop) self.statsd = FakeStatsdServer(self.io_loop)
statsd.install(self.application, **{'namespace': 'testing',
'host': self.statsd.sockaddr[0],
'port': self.statsd.sockaddr[1],
'prepend_metric_type': False,
'prepend_hostname': False})
def tearDown(self): def tearDown(self):
self.statsd.close() self.statsd.close()
super(StatsdConfigurationTests, self).tearDown() super(StatsdConfigurationTests, self).tearDown()