mirror of
https://github.com/sprockets/sprockets.mixins.metrics.git
synced 2025-04-07 17:00:20 -09:00
InfluxDBMixin: Remove unnecessary quotes from tags.
It turns out that tag values are always treated as string values so the quotes are not necessary.
This commit is contained in:
parent
1d6c2b7597
commit
b9d71dde6b
3 changed files with 9 additions and 7 deletions
|
@ -3,6 +3,10 @@
|
||||||
Release History
|
Release History
|
||||||
===============
|
===============
|
||||||
|
|
||||||
|
`Next Release`_
|
||||||
|
---------------
|
||||||
|
- Remove extraneous quotes from InfluxDB tag values.
|
||||||
|
|
||||||
`0.9.0`_ (27-Jan-2016)
|
`0.9.0`_ (27-Jan-2016)
|
||||||
----------------------
|
----------------------
|
||||||
- Add :class:`sprockets.mixins.metrics.StatsdMixin`
|
- Add :class:`sprockets.mixins.metrics.StatsdMixin`
|
||||||
|
|
|
@ -137,6 +137,6 @@ class InfluxDBMixin(object):
|
||||||
self.record_timing(self.request.request_time(), 'duration')
|
self.record_timing(self.request.request_time(), 'duration')
|
||||||
self.settings[self.SETTINGS_KEY]['db_connection'].submit(
|
self.settings[self.SETTINGS_KEY]['db_connection'].submit(
|
||||||
self.settings[self.SETTINGS_KEY]['measurement'],
|
self.settings[self.SETTINGS_KEY]['measurement'],
|
||||||
('{}="{}"'.format(k, v) for k, v in self.__tags.items()),
|
('{}={}'.format(k, v) for k, v in self.__tags.items()),
|
||||||
self.__metrics,
|
self.__metrics,
|
||||||
)
|
)
|
||||||
|
|
10
tests.py
10
tests.py
|
@ -146,10 +146,9 @@ class InfluxDbTests(testing.AsyncHTTPTestCase):
|
||||||
if key.startswith('my-service,'):
|
if key.startswith('my-service,'):
|
||||||
tag_dict = dict(a.split('=') for a in key.split(',')[1:])
|
tag_dict = dict(a.split('=') for a in key.split(',')[1:])
|
||||||
self.assertEqual(tag_dict['handler'],
|
self.assertEqual(tag_dict['handler'],
|
||||||
'"examples.influxdb.SimpleHandler"')
|
'examples.influxdb.SimpleHandler')
|
||||||
self.assertEqual(tag_dict['method'], '"GET"')
|
self.assertEqual(tag_dict['method'], 'GET')
|
||||||
self.assertEqual(tag_dict['host'],
|
self.assertEqual(tag_dict['host'], socket.gethostname())
|
||||||
'"{}"'.format(socket.gethostname()))
|
|
||||||
|
|
||||||
value_dict = dict(a.split('=') for a in fields.split(','))
|
value_dict = dict(a.split('=') for a in fields.split(','))
|
||||||
assert_between(0.25, float(value_dict['duration']), 0.3)
|
assert_between(0.25, float(value_dict['duration']), 0.3)
|
||||||
|
@ -205,8 +204,7 @@ class InfluxDbTests(testing.AsyncHTTPTestCase):
|
||||||
for key, fields, timestamp in self.influx_messages:
|
for key, fields, timestamp in self.influx_messages:
|
||||||
if key.startswith('my-service,'):
|
if key.startswith('my-service,'):
|
||||||
tag_dict = dict(a.split('=') for a in key.split(',')[1:])
|
tag_dict = dict(a.split('=') for a in key.split(',')[1:])
|
||||||
self.assertEqual(tag_dict['correlation_id'],
|
self.assertEqual(tag_dict['correlation_id'], cid)
|
||||||
'"{}"'.format(cid))
|
|
||||||
break
|
break
|
||||||
else:
|
else:
|
||||||
self.fail('Expected to find "request" metric in {!r}'.format(
|
self.fail('Expected to find "request" metric in {!r}'.format(
|
||||||
|
|
Loading…
Add table
Reference in a new issue