Merge pull request #1 from gmr/fix-server-matching

Tornado HTTPServerRequest.uri is just the path portion of the URI
This commit is contained in:
Correl Roush 2020-12-04 13:33:55 -05:00 committed by GitHub
commit 535eaaa988
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions

View file

@ -1,7 +1,7 @@
from dataclasses import dataclass
from typing import Dict, List, Optional
import unittest
from urllib.parse import urlencode
from urllib.parse import urlencode, urlparse
import attr
from hypothesis import given, settings # type: ignore
@ -115,7 +115,11 @@ class TestRequestFactory(unittest.TestCase):
def test_http_server_request(self, opts) -> None:
url, parameters = opts
request_url = f"{url}?{urlencode(parameters)}" if url else ""
tornado_request = HTTPServerRequest(method="GET", uri=request_url)
parsed = urlparse(request_url)
tornado_request = HTTPServerRequest(
method="GET", uri=f"{parsed.path}?{parsed.query}")
tornado_request.protocol = parsed.scheme
tornado_request.host = parsed.netloc.split(':')[0]
expected = OpenAPIRequest(
full_url_pattern=url,
method="get",

View file

@ -25,10 +25,9 @@ class TornadoRequestFactory:
path = ""
query_arguments = ImmutableMultiDict()
else:
if request.uri:
path, _, _ = request.uri.partition("?")
else:
path = ""
path, _, _ = request.full_url().partition("?")
if path == '://':
path = ''
query_arguments = ImmutableMultiDict(
itertools.chain(
*[