issue from Amazon AppStore team - casing in ticker could cause duplicate tickers (and crashing), fixed to always uppercase tickers when saving & checking for duplication

This commit is contained in:
mgroves 2011-04-12 21:54:21 -04:00
parent d6eba45a2d
commit d4e1ac708e

View file

@ -118,7 +118,7 @@ namespace MonoStockPortfolio.Core.PortfolioRepositories
public bool IsTickerAlreadyBeingTracked(string ticker, long portfolioId)
{
var cursor = Db.RawQuery("SELECT 1 FROM " + POSITION_TABLE_NAME + " WHERE Ticker = ? AND ContainingPortfolioID = ?",
new[] { ticker, portfolioId.ToString() });
new[] { ticker.ToUpper(), portfolioId.ToString() });
var result = cursor.Count > 0;
if(!cursor.IsClosed) cursor.Close();
return result;
@ -189,7 +189,7 @@ namespace MonoStockPortfolio.Core.PortfolioRepositories
{
var positionValues = new ContentValues();
positionValues.Put("PricePerShare", (double)position.PricePerShare);
positionValues.Put("Ticker", position.Ticker);
positionValues.Put("Ticker", position.Ticker.ToUpper());
positionValues.Put("Shares", (double)position.Shares);
positionValues.Put("ContainingPortfolioID", position.ContainingPortfolioID);
return positionValues;