github/mage
1
0
Fork 0
mirror of https://github.com/correl/mage.git synced 2025-03-29 17:00:07 -09:00
Code Issues Projects Releases Packages Wiki Activity

Real fix to prev commit

Browse source
This commit is contained in:
Oleg Agafonov 2020-01-12 09:25:51 +04:00
parent 92e15283ea
commit 589142aeb5
2 changed files with 3 additions and 6 deletions
Mage.Server.Plugins/Mage.Player.Human/src/mage/player/human
HumanPlayer.java
Mage.Tests/src/test/java/org/mage/test/cards/continuous
TappedForManaFromMultipleEffects.java

3
Mage.Server.Plugins/Mage.Player.Human/src/mage/player/human/HumanPlayer.java
View file

@ -1,6 +1,5 @@
package mage.player.human;
import jdk.nashorn.internal.objects.NativeError;
import mage.MageObject;
import mage.abilities.*;
import mage.abilities.costs.VariableCost;
@ -2399,7 +2398,7 @@ public class HumanPlayer extends PlayerImpl {
private boolean gameInCheckPlayableState(Game game, boolean ignoreWarning) {
if (game.inCheckPlayableState()) {
if (!ignoreWarning) {
logger.warn("Player interaction in checkPlayableState./n" + NativeError.printStackTrace(this));
logger.warn("Player interaction in checkPlayableState", new Throwable());
}
return true;
}

6
Mage.Tests/src/test/java/org/mage/test/cards/continuous/TappedForManaFromMultipleEffects.java
View file

@ -53,10 +53,8 @@ public class TappedForManaFromMultipleEffects extends CardTestPlayerBase {
// cast nyx 2
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Nyxbloom Ancient");
// real choice must be called one time only (from playManaAbility) after fix, see above to-do
// TODO: TAPPED_FOR_MANA replace event called from checkTappedForManaReplacement and start to choose replace events, if logs enabled then it cause the error
// use case 1 (human game only): do not ignore check playable logs in chooseReplacementEffect for HumanPlayer - you will get rollback error on second Nyxbloom Ancient cast
// use case 2 (that test): comment one 1-2 choices to fail in 1-2 calls
// TODO: TAPPED_FOR_MANA replace event called from checkTappedForManaReplacement and start to choose replace events (is that problem?)
// use case (that test): comment one 1-2 choices to fail in 1-2 calls
setChoice(playerA, "Nyxbloom Ancient: If you tap a permanent"); // getPlayable... checkTappedForManaReplacement... chooseReplacementEffect
setChoice(playerA, "Nyxbloom Ancient: If you tap a permanent"); // playManaAbility... resolve... checkToFirePossibleEvents... chooseReplacementEffect