Justin Herlehy
14507e7dc5
Fix GameImpl SBA for auras attached to players.
...
attachedToPlayer was always getting set to something so the null check in the SBA loop was not allowing auras to be put into the graveyard for being attached to an illegal player. Currently checks for hasLost() as the player leaving also sets loses to true.
2016-12-30 01:56:04 -05:00
ludwig.hirth
6c72794859
* Added test.
2016-12-29 17:05:32 +01:00
ludwig.hirth
b26a5730fa
* Mage Slayer - Fixed that the correct damage source was assigned for the additional damage.
2016-12-29 16:18:52 +01:00
LevelX2
d3c2c33b44
* Added static Goblins filter.
2016-12-28 11:32:29 +01:00
LevelX2
ecc18072cf
Cyclopean Tomb - Update.
2016-12-28 02:02:57 +01:00
LevelX2
cebfadbf34
Merge pull request #2709 from MTGfan/master
...
Cyclopean Tomb TODO: inside watcher get ID for card
2016-12-27 16:38:27 +01:00
LevelX2
8075ea2e50
* Fixed a problem that Emblems created by permanents where its owner left the game caused errors in clients. Some handling cganges of emblems.
2016-12-27 16:00:22 +01:00
LevelX2
ad5699f119
* Fixed a bug that the color choice was fixed if used in activated abilities (e.g. Obi-Wan Kenobi) beyond the first usgae.
2016-12-27 11:48:18 +01:00
Justin Herlehy
5cfec72d81
[TOKEN] Goblin with Haste
...
The 1/1 red goblin with haste token was failing to specify that it was a token with haste is the fallback autotext.
2016-12-27 00:08:13 -05:00
LevelX2
862ac38f51
* Fixed that special actions (e.g. delve mana payment) were handled correctly if a player plays a turn for another player.
2016-12-24 16:52:06 +01:00
LevelX2
a632f9c0e8
Fixed a problem that Dwarven Recruiter, Goblin Recruiter or Scouting Trek searched for the wrong subtype.
2016-12-24 11:55:30 +01:00
LevelX2
c6d54c929f
Fixed a problem that selecting cards in hand or libraray could unintended trigger "becomes the target of a spell or ability" abilities.
2016-12-24 11:42:11 +01:00
MTGfan
8a807c888c
Merge remote-tracking branch 'upstream/master'
2016-12-24 00:13:54 -05:00
LevelX2
8ba22ad7e2
* Fixed that selecting no target players let fizzle the spell (e.g. Wheel and Deal).
2016-12-22 23:50:02 +01:00
Styxo
c2ef2b1f47
[CN2] Added Deadly Designs and Fang of the Pack
2016-12-22 08:05:22 +01:00
MTGfan
7e867f4fcf
Cyclopean Tomb TODO: remove counters part of effect
2016-12-21 19:46:46 -05:00
LevelX2
f0ba7d38a6
Merge pull request #2697 from sotovdev/master
...
Refactoring SQl query + unwanted ArrayList creation
2016-12-21 15:48:01 +01:00
Styxo
2eb0a487a4
Added WishEffect, ExchangeLifeTargetEffect and did refactors
2016-12-20 13:31:39 +01:00
Styxo
009676f75f
Added HippoToken
2016-12-19 12:40:58 +01:00
Styxo
cff83aefb1
Created LoseHalfLifeTargetEffect, DiscardedByOpponentTrigger and made some refactors
2016-12-19 12:39:26 +01:00
vraskulin
2e83930ace
Creating new ArrayList is unneccesarry
...
We shouldn't create new arraylist with default size and no element in it to show that no elements found in database. It's one more object in heap, which will be never used. There is special method Collections.emptyList() - it's more readeable and returns empty immutable list
2016-12-19 12:23:23 +03:00
vraskulin
e22951c68e
Repository objects refactoring
...
SQL query is limited by 1, so there will be two cases - whether collection is empty or not. We should user convenient shortcut for checking emptiness of collection
2016-12-19 11:30:32 +03:00
LevelX2
1de210ab74
* Fixed a bug of DealsDamageToOneOrMoreCreaturesTriggeredAbility, added some tests.
2016-12-18 17:50:33 +01:00
LevelX2
d85b9943f1
* Added logic to remove control effects that refer to permanents of a player that leaves the game.
2016-12-18 16:57:34 +01:00
LevelX2
40d8a32695
XMage 1.4.19V1
2016-12-17 10:35:45 +01:00
LevelX2
61dd62b148
* Undiscovered Paradise - Fixed that it was not returned to hand on untap step ( fixes #2693 ).
2016-12-17 09:27:24 +01:00
LevelX2
8e51e3a2bf
Merge pull request #2686 from MTGfan/master
...
Guardian Angel and added Dynamic Value constructor to PreventDamageToTargetEffect
2016-12-16 22:57:21 +01:00
LevelX2
6955ad803f
Merge pull request #2691 from sotovdev/sqlPerf
...
SQL query perfomance improvements
2016-12-16 22:34:38 +01:00
LevelX2
8d6d8d25e5
* Reflecting Pool - Fixed that mana from dynamic mana abilities were not taken into account (e.g. Gaea's Cradle or Serra's Sanctum).
2016-12-16 18:38:40 +01:00
vraskulin
3be7598ee1
SQL query perfomance improvements
...
There will be always 0 or 1 distinct result. If we don't limit this query it will find an item, and still will go through the whole table trying another one, which is unneccesary and have performance impact.
2016-12-16 17:27:19 +03:00
Styxo
8e6cf84ce4
Added TargetHasCounterCondition and option for BecomesMonstrous
2016-12-15 15:33:35 +01:00
MTGfan
26c176abaa
Guardian Angel and added Dynamic Value constructor to PreventDamageToTargetEffect
2016-12-14 17:20:00 -05:00
LevelX2
3ca573b7c0
Merge pull request #2672 from MTGfan/master
...
Nettling Imp, TargetController and ControllerPredicate updated to include active choice
2016-12-13 15:23:36 +01:00
Justin Herlehy
557019e8a6
Merge pull request #2679 from JRHerlehy/master
...
[CN2] Refactor Council's Dilemma voting.
2016-12-13 02:02:43 -08:00
Styxo
f88d3f0bbf
Refactored RevealCardsFromLibraryUntil and some cards to use it
2016-12-13 09:21:11 +01:00
JRHerlehy
b9d5fbcbe5
[CN2] Create new vote effect to reduce boilerplate code duplication on Council's Dilemma cards.
2016-12-12 20:58:31 -08:00
MTGfan
2fcb26887c
Nettling Imp and predicate revisions
2016-12-12 15:16:36 -05:00
LevelX2
fe97f289f8
Ravnica: City of Guilds - Added the 5 missing cards with Radiance ability word.
2016-12-12 20:54:45 +01:00
MTGfan
a199d6eaea
Nettling Imp, TargetController and ControllerPredicate updated to include active choice
2016-12-12 03:03:39 -05:00
LevelX2
79c80fe24b
Added a test and some minor changes.
2016-12-11 23:10:20 +01:00
LevelX2
7c7cebc048
* Saskia the Unyielding - Fixed that the damage source of the triggered ability was not the combat damage causing creature.
2016-12-11 22:58:35 +01:00
LevelX2
4b4aef8ed5
* Orzhov Advokist - Fixed that the attack preventing effect did not work correctly.
2016-12-11 16:25:08 +01:00
LevelX2
fb2d3f911e
* Power Surge - Fixed some problems.
2016-12-11 15:14:09 +01:00
LevelX2
561f120ce0
* Consecrete Land - Some changes.
2016-12-11 12:38:25 +01:00
LevelX2
fde05d8efb
Merge pull request #2649 from MTGfan/master
...
I need help finishing these cards, thanks
2016-12-11 10:27:59 +01:00
Justin Herlehy
ba57ccfc9e
[USG] Lotus Blossom ( #2671 )
2016-12-09 16:11:16 -08:00
MTGfan
90aec7c517
Changes to Consecrate Land and Power Surge both not working yet.
2016-12-08 22:38:17 -05:00
MTGfan
4a2e1c5063
Merge remote-tracking branch 'upstream/master'
2016-12-08 21:37:02 -05:00
LevelX2
3d95849c10
Some fixes to the Monarch designation.
2016-12-07 17:14:08 +01:00
JRHerlehy
deb59d409d
Implement AER card Ajani Unyielding
...
Moved Swords to Plowshares effect to common class to dedupe code.
2016-12-07 00:45:06 -08:00