Oleg Agafonov
854eaadcc4
Additional fixed for #6147
2020-01-07 06:52:01 +04:00
Oleg Agafonov
b6d76a7c02
* Gain abilities - fixed wrong order effects with changeling ability (all creature type effect, #6147 );
2020-01-07 06:38:34 +04:00
Evan Kranzler
41407a4aee
added lazy loading to getter methods
2020-01-06 21:05:11 -05:00
Evan Kranzler
dff5c73e1c
pulled out DamagedPlayerThisTurnPredicate
2020-01-06 21:00:57 -05:00
Evan Kranzler
5239d0258b
fixed another compilation error
2020-01-06 20:50:14 -05:00
Evan Kranzler
9e7fcd33cd
fixed some import errors
2020-01-06 20:21:10 -05:00
Evan Kranzler
9c3b923b3f
refactored ControllerPredicate
2020-01-06 20:04:56 -05:00
Evan Kranzler
c14a079cc5
refactored OwnerPredicate
2020-01-06 19:59:56 -05:00
Evan Kranzler
3f0547a7fa
refactored DamagedPlayerThisTurnPredicate
2020-01-06 19:56:08 -05:00
Evan Kranzler
13d76bfc06
refactored PlayerPredicate
2020-01-06 19:53:29 -05:00
Evan Kranzler
8e29454916
add predicates to TargetController
2020-01-06 19:47:34 -05:00
Evan Kranzler
ecf26585b5
refactored SupertypePredicate to be part of SuperType
2020-01-06 19:21:27 -05:00
Evan Kranzler
aa72251627
Implemented Archon of Sun's Grace
2020-01-06 18:53:35 -05:00
Evan Kranzler
5a6f9022c0
Merge pull request #6151 from magefree/refactorSubTypePredicate
...
Refactored SubTypePredicate to be part of SubType
2020-01-06 18:27:03 -05:00
LevelX2
b68110f60b
* Removed redundant applies check.
2020-01-06 23:16:33 +01:00
LevelX2
b2a8d4293a
* War's Toll - Fixed the implementation of the restriction effect.
2020-01-06 23:16:10 +01:00
Evan Kranzler
86906ec25f
refactored all instances of SubtypePredicate
2020-01-06 16:48:00 -05:00
Evan Kranzler
3b8298e7c2
moved SubTypePredicate into SubType
2020-01-06 14:59:10 -05:00
Evan Kranzler
688be783aa
refactored all usages of CardTypePredicate to match the new implementation
2020-01-06 13:18:17 -05:00
Evan Kranzler
f685ee3d69
moved CardTypePredicate to the CardType class
2020-01-06 13:17:45 -05:00
Evan Kranzler
943e8dd827
Merge pull request #6144 from magefree/staticValueRefactor
...
Replaced instances StaticValue with singletons (ready to merge)
2020-01-06 08:37:53 -05:00
LevelX2
e565863bd2
Added test for Nissa, Sage Animist -7 ability.
2020-01-06 12:58:50 +01:00
Evan Kranzler
06e069c5db
updated implementation as suggested
2020-01-05 22:35:20 -05:00
Evan Kranzler
690e042b36
Implemented Arena Trickster
2020-01-05 21:55:44 -05:00
Evan Kranzler
38fe022fc0
Merge branch 'master' into staticValueRefactor
2020-01-05 20:46:59 -05:00
Evan Kranzler
724acc4e14
fixed failing tests
2020-01-05 20:44:43 -05:00
Evan Kranzler
9a603fbaab
replaced StaticValue with singletons
2020-01-05 11:33:21 -05:00
LevelX2
7f0d793544
* Fixed a problem with Licid creatures not dying if the enchanted creature dies.
2020-01-05 17:06:36 +01:00
Evan Kranzler
dccc17fac9
Implemented Purphoros's Intervention
2020-01-05 09:30:26 -05:00
LevelX2
ebdba3c57e
* Added logic to check if a card had a triggered ability in the graveyard if it was moved from graveyard to a hidden zone. Because if not, the ability does not trigger.
2020-01-04 23:53:47 +01:00
Oleg Agafonov
9110f70e2d
Fixed NPE errors in deck editor;
2020-01-05 02:03:01 +04:00
Oleg Agafonov
2dd64cf5cd
* Kicker abilities - fixed that AI can't cast cards with kicker for normal cost (AI don't use kicker now);
2020-01-05 01:04:35 +04:00
Oleg Agafonov
bb59cedbd9
AI fixes:
...
* Gain control abilities - fixed wrong target chooses by AI (selects weakest permanent instead most powerful);
* Target of an opponent’s choice abilities - fixed that AI was able to cancel card cast, fixed wrong target chooses (Evangelize, Echo Chamber, Arena, Preacher, etc);
2020-01-04 22:37:16 +04:00
Oleg Agafonov
bcb37992cc
* Buyback abilities - fixed that AI can't cast cards with buyback for normal cost (AI don't use buyback now);
2020-01-04 20:26:59 +04:00
Oleg Agafonov
1ae9fc883e
* Replicate abilities - fixed that AI can freeze the game after play card with replicate (AI don't use it now);
2020-01-04 20:22:49 +04:00
Oleg Agafonov
a249dcffd8
Fixed error with no abilities
2020-01-04 20:18:16 +04:00
Oleg Agafonov
13da4fd2b3
fixed Archon of Falling Stars (must be return to battlefield instead hand)
2020-01-04 19:40:25 +04:00
Evan Kranzler
bfdbac5552
updated THB spoiler
2020-01-04 08:56:21 -05:00
Evan Kranzler
d5474df005
Implemented Shimmerwing Chimera
2020-01-03 22:10:45 -05:00
jeffwadsworth
5ed5bce718
- Fixed #6127
2020-01-03 11:30:29 -06:00
Evan Kranzler
9a3d085a81
Implemented Triumph of Anax
2020-01-03 11:13:54 -05:00
jeffwadsworth
a37c9da789
- Fixed issue where one could see the "next" card on top of the library while casting the current one. Example, Bolas's Citadel ability.
2020-01-03 09:05:08 -06:00
LevelX2
19060954ae
Merge origin/master
2020-01-03 15:24:27 +01:00
LevelX2
8854871c15
* Fixed problems of Yixlid Jailer that removed abilities from cards in graveyard permanently ( fixes #1147 ).
2020-01-03 15:23:52 +01:00
Oleg Agafonov
c1351c2339
* Play from top library - fixed that unplayable lands marks as playable;
2020-01-03 17:33:03 +04:00
Oleg Agafonov
a381c1954c
* Bolas's Citadel - fixed that it can't play cards with mana abilities;
2020-01-03 17:20:46 +04:00
Oleg Agafonov
893bcbb01f
fixed The Birth of Meletis (missing defender ability in token)
2020-01-03 12:20:40 +04:00
Oleg Agafonov
65d914ffe7
Fixed missing watchers
2020-01-03 12:18:19 +04:00
Oleg Agafonov
dceb93e7a6
Additional fixes for getNetMana from #6132 (final)
2020-01-03 06:27:39 +04:00
Evan Kranzler
64ae38c632
Implemented Nessian Boar
2020-01-02 18:56:25 -05:00
Evan Kranzler
be32db8a80
Implemented Inspire Awe
2020-01-02 16:40:42 -05:00
Evan Kranzler
9948aca713
Implemented The Birth of Meletis
2020-01-02 16:40:40 -05:00
Oleg Agafonov
62636b5071
Additional fixes for getNetMana from #6132
2020-01-02 23:33:20 +04:00
Oleg Agafonov
0930bdd016
Merge pull request #5690 from magefree/copy_constructor_watchers
...
refactor the copy functionality for no-args watchers
2020-01-02 18:51:37 +01:00
Evan Kranzler
86fe25e68b
Implemented Pharika's Spawn
2020-01-02 09:45:04 -05:00
Oleg Agafonov
862fe69b53
* Adventure cards - improved game logs (card hint works with adventure spell now, added original card info to cast's log);
2020-01-02 14:48:28 +04:00
Oleg Agafonov
b4c55039e5
* Adventure cards - added adventure spell info in permanent's rules on battlefield;
2020-01-02 06:15:17 +04:00
Oleg Agafonov
d860c026bd
* Adventure cards - added missing adventure card type info into rules (instant or sorcery);
2020-01-02 05:53:56 +04:00
Oleg Agafonov
50195e8f35
* AI: fixed that computer can't target cards on battlefield if it contains tokens;
2020-01-02 04:46:20 +04:00
Evan Kranzler
14b002bce6
Implemented Glimpse of Freedom
2020-01-01 10:32:40 -05:00
LevelX2
12c4bacc07
* Reworked GainControlAllEffect that fixed a problem of Varchild, Betrayer of Kjeldor gaining control of creatures entering the battlefield after the Varchild left the battlefield.
2020-01-01 13:37:04 +01:00
Oleg Agafonov
3c727eb06b
Fixed missing rates for some cards
2020-01-01 14:28:58 +04:00
Oleg Agafonov
4d51d379fe
Fixed wrong symbols in rules
2020-01-01 14:28:12 +04:00
spjspj
5b40ca867e
Merge pull request #6110 from spjspj/master
...
Add an information format for deck
2020-01-01 17:48:37 +08:00
Oleg Agafonov
f5ef16c8cf
Additional fixes for getNetMana from #6132 , added TODO task for next mana improves;
2020-01-01 02:27:54 +04:00
jeffwadsworth
13cb86d69f
- See b9bee56
2019-12-31 15:40:13 -06:00
Evan Kranzler
8b8a05d1c9
Implemented Nadir Kraken
2019-12-31 12:37:56 -05:00
Oleg Agafonov
4445f8556e
Fixed multiple calls of mana choice dialogs, related to #6132
2019-12-31 20:24:25 +04:00
Oleg Agafonov
a7233df1c5
Fixed Empowered Autogenerator with new getNetMana
2019-12-31 18:02:52 +04:00
Oleg Agafonov
60781604f3
Merge branch 'master' into fix-tapped-for-mana-event
2019-12-31 12:12:25 +01:00
Oleg Agafonov
dca3e034f4
Refactor: fixed targets from cards list (support filters with player predicate);
2019-12-31 05:11:45 +04:00
LevelX2
b068d10c44
* Nissa, Vastwood Seer - Fixed a bug of the Nissa, Sage Animist that the animated lands lost the creature type as soon as Nissa was cast again from command zone or from hand ( fixes #5677 ).
2019-12-30 21:35:10 +01:00
Evan Kranzler
a0888af73a
Merge pull request #6124 from magefree/updateDevotion
...
Refactor Devotion dynamic value to enum (ready to merge)
2019-12-30 11:30:37 -05:00
Ingmar Goudt
978309827b
remove deprecated discard method
2019-12-30 00:22:33 +01:00
Ingmar Goudt
813aded7f9
Add missing generic
2019-12-29 23:18:38 +01:00
Ingmar Goudt
ee71495a3f
fix latest cards from master
2019-12-29 23:08:47 +01:00
Ingmar Goudt
998c3be2a5
Merge branch 'master' of https://github.com/magefree/mage into copy_constructor_watchers
2019-12-29 21:05:37 +01:00
Ingmar Goudt
1a8723697e
fix for Set as value of Map, make sure the set is new
2019-12-29 21:05:28 +01:00
Oleg Agafonov
87db04adfc
Fixed typo
2019-12-29 23:36:28 +04:00
Ingmar Goudt
ce23f6900d
fix conflicts
2019-12-29 19:28:20 +01:00
Ingmar Goudt
702a1f2498
remove all copy constructors and copy methods for all watchers
2019-12-29 19:18:20 +01:00
Evan Kranzler
d9e0b75545
built hints into devotion class
2019-12-29 10:27:23 -05:00
LevelX2
2508de1f82
* Aminatous Augury - Fixed a problem that the cards could not be cast from exile. Added logic so the player could select the card types to consume for the cast from exile.
2019-12-29 16:22:52 +01:00
LevelX2
8710bb5ca2
* PutCardFromHandOntoBattlefieldEffect - Fixed that the rule text did not show if the card entered the battlefield tapped (e.g. for Arboreal Grazer).
2019-12-29 14:30:16 +01:00
LevelX2
42a9aed977
* Tragic Arrogance - Fixed a problem that under some circumstances permanents of the wrong player were sacrificed.
2019-12-29 14:20:24 +01:00
LevelX2
554c5baf25
* Fixed a problem of triggered effects that detect if a creature was exiled but the creature ended in a another zone (e.g. commander) ( fixes #5905 ),
2019-12-28 18:21:32 +01:00
LevelX2
cadae9ee92
* Added checks in all the methods that wait for human response to prevent endless loops if the method is called from a the get playable actions.
2019-12-27 23:28:53 +01:00
LevelX2
1f82e7a4ae
Merge origin/master
2019-12-27 23:23:09 +01:00
LevelX2
1dc8f37d20
* Expropriate - Fixed a strange problem that the prompt text of the select permanent selection to get the control of the permanent was not shown. Still not clear what the exact reason was but using a player list to save the voters seemed to cause the problem.
2019-12-27 23:22:32 +01:00
Evan Kranzler
d3cfca6226
begin refactor of Devotion to enum
2019-12-27 10:53:31 -05:00
Evan Kranzler
5856d0744b
Merge pull request #6123 from ssouders412/FaeOfWIshesFix
...
Fae of Wishes//Granted fix
2019-12-27 10:52:36 -05:00
ssouders412
cfdae6ee9d
Fixed Fae of Wishes//Granted, added Noncreature card filter
...
Updated Drekavac and Entomber Exarch to use the new filter.
2019-12-27 10:34:27 -05:00
jeffwadsworth
b9bee56c89
- Starting the process of migrating cards that use the player.cast() method to access the full abilities of a card not cast from the hand zone.
2019-12-26 15:54:22 -06:00
LevelX2
06ed2f5927
* Improved display of vote for Council's Dilemma cards.
2019-12-26 14:31:51 +01:00
LevelX2
1798f5a151
* setCheckPlayableState(false) in finally error handling (related to 133cc7342d).
2019-12-26 14:26:16 +01:00
Oleg Agafonov
2460408da8
* Until your next turn effects - fixed that continuous effects of lost/leaved players can be discarded by combat or some cards before next turn starts;
2019-12-26 07:44:46 +04:00
Oleg Agafonov
61a58d36c2
Refactor: added missing getPlayersInRange in cards code (to ignore leaved/lost players);
2019-12-26 05:24:44 +04:00
LevelX2
133cc7342d
* Fixed a problem with check playable methods causing e.g. endless loop if Shared Fate was on the battlefield.
2019-12-25 16:01:02 +01:00
Oleg Agafonov
5b9f0c970c
Removed bloated logs
2019-12-24 21:12:20 +04:00
Oleg Agafonov
49ea0205d0
* Enters battlefield, played land triggered abilities - fixed multiple rollback errors on missing target;
2019-12-24 16:19:57 +04:00
