Commit graph

31683 commits

Author SHA1 Message Date
Oleg Agafonov
b5acf64772 * Monohybrid mana cost improves:
* fixed wrong manually pay by mana pool (it pays generic cost instead colored part of monohybrid);
 * fixed not working cost reduction effects (now monohybrid cost will be reduced correctly with some limitation, see #6130);
2020-02-11 22:33:32 +04:00
Oleg Agafonov
13ad86cb21 Test framework improves:
* added aliases support to many assertXXX commands (check objects by alias/GUID instead card name);
 * added mode to test/simulate human's mana pool usage without auto-payment (enable it by command disableManaAutoPayment, fill mana pool by activateManaAbility and simulate clicks on mana icon by setChoice);
 * improves activateManaAbility command (you can activate it multiple times by one command);
 * improves setChoice command (you can activate it multiple times by one command);
2020-02-11 20:04:19 +04:00
Samuel Sandeen
d56f6b991b
Fix Sevinne's Reclamation. (#6275)
This also handles the rather unique case caused by Sevinne's Reclamation where the original spell resolves before the copy of it.
Also fixes a couple typos.
2020-02-10 08:18:12 -05:00
Ingmar Goudt
ae7919cd07 program towards Interface rather than implementations 2020-02-10 10:40:06 +01:00
Oleg Agafonov
b04c436801 Merge pull request #6274 from Dilnu/Rider
Check zone change counters in PutOnLibrarySourceEffect
2020-02-09 19:49:29 +01:00
dilnu
a089b70d64 Use getSourceObjectIfItStillExists. 2020-02-09 13:40:26 -05:00
dilnu
847df3eeb8 Check zone change counters in PutOnLibrarySourceEffect 2020-02-09 11:56:13 -05:00
Oleg Agafonov
db2a556fca Additional comments and tests for #6268 2020-02-09 07:52:24 +04:00
Samuel Sandeen
29ce4b1ad4
Fix Lifelink so it triggers per source instead of per recipient in combat. (#6272)
* Fix Lifelink so it triggers once per source instead of once per recipient in combat.

* Undo an import collapse.

* Add more tests for lifelink.
2020-02-08 20:31:50 -06:00
Samuel Sandeen
fb82303b85 Fix Medomai's Prophecy (#6271)
Fixes https://github.com/magefree/mage/issues/6262
lookAtCards replaces old instances with the same name.
2020-02-08 18:29:12 -06:00
Samuel Sandeen
51424b1460 Fix Irencrag Feat's spell casting effect. (#6268)
* Create a test for Irencrag Feat to ensure it functions correctly.

* Fix Irencrag Feat so it works correctly.
2020-02-08 18:28:10 -06:00
Samuel Sandeen
def8ef0a26 Fix Turbulent Dreams. (#6269)
More specifically get the value of X from the discard cost not the mana cost and correctly set it to target exactly x permanents.
Fixes https://github.com/magefree/mage/issues/6264
2020-02-08 18:26:16 -06:00
Oleg Agafonov
6674ca5d20
Merge pull request #6251 from Dilnu/Bonecrusher
Only fire one TARGETTED event per target selected while changing targets.
2020-02-08 16:31:04 +01:00
jeffwadsworth
7cbf999e9b - Fixed Starfield of Nyx test. 2020-02-07 10:22:15 -06:00
jeffwadsworth
b11e2a0fe9 - refactor some cards and an effect 2020-02-07 08:52:04 -06:00
dilnu
6d005bae1d Add tests by JayDi85 and fix TestPlayer's Targetting code so it triggers Targetted Events. 2020-02-06 18:55:33 -05:00
jeffwadsworth
d6c2f031d0 - Fixed #6236 2020-02-06 17:47:08 -06:00
Oleg Agafonov
b75a5d86b1 * Dymanic mana abilities - fixed missing mana text (affected cards Priest of Titania); 2020-02-06 21:44:25 +04:00
Oleg Agafonov
dc43707a4d * Prevent all damage - fixed text; 2020-02-06 21:26:52 +04:00
Oleg Agafonov
1cbabacc23
Merge pull request #6243 from Dilnu/master
Fix the Divine Visitation replacement effect.
2020-02-05 12:40:32 +01:00
Oleg Agafonov
2b2d2c2d17
Merge pull request #6260 from magefree/dependabot/maven/Mage.Server/org.apache.shiro-shiro-core-1.4.2
Bump shiro-core from 1.4.0 to 1.4.2 in /Mage.Server
2020-02-05 12:05:31 +01:00
dependabot[bot]
72e9424113
Bump shiro-core from 1.4.0 to 1.4.2 in /Mage.Server
Bumps [shiro-core](https://github.com/apache/shiro) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/apache/shiro/releases)
- [Changelog](https://github.com/apache/shiro/blob/master/RELEASE-NOTES)
- [Commits](https://github.com/apache/shiro/compare/shiro-root-1.4.0...shiro-root-1.4.2)

Signed-off-by: dependabot[bot] <support@github.com>
2020-02-04 23:22:50 +00:00
Oleg Agafonov
c135be579f
Merge pull request #6258 from magefree/revert-6257-organize-imports
Revert "format: organize imports"
2020-02-04 23:17:48 +01:00
Oleg Agafonov
5adab75324
Revert "format: organize imports" 2020-02-05 02:17:00 +04:00
Oleg Agafonov
2dcd662669
Merge pull request #6257 from allentiak/organize-imports
format: organize imports
2020-02-04 23:13:22 +01:00
Leandro Doctors
8a0a9acff7 format: organize imports 2020-02-04 16:21:48 -03:00
Oleg Agafonov
4075ebaea0
Merge pull request #6255 from tylerFretz/stinging-lionfish-bugFix
added nonland filter to ability
2020-02-04 08:02:12 +01:00
Tyler Fretz
4a9b50bb71 added nonland filter to ability 2020-02-04 00:53:18 -05:00
dilnu
0d382d3875 Move the Token field added from GameEvent to a subclass. 2020-02-03 21:57:10 -05:00
dilnu
fc46c0b288 Turn on strict mode for the test and Add documentation for the cards in the test. 2020-02-03 18:01:36 -05:00
Oleg Agafonov
cbfcfa6d5e
Merge pull request #6247 from Dilnu/Reborn
Fix Niv Mizzet Reborn
2020-02-03 23:44:56 +01:00
Oleg Agafonov
78a9279438 Improved test for #6244 2020-02-04 02:22:26 +04:00
Oleg Agafonov
4c5ea62cea
Merge pull request #6244 from Dilnu/Chaos
Fix Chaos Wand
2020-02-03 23:19:34 +01:00
Oleg Agafonov
ee9abe4699 Fixed test 2020-02-04 01:37:21 +04:00
Oleg Agafonov
88f23bc0ee
Merge pull request #6245 from Dilnu/Despark
Allow players to block creatures attacking destroyed planeswalkers.
2020-02-03 22:34:45 +01:00
Oleg Agafonov
097eab783a
Merge pull request #6248 from Dilnu/Skyfire
Fix Skyfire Phoenix's triggered ability.
2020-02-03 22:19:33 +01:00
Oleg Agafonov
8ab21be00c
Merge pull request #6249 from Dilnu/Mogis
Fix Mogis God of Slaughter's ability when a player has no creatures.
2020-02-03 22:07:40 +01:00
Oleg Agafonov
f4bf0cf9c6
Merge pull request #6253 from andreacosta/master
Update Centurion banlist
2020-02-03 22:03:59 +01:00
acosta
3c90787993 Update Centurion banlist 2020-02-03 15:53:08 +01:00
jeffwadsworth
d7f300a06d - Fixed #6241 2020-02-02 19:35:52 -06:00
dilnu
b6af571779 Only fire one Targetted event per target
This specifically addresses changing the target of a spell or ability on the stack.
Fixes https://github.com/magefree/mage/issues/6158
2020-02-02 19:40:25 -05:00
Samuel Sandeen
87c65b0224
Merge branch 'master' into Chaos 2020-02-02 19:36:09 -05:00
dilnu
a8d8f4e621 Add tests to debug issues with Bonecrusher Giant
https://github.com/magefree/mage/issues/6158
2020-02-02 18:51:05 -05:00
dilnu
6f513c4630 Fix Mogis God of Slaughter's ability when a player has no creatures.
Fixes https://github.com/magefree/mage/issues/6232
2020-02-01 19:13:47 -05:00
dilnu
9a80b07d2a Fix Skyfire Phoenix's triggered ability. 2020-02-01 19:05:46 -05:00
dilnu
e14efc53b9 Revert "Fix Skyfire Phoenix's triggered ability."
This reverts commit d6989d15
2020-02-01 19:04:30 -05:00
dilnu
d6989d15b9 Fix Skyfire Phoenix's triggered ability. 2020-02-01 19:02:50 -05:00
dilnu
a020326fce Fix Niv Mizzet Reborn so you must select as many cards as possible and so that players are informed of all the revealed cards. 2020-02-01 18:06:20 -05:00
dilnu
06e77bd7d6 Allow players to block creatures attacking destroyed planeswalkers.
See Comprehensive rules: 506.4c
Fixes https://github.com/magefree/mage/issues/6240
2020-02-01 17:30:30 -05:00
dilnu
e3e68c4607 Fix Chaos Wand
Fixes https://github.com/magefree/mage/issues/6241
2020-02-01 16:51:19 -05:00