Evan Kranzler
d4ca4553d1
fixed a few recursion issues with party count computations
2020-09-03 20:44:24 -04:00
Evan Kranzler
cc0bb84dad
[ZNR] Implemented party mechanic ( #7036 )
...
* added incomplete party count implementation
* updated party count implementation
* added party count test
* fixed tests, updated test framework
* added an additional test
* fixed some errors in party count computation, should be good now
* fixed a small error with test generation
* fixed an NPE issue
2020-09-03 19:22:05 -04:00
Evan Kranzler
84609b74e0
fixed some errors in party count computation, should be good now
2020-09-03 18:25:59 -04:00
Oleg Agafonov
535e49b89f
Test framework: added aliases support for activated abilities (related to #7036 );
2020-09-04 02:18:40 +04:00
Oleg Agafonov
7a1795660a
Fixed missing copy fields in CardImpl (morph, modaldfc, art; related to rollback);
2020-09-04 01:29:31 +04:00
Evan Kranzler
e254371f91
updated party count implementation
2020-09-03 16:34:15 -04:00
Evan Kranzler
42e38a4e8a
some more changes to modal DFC implementation
2020-09-03 14:06:11 -04:00
Evan Kranzler
db11e2d92e
Update CardsInOpponentGraveCondition.java
2020-09-03 13:02:19 -04:00
Evan Kranzler
b54c9449ef
[ZNR] Implemented Mind Carver
2020-09-03 10:08:13 -04:00
Evan Kranzler
f9f845cb44
[ZNR] Implemented Prowling Felidar
2020-09-02 15:54:49 -04:00
Evan Kranzler
025a3edf9f
[ZNR] Implemented Archpriest of Iona
2020-09-01 22:30:01 -04:00
Evan Kranzler
3a1239ba38
[ZNR] Implemented Spoils of Adventure
2020-09-01 19:49:43 -04:00
Evan Kranzler
73d37f0b70
added incomplete party count implementation
2020-09-01 17:36:40 -04:00
Evan Kranzler
b4c2898b39
[ZNR] Implemented Shepherd of Heroes
2020-09-01 17:30:48 -04:00
jeffwadsworth
34cece1107
- Fixed #7033
2020-08-31 15:38:46 -05:00
LevelX2
61315ec741
* Improved some FixedTarget initializations.
2020-08-31 10:54:59 +02:00
LevelX2
50668a548f
* FixedTarget - Added check for missing init of zoneChangeCounter on use of getFirstTargetPermanentOrLKI (this fixes the problem with missing counter for Pelt Collector).
2020-08-31 10:54:08 +02:00
Oleg Agafonov
5a5c7f6224
Merge pull request #6998 from magefree/dependabot/maven/com.github.os72-protoc-jar-maven-plugin-3.11.4
...
Bump protoc-jar-maven-plugin from 3.6.0.1 to 3.11.4
2020-08-31 09:31:20 +02:00
LevelX2
bbf30c6f74
Merge pull request #7026 from acabaca24/branch-for-issue6643
...
Duplicated code in "return to its owner's hand" effect
2020-08-31 09:18:10 +02:00
André Cabaça
7926c7c7d7
Missing 's' in effect
...
In the line 'sb.append(" to their owners' hand");' changed "hand" to "hands".
2020-08-31 00:56:30 +01:00
Andre Cabaca
36a3008f4c
Optimized "Return to hand" effect text
...
Signed-off-by: Andre Cabaca <andre.cabaca24@gmail.com>
2020-08-30 12:49:24 +01:00
Andre Cabaca
0f6b8bbe9e
Fixing an issue with the "return to its owner's hand" that was duplicating the target text.
...
Signed-off-by: Andre Cabaca <andre.cabaca24@gmail.com>
2020-08-30 11:54:13 +01:00
Oleg Agafonov
0cad4acf31
Merge pull request #7017 from acabaca24/branch-for-issue6643
...
Correcting some M21 text issues
2020-08-29 21:34:59 +02:00
Oleg Agafonov
29242ec759
* Monarch designations - improved effects stability after game rollback or in AI games;
2020-08-29 21:21:13 +04:00
Oleg Agafonov
e1c7943636
* God-Eternal dies abilities - fixed rollback error in rare cases
2020-08-29 21:17:06 +04:00
Oleg Agafonov
87d8383eb8
* Undercity Reaches - fixed rollback error on plane's draw trigger
2020-08-29 20:40:02 +04:00
Oleg Agafonov
ede06098e0
Fixed typos in tests and additional refactor
2020-08-29 19:04:26 +04:00
Oleg Agafonov
ab8a4eb26a
Little fixes and code refactor
2020-08-29 18:09:44 +04:00
LevelX2
cd5c1c282c
* Angel of Jubilation - Fixed possible Null Pointer Exception in Player.canPayLifeCost method ( fixed #7019 ).
2020-08-28 09:26:38 +02:00
Andre Cabaca
c069cf4235
Fixed Caged Zombie in issue #6643
...
Fixed also cards with the same condition in an activated ability like Skirsdag High Priest
Signed-off-by: Andre Cabaca <andre.cabaca24@gmail.com>
2020-08-27 20:23:41 +01:00
Andre Cabaca
219cfdc583
Fixed BarrinTolarianArchmage oracle in #6643
...
Fixed all the "return up to one (...) to **their** owners and" to "return up to one (...) to **its** owners and" found in cards like Teferi Time Raveler or Barrin Tolarian Archmage
Signed-off-by: Andre Cabaca <andre.cabaca24@gmail.com>
2020-08-27 20:23:39 +01:00
Evan Kranzler
f4da18df89
[ZNR] Implemented Nahiri, Heir of the Ancients
2020-08-27 12:07:43 -04:00
LevelX2
e32396bbb6
Merge pull request #6991 from acabaca24/equipped_creature_dies_errata
...
Changed description of "when equipped creature dies"
2020-08-27 08:50:05 +02:00
Evan Kranzler
f1272ee8ac
fixed a few more errors
2020-08-26 19:28:12 -04:00
Evan Kranzler
cc84efa017
fixed an error
2020-08-26 18:57:35 -04:00
Evan Kranzler
6903dad861
Implemented Jace, Mirror Mage
2020-08-26 18:48:59 -04:00
Oleg Agafonov
8ce5c7f907
Fixed NPE on game.getState() usage
2020-08-26 13:34:08 +04:00
Oleg Agafonov
cf5b474c29
Fixed NPE on playersList usage
2020-08-25 23:41:41 +04:00
Oleg Agafonov
6fa4c0b8f2
Fixed NPE on playerList.getNext usage
2020-08-25 23:38:51 +04:00
LevelX2
f1d2d2fb22
* Safe Passage - Fixed a problem that damage to player was not prevented ( fixes #6995 ).
2020-08-25 16:30:48 +02:00
LevelX2
6b4336a00a
* Fixed some tooltip rule texts.
2020-08-24 22:45:54 +02:00
LevelX2
bd413d2749
* Workaround for StackOverflowError #6994 . Don't know yet why the loop happens - why the LookAtTopCardOfLibraryAnyTimeEffect is called during mana calculation..
2020-08-24 16:53:08 +02:00
LevelX2
dc45aaf02c
* Fixed possible null pointer exception.
2020-08-24 16:50:29 +02:00
LevelX2
234fabb81e
* Fixed that frame color of lands is set again to their mana colors in non game contect like editor.
2020-08-24 14:15:36 +02:00
dependabot[bot]
d1ace6df07
Bump protoc-jar-maven-plugin from 3.6.0.1 to 3.11.4
...
Bumps [protoc-jar-maven-plugin](https://github.com/os72/protoc-jar-maven-plugin ) from 3.6.0.1 to 3.11.4.
- [Release notes](https://github.com/os72/protoc-jar-maven-plugin/releases )
- [Changelog](https://github.com/os72/protoc-jar-maven-plugin/blob/master/RELEASE_NOTES.md )
- [Commits](https://github.com/os72/protoc-jar-maven-plugin/compare/v3.6.0.1...v3.11.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-08-24 06:35:01 +00:00
LevelX2
b7d86a71da
* Made choose a card name choices mandatory (not selecting a name could cause null pointer exceptions e.g. Meddling Mage).
2020-08-23 12:14:13 +02:00
Oleg Agafonov
920697d2e5
Prepare new release
2020-08-23 01:52:55 +04:00
Oleg Agafonov
4e174e25be
Merge fix
2020-08-22 19:21:25 +04:00
Oleg Agafonov
1b430e5d99
Added verify test to check missing second face cards in sets, fixed missing cards;
2020-08-22 18:48:15 +04:00
Oleg Agafonov
7aac355f4a
Tests: added many verify checks for missing cards, names, numbers, download settings:
...
* check wrong card numbers in sets;
* check missing cards from set;
* check wrong full art settings;
* check missing and unknown sets in scryfall download settings;
* check missing and unknown direct download links in scryfall download settings;
* improved ability text check results;
* removed unused tests for word checks;
2020-08-22 15:16:30 +04:00
Oleg Agafonov
b083dd48e6
Fixed wrong card numbers, names and missing reprints in sets
2020-08-22 15:03:40 +04:00
LevelX2
c16fb75668
* replaces all [source} by {this}. ATTENTION !!!: Only supporting [this} from now on in rule text.
2020-08-22 12:52:49 +02:00
LevelX2
d51acbf090
* Removed unused imports.
2020-08-22 11:51:34 +02:00
LevelX2
90c6637dc2
* Implemeented consumable flag for asThoughtEffects and a player choice which effect to use if multiple consumable effects allow the same action.
2020-08-21 21:24:42 +02:00
Andre Cabaca
90cc44cacf
Changed DiesAttachedTriggeredAbility.java to check if description has "equipped", if so, writes "Whenever" instead of "When"
...
resolves#6990
and fixes Malefic Scythe in #6643
Signed-off-by: Andre Cabaca <andre.cabaca24@gmail.com>
2020-08-21 17:23:39 +01:00
LevelX2
8105d8b26c
* Improved handling of asThoughtAs approval by abilities that allows a clear and easy assignment of the approving effect.
2020-08-21 14:58:22 +02:00
LevelX2
783239e79e
* Aminatou's Augury - Fixed that spells in exile where not shown as castable and that AI usage prevented casting of multiple spells from exile ( fixes #6987 ).
2020-08-20 16:48:13 +02:00
LevelX2
22e6fee101
* Fixed a bug that non permanent cards could be moved to battlefield instead of staying in the zone they are.
2020-08-18 19:02:15 +02:00
LevelX2
c19af65431
* Added calculation of mana sources of hand cards (related to #6698 ).
2020-08-18 14:52:26 +02:00
LevelX2
818952bf2d
* Fixed a bug that prevented to show cards as playable if castable by alternateSourceCosts (fixes Dream Halls problem related to #6698 ).
2020-08-18 14:00:06 +02:00
LevelX2
c48331f216
* Doubling Cube - Added support for possible mana calculation (related to #6698 ).
2020-08-18 00:22:53 +02:00
Oleg Agafonov
27db13605e
Reverted broken h2database dependency version (error on existed databases: Unsupported type 17)
2020-08-18 00:44:44 +04:00
Oleg Agafonov
486c0d7c2c
GUI: added problem cards selection on legality label clicks ( #6854 )
2020-08-17 05:15:31 +04:00
Oleg Agafonov
a4af5501f9
* If you control a commander - added card hints;
2020-08-17 04:03:54 +04:00
Oleg Agafonov
fcaacd8c1e
GUI: deck legality improves:
...
* Fixed wrong sorting;
* Added tooltip errors limit (#6854 );
* Added tooltip size restrictions (#6854 );
2020-08-17 02:55:51 +04:00
LevelX2
768f1bec4f
* Fixed available mana calculation for Cryptic Trilobite and Titans' Nest. Added some improvements for available mana calculation of conditional mana.
2020-08-16 01:16:52 +02:00
Erik
3d989b24ac
Text corrections from issue #6654 (WIP) ( #6707 )
...
* Collective restraint typo fix
* set text for EndlessSwarm. Add starts with vowel cond case to CountersSourceEffect
* Teferi's Curse, added text option to GainAbilityAttachEffect
* added set text to several cards. Implement reviewer suggestions in GainAbilityAttachedEffect
* Remove period from rule text (undo my lazy coding fix)
2020-08-16 00:55:59 +04:00
Thomas Winwood
81e348360c
Fix a bunch of card text errors (magefree#6643)
2020-08-15 23:56:53 +04:00
Oleg Agafonov
583f9957f4
Merge pull request #6932 from magefree/dependabot/maven/com.h2database-h2-1.4.200
...
Bump h2 from 1.4.197 to 1.4.200
2020-08-15 21:17:47 +02:00
Evan Kranzler
8240e956dc
updated historic legality implementation
2020-08-15 14:03:11 -04:00
htrajan
6bfa212bf3
add Amonkhet Remastered
2020-08-15 00:27:09 -07:00
Oleg Agafonov
d8c9d10066
* Do if cost paid - fixed that some cards asks player about pay two times (fixed ~30 cards);
2020-08-14 16:36:00 +04:00
Oleg Agafonov
61bfdf8108
Tests: added verify check for wrong optional settings on DoIfCostPaid usage;
2020-08-14 16:22:34 +04:00
Oleg Agafonov
9dc3d514bd
* Do if cost paid - added logs message if the player decided to pay the cost;
2020-08-14 15:57:47 +04:00
LevelX2
27b5c920f7
* Offering - Fixed handling of hybrid mana in casting costs of offered creatures ( fixes #6961 ).
2020-08-14 10:25:47 +02:00
jeffwadsworth
0cda2d9635
- Fixed #6889
2020-08-13 16:35:24 -05:00
jeffwadsworth
f795e7649f
- Fixed #6959
2020-08-12 17:09:07 -05:00
LevelX2
cc684ad6bb
Merge origin/master
2020-08-12 16:26:52 +02:00
LevelX2
3e498e23e6
* Offering ability - Fixed use in available mana calculation (related to #6698 ).
2020-08-12 16:26:22 +02:00
jeffwadsworth
79592d2b0a
- Fixed #6861
2020-08-12 09:24:40 -05:00
LevelX2
6a65e5bb23
* Mana Clash - Fixed use in available mana calculation (related to #6698 ).
2020-08-12 13:58:06 +02:00
jeffwadsworth
36468044f4
- Fixed #6946
2020-08-11 21:56:49 -05:00
jeffwadsworth
f0149c6a19
- Added Pretender's Claim and Unnatural Hunger
2020-08-11 18:13:30 -05:00
jeffwadsworth
3d0cd99655
- Refactor EnchantedCreatureBlockedTriggeredAbility to BecomesBlockedAttachedTriggeredAbility
2020-08-11 08:26:47 -05:00
jeffwadsworth
d3ba7d4dd5
- Added Righteous Indignation and Insubordination
2020-08-10 17:13:00 -05:00
LevelX2
9abbdae032
Merge origin/master
2020-08-10 21:12:34 +02:00
LevelX2
973c19c81f
* Fixed possible game exception with empty library and commander movement ( fixes #6952 ).
2020-08-10 21:12:12 +02:00
jeffwadsworth
3b90c48c75
- Refactored BlocksTriggeredAbility to BlocksSourceTriggeredAbility
2020-08-10 11:49:03 -05:00
LevelX2
12c50420bf
* Fixed possible game exception with empty library and commander movement ( fixes #6952 ).
2020-08-10 17:25:48 +02:00
Oleg Agafonov
b16d30b79b
Merge pull request #6190 from luziferius/refactor_promo_sets
...
[RFC] Refactor promo sets, add missing sets as listed on Scryfall
2020-08-10 16:57:00 +02:00
Oleg Agafonov
ad6797d3c0
GUI: added more error checks while import/load deck file;
2020-08-08 23:12:06 +04:00
Oleg Agafonov
c5d7a3e9f9
* GUI: added auto-fix for deck files on usage (if deck contains wrong card numbers then it will be fixed and saved automaticity);
2020-08-08 21:27:20 +04:00
Oleg Agafonov
66a8994318
Tests: added sets implementation statistics in test_checkMissingSets
2020-08-08 14:02:28 +04:00
Oleg Agafonov
7599acf1c8
Removed duplicated sets that was split into multiple (Champs, Game Day, Launch Party, Media Inserts, Super Series)
2020-08-08 11:00:07 +04:00
LevelX2
fcf27e55d6
* Archetype cards - Fixed layer to interact correctly with ability adding/removing continuous effects.
2020-08-07 22:52:45 +02:00
jeffwadsworth
2abeb43449
- Added Port Inspector and Robber Fly
2020-08-07 15:36:43 -05:00
LevelX2
457557852e
* Benthic Explorer - Fixed mana type calculation.
...
* DynamicManaEffect - Fixed mana type calculation.
Some code clean up.
2020-08-07 17:15:06 +02:00
LevelX2
66d5b915db
* Some code clean up.
2020-08-07 15:08:19 +02:00
Oleg Agafonov
9e6a348cb1
Merge branch 'master' into refactor_promo_sets
2020-08-07 02:48:40 +02:00
jeffwadsworth
bfa54c3418
- Fixed #6872 . ¯\_(ツ)_/¯
2020-08-06 16:06:48 -05:00