Commit graph

10520 commits

Author SHA1 Message Date
Oleg Agafonov
da6fd76c6a Fixed typo 2022-09-09 01:00:48 +04:00
Daniel Bomar
48df6902e1
[40K] Fixed Abaddon the Despoiler and enabled test (fixes #9490) 2022-09-08 11:35:42 -05:00
Alex W. Jackson
2f93647196 Fix IllegalArgumentException on Volcano Hellion echo trigger 2022-09-07 23:15:18 -04:00
Alex W. Jackson
a6c5209a2a Combat.getAttackers and Combat.getBlockers now return a Set instead of a List, so that two-headed blockers aren't included twice 2022-09-07 22:36:05 -04:00
Jeff Wadsworth
4aee1b714c - Fixed #9481 2022-09-07 13:13:09 -05:00
Alex W. Jackson
e310ede837 Replace many custom effects with ExileUntilSourceLeavesEffect 2022-09-06 06:50:01 -04:00
Daniel Bomar
a5621cf247
[DMU] Implemented Anointed Peacekeeper (#9478) 2022-09-05 21:49:10 -04:00
Evan Kranzler
c745bce734 [DMU] Implemented Shanna, Purifying Blade 2022-09-05 20:24:46 -04:00
Alex W. Jackson
b5b4b38cc6 Fix ShuffleIntoLibraryTargetEffect to support multiple target cards with possibly different owners 2022-09-05 19:44:09 -04:00
Evan Kranzler
30aafb7672 [DMU] Implemented The Phasing of Zhalfir 2022-09-05 16:56:53 -04:00
Evan Kranzler
b9bbb4d1b3 [DMU] Implemented Karn, Living Legacy 2022-09-05 16:56:52 -04:00
Evan Kranzler
02968c9cc1
[DMU] Implemented Sphinx of Clear Skies (#9474)
* create common class for effects similar to Fact or Fiction

* [DMU] Implemented Sphinx of Clear Skies

* change text generation to staticText
2022-09-05 16:14:16 -04:00
Alex Vasile
138fa46824 Fixed text generation for LoseLifeOpponentsEffect 2022-09-05 14:26:36 -04:00
Alex Vasile
c16ead128b [NCC] Address comments for Lethal Scheme 2022-09-04 13:26:26 -04:00
Alex W. Jackson
e3b8a813e5 Remove custom multitarget handling from DestroyTargetEffect (use EachTargetPointer instead) 2022-09-04 07:04:46 -04:00
Alex W. Jackson
addfd5166e Add new methods to Target and TargetPointer to help generate card rules text. Currently only used by ExileUntilSourceLeavesEffect 2022-09-04 05:15:12 -04:00
Alex W. Jackson
c6e1ce6697 Remove custom multitarget handling from ExileTargetEffect (use EachTargetPointer instead) 2022-09-03 22:59:19 -04:00
Alex W. Jackson
fbccdd3088 Add missing files from last commit 2022-09-03 06:04:31 -04:00
Alex W. Jackson
ce610be087 [ONS] Implement Crown of Ascension, Crown of Suspicion and Crown of Vigor 2022-09-03 05:46:59 -04:00
Alex Vasile
07a142c9e8
Refactor: Add proper support for modifying and querying base P/T (#9409) 2022-09-01 19:57:30 -04:00
Evan Kranzler
af0fa56c10 [DMC] Implemented Baru Wurmspeaker 2022-08-30 21:31:20 -04:00
Evan Kranzler
b14d7d24bb [DMU] Implemented Yotia Declares War 2022-08-30 20:50:26 -04:00
Evan Kranzler
d83cea8000 [DMU] Compleated Weatherlight 2022-08-30 20:36:10 -04:00
Alex W. Jackson
c26c2f3785 [DMC] Implemented General Marhault Elsdragon 2022-08-30 12:21:27 -04:00
Alex W. Jackson
e0ade383f2 Fix #9441 2022-08-30 11:40:30 -04:00
Evan Kranzler
06d7b508dc [DMU] Implemented Academy Loremaster 2022-08-29 20:09:16 -04:00
Evan Kranzler
2e94364b2a [DMU] Implemented Urborg Lhurgoyf 2022-08-29 20:02:30 -04:00
Evan Kranzler
a7b7f1bbe3
[DMU] Implemented Twinferno (#9437)
* create common class for copying the next spell cast

* [DMU] Implemented Twinferno

* add filter to CopyNextSpellDelayedTriggeredAbility
2022-08-29 18:51:22 -04:00
Evan Kranzler
697586a552
[DMU] Implement Enlist ability (#9431)
* implement enlist ability

* remove skips for enlist

* [DMU] Implemented Guardian of New Benalia

* add test for enlist
2022-08-29 18:51:13 -04:00
Evan Kranzler
3929cb25a8 [DMU] Implemented Radha's Firebrand 2022-08-28 10:24:31 -04:00
Evan Kranzler
90bd0dbf63
Implement Read Ahead mechanic (#9407)
* implement Read Ahead mechanic

* [DMU] Implemented The World Spell

* [DMU] Implemented The Elder Dragon War

* added read ahead test

* fix verify failure

* small change to test

* fix read ahead text
2022-08-27 14:53:39 -04:00
PurpleCrowbar
d04ea3a88b [CC2] Added set 2022-08-26 03:58:39 +01:00
Daniel Bomar
7ba500ebe5
[DMU] Implemented Stronghold Arena 2022-08-23 14:56:50 -05:00
Daniel Bomar
3ce05b06c7
[DMU] Implemented Lagomos, Hand of Hatred 2022-08-23 12:01:08 -05:00
Daniel Bomar
356091c750
Merge pull request #9402 from weirddan455/raven-man
[DMU] Implemented The Raven Man
2022-08-23 10:09:36 -05:00
Alex Vasile
0a96201b6a Simplified Mirri and Crawlspace by making their identical effects a common effect that is shared between them 2022-08-22 21:39:28 -04:00
Daniel Bomar
7f439e23ab
[DMU] Implemented Tori D'Avenant, Fury Rider 2022-08-22 18:24:07 -05:00
Evan Kranzler
17e673ddcf fix verify error, remove skip 2022-08-22 19:00:27 -04:00
Evan Kranzler
6b09fc68ef [DMU] Implemented Molten Monstrosity 2022-08-22 15:31:01 -04:00
Daniel Bomar
0d705fdea6
[DMU] Implemented The Raven Man 2022-08-22 11:42:18 -05:00
Alex W. Jackson
54896b3564
Fix #9357 (#9359) 2022-08-22 12:38:08 -04:00
Daniel Bomar
aea8c82728
[DMU] Implemented Phoenix Chick (#9397)
* [DMU] Implemented Phoenix Chick

* ReturnSourceFromGraveyardToBattlefieldWithCounterEffect - Fix constructor

* Revert back to using setText() to set staticText

* Make setText() return a String
2022-08-22 10:36:48 -05:00
Evan Kranzler
867c2569c8 [DMU] Implement Yavimaya Steelcrusher (dummy enlist ability) 2022-08-22 10:24:37 -04:00
PurpleCrowbar
eb62b921f0 Fixed Icingdeath, Frost Tongue not triggering on attack. Closes #9380 2022-08-22 02:32:49 +01:00
Daniel Bomar
39a6ce42e5
[DMU] Implemented Jhoira, Ageless Innovator 2022-08-21 15:27:35 -05:00
Daniel Bomar
e341023d23
[DMU] Compleated Ajani, Sleeper Agent 2022-08-21 13:41:48 -05:00
Daniel Bomar
c140b073ad
Merge pull request #9386 from weirddan455/braids
[DMU] Implemented Braids, Arisen Nightmare
2022-08-20 17:04:55 -05:00
Daniel Bomar
0f9a293762
Add/Refactor cards to use SharesCardTypePredicate 2022-08-20 12:37:50 -05:00
Alex Vasile
3c0951c350 Enabled assertAllCommandsUsed by default and fixed remaining tests 2022-08-20 07:36:32 -04:00
Evan Kranzler
a43eb00c1c
[DMU] Implemented Archangel of Wrath (#9385)
* [DMU] Implemented Archangel of Wrath

* fix kicker cost

* small change to text generation
2022-08-19 18:19:00 -04:00
Evan Kranzler
5e656b8da5
[DMU] Implemented Impede Momentum (#9383) 2022-08-18 20:38:54 -04:00
Evan Kranzler
55caa5e4eb [DMU] Implemented Sheoldred, the Apocalypse 2022-08-18 19:05:30 -04:00
arketec
56d5ad3dbc
[NCC] Implement The Beamtown Bullies (#9378) 2022-08-17 21:01:49 -04:00
Evan Kranzler
6cfefeea95
[DMU] Implemented all currently previewed cards (#9304) 2022-08-14 21:02:16 -04:00
Alex Vasile
19a896df57 Refactoring and cleaning up based on previous commit 2022-08-12 21:33:20 -04:00
Alex Vasile
c0c5c63284 Fixed "One mana of any color" abilities from allowing you to make {C}. Closes #9351. 2022-08-12 21:33:02 -04:00
sprangg
7554a2b6b5
Make Add Land dialog no longer add a random mix of regular and snow-covered basic lands (#9353)
The Add Land dialog now only adds regular basic lands and never snow-covered ones, unless you specifically select a set that only contains snow basics (e.g. MH1) Sets that only contain snow basics are not selectable when adding lands to a Limited deck.
2022-08-10 20:11:01 -04:00
Alex Vasile
ebdb6b53a4
Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage (#9343) 2022-08-08 23:28:46 -04:00
PurpleCrowbar
188e6dd8c1 Added default image set codes for several tokens 2022-08-06 21:54:15 +01:00
PurpleCrowbar
7a8dd704cf
[NCC] Implement Kros, Defense Contractor (#9362) 2022-08-06 15:28:37 -04:00
Daniel Bomar
d42f9f1eca
[NCC] Implemented Turf War (#9341) 2022-08-05 18:19:46 -04:00
DeepCrimson
9f22664bf1
Refactor: Delete Unused MageLoseGameAction (#9306) 2022-08-03 14:52:54 -04:00
Alex W. Jackson
7233061ae3
Remove lockedIn parameter from BoostTargetEffect. Fixes #9329 (#9334) 2022-08-02 02:40:59 -04:00
sprangg
1a3d5923de
Make draftbots never pick basic lands over any other card (#9342)
Co-authored-by: sprangg <a@b.c>
2022-08-02 02:38:27 -04:00
Alex Vasile
cbbfe5906a Added comments that need to be addressed for card draw. 2022-07-31 22:50:00 -04:00
sprangg
17deba2df3
Clipboard .mtga deck importing & fixes to .mtga and .dck importers (#9321) 2022-07-31 22:42:32 -04:00
Jeff Wadsworth
90e888fe13 - Fixed #9326 2022-07-27 08:59:31 -05:00
Alex Vasile
c34c6a59df
Test for Copied Gilded Drake reverting control when killed (#9198) 2022-07-27 08:05:10 -04:00
DeepCrimson
5d11bab6dd
Refactor: Remove unused subscribe method from CardRepository (#9243) 2022-07-27 08:02:59 -04:00
Alex W. Jackson
516ac042a2 Fix BecomesBlockedAttachedTriggeredAbility (#9325) 2022-07-27 00:42:32 -04:00
Alex Vasile
4b511775db Further optimization of BecomesAllBasicsControlledEffect by making static the basic mana abilities used for checking 2022-07-26 10:12:32 -04:00
PurpleCrowbar
e67f6df0d6 [CMD] Fixed Ruhan of the Fomori and cards with similar effects. Closes #9096 2022-07-26 01:08:32 +01:00
PurpleCrowbar
cc6936387e [NEO] Fixes Kaito Shizuki's emblem not triggering. Closes #9290 2022-07-25 02:17:27 +01:00
DeepCrimson
1f6170570b
Refactor: Document and clean-up getSpellOrLKIStack (#9293) 2022-07-24 16:15:56 -04:00
DeepCrimson
97b34e3129
Refactor: Remove Redundant Variable Assignment in getPlayableObjects (#9309) 2022-07-22 23:07:51 -04:00
DeepCrimson
4e139c9878
Refactor: Use primitive integer type (#9310) 2022-07-22 23:05:13 -04:00
PurpleCrowbar
474aeb560a Added 2X2 token images 2022-07-22 23:46:15 +01:00
Alex Vasile
513085bbcc Fixed Banishing Light-type effects to not exile creatures if the source permanent is not on the battlefield when the effect resolves. Closes #8899. 2022-07-17 21:08:09 -04:00
Alex Vasile
9715021a35 Fixed GoadAllEffect from affecting creatures that ETB after it resolves. Closes #9227. 2022-07-17 19:41:45 -04:00
Alex Vasile
8c22db650a [CLB] Fixed connive fizzling on stack when permanent that connived leaves the battlefield. Closes #9252. 2022-07-17 18:24:35 -04:00
Alex Vasile
8878dc5cc7 Added failing ignore test for #7655 2022-07-17 13:23:58 -04:00
Alex Vasile
2aa17d6153 Autotarget disabled for search effects. Closes #9254. 2022-07-12 21:23:04 -04:00
Alex Vasile
df39503a0b
Reduce CPU cost of BecomesAllBasicsControlledEffect. (#9263) 2022-07-12 21:16:55 -04:00
Alex W. Jackson
79234b4059 Fix various 'deals damage to a creature' abilities triggering on damage to planeswalkers 2022-07-09 20:37:06 -04:00
Alex Vasile
7ca7e10d80 Fix NPE in tryToAutoChoose when auto-choose is set to "Most" 2022-07-09 18:02:32 -04:00
Alex W. Jackson
a94c837ad0
Fix casting of Disturb cards with Auras on the back (#8600) 2022-07-08 23:37:52 -04:00
Alex Vasile
b473300680
More robust searching and importing of MDFCs, Split, Adventure cards, etc. (#8948) 2022-07-08 22:19:54 -04:00
Alex Vasile
484e6c20f1
Fixes to casting calculations (#9049) 2022-07-08 22:00:19 -04:00
Alex Vasile
96f6fbefc8
GUI: Autochoose targets if choice can be made (#9206) 2022-07-08 21:58:42 -04:00
Alex Vasile
5e7f145e3d
Fix message for choose target dialog for distributing +1/+1 counters (#9202) 2022-07-08 21:42:42 -04:00
Alex Vasile
69f9331d87
[AFC] Fix OneOrMoreDiceRolledTriggeredAbility to not trigger from Chaos Dragon (#9201) 2022-07-08 21:40:05 -04:00
DeepCrimson
545b7c143d
Refactor: Fix spelling (#9238) 2022-07-08 21:39:08 -04:00
Alex Vasile
f6ff32e38b
[AER] Inspiring Statuary display fix (#9214) 2022-07-08 21:37:31 -04:00
DeepCrimson
ea6cbcc962
Refactor: Fix fileName param (#9240) 2022-07-08 21:36:50 -04:00
DeepCrimson
f507a6605c
Refactor: Remove Unused triggerId variable (#9237) 2022-07-08 21:31:50 -04:00
DeepCrimson
f20210037b
Refactor: Delete Unused Methods cardExists (#9244) 2022-07-08 21:30:37 -04:00
DeepCrimson
05648f8c0c
Refactor: Delete unused getLastBuild (#9245) 2022-07-08 21:20:18 -04:00
DeepCrimson
702cfcaa86
Refactor: clean up getAllSetNames (#9246) 2022-07-08 21:19:59 -04:00
DeepCrimson
5c5cb46de6
Refactor: remove unused import (#9239) 2022-07-07 08:47:13 -04:00
Alex Vasile
a8a16968d3
[AKH] Fix game slowdown from Cascading Cataracts. Closes #7649. (#9068) 2022-07-04 22:20:54 -04:00
Alex Vasile
dca2ae546e
[CLB] Fix Incorrect Volo Behavior (#9190) 2022-07-04 22:17:33 -04:00
Alex Vasile
78f3547644
Added common interface to conditional effects (#9208) 2022-07-04 20:28:54 -04:00
Alex Vasile
5c54eccffd Revert "Condense mana strings shown to player. Fix #8945."
(condenseManaCostString does not respect mana symbol order)

This reverts commit 08fd93f073.
2022-07-04 15:42:51 -04:00
Alex Vasile
08fd93f073 Condense mana strings shown to player. Fix #8945. 2022-07-04 15:09:09 -04:00
Alex Vasile
1e4c64aacd Fix Goad + Planeswalker interaction. Fix #9148 2022-07-04 14:46:51 -04:00
Alex Vasile
a7a51b4117 Refactor: Simplified Xorn and Jolene implementation 2022-07-04 10:07:12 -04:00
Alex Vasile
b52576fcf9
Stop permanents getting counters when phased out (#9194) 2022-07-04 09:33:30 -04:00
sprangg
7bed65e8ec
Fix Redirection effects ending early (#9191) 2022-07-02 13:33:02 -04:00
Alex Vasile
6077deb1a3 Text fixes. Closes #6533. 2022-07-01 18:37:13 -04:00
Alex Vasile
df18950f15 Refactor: Fix reminder text on EquipAbility. 2022-07-01 17:44:02 -04:00
DeepCrimson
4cd262c45d
Refactor: Remove unused getManaAbilities method (#9169) 2022-07-01 17:11:18 -04:00
Alex Vasile
75c8876746 [AFR] Fix Classes leveling up even if phased out. Closes #8549. 2022-07-01 14:32:02 -04:00
Alex Vasile
448577a0fe [HOU] Added indicators DesertControlledOrGraveyardHint 2022-06-30 20:43:34 -04:00
Evan Kranzler
deb29c0659 replaced instances of Optional::of with Optional::ofNullable (fixes #9183) 2022-06-29 18:32:15 -04:00
Daniel Bomar
c6cc9bd83f
[NCC] Implemented Dogged Detective 2022-06-29 11:55:30 -05:00
Jeff Wadsworth
009f53844a - Fixed #9177 2022-06-28 15:22:20 -05:00
Jeff Wadsworth
da10b6397c - Fixed #9161 2022-06-28 10:26:12 -05:00
DeepCrimson
7bb851e0a5
Refactor: Fix spelling of 'controller' (#9163) 2022-06-26 22:58:06 -04:00
Alex Vasile
0e38392722 Fixed typo in ControlACommanderCondition 2022-06-25 11:35:38 -04:00
Alex Vasile
62a8983b48 [CLB] Fixed CommanderInPlayCondition, now only triggers for OWN commander. Closes #9125. 2022-06-25 11:17:06 -04:00
Jeff Wadsworth
48a96e5e8f - Fixed #8916 2022-06-24 15:31:35 -05:00
PurpleCrowbar
227ae8c2e2 Assigned emblem images 2022-06-24 18:05:35 +01:00
PurpleCrowbar
494fc39dba
Added "available image set codes" functionality to emblems (#9150)
* Added pulling image from list of available image set codes functionality to emblems

* Provided available image set codes for Daretti, Scrap Savant emblem

* Fixed typo in a comment
2022-06-24 10:32:07 +04:00
Alex Vasile
5aae6bf735 [CLB] Fix Undercity Dungeon +1/+1 counter amount and Stash next room bugs. Closes #9123. 2022-06-22 14:40:32 -04:00
Jeff Wadsworth
e7205391ba - Fixed #9128 2022-06-20 11:53:02 -05:00
Oleg Agafonov
90fedddc92
Merge pull request #9113 from DeepCrimson/rawWhere
Refactor: Fix Raw use of parameterized class 'Where'
2022-06-17 08:41:51 +04:00
Oleg Agafonov
6bf9f45cd5
Merge pull request #9116 from DeepCrimson/removeUnusedParamFromContainsControlled
Refactor: Remove unused sourceID param from `containsControlled` method
2022-06-17 08:41:25 +04:00
Oleg Agafonov
4e20c4c475
Merge pull request #9117 from DeepCrimson/removeUnusedParamFromContainsMethod
Refactor: Remove unused `sourceID` param from `contains` method
2022-06-17 08:40:57 +04:00
Oleg Agafonov
08740b1b04
Merge pull request #9120 from DeepCrimson/manaCostImpl
Refactor: Fix remaining raw unparameterized usages of ManaCostImpl
2022-06-17 08:35:38 +04:00
DeepCrimson
ae88cc2f66
Refactor: Delete commented out code blocks in GameImpl.java (#9108)
Co-authored-by: DeepCrimson <deepcrimson@users.noreplyl.github.com>
2022-06-17 08:27:51 +04:00
Oleg Agafonov
5c1fe5075f [CLB] fixed verify tests 2022-06-17 08:20:22 +04:00
DeepCrimson
4546623fb6
Refactor: Fix spelling of DENY_PERMISSION_TO_ROLLBACK_TURN (#9114) 2022-06-16 22:16:03 -04:00
DeepCrimson
882afbf8b5
Fix remaining raw unparameterized usages of ManaCostImpl 2022-06-16 14:53:44 -07:00
DeepCrimson
6cf3af1d94
Refactor: Improve docstring for getPermanent and containsPermanent methods in Battlefield.java (#9115) 2022-06-16 14:25:47 -04:00
DeepCrimson
3192a191a4 Refactor: Remove unused sourceID param from contains method 2022-06-15 21:34:25 -07:00
DeepCrimson
788e42629d Refactor:Remove unused sourceID param from containsControlled method 2022-06-15 21:24:54 -07:00
DeepCrimson
b1f254bdc3
Refactor: Fix Raw use of parameterized class 'Where' 2022-06-15 20:29:59 -07:00
Evan Kranzler
f2e27148cb [CLB] various text fixes 2022-06-13 21:50:50 -04:00
DeepCrimson
5d09315387
Refactor: Fix typo in GameImpl.java (#9105) 2022-06-13 08:24:37 -04:00
DeepCrimson
3ae5f4979d
Refactor: Remove redundant boxing/unboxing to parse int primitives (#9065) 2022-06-12 12:46:59 -04:00
PurpleCrowbar
e421f4757e Fixed CLB shapeshifter tokens' images 2022-06-11 22:42:43 +01:00
PurpleCrowbar
cc78e3fae5 Fixed goblin token images 2022-06-09 00:31:10 +01:00
PurpleCrowbar
4456fd45d7 Removed ANA as an available token image source (no token images) 2022-06-09 00:17:31 +01:00
PurpleCrowbar
8316e6a813 Removed 5DN as an available token image source (no token images) 2022-06-09 00:15:35 +01:00
PurpleCrowbar
c3e20a3f0c Removed 4ED as an available token image source (no token images) 2022-06-09 00:05:45 +01:00
PurpleCrowbar
323191b2d0 Fixed pegasus token images 2022-06-09 00:01:32 +01:00
PurpleCrowbar
c6e8583d63 Removed TSP as an available token image source (no token images) 2022-06-08 23:58:13 +01:00
PurpleCrowbar
dd95a5dd3b Removed TMP as an available token image source (no token images) 2022-06-08 23:50:44 +01:00
PurpleCrowbar
49764df243 Removed MIR as an available token image source (no token images) 2022-06-08 23:40:00 +01:00
PurpleCrowbar
2255b1e409 Removed GPT as an available token image source (no token images) 2022-06-08 23:35:17 +01:00