Commit graph

23237 commits

Author SHA1 Message Date
spjspj
498a39126d Song of Blood (VIS) 2018-03-23 00:24:07 +11:00
ArcadeMode
5ac975c52e Blocker and Critical level bugfixes throughout the project (#4648)
* fixed https://sonarcloud.io/project/issues?id=org.xmage%3Amage-root&issues=AWIlv32RgrzAwlaaQ7rP&open=AWIlv32RgrzAwlaaQ7rP

* ensure closing of scanner if it was opened

* Refactored method in EmpyrialArchAngel to not always return same value.

* Refactored method in FalkenrathAristocrat to not always return same value.

* Refactored method in GilderBairn to not always return the same value.

* fixed left open resources, ensured quiet closing of the streams

* Refactored method in IceCave to not always return same value.

* Refactored method in KjeldoranRoyalGuard to not always return same value.

* Refactored method in LegionsInitiative to not always return same value.

* Refactored method in NaturesWill to not always return same value.

* added quiet closing method in new streamutils class, used to clean up the connectdialog

* Fix small typo

* added quiet closing to saveobjectutil

* closed resources in savegame method of gamecontroller

* properly close resources in loadGame method of GameReplay class

* further proper resource closing in ServerMessagesUtil

* fixed unclosed resources in copy method in mage framework Copier

* closed unclosed resources in copyCompressed method in Copier

* ensure closing of filewriter in manasymbols

* ensure proper closing of Stream in arcane UI

* ensure closing of datagram socket in arcane Util

* ensure resource closing in deckimport from clipboard

* ensure closing of plugin classloader

* ensured closing of zipinputstream resource

* ensure closing of fileoutputstream in ScryfallSymbolsSource

* ensure closing resources after finishing/canceling download of pictures

* remove commented code

* move locks to try block to ensure unlocking along all execution paths

* remove dangerous instance of double-checked locking

* removed dangerous instance of double checked locking in settingsmanager

* Removed dangerous instance of double-checked locking in ThemePluginImpl

* close resource which did not happen certainly

* close another stream

* ensure closing of inputstream
2018-03-22 08:13:13 -05:00
Jeff
ec77cecbf6 - Removed unneeded spell copy checks 2018-03-22 08:07:40 -05:00
Marc Zwart
a22eaff49c ensure closing of inputstream 2018-03-22 12:51:55 +01:00
igoudt
af83a34c64 added Academy Drake, Knight of Malice, Hexproof from White 2018-03-22 12:06:45 +01:00
igoudt
ad8b046b05 a list that is null is just strange, just use an empty List 2018-03-22 12:06:45 +01:00
igoudt
e205fef785 added a removeIf and streams 2018-03-22 12:06:45 +01:00
Marc Zwart
82e439c14b close another stream 2018-03-22 10:32:48 +01:00
Marc Zwart
c2c395420e close resource which did not happen certainly 2018-03-22 10:30:10 +01:00
Oleg Agafonov
ddc43d05f6 Removed unnecessary log info on user's freeze (#4646) 2018-03-22 11:58:14 +04:00
Jeff
270951bf89 - Added Dwarven Shrine. 2018-03-21 17:19:01 -05:00
Jeff
be67d61997 - Added Mad Dog. 2018-03-21 16:29:09 -05:00
igoudt
b6dbdf60d5 add Serra Disciple, change collector number Knight of Grace 2018-03-21 17:32:05 +01:00
igoudt
72879c44b9 fix comment and rename effect 2018-03-21 16:36:37 +01:00
LevelX2
9f2f7673c6 [ODY] Added Natuko Shrine and Rites of Spring. 2018-03-21 00:09:20 +01:00
LevelX2
f56b2fb86c [ODY] Added Charmed Pendant. 2018-03-20 21:42:10 +01:00
Jeff
cddb4af9e6 - Added Painbringer. 2018-03-20 10:21:12 -05:00
Danny Plenge
90631eff60 Removed dangerous instance of double-checked locking in ThemePluginImpl 2018-03-20 16:10:09 +01:00
Marc Zwart
3e1312064f removed dangerous instance of double checked locking in settingsmanager 2018-03-20 16:04:10 +01:00
Marc Zwart
6debe066f1 remove dangerous instance of double-checked locking 2018-03-20 16:01:48 +01:00
Marc Zwart
ea7c75cb52 move locks to try block to ensure unlocking along all execution paths 2018-03-20 15:47:34 +01:00
Marc Zwart
d299ee0882 remove commented code 2018-03-20 15:37:46 +01:00
Marc Zwart
f883d6b0a8 ensure closing resources after finishing/canceling download of pictures 2018-03-20 15:37:25 +01:00
Marc Zwart
1e18875725 ensure closing of fileoutputstream in ScryfallSymbolsSource 2018-03-20 15:27:14 +01:00
Marc Zwart
9402c4a59c ensured closing of zipinputstream resource 2018-03-20 15:19:59 +01:00
Marc Zwart
ccb0d3da52 ensure closing of plugin classloader 2018-03-20 15:11:59 +01:00
Marc Zwart
1ec5a3fb4d ensure resource closing in deckimport from clipboard 2018-03-20 15:00:08 +01:00
Marc Zwart
338e9833cc ensure closing of datagram socket in arcane Util 2018-03-20 14:59:41 +01:00
Marc Zwart
63dbfb8a9b ensure proper closing of Stream in arcane UI 2018-03-20 14:48:22 +01:00
Marc Zwart
a0a2ac1b5a ensure closing of filewriter in manasymbols 2018-03-20 14:40:58 +01:00
Marc Zwart
b2e2f48ad9 closed unclosed resources in copyCompressed method in Copier 2018-03-20 14:20:31 +01:00
Marc Zwart
dc25eedfc3 fixed unclosed resources in copy method in mage framework Copier 2018-03-20 14:18:42 +01:00
Marc Zwart
91b538be63 further proper resource closing in ServerMessagesUtil 2018-03-20 14:10:03 +01:00
Marc Zwart
2a9d23221e properly close resources in loadGame method of GameReplay class 2018-03-20 13:58:46 +01:00
Marc Zwart
532a190587 closed resources in savegame method of gamecontroller 2018-03-20 13:52:23 +01:00
LevelX2
48cfe249f7 * Fixed a problem that a gained "is all creature types" from continous effects were not propertly reset on permanents. 2018-03-20 13:39:48 +01:00
Marc Zwart
4bc5a9bd61 Merge branches 'hotfix/close-unclosed-resources-mage-client', 'hotfix/close-streams-in-updater', 'hotfix/fix-non-closed-scanner' and 'hotfix/manapiechart-potential-zero-division' into feature/SonarqubeFixes 2018-03-20 13:03:28 +01:00
Marc Zwart
7233f5d86f added quiet closing to saveobjectutil 2018-03-20 12:55:37 +01:00
Danny Plenge
1799143be0 Fix small typo 2018-03-20 12:53:04 +01:00
Marc Zwart
9912a23007 added quiet closing method in new streamutils class, used to clean up the connectdialog 2018-03-20 12:46:53 +01:00
Danny Plenge
22d8a4ab36 Refactored method in NaturesWill to not always return same value. 2018-03-20 12:13:11 +01:00
Danny Plenge
3ab65c1d86 Refactored method in LegionsInitiative to not always return same value. 2018-03-20 12:05:12 +01:00
Danny Plenge
dfba153519 Refactored method in KjeldoranRoyalGuard to not always return same value. 2018-03-20 12:03:09 +01:00
Danny Plenge
becae01f73 Refactored method in IceCave to not always return same value. 2018-03-20 12:02:48 +01:00
Marc Zwart
9187248e85 fixed left open resources, ensured quiet closing of the streams 2018-03-20 12:01:25 +01:00
Danny Plenge
a490f9e468 Refactored method in GilderBairn to not always return the same value. 2018-03-20 11:58:10 +01:00
Danny Plenge
5096410aec Refactored method in FalkenrathAristocrat to not always return same value. 2018-03-20 11:57:49 +01:00
Danny Plenge
d0bde94ffe Refactored method in EmpyrialArchAngel to not always return same value. 2018-03-20 11:57:15 +01:00
LevelX2
3ced3fde11 Merge origin/master 2018-03-20 11:29:47 +01:00
LevelX2
dcb3d5fb27 * Fixed a bug of Mizzixs Mastery that could lead to a endless loop. 2018-03-20 11:29:09 +01:00