Commit graph

1111 commits

Author SHA1 Message Date
LevelX2
0af5ed4e7b * Chandra's Phoenix - Fixed check for source object doing damage to opponents. 2015-12-03 16:36:30 +01:00
poixen
46eb6c0525 Restructured Mage module 2015-11-29 21:56:49 +01:00
Neil Gentleman
e678577720 run Mage.Tests with a fresh card db
currently tests are failing in Jenkins
2015-11-28 21:35:07 -08:00
Neil Gentleman
bfb428b13a always use log4j
removed all references to mage.util.Logging, java.util.logging

transient static doesn't mean anything, since static fields are never
included in serialization
2015-11-28 21:11:25 -08:00
Quercitron
28a087812a Add comments to Turntimber Basilisk test 2015-11-29 00:31:38 +03:00
Quercitron
b9add2e041 * Turntimber Basilisk - Fix a bug when a creature that must be blocked is not attacking 2015-11-29 00:19:21 +03:00
LevelX2
d94a2712ba * Fixed a bug that a dies ability did still trigger as the stack was not cleared meanwhile. 2015-11-28 12:52:13 +01:00
LevelX2
f23756c20b * Fixed that DiesThisOrAnotherCreatureTriggeredAbility did not work if the source died itself (e.g. Omnath, Locus of Rage). 2015-11-27 12:27:46 +01:00
LevelX2
eb6a5e7dcb * Some rework of play card effects. 2015-11-26 17:06:50 +01:00
LevelX2
780702be1b * Fixed some problems with replaced play land special action. 2015-11-26 10:48:40 +01:00
LevelX2
e51c4d5f67 * Fixed a bug where wrongly a card object was moved for a copied spell. 2015-11-26 00:48:28 +01:00
poixen
3ffb11d2e9 Updated mana class to pass failing tests 2015-11-25 19:57:11 +01:00
LevelX2
b637d2c65c * Fixed layer problem of BecomesCreatureSourceEffect (causes Chimeric Mass to die after entering the Battlefield). 2015-11-25 14:51:41 +01:00
LevelX2
62992d46db Fixed the sometimes failing Evolve test. 2015-11-25 14:50:27 +01:00
Neil Gentleman
f83cb32ed3 don't use <i/> to end italic text
it's not correct html, and causes all following text to render italic.

only visible on a few cards, because reminder text typically comes at
the end of line.
2015-11-25 00:32:00 -08:00
LevelX2
db669f02d5 * Zada, Hedron Grinder - Fixed that the spell copy target setting did not work correctly for targets that optional allowed more than one target creature (e.g. spells with Strive). 2015-11-24 17:07:52 +01:00
LevelX2
d65b236d0a Added some tests. 2015-11-24 16:37:43 +01:00
LevelX2
8c0b615faf Merge pull request #1380 from poixen/evolveTestFix
Fixed broken evolve test
2015-11-24 09:08:22 +01:00
Neil Gentleman
085b00499c fix Grinning Totem
the exiled card wouldn't be put in its owner's graveyard if Grinning Totem
changed zones before the delayed trigger

any cards using CardUtil.getCardExileZoneId for delayed effects are likely
broken in the same way
2015-11-22 18:40:46 -08:00
Neil Gentleman
230d1d37bd fix Grinning Totem, Thada Adel, Commune with Lava
opponent was able to cast the exiled cards

also changed Knacksaw Clique to use the same templating as Ornate Kanzashi
2015-11-22 18:40:38 -08:00
Neil Gentleman
f06de472a4 fix Hostility
was preventing damage to opponents regardless of source
2015-11-22 18:00:28 -08:00
Neil Gentleman
038d02e8d7 add test for non-standard booster generation 2015-11-21 18:35:10 -08:00
LevelX2
96bc3172f5 * Fixed a problem of returning cards from exile (e.g. Fiend Hunter) if the triggering permanent made multiple zone changes before the left battlefield triggered ability resolved to return the exiled permanents. 2015-11-21 23:41:41 +01:00
poixen
b0da2f2260 Merge pull request #1378 from poixen/mana_cleanup
Removed minus subtraction limits
2015-11-21 12:06:02 +01:00
poixen
a5242ff087 resolved conflicts 2015-11-21 12:02:55 +01:00
poixen
5c6bdfceb8 Merge pull request #1379 from poixen/manasymbol
Manasymbol
2015-11-21 11:47:28 +01:00
LevelX2
0d86e8e063 Xmage 1.4.5v0 2015-11-21 10:33:43 +01:00
poixen
bb8137c81a Fixed broken evolve test
As mentioned in the test comments:

“* I take two Ivy Lane Denizen on to the stack and then Renegade
Krasis's Evolve
     * Ability, so resolving Renegade Krasis's Evolve Ability is first
. (Maybe
     * Ivy Lane Denizen's target is any.) When Renegade Krasis's Evolve
Ability
     * resolves, +1/+1 counter is placed on it, but doesn't triggers
Renegade
     * Krasis's second ability.”

This means that Renegade dent put a counter on Adaptive, as the ivy +1
triggers are still on the stack
2015-11-21 00:12:23 +01:00
poixen
f2972c5b8e Updated Phyrexian Mana
+ “A Phyrexian mana symbol represents a cost that can be paid either
with *one mana of its color* or by paying 2 life”. These symbols are
mono colored, as such I have made them so.
+ Added test cases for phyrexian mana symbols
2015-11-20 22:43:26 +01:00
poixen
6138af0ffb Added Snow Mana Test
+ Added test case for snow mana
2015-11-20 22:29:49 +01:00
poixen
09ea717ed3 Added Hybrid Mana Tests
+ Added hybrid mana test cases
2015-11-20 22:24:55 +01:00
poixen
f34e69308e Updated mono colored hybrid mana type
+ “107.4e. Hybrid mana symbols are also colored mana symbols.” I have
added the Type COLORED to each mono hybrid symbol
+ added tests for hybrid mana symbols
2015-11-20 22:07:24 +01:00
poixen
f6cc03ec44 Added W mana test case
Added U mana test case
Added B mana test case
Added R mana test case
Added G mana test case
2015-11-20 20:59:52 +01:00
poixen
56be135532 Removed minus subtraction limits
+ Removed minus subtraction limits to allow other areas of code to work
2015-11-20 17:22:48 +01:00
LevelX2
8a133a43d0 Added test for Mana.enough method. 2015-11-20 15:06:00 +01:00
Quercitron
7e58dc70d5 Update Swiss tournament pairing - For the last round, for each unpaired player pair against the highest ranked player they haven't played against 2015-11-20 02:54:50 +03:00
LevelX2
b30a6c4b15 * Cryptoplasm - Fixed that the copied creature did not have the triggered ability (fixes #1367). 2015-11-19 23:28:12 +01:00
LevelX2
c4ab5806e0 Revert "Mana Class Overhaul" 2015-11-19 22:59:57 +01:00
LevelX2
68ff09c219 Revert "Mana updates" 2015-11-19 22:59:15 +01:00
LevelX2
f4871fe489 Merge pull request #1375 from poixen/mana_cleanup
Mana updates
2015-11-19 22:37:14 +01:00
poixen
05b841577a added subtraction logic to enough()
+ added subornation logic to enough(). We do not want to mix the public
subtract() call with this method. As doing so would mean that either a)
subtraction can go below 0 (this should not happen) or b) we break this
function with exceptions. This is a work around for these scenarios.
2015-11-19 17:42:59 +01:00
poixen
2c617a6aaf Mana updates
+ calling subtraction will now throw an exception if you try and use
more mana than is available. This is better than setting it to 0.
Setting to 0 impose that you should still be allowed to perform the
action.
+ updated subtraction test to check for exception
+ subtractionCost() will not allow using mana that is not available,
same as subtract()
2015-11-19 17:09:40 +01:00
LevelX2
ec7c888044 Some fixes to put token onto battlefield handling of cards. Some minor reworks. 2015-11-19 15:52:45 +01:00
LevelX2
7bb5d1bb43 Merge pull request #1374 from poixen/mana_cleanup
Mana Class Overhaul
2015-11-19 14:37:39 +01:00
Quercitron
486d547f5e Fix Swiss pairing for the case when some players have left the tournament 2015-11-19 13:18:43 +03:00
poixen
1f5638539f Class Overhaul
+ added javadoc
+ added final to method variables that should not be mutated
+ Mana can no longer be initialised with minus values
+ added null assertions
+ renamed ‘addXXX’ to ‘increaseXXX’. Add implies that you are able to
add variable amounts.
+ subtraction can no longer allow minus values.
+ removed unused state
+ refactored classes use renamed/removed mana calls
+ added comment to contains(), needs to be looked into?
+ Added validation to setting of mana. Can no longer be set to minus
values. Will log if an attempt is made
+Added comment to static mana, this is unsafe.
2015-11-19 09:53:52 +01:00
Quercitron
05a789cd8b Use approach with minimal weight matching to determine Swiss tournament pairings 2015-11-19 02:58:02 +03:00
LevelX2
7044e58231 [C15] Added Scourge of Nel Toth. 2015-11-18 17:39:32 +01:00
LevelX2
70bce1c082 * Void Winnower - Fixed that the check for even casting costs did not work correctly. 2015-11-14 11:24:26 +01:00
LevelX2
d3000da3a3 * Void Winnower - Fixed that the check for even casting costs did not work correctly. 2015-11-14 11:14:50 +01:00