Oleg Agafonov
2d96d36ec8
AsThough effects improves and fixes:
...
* AsThough: added documentation about code usage and restrictions;
* AsThough: added additional checks for correct usage;
* AsThough: simplified some code;
* PlayFromNotOwnHandZoneTargetEffect - added permanents support as targets;
* Release to the Wind - fixed that it can't cast exiled cards (#7415 , #7416 );
* Test framework: fixed that checkExileCount checking card's owner;
* GUI: fixed typo in Trample card icons;
2021-01-31 22:32:23 +04:00
Evan Kranzler
b8a95765fc
fixed a test failure
2021-01-31 13:13:53 -05:00
Evan Kranzler
3a4b0159a9
Add a limit to how many tokens are made ( #7469 )
...
* added a simple token limit
* updated implementation of token limit
* added token limit test
2021-01-31 12:55:30 -05:00
Evan Kranzler
7286593c64
some more counter text changes
2021-01-31 11:55:33 -05:00
Evan Kranzler
f76107702f
updated counter adding text to handle articles correctly
2021-01-31 11:46:32 -05:00
Evan Kranzler
f9dfb56d4e
[KHM] more text fixes
2021-01-31 11:28:44 -05:00
Oleg Agafonov
e5863eb99f
[KHM] fixed GreatestSharedCreatureTypeCount's rollback errors;
2021-01-31 06:19:25 +04:00
Evan Kranzler
175e15ff98
updated a test failure fix
2021-01-30 13:37:29 -05:00
Evan Kranzler
4df7bc157c
fixed some test failures
2021-01-30 13:21:49 -05:00
Evan Kranzler
bcdaebf3ee
fixed some more text
2021-01-30 11:08:35 -05:00
Evan Kranzler
b33bf171f8
changed library searching text to be in line with more cards
2021-01-30 10:28:08 -05:00
Oleg Agafonov
a1da5ef437
* GUI: new reworked GUI and card render engine, card icons and dozens of other fixes (see full list in related PR);
2021-01-30 16:38:55 +04:00
Oleg Agafonov
df98cc3e62
[KHM] foretell improves (related to bc25c3d60a
):
...
* reverted code format of AsThoughEffectType;
* fixed disabled test;
* added test for Dream Devourer;
* simplified some code;
2021-01-30 11:21:51 +04:00
jeffwadsworth
bc25c3d60a
- [KHM] Added Cosmos Charger and Dream Devourer. Refactored ForetellAbility to work with Dream Devourer. Text fixes are required in some cases. Ignored a test for foretell.
2021-01-29 20:35:35 -06:00
Evan Kranzler
d5822a7246
[KHM] various text fixes
2021-01-29 17:37:56 -05:00
Evan Kranzler
47f289fb34
[MIR] Implemented Unerring Sling ( #7459 )
2021-01-29 09:23:42 -05:00
Oleg Agafonov
6f2ce47885
Tests: added verify test for wrong mdash usage and fixed related cards ( #7457 ), added tests for ( #7460 );
2021-01-29 11:35:13 +04:00
Evan Kranzler
d056f6cec2
[KHM] Implemented Cosima, God of the Voyage
2021-01-28 10:50:14 -05:00
Evan Kranzler
826e509ee6
[KHM] Implemented Wolverine Riders
2021-01-27 10:12:08 -05:00
Jozsef Kerekes
f1bb76b40d
[KHM] Implemented King Narfi's Betrayal ( #7446 )
...
* [KHM] Implemented King Narfi's Betrayal
* [KHM] Corrected rules text for King Narfi's Betrayal
* [KHM] Allow adventure cards to go on adventures when exiled with King Narfi's Betrayal
* CanPlayCardControllerEffect - Fixed handling of Adventure/Split Cards
* [KHM] King Narfi's Betrayal - Added null check and fixed rules text
Co-authored-by: Daniel Bomar <dbdaniel42@gmail.com>
2021-01-27 06:40:55 -06:00
Oleg Agafonov
e3db50f111
* Double faces and adventure cards: improved support with some "exile and cast" effects like Hostage Taker ( #7446 );
2021-01-27 10:13:10 +04:00
Evan Kranzler
a535cb5adc
Refactoring methods which add counters to track which player adds the counters (ready for review) ( #7448 )
...
* added parameter for player adding counters to players
* added parameter for player adding counters to cards/permanents
* updated methods to use new parameter
* fixed a few initial errors
* refactored instances of cards that add counters by a player other than the controller
* fixed some instances of incorrect arguments
* refactored abilities that trigger off of a particular player adding counters
* a few more cards that were missed
* [KHM] Implemented Vorinclex, Monstrous Raider
* added test for Vorinclex, Monstrous Raider
* fixed a test failure
2021-01-26 19:06:13 -05:00
Evan Kranzler
4db79ae3c1
[MIR] fixed Jungle Wurm calculating incorrectly ( fixes #7449 )
2021-01-26 17:05:32 -05:00
Jozsef Kerekes
c5cc99144d
[KHM] Implemented Giant Ox ( #7447 )
...
* [KHM] Implemented Giant Ox
* [KHM] Giant Ox rework after review
2021-01-26 15:31:52 -05:00
jeffwadsworth
68f2a3d032
- Added ForetoldWatcher, ForetoldCondition. Added card from
...
weirddan455 [KHM] Poison the Cup that uses it.
2021-01-26 10:59:46 -06:00
Evan Kranzler
dacf30f4b9
Refactoring subtypes to make Maskwood Nexus work (ready for review) ( #7432 )
...
* removed and renamed SubTypeList
* updated subtype test
* refactored Changeling to be an ability that actually does something
* moved isAllCreatureTypes into SubTypes class
* renamed copyTo method to copyFrom
* added removeAllCreatureTypes where usable
* replaced some subtype methods
* replaced some more subtype methods
* replaced subtype mass add/remove methods
* updated more subtype methods
* fixed some errors
* made common shared creature type predicate
* refactored another card involving subtypes
* Added usage of object attribute in subTypes's write operations;
* Refactor: use same param styles in subtype methods
* Refactor: simplified usage of copy appliers;
* Refactor: fixed code usage in CopyApplier
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-01-26 08:52:35 -05:00
Jeff
6f42b90305
- Added another sanity check for Foretell keyword.
2021-01-25 21:32:43 -06:00
jeffwadsworth
3f42d24e2c
- Fixed Foretell keyword. #7439 #7442
2021-01-25 14:37:48 -06:00
Jeff
79a2815aef
- [KHM} - Added Alrund, God of the Cosmos
2021-01-23 21:26:37 -06:00
Jeff
432f9f5a67
- fixed a null pointer in ForetellAbility
2021-01-23 20:36:47 -06:00
Jeff
99c41d78ad
- [KHM] added Foretell keyword ability. Just getting it up here so it can be tweaked.
2021-01-23 12:00:40 -06:00
Daniel Bomar
c5dc43630f
Fixed missing variables in copy constructor
2021-01-22 18:34:10 -06:00
Evan Kranzler
7e7078b0ae
[KHM] Implemented Littjara Mirrorlake
2021-01-22 15:55:03 -05:00
Daniel Bomar
c3a862d336
[KHM] Implemented Blood on the Snow ( #7428 )
...
* [KHM] Implemented Blood on the Snow
* [KHM] Blood on the Snow - Changed target text
* [KHM] Blood on the Snow - Fixed rule text
2021-01-22 13:43:33 -05:00
Daniel Bomar
a26d9b2fd0
[KHM] Implemented The Raven's Warning ( #7425 )
2021-01-22 13:13:20 -05:00
Evan Kranzler
ca05fb9253
[KHM] Implemented Codespell Cleric
2021-01-22 12:52:54 -05:00
jeffwadsworth
08da78d184
- fixed Szat's Will.
2021-01-22 10:49:14 -06:00
Evan Kranzler
747c1c096c
[KHC] Implemented Lathril, Blade of the Elves
2021-01-22 10:13:22 -05:00
Evan Kranzler
567059ea82
[KHM] Implemented Boreal Outrider
2021-01-21 19:16:04 -05:00
Evan Kranzler
e5344b7a96
Refactoring snow mana to allow tracking how much is spent (Ready for Review) ( #7406 )
...
* refactored mana methods to WUBRG order
* more WUBRG refactoring
* added new mana tracking object
* fixed code error
* fixed missing mana count
* fixed null pointer exception in tests
* fixed issue with equality
* more equality fixes
* some cosmetic changes to ManaTest
* added copy method to setToMana
* fixed some initialization issues
* fixed serialization issue
* [KHM] Implemented Search for Glory
* updated mana handling to track snow
* added tests for snow mana tracking
* updated implementation of setter methods
* updated paramater to use copy methods
* fixed snow mana test to ensure proper mana tapping
* replaced instances of getPayment with getUsedManaToPay
* updated tracking of snow mana
* reverted snow mana tracking removal
* finished reverting change
2021-01-21 18:13:51 -05:00
Daniel Bomar
5e4b5239d8
ExileFromGraveCost - Support multiple targets for setTargetPointer
2021-01-21 16:09:45 -06:00
Daniel Bomar
30b3e2e658
[KHM] Implemented Resplendent Marshal ( #7419 )
2021-01-21 10:40:31 -05:00
Daniel Bomar
be23f19a32
Fixed text for costs starting with "and"
2021-01-20 09:52:02 -06:00
jeffwadsworth
2a23e81e9c
- refactor a few parts of Valki, God of Lies and its emblem
2021-01-19 09:28:00 -06:00
Evan Kranzler
2efa8e4356
[KHM] Implemented Svella, Ice Shaper
2021-01-19 09:30:04 -05:00
Evan Kranzler
63c3664629
[KHM] Implemented Crippling Fear
2021-01-19 08:55:34 -05:00
Evan Kranzler
6837a02518
[KHM] Implemented Birgi, God of Storytelling
2021-01-19 08:42:36 -05:00
jeffwadsworth
b750bb93d5
- [KHM] Added Valki, God of Lies
2021-01-18 18:02:48 -06:00
Evan Kranzler
163d7b07fa
[KHM] Implemented The Bloodsky Massacre
2021-01-18 08:00:03 -05:00
Evan Kranzler
07b5898bdc
[KHM] Implemented Jarl of the Forsaken
2021-01-18 07:10:55 -05:00
ddzn
e05875c7e5
Add detrimental P/T counter types from older sets ( #7381 )
...
* Add debuff counter types from older sets
* Make cards use new counter types
2021-01-17 12:59:34 -05:00
Evan Kranzler
e8a15e6491
[KHM] Implemented Immersturm Predator
2021-01-17 11:20:17 -05:00
Daniel Bomar
65aa3e95ec
Refactored 4 exisiting cards to use ExileTopXMayPlayUntilEndOfTurnEffect ( #7401 )
2021-01-16 16:49:52 -05:00
Evan Kranzler
bc464c5ed4
[KHM] Implemented Ascendant Spirit
2021-01-16 12:39:27 -05:00
Daniel Bomar
4e66d4877c
[KHM] Implemented Tuskeri Firewalker ( #7400 )
...
* Refactored ExileTop3 -> ExileTopXMayPlayUntilEndOfTurnEffect
* [KHM] Implemented Tuskeri Firewalker
2021-01-16 12:39:10 -05:00
Daniel Bomar
c510df37e4
[KHM] Implemented Firja's Retribution ( #7396 )
2021-01-15 17:47:18 -05:00
Daniel Bomar
0168453eed
CreateTokenAttachSourceEffect - Remove redundant setText
2021-01-15 18:04:06 +01:00
Daniel Bomar
9165cab00a
[KHM] Implemented Draugr's Helm ( #7393 )
...
* [KHM] Implemented Draugr's Helm
* Implemented CreateTokenAttachSourceEffect and refactored existing cards to use it
2021-01-15 09:07:25 -05:00
Evan Kranzler
14651c1816
[KHM] Implemented Fearless Liberator
2021-01-14 18:02:49 -05:00
Evan Kranzler
5105fec8e3
[KHM] Implemented Usher of the Fallen
2021-01-14 17:55:36 -05:00
Evan Kranzler
5d7fc394fd
[KHM] Implemented Rune of Flight
2021-01-14 17:14:07 -05:00
Daniel Bomar
69eed4cc2e
Fixed test errors and fixed newlines ( #7391 )
...
* Fixed test errors
* Fixed newlines
2021-01-14 16:35:28 -05:00
jeffwadsworth
708a486eb6
- [KHM] Added Withercrown
2021-01-14 10:50:30 -06:00
Evan Kranzler
495bc13078
[KHM] Implemented Duskwielder
2021-01-13 21:02:15 -05:00
Evan Kranzler
c0efada19a
[KHM] Implemented Toralf, God of Fury / Toralf's Hammer
2021-01-13 19:32:56 -05:00
Evan Kranzler
e18e3c79d4
[KHM] Implemented Glittering Frost
2021-01-13 18:02:25 -05:00
LevelX2
9fc0e2f25a
* Added some trace output for continous effects and triggered abilities. Changed duration of AffinityEffect to WhileOnStack to prevent wrong handling for removement of the effect.
2021-01-13 09:14:29 +01:00
Evan Kranzler
4b2b36cf7d
[KHM] Implemented Waking the Trolls
2021-01-12 20:52:12 -05:00
Daniel Bomar
2bd682dcbf
[KHM] Implemented Egon, God of Death ( #7377 )
2021-01-12 20:49:06 -05:00
Evan Kranzler
8c9d285d80
[KHM] Implemented Rise of the Dread Marn
2021-01-12 17:44:17 -05:00
Evan Kranzler
d515496b6e
[KHM] Implemented Skemfar Shadowsage
2021-01-12 17:28:52 -05:00
Oleg Agafonov
2e611b98f6
Merge pull request #7372 from weirddan455/koma
...
[KHM] Implemented Koma, Cosmos Serpent
2021-01-12 05:21:05 +01:00
Oleg Agafonov
b184fa7842
Merge branch 'master' into tyvar-kell
2021-01-12 01:45:58 +01:00
Oleg Agafonov
6dcbcbe962
Tyvar Kell and gain ability fixes:
...
* GainAbilityTargetEffect - reworked to support static/dynamic targets, added support of spells (card + related permanent);
* SpellCastControllerTriggeredAbility - now it can setup the target to a card instead a spell;
* Added checks/errors on wrong ability adding code (example: if you add permanent's ability by game state instead permanent's method);
* Tyvar Kell Emblem now use a standard code;
* Test framework: added additional logs for some errors;
2021-01-12 04:41:35 +04:00
Daniel Bomar
ed1133c338
Removed redundant CantBeCounteredAbility ( #7373 )
2021-01-11 19:28:26 -05:00
Daniel Bomar
efca24d617
[KHM] Implemented Koma, Cosmos Serpent
2021-01-11 18:02:18 -06:00
Daniel Bomar
4f4ea502e1
[KHM] Implemented Eradicator Valkyrie ( #7367 )
2021-01-10 22:07:18 -05:00
Evan Kranzler
065dc3da0e
[KHM] Implemented Maskwood Nexus
2021-01-10 21:33:14 -05:00
Daniel Bomar
e7a557f287
[KHM] Implemented Vega, the Watcher ( #7366 )
2021-01-10 20:36:32 -05:00
Evan Kranzler
01261575a8
[KHM] Niko Aris
2021-01-10 17:25:17 -05:00
Daniel Bomar
f131fd0d12
[KHM] Tyvar Kell - Added check for zone change counters in emblem effect
2021-01-10 15:30:18 -06:00
Daniel Bomar
6d3e29078c
[KHM] Implemented Tyvar Kell
2021-01-10 14:04:21 -06:00
ciaccona007
1825747b45
[KHM] Implement Esika's Chariot ( #7363 )
2021-01-10 13:42:18 -05:00
Evan Kranzler
4ea5898360
[KHM] Implemented Replicating Ring
2021-01-10 08:58:39 -05:00
Evan Kranzler
a7b610d59d
[KHM] Implemented The Trickster-God's Heist
2021-01-09 16:36:34 -05:00
ciaccona007
bad00742b2
[KHM] Implement Giant's Amulet ( #7357 )
2021-01-09 16:30:47 -05:00
Oleg Agafonov
6b3de78db8
[KHM] fixed Boast hint's text style ( #7341 )
2021-01-09 20:22:03 +04:00
Evan Kranzler
36fa356bd0
[KHM] Implemented Koma's Faithful
2021-01-09 11:20:02 -05:00
Evan Kranzler
91c8e1f5b5
[KHM] Implemented Doomskar Oracle
2021-01-09 11:20:01 -05:00
Oleg Agafonov
924663f27e
Reverted #7324
2021-01-09 20:10:51 +04:00
Evan Kranzler
bb827eafbf
[KHM] added Foretell placeholder ability
2021-01-08 08:49:08 -05:00
Daniel Bomar
0f4d90b871
[KHM] Implemented Varragoth, Bloodsky Sire ( #7341 )
...
* [KHM] Implemented Boast mechanic
* BoastAbility - Added author tag
* [KHM] Implemented Varragoth, Bloodsky Sire
* [KHM] Fixup BoastAbility and added BoastHint
* [KHM] BoastAbility - Call super instead of copying code
2021-01-08 08:04:47 -05:00
LevelX2
c67ce93ec4
* Fixed some problems with color changes of cards and spells - e.g. Painter's Servant ( fixes #7325 fixes #6487 ).
2021-01-08 11:03:39 +01:00
Evan Kranzler
f6c70d5d4a
[KHM] fixed verify error
2021-01-07 22:02:26 -05:00
Evan Kranzler
dd558970ac
fixed text for forecast ability
2021-01-07 19:17:46 -05:00
Evan Kranzler
65ace87a83
[KHM] Implemented Invasion of the Giants
2021-01-06 22:52:19 -05:00
cheeses-fries
d231eb0c23
Fixed other Xs grammar for GainAbilityControlledEffect ( #7324 )
2021-01-04 15:54:34 -06:00
Daniel Bomar
923cf1e3ac
Allow morph lands to be cast face down at instant speed ( #7169 )
2021-01-01 11:42:54 -06:00
Daniel Bomar
2e4baeed93
Fixed escape being castable from non graveyard zones ex. Cascade ( fixes #7225 ) ( #7319 )
2021-01-01 00:21:59 -06:00
weirddan455
57c8094fa1
Fixed rule text on BecomesTappedSourceTriggeredAbility ( #7312 )
2020-12-29 14:25:10 -05:00