vraskulin
0557b5e89c
list.size > 0 changed to !list.isEmpty
...
We care about if it's empty or not, not about it's size
2017-02-06 14:32:51 +03:00
vraskulin
f60ebfbb1f
All 1-character strings converted to primitives
...
"b" + "r" now changed to 'b' + 'w'. It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-02-06 14:32:51 +03:00
vraskulin
31589778ca
Try/finally refactored to try with resources
2017-02-06 14:32:11 +03:00
kubikrubikvkube
6a114ac902
Merge branch 'master' into master
2017-02-06 14:29:59 +03:00
LevelX2
b3597d64a0
Merge origin/master
2017-02-05 13:54:24 +01:00
LevelX2
b86acbe0da
Some minor fixes.
2017-02-05 13:53:36 +01:00
spjspj
72f4778506
Merge pull request #2837 from spjspj/master
...
Add Canadian Highlander Deck/Game implementation.
2017-02-05 23:25:53 +11:00
spjspj
c98bf163be
Add Canadian Highlander Deck/Game implementation. Also implements the double-mulligan-on-6,5,4,3,2,1 rule.
2017-02-05 23:23:51 +11:00
LevelX2
d71ebdcea9
Merge origin/master
2017-02-05 11:41:20 +01:00
LevelX2
3525e46514
XMage 1.4.21V2
2017-02-05 11:39:43 +01:00
spjspj
9fe53e52c2
Merge pull request #2836 from spjspj/master
...
Add field for server console
2017-02-05 14:54:28 +11:00
spjspj
fa97e4647e
Add field for server console
2017-02-05 14:11:05 +11:00
LevelX2
ff6d79829e
* Fixed a bug that damage was wrongly still assigned to players during combat that already left the game.
2017-02-04 23:56:03 +01:00
LevelX2
1d404ee57f
Fixed a problem that the TAPPED_FOR_MANA event was not always send ( fixed #2826 ).
2017-02-04 17:56:04 +01:00
LevelX2
0dacf2a6fa
* Fixed that the cascade converted mana costs comparison did not work correctly with split spells.
2017-02-04 14:26:17 +01:00
LevelX2
227143aacf
* Entwine - Fixed that for spells cast without mana costs entwine could wrongly be used for free.
2017-02-04 14:24:30 +01:00
LevelX2
067b72dcce
* Added test.
2017-02-03 21:36:33 +01:00
LevelX2
a5299e3a30
* Fixed a bug that card art of cards with multiple arts (e.g. FEM) were not displayed during game play.
2017-02-03 20:45:47 +01:00
emerald000
f4c9ac53db
Added Battlefield Scrounger, Death Spark and Rasputin Dreamweaver.
2017-01-31 11:06:49 -05:00
LevelX2
9ec65dc480
* Green Sun's Zenith - Fixed a bug of the used Search effect (also affecting the other colors).
2017-01-31 16:20:21 +01:00
LevelX2
034ef22468
* Fixed PreventDamageByTargetEffect to handle delayed spell damge ( fixes #2822 ).
2017-01-30 21:19:17 +01:00
LevelX2
0a1356d40e
* Fixes to test and fix for issue #2816
2017-01-29 11:16:04 +01:00
LevelX2
2cf15830d7
* Some fixes to Hivestone and BecomesSubtyoeAllEffect.
2017-01-29 11:15:09 +01:00
LevelX2
e9d46db772
* Scrapheap Scrounger - Fixed that the exile cost was not mandatory.
2017-01-28 12:10:38 +01:00
vraskulin
fc54c0156c
list.size > 0 changed to !list.isEmpty
...
We care about if it's empty or not, not about it's size
2017-01-27 16:05:11 +03:00
vraskulin
0de8bd2f70
All 1-character strings converted to primitives
...
"b" + "r" now changed to 'b' + 'w'. It's more straight-forward, and may cause perfomance improvements - character primitives allocation is faster and less expensive than string creation.
2017-01-27 15:57:26 +03:00
goblin
7b40803b4f
fix the issue
...
Alter the constructor to create the object with setTargetPointer, like
the other constructors.
I hope nothing relies on it being false. Tests don't show anything breaking.
2017-01-27 13:26:31 +01:00
vraskulin
7b35e25347
Try/finally refactored to try with resources
2017-01-26 20:58:40 +03:00
LevelX2
082210a4bd
Xmage 1.4.21V1
2017-01-25 00:14:05 +01:00
LevelX2
ca0485075c
Merge pull request #2810 from Galatolol/master
...
Added 5 cards
2017-01-24 23:12:22 +01:00
LevelX2
cec9d00a59
* Fixed that non creature spells with morph could not be countered with Remove if cast with morph.
2017-01-24 23:08:47 +01:00
LevelX2
8d06c23602
* Selvala, Explorer Returned - Fixed that library top cards were revealead without using the mana ability. Possible mana from this source is no longer calculated for possible mana pool. Tapping for man can no longer be undone.( #2191 ).
2017-01-24 16:25:26 +01:00
LevelX2
0014c7dcc5
* Fixed some possible null pointer exceptions.
2017-01-22 22:46:14 +01:00
LevelX2
719f88b3c8
* Fixed possible IndexOutOfBoundsException during combat.
2017-01-22 22:27:39 +01:00
LevelX2
fdd28cde4b
* Possibility Storm - Fixed a problem with split card moving.
2017-01-22 22:04:50 +01:00
Galatolol
9cbe82299c
Fixed AddCardSubtypeAllEffect
2017-01-22 11:40:52 +01:00
Galatolol
8969157ce8
Added 5 cards
2017-01-21 14:26:04 +01:00
LevelX2
fe4abd26c9
Fixed a bug of the Revolt ability word that prevented that ot triggered always correctly.
2017-01-21 01:33:46 +01:00
LevelX2
b1a51ce7cf
* Lightning Runner - Fixed a bug of the optional untap and add combat phase effect.
2017-01-21 01:10:37 +01:00
LevelX2
5fe25b0af7
* Fixed some problems with set icon download and displaying.
2017-01-21 00:51:31 +01:00
LevelX2
d68ff964fb
* Gonti’s Machinations - Fixed that it triggered more than once per turn.
2017-01-20 00:34:45 +01:00
LevelX2
16648e53d1
* Maelstrom Nexus - Fixed that cascade wrongly triggered not only for the first spell cast.
2017-01-20 00:15:27 +01:00
Ludwig.Hirth
a175ac3a1d
Merge origin/master
...
Conflicts:
Mage.Sets/src/mage/cards/c/CogworkAssembler.java
2017-01-19 17:01:34 +01:00
Ludwig.Hirth
a3659826a8
* Toxin Sliver - Fixed not corretly working triggerd ability.
2017-01-19 16:59:58 +01:00
Styxo
d690926cef
[AER] Refactored some similar abilities and effects
2017-01-18 14:25:58 +01:00
LevelX2
6625bf86be
Xmage 1.4.21V0
2017-01-15 17:44:02 +01:00
LevelX2
b7c0c1e8b4
* Mindbreak Trap - Fixed a problem with exiling copied (e.g. by Storm)spells.
2017-01-15 16:04:45 +01:00
LevelX2
75cbfdf3b9
* Some changes to EnterTheBattlefield events, some other fixes ( fixes #2765 ).
2017-01-15 15:22:33 +01:00
LevelX2
78cff4d24f
* Fixed Flailing Drake and test.
2017-01-14 15:47:33 +01:00
LevelX2
c996454486
* Duel Commander - Removed commander damage logic.
2017-01-14 15:35:22 +01:00
LevelX2
2d13deff3a
* Vorinclex, Voice of Hunger - FIxed a bug that id did not work correctly with some conditional land mana sources (e.g. Gemstone Caverns).
2017-01-14 12:25:07 +01:00
LevelX2
6a70f53f1a
Merge pull request #2777 from Galatolol/master
...
Added 4 cards
2017-01-14 00:15:32 +01:00
LevelX2
94684baf3c
* Ghostly Flicker - Reworked effect code again.
2017-01-14 00:00:42 +01:00
LevelX2
8f059ee71a
* Fixed a logical bug to DiscardTargetEffect.
2017-01-13 23:43:48 +01:00
LevelX2
eb802431fa
* Duel Commander - Removed commander damage logic.
2017-01-13 23:36:22 +01:00
LevelX2
d1af9b0b85
* Fixed a problem of the improvise ability that prevented to pay costs during the resolution of the spell cast using improvise (e.g. Metallic Rebike).
2017-01-13 23:02:21 +01:00
LevelX2
17fbee2400
* Fixed a bug that adding counters with Skyship Plunder or Maulfist Revolution did not trigger counter added events.
2017-01-13 22:40:37 +01:00
LevelX2
350436dee2
* Fixed a bug with rule text generation (e.g. for Lapse of Certainty).
2017-01-13 22:38:04 +01:00
Galatolol
59cf0cf1f3
Fixed target and changed name of the effect
2017-01-13 20:57:44 +01:00
LevelX2
9b14795032
* Champion of Lambholt, Goldnight Commander, Griffin Protector and Healer of the Pride - Fixed that the triggered ability also triggered for not controlled permanents.
2017-01-13 20:47:43 +01:00
LevelX2
450eba06e8
Merge pull request #2772 from ingmargoudt/master
...
replaced enum comparison from equals to ==
2017-01-13 17:26:50 +01:00
fireshoes
1e7509a765
Fixed Goblin Chieftain missing haste ability for controlled goblins. Fixed missing basic lands from AER booster packs.
2017-01-12 14:10:25 -06:00
test
e18a429e92
* fixed the planeswalker search cards to work correctly with aven mindcensor like effects
2017-01-12 13:51:22 +01:00
Galatolol
0b6e7fdb7d
Added 4 cards
2017-01-11 20:35:50 +01:00
igoudt
ac8962cb29
replaced enum comparison from equals to ==
2017-01-11 09:53:16 +01:00
LevelX2
1c4bf298eb
Merge pull request #2762 from sotovdev/bigRefactoring
...
Big refactoring
2017-01-11 07:42:52 +01:00
LevelX2
17dbd996d2
Merge pull request #2760 from ingmargoudt/master
...
some rewrites to reference putIfAbsent
2017-01-11 07:36:12 +01:00
LevelX2
0e9b46bdc1
Merge pull request #2759 from sotovdev/master
...
We can't invoke equals method on object that can be null
2017-01-11 07:33:54 +01:00
LevelX2
a2b8891188
Fixed a NPE of Meld effect.
2017-01-10 23:54:42 +01:00
vraskulin
076840df53
Big refactoring
...
I used Intellij IDEA to automatically refactor code to achive 3 goals.
1) get rid of anonymouse classes, and replace the with lamba to get more readeable and clean code (like in TableWaitingDialog).
2) make effectively final variables actually final to avoid inadvertent changes on it in further releases and keep objects as immutable, as possible.
3) Get rid of unused imports (most of the changes) in whole project classes.
2017-01-09 19:16:53 +03:00
vraskulin
a9f2c8c407
Refactoring
...
We don't need to override basic methods to just call the basic method again.
2017-01-09 18:13:43 +03:00
vraskulin
b626bf6866
Properties can be final in these objects
2017-01-09 17:52:17 +03:00
vraskulin
33b9ec52b0
SQLException fixed
...
ERROR 2017-01-09 15:35:35,693 java.sql.SQLException: Cannot update class mage.cards.repository.ExpansionInfo because it doesn't have an id field =>[main] ExpansionRepository.update
2017-01-09 15:40:20 +03:00
igoudt
316137b5e2
replaced various !contains -> put with putIfAbsent
2017-01-09 13:07:32 +01:00
igoudt
ab624c22ef
library replaced !contains -> put with putIfAbsent
2017-01-09 12:09:03 +01:00
LevelX2
0ec712fcd9
Added some additional logic to prevent the ExpansionRepository update errors.
2017-01-08 20:41:29 +01:00
LevelX2
4dd023716e
* Added another general static filter class.
2017-01-08 10:35:46 +01:00
LevelX2
fa4cf8161d
* Added missing creature type "Servo" to the creature type list.
2017-01-08 10:16:08 +01:00
LevelX2
ee203cf981
Xmage Release 1.4.20V0
2017-01-08 01:36:05 +01:00
LevelX2
a75e4f4fcb
Fixed that adding counters to players did not work correctly (e.g. Winding Constrictor).
2017-01-07 23:53:47 +01:00
LevelX2
491ab5fbb0
[AER] Fixed Daredevil Dragster.
2017-01-07 23:29:27 +01:00
LevelX2
9353c5aa9c
[AER] Some more minor fixes.
2017-01-07 22:22:17 +01:00
LevelX2
b358597bf4
[AER] Added the last missing cards. Some fixes.
2017-01-07 21:42:29 +01:00
LevelX2
c7e149904b
[AER] Fixed some problems with revolt.
2017-01-07 20:03:03 +01:00
spjspj
7a8055172d
spjspj - Allow appending from the clipboard in deck editor
2017-01-08 01:02:01 +11:00
LevelX2
b1e65b1bb4
Merge pull request #2744 from Galatolol/master
...
Added 3 cards, little refactoring (Unattach cost)
2017-01-07 00:40:04 +01:00
Styxo
90b3bacf6e
[AER] Added rest of green cards
2017-01-07 00:26:30 +01:00
LevelX2
7ec9394a83
Merge origin/master
...
Conflicts:
Mage.Sets/src/mage/sets/AetherRevolt.java
2017-01-06 21:57:18 +01:00
LevelX2
69db775d05
[AEN] Added Hidden Stockpile.
2017-01-06 21:52:51 +01:00
Styxo
7aa57cc01f
[AER] Added white cards
2017-01-06 21:22:24 +01:00
fireshoes
4888a4a15b
[AER] Added most of the 1/5 spoiled cards. Fixed a name.
2017-01-05 23:50:20 -06:00
Styxo
e057bde150
[Refactor] Merged some similar abilities together
2017-01-05 14:12:18 +01:00
fireshoes
e4727a1063
[AER] Implemented several cards.
2017-01-04 14:25:39 -06:00
Styxo
fad4f53365
[Refactor] Removed some duplicate classes
2017-01-04 15:10:25 +01:00
Styxo
19316b4e20
Forgot one new class
2017-01-04 12:07:54 +01:00
Styxo
8fd28f70e6
[AER] Added Release Gremlins, Aetherwind Basker and Inspiration Monuments
2017-01-04 12:06:16 +01:00
Styxo
3c67e51db0
[REFACTOR] Removed duplicate code and an unused effect
2017-01-04 09:58:10 +01:00
Justin Herlehy
1c6914398b
Code Deduplication
...
Move the cast from hand effect from the expertise cards to its own effect that can have different values assigned to it.
2017-01-03 23:49:16 -05:00
Galatolol
b0dc7fe276
Added 3 cards, little refactoring (Unattach cost)
2017-01-03 20:51:39 +01:00
ludwig.hirth
3040072be9
Merge origin/master
2017-01-03 14:38:51 +01:00
ludwig.hirth
94717fd041
* Tel-Jilad Wolf - Fixed that the ability triggered for all creatures not only artifact creatures ( fixed #2738 ).
2017-01-03 14:38:18 +01:00
Styxo
7c2af646ec
[Refactor] Edited some filter text
2017-01-03 13:58:03 +01:00
Styxo
a4a9e41464
[Refactor] Edited RevealLibraryPutIntoHandEffect, deleted the same effect class (EnvoyEffect) and changed some cards
2017-01-03 10:05:58 +01:00
Styxo
656e658fb4
[Refactor] Added DamageWithPowerEffect and change some cards
2017-01-03 09:23:35 +01:00
emerald000
c6c7c82508
[AER] Implemented Revolt mechanic + 2 cards using it.
...
Decommission and Fatal Push
2017-01-03 01:11:24 -05:00
LevelX2
54b40646d9
Some minor changes.
2017-01-02 18:09:33 +01:00
LevelX2
4ea6a0befb
Merge pull request #2730 from Galatolol/master
...
Added 7 cards
2017-01-02 17:25:21 +01:00
LevelX2
2162fab114
* Fixed a problem of AI target handling (e.g. for Precursor Golem)
2017-01-01 14:56:34 +01:00
Galatolol
2db6ff1825
Fixed 3 cards
2017-01-01 12:11:11 +01:00
Justin Herlehy
f3c0d3fce0
[MMQ] Ramosian Rally
...
Also fixed order of check in GameImpl for attached player to prevent possible NPE.
2016-12-31 14:41:38 -05:00
LevelX2
df0cd60fbc
* Marionette Master and Mortis Dogs, fixed that power below 0 caused life gain.
2016-12-31 17:41:12 +01:00
LevelX2
c2852ca233
[AER] Added Battke at the Bridge.
2016-12-31 17:00:00 +01:00
LevelX2
eb5b1771e6
Merge pull request #2728 from sotovdev/fix_29122016_2
...
Refactoring
2016-12-31 00:12:03 +01:00
Galatolol
f577a4b614
Added 7 cards
2016-12-30 12:15:56 +01:00
Justin Herlehy
14507e7dc5
Fix GameImpl SBA for auras attached to players.
...
attachedToPlayer was always getting set to something so the null check in the SBA loop was not allowing auras to be put into the graveyard for being attached to an illegal player. Currently checks for hasLost() as the player leaving also sets loses to true.
2016-12-30 01:56:04 -05:00
ludwig.hirth
6c72794859
* Added test.
2016-12-29 17:05:32 +01:00
ludwig.hirth
b26a5730fa
* Mage Slayer - Fixed that the correct damage source was assigned for the additional damage.
2016-12-29 16:18:52 +01:00
vraskulin
f04ba151f7
Refactoring
...
See github line by line comments in 'File changed'
2016-12-29 16:49:12 +03:00
vraskulin
c0cf22bbf7
Refactoring
...
See github line by line comments in 'File changed'
2016-12-29 16:16:08 +03:00
vraskulin
01bb9572e9
Refactoring
...
See github line by line comments in 'File changed'
2016-12-29 15:38:22 +03:00
vraskulin
c526306c5b
Refactoring
...
See github line by line comments in 'File changed'
2016-12-29 15:26:19 +03:00
LevelX2
d3c2c33b44
* Added static Goblins filter.
2016-12-28 11:32:29 +01:00
LevelX2
ecc18072cf
Cyclopean Tomb - Update.
2016-12-28 02:02:57 +01:00
LevelX2
cebfadbf34
Merge pull request #2709 from MTGfan/master
...
Cyclopean Tomb TODO: inside watcher get ID for card
2016-12-27 16:38:27 +01:00
LevelX2
8075ea2e50
* Fixed a problem that Emblems created by permanents where its owner left the game caused errors in clients. Some handling cganges of emblems.
2016-12-27 16:00:22 +01:00
LevelX2
ad5699f119
* Fixed a bug that the color choice was fixed if used in activated abilities (e.g. Obi-Wan Kenobi) beyond the first usgae.
2016-12-27 11:48:18 +01:00
Justin Herlehy
5cfec72d81
[TOKEN] Goblin with Haste
...
The 1/1 red goblin with haste token was failing to specify that it was a token with haste is the fallback autotext.
2016-12-27 00:08:13 -05:00
LevelX2
862ac38f51
* Fixed that special actions (e.g. delve mana payment) were handled correctly if a player plays a turn for another player.
2016-12-24 16:52:06 +01:00
LevelX2
a632f9c0e8
Fixed a problem that Dwarven Recruiter, Goblin Recruiter or Scouting Trek searched for the wrong subtype.
2016-12-24 11:55:30 +01:00
LevelX2
c6d54c929f
Fixed a problem that selecting cards in hand or libraray could unintended trigger "becomes the target of a spell or ability" abilities.
2016-12-24 11:42:11 +01:00
MTGfan
8a807c888c
Merge remote-tracking branch 'upstream/master'
2016-12-24 00:13:54 -05:00
LevelX2
8ba22ad7e2
* Fixed that selecting no target players let fizzle the spell (e.g. Wheel and Deal).
2016-12-22 23:50:02 +01:00
Styxo
c2ef2b1f47
[CN2] Added Deadly Designs and Fang of the Pack
2016-12-22 08:05:22 +01:00
MTGfan
7e867f4fcf
Cyclopean Tomb TODO: remove counters part of effect
2016-12-21 19:46:46 -05:00
LevelX2
f0ba7d38a6
Merge pull request #2697 from sotovdev/master
...
Refactoring SQl query + unwanted ArrayList creation
2016-12-21 15:48:01 +01:00
Styxo
2eb0a487a4
Added WishEffect, ExchangeLifeTargetEffect and did refactors
2016-12-20 13:31:39 +01:00
Styxo
009676f75f
Added HippoToken
2016-12-19 12:40:58 +01:00
Styxo
cff83aefb1
Created LoseHalfLifeTargetEffect, DiscardedByOpponentTrigger and made some refactors
2016-12-19 12:39:26 +01:00
vraskulin
2e83930ace
Creating new ArrayList is unneccesarry
...
We shouldn't create new arraylist with default size and no element in it to show that no elements found in database. It's one more object in heap, which will be never used. There is special method Collections.emptyList() - it's more readeable and returns empty immutable list
2016-12-19 12:23:23 +03:00
vraskulin
e22951c68e
Repository objects refactoring
...
SQL query is limited by 1, so there will be two cases - whether collection is empty or not. We should user convenient shortcut for checking emptiness of collection
2016-12-19 11:30:32 +03:00
LevelX2
1de210ab74
* Fixed a bug of DealsDamageToOneOrMoreCreaturesTriggeredAbility, added some tests.
2016-12-18 17:50:33 +01:00
LevelX2
d85b9943f1
* Added logic to remove control effects that refer to permanents of a player that leaves the game.
2016-12-18 16:57:34 +01:00
LevelX2
40d8a32695
XMage 1.4.19V1
2016-12-17 10:35:45 +01:00
LevelX2
61dd62b148
* Undiscovered Paradise - Fixed that it was not returned to hand on untap step ( fixes #2693 ).
2016-12-17 09:27:24 +01:00
LevelX2
8e51e3a2bf
Merge pull request #2686 from MTGfan/master
...
Guardian Angel and added Dynamic Value constructor to PreventDamageToTargetEffect
2016-12-16 22:57:21 +01:00
LevelX2
6955ad803f
Merge pull request #2691 from sotovdev/sqlPerf
...
SQL query perfomance improvements
2016-12-16 22:34:38 +01:00
LevelX2
8d6d8d25e5
* Reflecting Pool - Fixed that mana from dynamic mana abilities were not taken into account (e.g. Gaea's Cradle or Serra's Sanctum).
2016-12-16 18:38:40 +01:00
vraskulin
3be7598ee1
SQL query perfomance improvements
...
There will be always 0 or 1 distinct result. If we don't limit this query it will find an item, and still will go through the whole table trying another one, which is unneccesary and have performance impact.
2016-12-16 17:27:19 +03:00
Styxo
8e6cf84ce4
Added TargetHasCounterCondition and option for BecomesMonstrous
2016-12-15 15:33:35 +01:00
MTGfan
26c176abaa
Guardian Angel and added Dynamic Value constructor to PreventDamageToTargetEffect
2016-12-14 17:20:00 -05:00
