Commit graph

40491 commits

Author SHA1 Message Date
xenohedron
4221cd773b Fix Dancing Sword 2023-05-22 23:49:12 -04:00
xenohedron
d7fc52daea Fix Haunted Plate Mail 2023-05-22 23:49:12 -04:00
xenohedron
515672bb53 Fix Chimeric Sphere 2023-05-22 23:49:12 -04:00
xenohedron
091b6e7c0c Add/revise comments for clarity 2023-05-22 01:07:29 -04:00
xenohedron
aecdde421b Refactor to single constructor with CardType enum 2023-05-21 23:47:43 -04:00
xenohedron
00ca915581 Move loseAbilities out of constructor 2023-05-21 23:47:11 -04:00
xenohedron
9b73c8367f Check CDAs from token, remove explicit parameter 2023-05-21 23:46:46 -04:00
xenohedron
ce5423bbf6 Add CR reference comment 2023-05-21 21:51:01 -04:00
xenohedron
7ffd805f87 Fix text for cards with duration at start 2023-05-21 01:31:00 -04:00
xenohedron
26a95eed51 More sensible parameter ordering 2023-05-21 01:21:42 -04:00
xenohedron
0bc473f4b2 Clean up constructors and add comments 2023-05-21 01:21:42 -04:00
xenohedron
9aaf1ccef7 Update constructors 2023-05-21 01:21:42 -04:00
xenohedron
3a6e84043c prepare to move power/toughness out of constructor 2023-05-21 01:21:42 -04:00
xenohedron
70248cdd2b Fix text generation for default duration rule at end 2023-05-21 01:21:42 -04:00
Evan Kranzler
60e488cf05
rename classes (#10383) 2023-05-17 18:49:30 -04:00
Artemis Kearney
d199640fb5
respect testMode=false in development builds (#10376) 2023-05-16 22:53:12 +04:00
Artemis Kearney
cf51701705
text: Runemarks grant abilities to enchanted creatures, not themselves (#10380) 2023-05-15 23:51:19 -04:00
theelk801
4be4c51443 [MOM] fix Omnath, Locus of All not revealing cards(fixes #10248) 2023-05-15 19:26:32 -04:00
xenohedron
ce8eb44099
Fix Offer Immortality (#10373) 2023-05-14 18:35:31 -04:00
Evan Kranzler
024c3081df
[BRC] Implement Rootpath Purifier (ready for review) (#10363)
* refactor check supertype methods

* change supertype to list to match card type

* refactor various subtype methods

* implement mageobjectattribute for supertype

* a few fixes

* [BRC] Implement Rootpath Purifier

* a few extra fixes

* more fixes

* add test for purifier
2023-05-13 10:48:07 -04:00
Evan Kranzler
a850e3660b
Change supertype method in constructors (#10361)
* replace addSuperType with supertype.add in card constructors

* more supertype replacements

* update MDFC supertype implementation

* remove unnecessary class

* update test
2023-05-12 20:45:07 -04:00
xenohedron
4cc9329b15
New feature: "Chaos Remixed" booster draft (#10328)
* Fix error in draft pick logger that was failing on chaos drafts with fewer than 3 sets

* Implement Remixed Booster Draft

* Add debug test

* minor cleanup

* Cleanup unnecessary checks

* Fix elimination tournament type

* Add note for future improvement
2023-05-12 18:12:23 +04:00
Oleg Agafonov
6d4e353867 Designation - fixed not working abilities like Monarch and Initiative (#10334, #10338); 2023-05-12 18:00:52 +04:00
Oleg Agafonov
b860253624 tests: added monarch check command, added game info in some check fails 2023-05-12 17:08:52 +04:00
bobwoco
09892bf1f2
Fix Slayer's cleaver implementation to check if attached permanent can be blocked instead of the equipment (#10327)
Co-authored-by: Ethan Ward <ethanandrewward@gmail.com>
2023-05-12 11:53:08 +04:00
Alexander Novotny
c45a546526
Fixes for Vessel of the all-consuming (#10306)
* Added some tests for Vessel of the All-Consuming
* Fixed Vessel of the All-consuming
Fixes magefree/mage#10283

Added more commentsto the test.

The bug was for a few reasons. The map was keeping track of how many times a player was dealt damage, not how much damage was being dealt. As well, creating a MageObjectReference from an ability doesn't seem like it works properly, so retrieving from the map never worked.

---------

Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2023-05-12 11:45:45 +04:00
xenohedron
f5ab5a8caf
Fix Norn's Inquisitor (#10357) 2023-05-12 11:07:59 +04:00
xenohedron
e4f3f263a4
Fix Drinker of Sorrow (#10352) 2023-05-12 10:53:57 +04:00
xenohedron
1e7ef881cd
Fix Goblin Dynamo (#10353) 2023-05-12 10:35:27 +04:00
xenohedron
36c54c1098
Fix Errant Minion (#10354) 2023-05-12 10:34:32 +04:00
xenohedron
c41c084496
Fix Tandem Takedown (logic from Band Together) (#10356) 2023-05-12 10:33:26 +04:00
Oleg Agafonov
997dd91c20 Merge fix 2023-05-11 01:12:42 +04:00
Oleg Agafonov
e8475f2aee tests: improved ability text checks in verify:
- added multiple sets support like "MAT;CMD;XLN" (related to 10343);
 - added all sets support like "*";
 - added check stats and percent (total, good, bad);
2023-05-11 01:04:55 +04:00
Oleg Agafonov
30e582ba8f Fixed test 2023-05-11 00:21:43 +04:00
chesse20
7685115832
add non token predicate (#10349) 2023-05-10 15:30:38 -04:00
Oleg Agafonov
b44347b1b6 docs: added sonarcloud badges (loc, code coverage, tech debt), fixed travis badge, now a static code analysis by sonarcloud report available by https://sonarcloud.io/project/overview?id=magefree_mage 2023-05-10 18:16:49 +04:00
theelk801
4f961a9e70 [UNF] Implement Starlight Spectacular 2023-05-10 09:44:27 -04:00
theelk801
4e7e0b2a8d [MAT] Implement Tazri, Stalwart Survivor 2023-05-10 09:36:43 -04:00
xenohedron
4c13b42dee
Cleanup: replace custom code with common classes, text fixes to abilities (#10304)
* Use common FirstCombatPhaseCondition on Raiyuu, Storm's Edge

* Use common ReturnFromExileForSourceEffect on Parallax Wave

* Use common exile effects on Prowling Geistcatcher (attempt to fix #9981)

* Fix text: Fading ability

* Fix text: Endangered Armodon

* Fix text: Nemata, Primeval Warden

* Fix text: Capitalization on alternative/additional costs other than mana
2023-05-09 18:01:48 +04:00
Oleg Agafonov
550d719498 Fixed NPE error in drafting and timeout 2023-05-09 16:54:22 +04:00
Oleg Agafonov
30389e426f Fixed NPE error in drafting and disconnected player 2023-05-09 16:54:22 +04:00
Oleg Agafonov
6a9a4c78ca Shared Fate - fixed game error (NPE error) 2023-05-09 16:54:22 +04:00
Oleg Agafonov
a18dcd9911 Drana and Linvala - fixed game error on usage with same abilities from permanents (NPE error) 2023-05-09 16:54:22 +04:00
Oleg Agafonov
1dc5ee13a3 Combat Calligrapher - fixed game error (NPE error) 2023-05-09 16:54:22 +04:00
PurpleCrowbar
05443fb3f4 Clean up some code for Marneus Calgar and Elesh Norn, Mother of Machines 2023-05-09 13:52:49 +01:00
Oleg Agafonov
a315171ca4 Connive ability - fixed game error on usage (NPE), fixed game freeze on disconnect, fixed miss LKI related code; 2023-05-09 15:36:33 +04:00
Oleg Agafonov
3c66dc8706 Additional fixes for 9d9916280a 2023-05-09 15:05:24 +04:00
Oleg Agafonov
9d9916280a Attacking you abilities and filters - fixed that planeswalker removes from a combat can cause a game error (NPE error, example: Curse of Hospitality) 2023-05-09 14:59:44 +04:00
Oleg Agafonov
1f4dfd08ce docs: added some comments about tokens, verify, test mode, etc 2023-05-09 12:27:18 +04:00
Oleg Agafonov
7d9d037416 db: fixed not working sets update on server's start 2023-05-09 08:58:32 +04:00