dilnu
9a80b07d2a
Fix Skyfire Phoenix's triggered ability.
2020-02-01 19:05:46 -05:00
dilnu
06e77bd7d6
Allow players to block creatures attacking destroyed planeswalkers.
...
See Comprehensive rules: 506.4c
Fixes https://github.com/magefree/mage/issues/6240
2020-02-01 17:30:30 -05:00
dilnu
e3e68c4607
Fix Chaos Wand
...
Fixes https://github.com/magefree/mage/issues/6241
2020-02-01 16:51:19 -05:00
Oleg Agafonov
c767d19534
Test framework: added AI support in basic card tests:
...
* added new command to play one best action on priority by AI (aiPlayPriority);
* added new command to play all best actions on step by AI (aiPlayStep);
* now you can setup battlefield by standard commands and run AI simulations for single priority/step;
* CardTestPlayerBase - old default class for card tests, it uses simple AI for choosing, but do not play/simulate it;
* CardTestPlayerBaseAI - old default class for AI game tests, auto-playable playerA, you can control only playerB;
* CardTestPlayerBaseWithAIHelps - new improved class for card tests, it uses controllable and real AI with game simulations;
2020-01-29 07:42:20 +04:00
Oleg Agafonov
89394ffe0a
Improved ability outcome processing;
2020-01-29 07:33:33 +04:00
Oleg Agafonov
eb93c08a6f
Fixed tests
2020-01-28 16:42:44 +04:00
Oleg Agafonov
5c058d8f85
Cleanup code (added logs rotation to tests)
2020-01-28 12:02:56 +04:00
Oleg Agafonov
0525463faf
Test framework: added more aliases support, improved logs output for show commands;
2020-01-27 17:31:18 +04:00
Oleg Agafonov
ccdad1f5ca
Test framework: added alias support in chooseTarget;
2020-01-27 14:02:21 +04:00
Oleg Agafonov
ffdc884949
Logs cleanup (removed database logs)
2020-01-27 06:01:56 +04:00
Oleg Agafonov
ec6b0b94c6
Test framework: improved aliases support:
...
* added check commands support;
* added on of the choose method support;
* added todo and checks for wrong test commands setup;
2020-01-27 06:00:46 +04:00
Oleg Agafonov
016f5fa9f5
Merge fix
2020-01-26 20:39:19 +04:00
Oleg Agafonov
b86438b80d
Tests for #6222
2020-01-26 20:37:32 +04:00
Oleg Agafonov
9ec6aa83c4
* Infected counters - fixed rollback error on usage;
2020-01-26 18:41:01 +04:00
Oleg Agafonov
ab2fb29270
Code cleanup (removed unused log4j setting files, added extra info, samples and instructions, removed java logs)
2020-01-26 16:30:42 +04:00
Oleg Agafonov
c835fb409d
* Bolas's Citadel - fixed that it can't play cards with cycling ( #6215 );
2020-01-22 14:45:44 +04:00
michaelrfarcasin
cef3b9488f
Merge from origin/master
2020-01-20 23:01:31 -06:00
michaelrfarcasin
c3cb54f371
Add Freeform Unlimited Commander game type
...
Currently there's no multiplayer format that allows players to cast
spells from the command zone and also allows any deck size.
This is a problem for players who want to test EDH Cube decks. These
decks:
- can have any size - often between 40 and 100 - with no standard
- can have cards outside the commander's color identity
- may break the singleton rule
Create a game and deck type to accommodate these types of decks.
Notable differences from Freeform Commander in addition to the above:
- Decks can have any number of cards in the maindeck or sideboard
- Sideboard cards can be any type
- There are no illegal expansions
- Games can have a minimum 2 players
2020-01-20 22:47:27 -06:00
LevelX2
d87a4e4c9b
* Karn Liberated - Fixed that a with Karn's ability exiled commander was not put to battlefield after game restart.
2020-01-19 16:48:58 +01:00
Oleg Agafonov
a31da48084
Little fixes
2020-01-16 17:11:19 +04:00
Oleg Agafonov
ec2ea7f070
Reverted some changes, related to #6187 , see comments from d20a20fb6a
2020-01-16 08:22:23 +04:00
LevelX2
180c7dfff6
* Updated UnequipEventTest.
2020-01-15 17:32:07 +01:00
LevelX2
7575510c85
* Fixed that Soulfire Grand Master did not work for adventure or split cards ( fixes #6182 ).
2020-01-14 23:26:04 +01:00
LevelX2
55fe1db60d
Merge origin/master
2020-01-14 17:43:43 +01:00
LevelX2
6455180765
* Some code clean up and a new test.
2020-01-14 17:42:58 +01:00
Oleg Agafonov
748d14e55e
* Thassa, Deep-Dwelling - fixed text;
2020-01-14 18:53:47 +04:00
Oleg Agafonov
e768c375dc
* Yorvo, Lord of Garenbrig - fixed that it doesn't add +1 counter is green creature dies before resolve;
2020-01-14 12:55:21 +04:00
Oleg Agafonov
92eba9861d
fixed Uro, Titan of Nature's Wrath (getSpellOrLKIStack return ability instead spell after card triggers);
2020-01-14 11:48:15 +04:00
Oleg Agafonov
11976b5c89
Refactor: move player.damage params to default (same as permanent.damage);
2020-01-14 09:15:33 +04:00
Oleg Agafonov
fe0717cbc7
* Goblin Clearcutter - fixed that tapped for mana replacement effects ignore his mana;
2020-01-12 11:19:17 +04:00
Oleg Agafonov
860c57d9d9
* Chrom Mox - fixed that tapped for mana replacement effects ignore his mana;
2020-01-12 10:09:51 +04:00
Oleg Agafonov
589142aeb5
Real fix to prev commit
2020-01-12 09:26:52 +04:00
Oleg Agafonov
92e15283ea
* Tapped for mana abilities - fixed that it cause rollback error if you cast second card with that effect (Nyxbloom Ancient, etc);
2020-01-12 09:11:38 +04:00
Oleg Agafonov
e1fea330dd
Test framework - multiple improves:
...
* Added support of spell ability choice in free cast (chooseSpellAbilityForCast);
* Added support of "up to" targets setup in addTargetAmount (use TestPlayer.TARGET_SKIP to stop target choose);
* Restored multiple checks for addTargetAmount;
* Fixed many wrong tests (wrong order or missing commands);
2020-01-12 01:17:39 +04:00
LevelX2
044645aca2
* Added test for split card cast with fuse.
2020-01-10 20:50:24 +01:00
LevelX2
2a0723b7cd
* Vivien, Arkbow Ranger - Fixed target handling of +1 ability.
2020-01-10 15:49:55 +01:00
LevelX2
ac2a59fdc2
* Added better handling of TargetAmount for tests.
2020-01-10 15:48:21 +01:00
LevelX2
47a8686958
* Some more move actions replaced and added missing methods for move to command zone.
2020-01-09 23:17:39 +01:00
LevelX2
b6b2103b6c
* Kiss, Dissident Mage - Fixed that it did not exile from graveyard casted split cards.
2020-01-09 21:29:27 +01:00
LevelX2
7ce7c2ad70
* Fixed a problem with P/T of permanets that transform back again to the original source card ( fixes #6156 ).
2020-01-09 08:25:29 +01:00
Oleg Agafonov
b366a83a45
Prepare new release
2020-01-09 08:55:26 +04:00
LevelX2
d4ec65cddb
Added Test and changed some log messages from info to debug.
2020-01-07 17:56:26 +01:00
Oleg Agafonov
854eaadcc4
Additional fixed for #6147
2020-01-07 06:52:01 +04:00
Oleg Agafonov
b6d76a7c02
* Gain abilities - fixed wrong order effects with changeling ability (all creature type effect, #6147 );
2020-01-07 06:38:34 +04:00
Evan Kranzler
5a6f9022c0
Merge pull request #6151 from magefree/refactorSubTypePredicate
...
Refactored SubTypePredicate to be part of SubType
2020-01-06 18:27:03 -05:00
Evan Kranzler
86906ec25f
refactored all instances of SubtypePredicate
2020-01-06 16:48:00 -05:00
LevelX2
79f5d7a358
Merge origin/master
2020-01-06 21:16:09 +01:00
LevelX2
e565863bd2
Added test for Nissa, Sage Animist -7 ability.
2020-01-06 12:58:50 +01:00
LevelX2
7bf213c0ec
* Added Hideaway test.
2020-01-05 17:55:38 +01:00
LevelX2
7f0d793544
* Fixed a problem with Licid creatures not dying if the enchanted creature dies.
2020-01-05 17:06:36 +01:00
LevelX2
ebdba3c57e
* Added logic to check if a card had a triggered ability in the graveyard if it was moved from graveyard to a hidden zone. Because if not, the ability does not trigger.
2020-01-04 23:53:47 +01:00
Oleg Agafonov
2dd64cf5cd
* Kicker abilities - fixed that AI can't cast cards with kicker for normal cost (AI don't use kicker now);
2020-01-05 01:04:35 +04:00
Oleg Agafonov
bb59cedbd9
AI fixes:
...
* Gain control abilities - fixed wrong target chooses by AI (selects weakest permanent instead most powerful);
* Target of an opponent’s choice abilities - fixed that AI was able to cancel card cast, fixed wrong target chooses (Evangelize, Echo Chamber, Arena, Preacher, etc);
2020-01-04 22:37:16 +04:00
Oleg Agafonov
bcb37992cc
* Buyback abilities - fixed that AI can't cast cards with buyback for normal cost (AI don't use buyback now);
2020-01-04 20:26:59 +04:00
Oleg Agafonov
1ae9fc883e
* Replicate abilities - fixed that AI can freeze the game after play card with replicate (AI don't use it now);
2020-01-04 20:22:49 +04:00
Oleg Agafonov
b3ec79f467
Test framework: added command to show available mana;
2020-01-04 20:15:43 +04:00
LevelX2
19060954ae
Merge origin/master
2020-01-03 15:24:27 +01:00
LevelX2
8854871c15
* Fixed problems of Yixlid Jailer that removed abilities from cards in graveyard permanently ( fixes #1147 ).
2020-01-03 15:23:52 +01:00
Oleg Agafonov
a381c1954c
* Bolas's Citadel - fixed that it can't play cards with mana abilities;
2020-01-03 17:20:46 +04:00
Oleg Agafonov
53296446a8
Test fix
2020-01-02 06:18:15 +04:00
Oleg Agafonov
b4c55039e5
* Adventure cards - added adventure spell info in permanent's rules on battlefield;
2020-01-02 06:15:17 +04:00
Oleg Agafonov
50195e8f35
* AI: fixed that computer can't target cards on battlefield if it contains tokens;
2020-01-02 04:46:20 +04:00
LevelX2
12c4bacc07
* Reworked GainControlAllEffect that fixed a problem of Varchild, Betrayer of Kjeldor gaining control of creatures entering the battlefield after the Varchild left the battlefield.
2020-01-01 13:37:04 +01:00
Oleg Agafonov
f5ef16c8cf
Additional fixes for getNetMana from #6132 , added TODO task for next mana improves;
2020-01-01 02:27:54 +04:00
Oleg Agafonov
a7233df1c5
Fixed Empowered Autogenerator with new getNetMana
2019-12-31 18:02:52 +04:00
Oleg Agafonov
60781604f3
Merge branch 'master' into fix-tapped-for-mana-event
2019-12-31 12:12:25 +01:00
Oleg Agafonov
0faecb2fb6
Server: fixed missing data compress for some server's responses;
2019-12-31 04:11:23 +04:00
Oleg Agafonov
5524224d63
Tests: removed bloated logs from AI load tests;
2019-12-31 04:08:13 +04:00
Ingmar Goudt
978309827b
remove deprecated discard method
2019-12-30 00:22:33 +01:00
Oleg Agafonov
9b685cf14b
Tests: added chat messages processing in AI load tests;
2019-12-29 17:03:19 +04:00
LevelX2
554c5baf25
* Fixed a problem of triggered effects that detect if a creature was exiled but the creature ended in a another zone (e.g. commander) ( fixes #5905 ),
2019-12-28 18:21:32 +01:00
LevelX2
12639bce26
* Added Test for #5905 .
2019-12-28 01:33:14 +01:00
LevelX2
b38242bf93
* Faerie Artisans - Fixed a problem that the triggering permanent was not copied if it already left the battlefield ( fixes #5904 ).
2019-12-28 00:44:38 +01:00
Oleg Agafonov
2460408da8
* Until your next turn effects - fixed that continuous effects of lost/leaved players can be discarded by combat or some cards before next turn starts;
2019-12-26 07:44:46 +04:00
Oleg Agafonov
61a58d36c2
Refactor: added missing getPlayersInRange in cards code (to ignore leaved/lost players);
2019-12-26 05:24:44 +04:00
LevelX2
1977e7f986
* Opportunistic Dragon - Fixed that the can't attack effect was not discarded if the Opportunistic Dragon left the battlefield.
2019-12-25 17:05:52 +01:00
LevelX2
133cc7342d
* Fixed a problem with check playable methods causing e.g. endless loop if Shared Fate was on the battlefield.
2019-12-25 16:01:02 +01:00
Oleg Agafonov
9cf1ee2f42
Questing Beast - fixed rollback error on damage prevent ( #6116 );
2019-12-24 10:53:51 +04:00
LevelX2
82371456cd
* Commented out showXXX commands in tests to reduce the output.
2019-12-23 19:22:56 +01:00
Oleg Agafonov
fac7ea1388
* AI: fixed rollback errors with copy spell abilities;
...
Tests: added copy spell support for test player;
2019-12-23 21:47:01 +04:00
LevelX2
2f998060a2
* Fixed a problem with power/toughness setting of copied transformed permanents ( fixes #5893 ).
2019-12-23 15:35:53 +01:00
Oleg Agafonov
d26fde8dbc
Prepare new release
2019-12-21 18:23:15 +04:00
Oleg Agafonov
bd71c98e3e
Fixed AI freeze with non available targets
2019-12-21 18:10:29 +04:00
Oleg Agafonov
7a7a9c20ec
Tests: fixed false positive tests (AI related, see prev commit);
2019-12-20 20:22:38 +04:00
Oleg Agafonov
8cce5a3648
* AI: reworked computer choices for "target permanent" targets:
...
* Fixed that computer was able to target own permanents for bad effects and opponent permanents for good effect;
* Improved target choices on card score (as example: boost most valuable, discard most weaker);
* Tests: fixed false positive tests (AI depended);
* Tests: fixed that test player can't find permanents for some filters/predicates;
2019-12-20 20:20:16 +04:00
jeffwadsworth
27a505ced9
- Fixed #6096 .
2019-12-19 15:31:48 -06:00
Oleg Agafonov
cde9957f54
* UI: added playable card marks in look-at windows;
2019-12-18 22:44:42 +04:00
Oleg Agafonov
ff1299cca9
* Copy activated ability - fixed that it raise error on triggering on copied permanents;
2019-12-18 18:16:16 +04:00
Oleg Agafonov
23ef0e4269
* Spark Double - fixed that copy of spark contains legendary type ( #6097 )
2019-12-18 17:57:41 +04:00
Oleg Agafonov
419cbf3c28
* AI: fixed that computer was able to choose non valid targets/cards (from all graveyards, hands, etc);
2019-12-16 02:58:10 +04:00
Oleg Agafonov
0885a01849
Fixed that TargetCard ignore filter in some calls
2019-12-16 02:55:13 +04:00
LevelX2
af9f2c93dd
Merge pull request #5910 from magefree/set_lint
...
Fix various hints and warnings on many set & block classes (via Intel…
2019-12-15 13:21:08 +01:00
LevelX2
8d46f46cf8
Fixed a problem that DiesTriggeredAbilities from Tokens that were removed by an effect did nevertheless trigger ( fixes #5825 ).
2019-12-15 13:10:11 +01:00
LevelX2
d458e73795
Merge pull request #5826 from drmDev/ut/trickster
...
Unit Tests for Merfolk Trickster, confirming #5825
2019-12-15 12:23:48 +01:00
Patrick Hulin
5d35ee675d
Fix Mysterious Pathlighter.
2019-12-14 23:31:39 -05:00
LevelX2
81ff37ad17
Fixed a bug that sometimes wrongly power of new source instance was used to determine a number and fixed also a bug that counters were added wrongly to an already new instance of the source object ( fixes #6035 ).
2019-12-15 00:50:44 +01:00
LevelX2
b7b3bc4474
Merge origin/master
...
Conflicts:
Mage/src/main/java/mage/players/PlayerImpl.java
2019-12-14 18:41:12 +01:00
LevelX2
da9f24e008
Removed deprecated AdjustingSourceCosts interface.
2019-12-14 18:33:11 +01:00
Oleg Agafonov
732a48e936
Fixed and improved tests for latest changes like asThough and adventure cards;
2019-12-14 19:19:32 +04:00
Oleg Agafonov
a05da68493
Improved alternative cost from dynamic effects (it's like #5913 PR):
...
* Game: added multiple cards/effects support (old version supported only 1 effect per game);
* Game: added combo support with split and adventure cards;
* AI: computer can see and play cards with dynamic added alternative cost (like Bolas's Citadel);
* UI: users can see playable cards with alternative cost.
2019-12-14 19:09:25 +04:00