Commit graph

4682 commits

Author SHA1 Message Date
LevelX2
70833c6938 Merge pull request #1422 from LoneFox78/master
New cards from Mirrodin + some random stuff
2015-12-16 11:30:06 +01:00
LoneFox
07f7f38843 Fix a bogus warning when removing all counters of one type from a permanent 2015-12-15 14:29:14 +02:00
LoneFox
86104fa124 Add DistributeCountersEffect and use it for existing cards. Fix Armament Corps, which allowed to
put counters on other players' creatures. Implement cards: Bounty of the Hunt, Shambling Swarm, and
Wurmskin Forger
2015-12-15 14:11:08 +02:00
fireshoes
3008b5ed14 [OGW] Added 18 cards. Cards with <> in their activation costs are untested. 2015-12-14 23:02:35 -06:00
Quercitron
5a709468b5 Add Rakdos the Defiler 2015-12-15 03:09:14 +03:00
Quercitron
50a71f5cb9 Add HalfValue dynamic value 2015-12-15 03:08:17 +03:00
LevelX2
0157bf0494 * Fixed that the name of a face down spell on the stack was shown in the game log if the spell was targeted by another stack object. 2015-12-14 22:03:00 +01:00
LoneFox
acb2c47207 Clean up various Control Magic effects 2015-12-14 12:51:23 +02:00
LevelX2
207f486afc * Xmage 1.4.6v0 2015-12-13 19:47:04 +01:00
LevelX2
bdc9260dfa * Corpse Augur - Fixed that all cards in target players graveyard were counted instead of only creature cards. 2015-12-13 17:39:38 +01:00
LevelX2
d9b20298b7 * Bloodlord of Vaasgoth - Fixed that Vampires entering the battlefield did never bloodthirst from the Bloodlord. 2015-12-13 10:05:54 +01:00
LevelX2
e2873be2f8 * Mirror Entity - Fixed that the "gain all creature types" was applied in the wrong layer. 2015-12-12 18:20:42 +01:00
LevelX2
8b5272cb64 * Fixed a problem that the controller of triggered abilities was set to a false value if the source object of the triggered ability was removed from battlefield at the same time as other objects (fixes #1417). 2015-12-12 17:36:12 +01:00
LevelX2
4ca5909840 * Some minor changes. 2015-12-12 07:32:56 +01:00
fireshoes
692fe8046e Merge origin/master 2015-12-11 16:13:39 -06:00
fireshoes
636f2d960e Updated text of cards that add colorless mana to use {C}. Added ExileSourceUnlessPaysEffect. Added some random cards. 2015-12-11 16:12:46 -06:00
emerald000
2ceb8425e5 Remove obsolete Pick zone. 2015-12-11 17:03:45 -05:00
LevelX2
af793c30fe * Added a slider to the preferences to adjust the delay for the card tooltip window appearance. 2015-12-08 18:39:47 +01:00
LevelX2
0488da6b22 * Amoeboid Changeling, Wings of Veles-Vel - Fixed that the character types were changed on the wrong layer. 2015-12-08 15:24:24 +01:00
LevelX2
4d01eb143a Redesigned handling of attack allowed check related to the complete attack. 2015-12-08 12:20:37 +01:00
LevelX2
15a884c00c * Added a test. 2015-12-07 17:19:37 +01:00
LevelX2
259d6744ae * Fixed that casting spells without mana costs did not work correctly for spells with mono hybrid mana costs (e.g. Beseech the Queen by Omniscience) fixes #1404. 2015-12-06 09:37:45 +01:00
LevelX2
2619202931 Merge pull request #1409 from LoneFox78/master
New cards
2015-12-06 09:35:21 +01:00
LevelX2
de285ba1ed * Fixed that draw effect was only applied to the first target (e.g. Wheel and Deal only one opponent draws 7 cards). 2015-12-05 01:09:22 +01:00
LevelX2
dd50521887 * Grasp of Fate - Fixed that only the first target was exiled. 2015-12-04 19:11:34 +01:00
LoneFox
04e2282e82 Extract RecruiterEffect from Goblin Recruiter to its own file. Implement cards: Dwarven Recruiter and Scouting Trek 2015-12-04 12:58:59 +02:00
LevelX2
ac19cfe379 Some changes to token expansion set calculation. 2015-12-04 08:24:18 +01:00
emerald000
3dcdd7f046 Removed obsolete Zone parameter in CardsImpl constructors. 2015-12-04 00:34:10 -05:00
fireshoes
e5b4790d20 Merge origin/master 2015-12-03 16:27:30 -06:00
fireshoes
7abd1133e6 Added numerous cards, mostly from PO2 and PO3. Fixed that Suture Priest's first ability wasn't optional. Updated Adam Styborski's Pauper Cube. 2015-12-03 16:26:29 -06:00
LevelX2
eb1c738b37 * Moved some logic in a framework class. Fixed some problems of Whirlpool creatures. 2015-12-02 16:55:09 +01:00
LevelX2
87fc4d53dc Fixed Framework pom - removed fixed src folder. Minor fixes to ManaTest. 2015-12-01 22:43:56 +01:00
LevelX2
595a55b7c5 Revert "Fixed package declarations for moved Mage package."
This reverts commit 06199eeca3.
2015-12-01 22:33:59 +01:00
poixen
db2af7000e Merge pull request #1399 from poixen/counters
Added unit tests and javadoc for Counter class.
2015-12-01 20:04:15 +01:00
emerald000
7abfc7d025 File that wanted to feel special and not be part of last commit. 2015-12-01 06:16:00 -05:00
emerald000
06199eeca3 Fixed package declarations for moved Mage package. 2015-12-01 06:07:01 -05:00
poixen
ad0fb6b7eb Added unit tests and javadoc for Counter class. 2015-11-30 21:44:57 +01:00
poixen
46eb6c0525 Restructured Mage module 2015-11-29 21:56:49 +01:00
poixen
409e66a2e9 Removed mutable public static mana 2015-11-29 20:12:39 +01:00
Neil Gentleman
7996d02b1a add Accelerated Mutation, Torrent of Fire, et al.
using new HighestConvertedManaCostValue
2015-11-28 21:11:56 -08:00
Neil Gentleman
bfb428b13a always use log4j
removed all references to mage.util.Logging, java.util.logging

transient static doesn't mean anything, since static fields are never
included in serialization
2015-11-28 21:11:25 -08:00
Quercitron
b9add2e041 * Turntimber Basilisk - Fix a bug when a creature that must be blocked is not attacking 2015-11-29 00:19:21 +03:00
LevelX2
d94a2712ba * Fixed a bug that a dies ability did still trigger as the stack was not cleared meanwhile. 2015-11-28 12:52:13 +01:00
poixen
b22036c041 added javadoc and final modifiers 2015-11-28 11:57:46 +01:00
LevelX2
cb4f996bce * Fixed a problem were Menace restriction could be bypassed by using Undo Block action. 2015-11-27 20:23:04 +01:00
LevelX2
121e55f1d7 * Fixed a problem with calculation of playable lands. 2015-11-27 20:21:48 +01:00
LevelX2
f23756c20b * Fixed that DiesThisOrAnotherCreatureTriggeredAbility did not work if the source died itself (e.g. Omnath, Locus of Rage). 2015-11-27 12:27:46 +01:00
LevelX2
123afcb44c * Some minor tooltip rule text fixes. 2015-11-26 22:57:42 +01:00
LevelX2
0b832c9b11 * Fixed a bug of cost reduction calculation. 2015-11-26 22:56:42 +01:00
LevelX2
eb6a5e7dcb * Some rework of play card effects. 2015-11-26 17:06:50 +01:00
LevelX2
780702be1b * Fixed some problems with replaced play land special action. 2015-11-26 10:48:40 +01:00
LevelX2
e51c4d5f67 * Fixed a bug where wrongly a card object was moved for a copied spell. 2015-11-26 00:48:28 +01:00
poixen
c0ee279da9 methods now access and set state directly, rather than through the API, which is meant to prevent accidently setting minus values 2015-11-25 23:12:23 +01:00
poixen
3ffb11d2e9 Updated mana class to pass failing tests 2015-11-25 19:57:11 +01:00
LevelX2
fbb3929d0a * Fixed some adjustTargets methods of cards were that the target adjustment could be applied to abilities not intended (fixes #1384). 2015-11-25 16:30:18 +01:00
LevelX2
b637d2c65c * Fixed layer problem of BecomesCreatureSourceEffect (causes Chimeric Mass to die after entering the Battlefield). 2015-11-25 14:51:41 +01:00
Neil Gentleman
12b6a22327 improve Devotion formatting
fixes Aspect of Hydra, Evangel of Heliod
2015-11-25 00:32:02 -08:00
Neil Gentleman
19a0e1dcc4 correct grammar, remove duplicate parentheses 2015-11-25 00:32:02 -08:00
Neil Gentleman
b1cc464d98 remove useless .toString() 2015-11-25 00:32:01 -08:00
Neil Gentleman
f83cb32ed3 don't use <i/> to end italic text
it's not correct html, and causes all following text to render italic.

only visible on a few cards, because reminder text typically comes at
the end of line.
2015-11-25 00:32:00 -08:00
fireshoes
692c7d2812 Added some POR cards and a few misc cards. Fixed POR collector's numbers. 2015-11-25 01:07:43 -06:00
LevelX2
8b3958f7d5 Merge pull request #1385 from LoneFox78/master
Some Coldsnap
2015-11-24 09:09:21 +01:00
LoneFox
6b345fb291 Snow mana symbol is {S}, not {snow} 2015-11-23 16:47:16 +02:00
LevelX2
be49cfc561 * Myriad - Fixed that wrongly also a token was created for the defending player. 2015-11-23 12:24:46 +01:00
Neil Gentleman
230d1d37bd fix Grinning Totem, Thada Adel, Commune with Lava
opponent was able to cast the exiled cards

also changed Knacksaw Clique to use the same templating as Ornate Kanzashi
2015-11-22 18:40:38 -08:00
Neil Gentleman
a90d0e5597 reuse shared code for picking basic land sets 2015-11-22 18:00:10 -08:00
LoneFox
4214ef94b0 Fix the text of ripple abilities 2015-11-22 20:10:39 +02:00
LevelX2
05dd1daee6 * Added some information to the player tooltip in game (expericence counters, deck hash code, # of wins). 2015-11-22 11:07:48 +01:00
Neil Gentleman
038d02e8d7 add test for non-standard booster generation 2015-11-21 18:35:10 -08:00
LevelX2
96bc3172f5 * Fixed a problem of returning cards from exile (e.g. Fiend Hunter) if the triggering permanent made multiple zone changes before the left battlefield triggered ability resolved to return the exiled permanents. 2015-11-21 23:41:41 +01:00
poixen
b0da2f2260 Merge pull request #1378 from poixen/mana_cleanup
Removed minus subtraction limits
2015-11-21 12:06:02 +01:00
poixen
a5242ff087 resolved conflicts 2015-11-21 12:02:55 +01:00
poixen
5c6bdfceb8 Merge pull request #1379 from poixen/manasymbol
Manasymbol
2015-11-21 11:47:28 +01:00
LevelX2
0d86e8e063 Xmage 1.4.5v0 2015-11-21 10:33:43 +01:00
emerald000
59fabeee20 Added missing Scion subtype. 2015-11-20 17:42:14 -05:00
poixen
f2972c5b8e Updated Phyrexian Mana
+ “A Phyrexian mana symbol represents a cost that can be paid either
with *one mana of its color* or by paying 2 life”. These symbols are
mono colored, as such I have made them so.
+ Added test cases for phyrexian mana symbols
2015-11-20 22:43:26 +01:00
poixen
de13fb5cba Removed redundant modifiers
+ Removed the private modifiers. They are not needed in an ENUM class.
2015-11-20 22:08:39 +01:00
poixen
f34e69308e Updated mono colored hybrid mana type
+ “107.4e. Hybrid mana symbols are also colored mana symbols.” I have
added the Type COLORED to each mono hybrid symbol
+ added tests for hybrid mana symbols
2015-11-20 22:07:24 +01:00
poixen
f6cc03ec44 Added W mana test case
Added U mana test case
Added B mana test case
Added R mana test case
Added G mana test case
2015-11-20 20:59:52 +01:00
poixen
56be135532 Removed minus subtraction limits
+ Removed minus subtraction limits to allow other areas of code to work
2015-11-20 17:22:48 +01:00
LevelX2
8a133a43d0 Added test for Mana.enough method. 2015-11-20 15:06:00 +01:00
Quercitron
7e58dc70d5 Update Swiss tournament pairing - For the last round, for each unpaired player pair against the highest ranked player they haven't played against 2015-11-20 02:54:50 +03:00
LevelX2
c4ab5806e0 Revert "Mana Class Overhaul" 2015-11-19 22:59:57 +01:00
LevelX2
68ff09c219 Revert "Mana updates" 2015-11-19 22:59:15 +01:00
LevelX2
f4871fe489 Merge pull request #1375 from poixen/mana_cleanup
Mana updates
2015-11-19 22:37:14 +01:00
poixen
05b841577a added subtraction logic to enough()
+ added subornation logic to enough(). We do not want to mix the public
subtract() call with this method. As doing so would mean that either a)
subtraction can go below 0 (this should not happen) or b) we break this
function with exceptions. This is a work around for these scenarios.
2015-11-19 17:42:59 +01:00
poixen
2c617a6aaf Mana updates
+ calling subtraction will now throw an exception if you try and use
more mana than is available. This is better than setting it to 0.
Setting to 0 impose that you should still be allowed to perform the
action.
+ updated subtraction test to check for exception
+ subtractionCost() will not allow using mana that is not available,
same as subtract()
2015-11-19 17:09:40 +01:00
LevelX2
ec7c888044 Some fixes to put token onto battlefield handling of cards. Some minor reworks. 2015-11-19 15:52:45 +01:00
LevelX2
7bb5d1bb43 Merge pull request #1374 from poixen/mana_cleanup
Mana Class Overhaul
2015-11-19 14:37:39 +01:00
Quercitron
486d547f5e Fix Swiss pairing for the case when some players have left the tournament 2015-11-19 13:18:43 +03:00
poixen
1f5638539f Class Overhaul
+ added javadoc
+ added final to method variables that should not be mutated
+ Mana can no longer be initialised with minus values
+ added null assertions
+ renamed ‘addXXX’ to ‘increaseXXX’. Add implies that you are able to
add variable amounts.
+ subtraction can no longer allow minus values.
+ removed unused state
+ refactored classes use renamed/removed mana calls
+ added comment to contains(), needs to be looked into?
+ Added validation to setting of mana. Can no longer be set to minus
values. Will log if an attempt is made
+Added comment to static mana, this is unsafe.
2015-11-19 09:53:52 +01:00
Neil Gentleman
00ec431889 add Gorgon Recluse, cleanup similar cards
Added filtering to BlocksOrBecomesBlockedByCreatureTriggeredAbility,
so that non-wall and color-specific basilisks could reuse it.

Simic Basilisk and Deathgazer were incorrectly destroying the creature
immediately, not at end of combat.
2015-11-18 21:05:14 -08:00
Quercitron
05a789cd8b Use approach with minimal weight matching to determine Swiss tournament pairings 2015-11-19 02:58:02 +03:00
LevelX2
9b074876db Merge origin/master 2015-11-19 00:42:45 +01:00
LevelX2
fd0d9c166d [C15] Added Mizzix's Mastery, Mirror Match and Synthetic Destiny. 2015-11-19 00:39:43 +01:00
Fiorden
3991ec4ba0 Merge pull request #1 from magefree/master
testing update
2015-11-18 21:05:09 +01:00
Fiorden
bfb7d06cae Fixed that Mountain subtype was not remowed by Spreading Seas, Sea's Claim 2015-11-18 20:05:06 +01:00
LevelX2
dcf3ac87f1 [C15] Added Deadly Tempest and Dread Summons. 2015-11-18 20:04:00 +01:00
LevelX2
7044e58231 [C15] Added Scourge of Nel Toth. 2015-11-18 17:39:32 +01:00
LevelX2
bfb54ca112 * Deflecting Palm - Fixed a bug that the to the source controller redirected damage of Deflecting Palm could not be redirected to an existing planeswalker of that controller. 2015-11-18 17:38:48 +01:00
Neil Gentleman
1750bf32a1 fix Seance
Spirit subtype wasn't being added, and the token shouldn't have haste
2015-11-17 23:36:06 -08:00
LevelX2
1d590442d0 [C15] Added Awaken the Sky Tyrant and Dream Pillager. 2015-11-15 20:05:58 +01:00
LevelX2
160f14eed1 [C15] Oreskos Explorer, Bastion Protector and Dawnbreak Reclaimer. 2015-11-15 18:54:26 +01:00
LevelX2
d3751af0db [C15] Added Skullwinder and Ezuri's Predation. 2015-11-15 11:10:52 +01:00
LevelX2
576a9ea74f Updated mtg-cards-data.txt. Added a land deck for Mormir Basic format. 2015-11-15 10:25:02 +01:00
LevelX2
dd28bb18c4 * Untap symbol - Fixed that the creature has to be under your control since the start of the last turn or needs to have haste to be able to pay the untap cost (e.g. Pili-Pala). 2015-11-14 11:46:23 +01:00
LevelX2
d3000da3a3 * Void Winnower - Fixed that the check for even casting costs did not work correctly. 2015-11-14 11:14:50 +01:00
LevelX2
50b5602459 * Conflagrate - Fixed that the damage amount could be calulated if cast by flashback. 2015-11-14 10:01:13 +01:00
LevelX2
1335d58e77 * Collapsing Borders - Fixed that it did not give life to players. 2015-11-14 02:33:24 +01:00
LevelX2
4711e0cf99 Changed ability handling of modal spells to be able to select the same mode multiple times with different targets. 2015-11-14 01:56:56 +01:00
LevelX2
ae3640557a Merge pull request #1361 from nigelzor/vanguard
add Momir Basic game type
2015-11-12 04:00:27 -05:00
Neil Gentleman
c5ecb26289 Momir: lookup token at activation
loading all the cards at game start is quite slow
2015-11-11 12:55:49 -08:00
Neil Gentleman
cda5a06a6c fix sorcery-speed LimitedTimesPerTurnActivatedAbility
calling super.canActivate() from inside activate() will always fail,
because the stack is no longer empty
2015-11-11 12:31:42 -08:00
LoneFox
70f77b858e Rename BecomesTappedCreatureControlledTriggeredAbility -> BecomesTappedTriggeredAbility and generalize it to allow all kinds of permanent fiilters instead of just controlled creatures. Implement cards: Lifeblood and Lifetap 2015-11-11 10:18:49 +02:00
LoneFox
f133854db1 Rename BecomesTappedTriggeredAbility -> BecomesTappedSourceTriggeredAbility 2015-11-11 09:49:25 +02:00
LoneFox
2c23d23566 Fix PlayWithTheTopCardRevealedEffect's text. Implement cards: Field of Dreams and Wizened Snitches 2015-11-10 21:11:11 +02:00
LoneFox
c33e7ad59b Add support for selecting the counter type during resolution to RemoveCounterTargetEffect. Use it for existing cards. Fix some tooltip text issues with the effect. Implement cards: Ferropede and Spinal Parasite 2015-11-10 20:35:48 +02:00
LevelX2
932b454595 * Myriad - Fixed handling of source object determination. 2015-11-09 14:25:42 +01:00
Neil Gentleman
eda5d1a1ef BoostSourceEffect: format X like BoostTargetEffect
primarily to fix Chameleon Colossus and friends, but also updated
Terra Ravager's ability to match the corrected format, and now
both Source and Target support -X, for Death's Shadow.
2015-11-08 22:14:15 -08:00
LevelX2
431d0005f2 Updated modes to handle selection of modes multiple times (not working yet if targets included). 2015-11-08 20:07:02 +01:00
Quercitron
9b29cd042f Move updateExpansionSetCode from CreateTokenEffect.apply to Token.putOntoBattlefield 2015-11-08 20:16:47 +03:00
Quercitron
e23fc13db0 Fix pictures for some tokens from recent sets 2015-11-08 20:16:47 +03:00
LevelX2
6f2d3a18c0 [C15] Added Myriad keyword. 2015-11-08 11:51:36 +01:00
LevelX2
7572c756c4 * PlanarGate, Mana Matrix, StoneCalendar - Fixed not correctly working spell cost reduction. 2015-11-08 09:57:35 +01:00
fireshoes
4de4caad26 [C15] Implemented Shielded by Faith, Grasp of Fate, Arachnogenesis, and Great Oak Guardian. 2015-11-07 21:18:21 -06:00
LevelX2
5702c694a9 * Fixed that the corresponding token image was not always set correctly. 2015-11-07 21:23:22 +01:00
LevelX2
f3e8a93316 * Renegade Krasis - Fixed that check if Renegade Krasis was evolved did not always work correctly. 2015-11-07 21:21:03 +01:00
LevelX2
d596a1ef83 * Fixed a bug that self scope were checked for non relevant events (fixes #1350). 2015-11-07 13:32:15 +01:00
LevelX2
b1c3d690f5 * Fixed some ability and subtype removing effects (fixes #1352). 2015-11-07 12:29:31 +01:00
LevelX2
bb99148b78 * Fixed a problem with zone change counter comparation. 2015-11-07 10:16:11 +01:00
fireshoes
ae55c8b176 [C15] Updated complete spoiler and added existing reprints. Add Rite of the Raging Storm and Corpse Augur. 2015-11-06 12:35:50 -06:00
LevelX2
e3c43c0c31 Merge origin/master 2015-11-06 12:30:15 +01:00
LevelX2
27ae613ce8 * Fixed handling of zoneChangeCounter of PermanentCard (fixes #1353). 2015-11-06 12:28:58 +01:00
LevelX2
e6860a6020 Merge pull request #1357 from LoneFox78/master
Some Tempest
2015-11-06 12:09:52 +01:00
LoneFox
fde9ae68dc Extract DestroyTargetAtBeginningOfNextEndStepEffect from Stone Giant to its own file. Implement cards: Blood Frenzy, Flowstone Sculpture, Imps' Taunt, and Mogg Cannon 2015-11-06 09:19:47 +02:00
LevelX2
e82a7b621e * Fixed a problem with countering abilities on the stack. 2015-11-05 15:39:12 +01:00
LevelX2
3de7ff6808 * Some rework of card moving after spell countering. 2015-11-05 00:37:30 +01:00
LevelX2
1139495fd7 * SetPowerToughnessSourceEffect - Set the correct sublayer to use (fixes #1354). 2015-11-04 22:31:35 +01:00
LoneFox
2080ad3ab8 Add CastOnlyIfYouHaveCastAnotherSpellEffect and use it for existing cards. Implement card: Skyshroud Condor 2015-11-04 10:40:07 +02:00
LoneFox
9e3ef31b4b Implement cards: Apes of Rath, Endless Scream, Fool's Tome, and Fylamarid 2015-11-04 09:29:08 +02:00
BursegSardaukar
3376f418c6 Pulled from trunk. 2015-11-01 16:42:44 -05:00
BursegSardaukar
6807496357 Corrected bug with copy/paste 2015-10-04 21:32:40 -04:00
BursegSardaukar
8afc24ae15 Added the effect to allow for future card usage. 2015-10-04 16:10:52 -04:00
LevelX2
abca80e951 * Cascade - Fixed that the remaining cards were not set to graveyard in a random order. 2015-10-02 15:05:00 +02:00
LevelX2
cc8c650285 * Iname as One - Fixed that it was able to return itself. 2015-10-02 08:40:26 +02:00
LevelX2
73766a21eb * Fixed that the token image of Kithkin Solder was not shown (token was only named Kithkin instead of Kithkin Solder). 2015-10-02 01:37:15 +02:00
LevelX2
5912ed80ad * Fixed some problems with undo/cancel action (fixes #1267). 2015-10-02 01:04:40 +02:00
LevelX2
8044940a97 * Fixed a bug that if all targets (if targets were set) of a spell with an up to target definition (e.g. Adverse Conditions) became illegal the spell did not fizzle as it should. 2015-09-30 00:53:33 +02:00
LevelX2
f5b411c516 Merge pull request #1292 from LoneFox78/master
Third part of the big token cleanup + a few other fixes and new cards
2015-09-29 15:48:09 +02:00
LoneFox
ab0e4b0ddc Revert connectSource changes from TapTargetEffect. Not needed anymore. 2015-09-29 15:25:52 +03:00