Oleg Agafonov
aeb2d31d47
[CMR] fixed Gilanra, Caller of Wirewood - duplicated triggers on unused mana ( #7191 );
2020-11-20 12:53:13 +04:00
Oleg Agafonov
39a556f233
* Long-Term Plans and Volrath's Dungeon - fixed that it shows card name in game logs to other players ( #7179 );
2020-11-18 12:44:58 +04:00
Oleg Agafonov
656653f38b
Modal Double Faces cards fixes:
...
* Fixed that mdf card can duplicate triggers (example: Skyclave Cleric, see #7187 );
* Fixed that mdf card can raise triggers from another side (example: Kazandu Mammoth, see #7180 );
2020-11-18 02:04:32 +04:00
Evan Kranzler
01a0d23a55
removed method for preventing library search triggers
2020-11-13 09:40:18 -05:00
Francesco Burato
6e3750d50a
[app-wiring-refactor]: Apply review comments:
...
- Add reference to original library in `FluentBuilder`.
- Change `I<Name>` notation to `<Name>Impl` notation.
- Move error config to test resources
- Add comment with config instruction
- Add config to the documentation
2020-11-12 20:12:50 +00:00
Francesco Burato
d0c2135e17
[app-wiring-refactor]: Remove static initialisation
...
- Remove all enum static managers
- Introduce interfaces for the managers
- Define new application wiring class (`ManagerFactory`)
- Externalise the configuration
2020-11-12 20:12:48 +00:00
Oleg Agafonov
ea46afbe62
Prepare new release
2020-11-10 13:11:45 +04:00
Oleg Agafonov
5578437dde
* GUI: increased ignore list max size from 100 to 500;
2020-11-09 00:42:43 +04:00
Oleg Agafonov
cff67085b7
[ZNR] Fixed MDF cards with put to battlefield effects ( #7174 )
2020-11-07 21:24:59 +04:00
Oleg Agafonov
02e19f0a3f
[ZNR] Improved modal double faces cards implementation and more tests ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
e4c8ba046a
[ZNR] Improved modal double faces cards implementation and more tests ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
19cd742f40
Tests: fixed BlazingTorchTest
2020-11-01 10:03:09 +01:00
Oleg Agafonov
a73c9bddae
[ZNR] Added all modal double faces cards ( #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
70514124a6
* Disrupting Shoal - fixed that it counter spells by CMC from any payed split card's parts instead combined CMC only;
2020-11-01 10:03:09 +01:00
Oleg Agafonov
8ac78b4b9e
Added modal double faces cards implementation (MDF cards, #7012 )
2020-11-01 10:03:09 +01:00
Oleg Agafonov
bbed5a16b8
Test framework: added library realtime check command;
2020-11-01 10:03:09 +01:00
Evan Kranzler
8617bc128e
Fixing issues with Changelings and general problems with creature types (ready to merge) ( #7098 )
...
* updated Changelings to use setIsAllCreatureTypes
* updated Dr Julius Jumblemorph and Mistform Ultimus to not use changeling
* added test for Mistform Ultimus
* updated effects which give all creature types to controlled creatures
* updated effects which give all creature types to targeted creatures
* Update LoseAllCreatureTypesTargetEffect.java
* updated effects which give all creature types to attached creatures
* Update EgoErasure.java
* added another test for changelings
* updated two tokens I left out before
* updated hasSubtype
* updated shareCreatureTypes
* fixed an incorrect test
* cleaned up some cards which check for shared creature types
* added new changeling test
* fixed issue with shareCreatureTypes
* fixed a text issue
* added new tests for subtype effects
* various individual card fixes and cleanups
* fixed and updated various effects
* many more fixes
* a few more fixes
* added test for One with the Stars
* added changeling verify test
* updated effects which add additional subtypes
* more miscellaneous fixes
* added additional test
* some fixes for card type checks
* updated methods for adding types to make it easier to avoid duplicates and illegal additions
* small test update
* fixed a recursive loop issue
* fixed another error
* fixed it for real this time
* streamlined type removal process
* streamlined subtype set generation
2020-10-30 22:32:59 -04:00
Evan Kranzler
a66428b2b6
updated implementation of equipment which use themself in a gained ability
2020-10-22 21:37:03 -04:00
Evan Kranzler
9f7a873e5b
added test for Omnath, Locus of Rage and protection effects ( closes #7133 )
2020-10-14 20:36:50 -04:00
Evan Kranzler
e65d769e47
fixed Chainer, Nightmare Adept not triggering off of creatures owned by other players
2020-10-12 21:08:37 -04:00
Evan Kranzler
92445ace3d
added more tests for Pelt Collector
2020-09-29 20:41:47 -04:00
Evan Kranzler
3f4698434b
fixed random mystery booster test failures
2020-09-29 19:35:32 -04:00
Evan Kranzler
827ffb5fb2
changed how effects are applied for triggered abilities, added test ( fixes #7083 )
2020-09-29 18:55:51 -04:00
Evan Kranzler
27a4f27727
reworked Chainer, Nightmare Adept and added test
2020-09-29 18:03:56 -04:00
Evan Kranzler
4162c3e5cb
[ZNC] fixed Whispersteel Dagger, added test ( #7085 )
2020-09-28 19:22:30 -04:00
Evan Kranzler
7647a3d8f0
Support for copying permanent spells (WIP, do not merge) ( #7084 )
...
* added initial support for permanent tokens
* [ZNR] Implemented Lithoform Engine
* [ZNR] Implemented Verazol, the Split Current
* permanent spell tokens no longer count as created
* small change to token generation
* added test, currently incomplete
* found a potential solution for kicker issue, possibly too much of a hack
* fixed a test failure
* reversed hack changes
* skipped failing tests
* added more tests
2020-09-27 10:54:44 -04:00
Evan Kranzler
ee94eb3553
[ZNR] small update to Ashaya test
2020-09-24 22:07:18 -04:00
Evan Kranzler
5cad7d9bff
[ZNR] added test for Ashaya, Soul of the Wild (needs more cases)
2020-09-24 21:59:36 -04:00
Evan Kranzler
66235dc6e0
[ZNR] added a test for Moraug, Fury of Akoum
2020-09-23 21:18:15 -04:00
Evan Kranzler
a022d79b65
fixed Pelt Collector implementation, expanded test
2020-09-22 17:23:42 -04:00
LevelX2
2fec825523
* Some standardisation of dies trigger handling ( fixes #7063 Midnight Reaper triggers when dies face down).
2020-09-18 16:15:21 +02:00
LevelX2
e1ab14e0f5
Merge pull request #7071 from Dilnu/Haruspex
...
Create a test to verify Grim Haruspex's ability.
2020-09-18 13:19:33 +02:00
LevelX2
1125d9cca1
Added a test. Some mionor changes.
2020-09-17 10:02:08 +02:00
LevelX2
4050631807
Fixed that some AlternativeCostSourceAbilities had no sourceId set.
2020-09-17 10:00:46 +02:00
Oleg Agafonov
6e0c7e868c
Additional and alternative costs improved:
...
* Now player must choose additional costs before ability's modes;
* Fixed broken kicker ability from ZNR (see comments from d4ca287f0f
);
* Improved compatibility of additional cost with cost modification effects (fixed that optional multi-costs doesn't affected by cost modification);
* Improved compatibility of additional cost with alternative cost (some cards ignores additional cost on alternative usage, e.g. on play free);
2020-09-13 09:57:17 +04:00
Oleg Agafonov
586538a66c
Test framework: added fast command to add cost modification effect in test game (addCustomEffect_SpellCostModification)
2020-09-13 09:57:17 +04:00
Evan Kranzler
439303882c
updated cost adjustment for Mobilized District, added test
2020-09-10 17:08:01 -04:00
Evan Kranzler
4daaaddbb0
updated cost adjustment for Pteramander, added test
2020-09-10 17:07:29 -04:00
Evan Kranzler
649ff35359
[ZNR] small additional fix to party count test
2020-09-10 12:44:48 -04:00
Evan Kranzler
100c130cec
[ZNR] fixed party count including opposing creatures, updated test ( fixes #7061 )
2020-09-10 12:40:01 -04:00
Oleg Agafonov
5831ba81fc
Merge pull request #7030 from BrunoChevalier/master
...
Additional fixes for pvs-studio report, see #7021
* Rename BasicSaheekiSublimeArtificerTest.java to BasicSaheeliSublimeArtificerTest.java
* S3Uploader.java: Remove redundant null check
* Effects.java: remove redundant check. When in the else part, the lastRule already is guaranteed to not end on a dot
* TableController.java: change warning message when match == null to avoid nullpointer exception
* Reverted already fixed line from, see #7021
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2020-09-08 23:04:30 +02:00
LevelX2
d0ccafd2a8
Added test for Pako Arcane Retriever.
2020-09-08 15:29:58 +02:00
LevelX2
8e465acb11
Primordial Mist - Fixed selection of face down targets ( fixes #7045 ).
2020-09-08 13:14:15 +02:00
Evan Kranzler
91067e89cb
rewrote party count test to allow for more easily adding additional cases
2020-09-05 16:50:51 -04:00
Evan Kranzler
cc0bb84dad
[ZNR] Implemented party mechanic ( #7036 )
...
* added incomplete party count implementation
* updated party count implementation
* added party count test
* fixed tests, updated test framework
* added an additional test
* fixed some errors in party count computation, should be good now
* fixed a small error with test generation
* fixed an NPE issue
2020-09-03 19:22:05 -04:00
Evan Kranzler
0d12f566e5
fixed an NPE issue
2020-09-03 18:39:05 -04:00
Evan Kranzler
003fd098b0
fixed a small error with test generation
2020-09-03 18:36:27 -04:00
Evan Kranzler
86446f4977
added an additional test
2020-09-03 18:25:39 -04:00
Oleg Agafonov
535e49b89f
Test framework: added aliases support for activated abilities (related to #7036 );
2020-09-04 02:18:40 +04:00
Evan Kranzler
f0df4267a3
fixed tests, updated test framework
2020-09-03 18:12:43 -04:00
Evan Kranzler
fa40ffe837
added party count test
2020-09-03 16:34:25 -04:00
LevelX2
1f869fab4d
* Added Test for Plague Engineer.
2020-09-02 15:05:39 +02:00
LevelX2
61315ec741
* Improved some FixedTarget initializations.
2020-08-31 10:54:59 +02:00
Bruno Chevalier
1dccb62d10
Rename BasicSaheekiSublimeArtificerTest.java to BasicSaheeliSublimeArtificerTest.java
2020-08-31 10:51:24 +02:00
LevelX2
323b4f8880
* Fixed wrong Kard name in MTGO Legacy Cube July 2019 (Kozilek, Butcher of Truth), added a test.
2020-08-30 12:07:23 +02:00
Oleg Agafonov
87d8383eb8
* Undercity Reaches - fixed rollback error on plane's draw trigger
2020-08-29 20:40:02 +04:00
Oleg Agafonov
30fe344e23
Test framework: added planes support in tests (command: addPlane)
2020-08-29 20:38:57 +04:00
Oleg Agafonov
ede06098e0
Fixed typos in tests and additional refactor
2020-08-29 19:04:26 +04:00
LevelX2
f819340297
* Added Entwine Test.
2020-08-28 17:17:02 +02:00
LevelX2
83ac7f7bc2
* Nim Deathmantle - Fixed that creature was not returned to battlefield ( fixes #7018 ).
2020-08-28 13:46:21 +02:00
LevelX2
cd5c1c282c
* Angel of Jubilation - Fixed possible Null Pointer Exception in Player.canPayLifeCost method ( fixed #7019 ).
2020-08-28 09:26:38 +02:00
Oleg Agafonov
a0c16dc4e1
Added charset check and hint in startup logs (related to #7020 )
2020-08-28 08:34:01 +04:00
Oleg Agafonov
b610d0a31a
Added default charset information in startup logs
2020-08-28 07:33:42 +04:00
LevelX2
11de701ee8
Merge origin/master
2020-08-26 17:03:02 +02:00
LevelX2
863829085e
* Added a test.
2020-08-26 17:02:23 +02:00
Oleg Agafonov
6787688610
Tests: fixed random failed test testMysteryBooster1, removed redundant logs;
2020-08-26 14:20:39 +04:00
LevelX2
f1d2d2fb22
* Safe Passage - Fixed a problem that damage to player was not prevented ( fixes #6995 ).
2020-08-25 16:30:48 +02:00
LevelX2
b5a1971aa3
* Some minor changes.
2020-08-24 16:50:47 +02:00
LevelX2
149635a9f1
* Added test for Propaganda.
2020-08-23 11:36:01 +02:00
LevelX2
b14c9c341b
* Added test for Palace Jailer.
2020-08-23 10:51:08 +02:00
Oleg Agafonov
920697d2e5
Prepare new release
2020-08-23 01:52:55 +04:00
Oleg Agafonov
1b430e5d99
Added verify test to check missing second face cards in sets, fixed missing cards;
2020-08-22 18:48:15 +04:00
LevelX2
c16fb75668
* replaces all [source} by {this}. ATTENTION !!!: Only supporting [this} from now on in rule text.
2020-08-22 12:52:49 +02:00
LevelX2
d51acbf090
* Removed unused imports.
2020-08-22 11:51:34 +02:00
LevelX2
546205bba4
* Fixed failing test.
2020-08-22 11:26:21 +02:00
LevelX2
82ae1f9cb7
Revert "* Fixed failing test."
...
This reverts commit 7508de950d
.
2020-08-22 11:25:01 +02:00
LevelX2
7508de950d
* Fixed failing test.
2020-08-22 11:16:20 +02:00
LevelX2
01d0183e49
* Fixed failing test.
2020-08-22 10:46:44 +02:00
LevelX2
90c6637dc2
* Implemeented consumable flag for asThoughtEffects and a player choice which effect to use if multiple consumable effects allow the same action.
2020-08-21 21:24:42 +02:00
LevelX2
8105d8b26c
* Improved handling of asThoughtAs approval by abilities that allows a clear and easy assignment of the approving effect.
2020-08-21 14:58:22 +02:00
LevelX2
0565d32f55
* Added test for The Ur-Dragon.
2020-08-20 17:17:27 +02:00
LevelX2
783239e79e
* Aminatou's Augury - Fixed that spells in exile where not shown as castable and that AI usage prevented casting of multiple spells from exile ( fixes #6987 ).
2020-08-20 16:48:13 +02:00
LevelX2
89639f5e9b
* Karador, Ghost Chieftain - Fixed not correct usage detection, simplified/fixed asThoughtAs effect handling.
2020-08-20 14:37:36 +02:00
LevelX2
22e6fee101
* Fixed a bug that non permanent cards could be moved to battlefield instead of staying in the zone they are.
2020-08-18 19:02:15 +02:00
LevelX2
c19af65431
* Added calculation of mana sources of hand cards (related to #6698 ).
2020-08-18 14:52:26 +02:00
LevelX2
818952bf2d
* Fixed a bug that prevented to show cards as playable if castable by alternateSourceCosts (fixes Dream Halls problem related to #6698 ).
2020-08-18 14:00:06 +02:00
LevelX2
c48331f216
* Doubling Cube - Added support for possible mana calculation (related to #6698 ).
2020-08-18 00:22:53 +02:00
Ingmar Goudt
a9627e6101
m21 tests 'F'
2020-08-16 23:39:15 +02:00
LevelX2
768f1bec4f
* Fixed available mana calculation for Cryptic Trilobite and Titans' Nest. Added some improvements for available mana calculation of conditional mana.
2020-08-16 01:16:52 +02:00
Oleg Agafonov
dd7978e106
Merge pull request #6953 from magefree/dependabot/maven/org.apache.maven.plugins-maven-clean-plugin-3.1.0
...
Bump maven-clean-plugin from 2.5 to 3.1.0
2020-08-15 21:17:17 +02:00
Oleg Agafonov
b7c84c9342
[AKR] fixed card numbers, fixed booster generation;
2020-08-15 21:11:17 +04:00
Oleg Agafonov
b89c1c03ca
* Dire Fleet Warmonger - fixed that it asks user two times, fixed text ( #6643 );
2020-08-14 15:12:59 +04:00
LevelX2
27b5c920f7
* Offering - Fixed handling of hybrid mana in casting costs of offered creatures ( fixes #6961 ).
2020-08-14 10:25:47 +02:00
LevelX2
3e498e23e6
* Offering ability - Fixed use in available mana calculation (related to #6698 ).
2020-08-12 16:26:22 +02:00
LevelX2
6a65e5bb23
* Mana Clash - Fixed use in available mana calculation (related to #6698 ).
2020-08-12 13:58:06 +02:00
LevelX2
0d83a8e09a
* Once Upon A Time - Added test ( #6954 ).
2020-08-11 15:15:08 +02:00
Ingmar Goudt
bbefed9b6d
fix test, seems ability triggers twice, need double check
2020-08-10 23:28:10 +02:00
Ingmar Goudt
452ba945e0
add some m21 tests
2020-08-10 23:03:12 +02:00
LevelX2
12c50420bf
* Fixed possible game exception with empty library and commander movement ( fixes #6952 ).
2020-08-10 17:25:48 +02:00
Oleg Agafonov
b16d30b79b
Merge pull request #6190 from luziferius/refactor_promo_sets
...
[RFC] Refactor promo sets, add missing sets as listed on Scryfall
2020-08-10 16:57:00 +02:00