Commit graph

21897 commits

Author SHA1 Message Date
Evan Kranzler
8704b9cb9b [VIS] fixed Vision Charm effect duration (fixes #7652) 2021-03-06 07:56:42 -05:00
Evan Kranzler
6894ad96bc [TSR] various text fixes 2021-03-05 19:10:29 -05:00
Evan Kranzler
bb2e0922ab [TSR] fixed a test failure 2021-03-05 18:34:28 -05:00
Evan Kranzler
425c1eda26 [TSR] added set 2021-03-05 18:17:01 -05:00
Evan Kranzler
b55e3d52c6 [AKH] fixed Throne of the God-Pharaoh text (fixes #7647) 2021-03-05 17:26:40 -05:00
Evan Kranzler
622d13484f fixed some outdated token text 2021-03-05 10:54:15 -05:00
Oleg Agafonov
654c0be1ac Additional fixes for 4a3679285e (#7645) 2021-03-04 23:49:00 +04:00
Evan Kranzler
b1da4d4d79 [MOR] fixed Knowledge Exploitation not working (fixes #7646) 2021-03-04 14:20:33 -05:00
Evan Kranzler
87c272bf06 [KHM] fixed Battle for Bretagard allowing controller to copy tokens they don't control (fixes #7642) 2021-03-03 22:14:42 -05:00
Evan Kranzler
afcdc0f23a simplified and consolidated werewolf triggered abilities 2021-03-03 22:13:16 -05:00
Evan Kranzler
378d596e3c [ULG] reimplemented Damping Engine, fixed text 2021-03-03 20:49:39 -05:00
Evan Kranzler
29be124725 refactored card.moveToExile for M-N
reworked Mindreaver
2021-03-03 10:04:15 -05:00
Evan Kranzler
4c3de17006 refactored card.moveToExile for I-J
reworked Inverter of Truth and Luminate Primordial
2021-03-03 09:22:29 -05:00
Evan Kranzler
b9d5e34f8b [USG] fixed text and implementation of Wizard Mentor 2021-03-02 14:59:09 -05:00
Evan Kranzler
c552234e9c refactored card.moveToExile usage for G-H
heavily reworked Haunting Echoes and Hypnox
2021-03-01 18:03:00 -05:00
Evan Kranzler
852aa562d2 [LRW] fixed Vigor applying to opponent's creatures 2021-02-28 21:03:46 -05:00
Evan Kranzler
9567b19b01 refactored card.moveToExile usages E-F 2021-02-28 17:09:37 -05:00
Evan Kranzler
4a09654743 refactored card.moveToExile usages A through D
heavily reworked Dark Impostor and Dimensional Breach
2021-02-28 17:06:13 -05:00
Oleg Agafonov
098796f86e * Commander: fixed that non hand abilities are castable from command zone (example: Escape, Jumpstart, see #7632); 2021-03-01 01:14:00 +04:00
Evan Kranzler
2daf1945e7 [RTR] reworked Nivmagus Elemental and added test 2021-02-27 15:35:04 -05:00
Daniel Bomar
cd4b93a71a
[KHM] Fixed Battle Mammoth triggering too many times 2021-02-27 12:39:04 -06:00
Daniel Bomar
58fda68117
[KHM] Fixed Draugr Necromancer being able to play lands from MDFCs 2021-02-27 11:34:24 -06:00
Oleg Agafonov
dda69cd009 * AI: improved support of "as though mana" abilities (now computer can choose correct mana ability to pay, example: Draugr Necromancer);
* Dev: added card's LKI support of multi part cards (mdf/split/adventure);
* Dev: improved support of adding/removing counters from mdf cards;
* Draugr Necromancer - fixed support of mdf/split/adventure cards (#7620);
2021-02-27 20:14:12 +04:00
Evan Kranzler
bb04962144 finished the last few refactors for card.moveToZone 2021-02-27 09:57:45 -05:00
Evan Kranzler
ffd5f68220 refactored zone changes, letters M through P
most cards are minor refactors except for Puppet Master which was heavily reworked
2021-02-27 09:24:31 -05:00
Evan Kranzler
d4311916a4 [ATQ] fixed implementation of Goblin Artisans (fixes #7629) 2021-02-27 09:04:26 -05:00
Evan Kranzler
50071b59a0 refactored zone changes, letters I through L
fixed some issues with Immortal Coil, simplified Increasing Ambition, reworked Induced Amnesia and Legion's Initiative, corrected Khalni Gem targeting on trigger
2021-02-26 20:46:34 -05:00
Daniel Bomar
73f594583f
[KHM] Fixed Draugr Necromancer being unable to cast Adventures 2021-02-26 16:10:46 -06:00
Daniel Bomar
87b3511ee2
[M20] Fixed Leyline of Combustion triggering too many times 2021-02-26 13:31:15 -06:00
Daniel Bomar
27c0f75302
Fixed Archfiend's Vessel not moving to exile (fixes #7622) 2021-02-25 16:39:20 -06:00
Evan Kranzler
35be23537f simplified and consolidated effects which check cards put into graveyards from the battlefield 2021-02-25 10:45:26 -05:00
Evan Kranzler
5f23ccf24c fixed a test failure 2021-02-24 16:32:30 -05:00
jeffwadsworth
27b85bca88 - S cards: A player now moves the card/permanent to a zone. 2021-02-24 15:25:08 -06:00
Evan Kranzler
16306eb428 refactored zone changes, letters G and H
reworked Gift of the Gargantuan to allow cleaner choice
2021-02-24 15:57:57 -05:00
Evan Kranzler
756ca46718 refactored zone changes, letters E and F
simplified Enduring Renewal and Firemind's Foresight, fixed Faith's Reward and Fell Shepherd counting cards which had left and re-entered graveyards
2021-02-24 15:41:20 -05:00
Evan Kranzler
746d5eef3b refactored more zone changes, letters C and D (#7572)
Decaying Soil has been heavily reworked
2021-02-24 14:37:22 -05:00
Jeff
47dc1d8d61 - T, V, U cards: A player now moves the card/permanent to a zone. 2021-02-24 11:07:36 -06:00
Evan Kranzler
ae3ff96e11 refactored some zone change handling 2021-02-24 09:24:11 -05:00
jeffwadsworth
1ac7112b5d - W cards: A player now moves the card/permanent to a zone. 2021-02-23 19:45:47 -06:00
Evan Kranzler
f5f7638216 [KHM] updated Draugr Necromancer, added test (#7620) 2021-02-23 19:11:21 -05:00
Evan Kranzler
bac2585d83 [KHM] fixed Draugr Necromancer not allowing snow mana to be used for exiled cards 2021-02-23 13:47:23 -05:00
Evan Kranzler
5736b00f0f combined "enchanted player's upkeep" triggers into one class 2021-02-23 09:44:26 -05:00
Evan Kranzler
2ffa719278 fixed issue with Kruphix, God of Horizons and Horizon Stone causing endless replacement effect loop 2021-02-23 08:41:54 -05:00
Evan Kranzler
5e43c79f11 [KHM] fixed King Harald's Revenge requiring all creatures to block rather than just one 2021-02-22 18:09:52 -05:00
Evan Kranzler
5390963d38
Fix handling of damage to permanents (WIP) (#7592)
* initial refactor of damage events

* cleaned up some instances of classes that need to be removed

* removed old damage event classes

* removed outdated imports

* temporarily refactor Everlasting Torment (this will need to be changed more)

* updated damage handling to use new changes

* some reworking of lethal/excess damage plus a test

* updated damage marking to handle planeswalkers

* updated implementation of Phyrexian Unlife

* updated implementation of Everlasting Torment

* added some more excess damage tests

* small change to wither check
2021-02-22 17:11:24 -05:00
Oleg Agafonov
39f6b69391
Merge pull request #7584 from weirddan455/cascade
Implemented updated Cascade ruling 702.84a
2021-02-22 23:03:56 +01:00
Oleg Agafonov
91f4d78992 Changes related to Cascade ability (#7583):
* Cascade: added correct spell ability choose for forced cast of mdf and adventure cards (can contains one or both sides);
* Cascade: added tests from latest oracle changes;
* AI: improved spell ability choose for forced cast (example: cast target card without mana cost);
* GUI: improved spell ability choose for forced cast (now you can see only castable spells to choose);
* Other: fixed wrong PlayFromNotOwnHandZone in some cards, fixed NPE;
2021-02-23 02:00:38 +04:00
Evan Kranzler
bd3777997e
updated various cards to improve how they handle exiling with info (#7615) 2021-02-22 15:26:58 -05:00
Daniel Bomar
bb0a995541
Tibalt, Cosmic Impostor - fixed that emblem can't cast not owned cards (#7598)
* Fixed ability.canChooseTarget not using correct playerId

* Fixed Necrotic Plague

* Revert "Fixed Necrotic Plague"

This reverts commit 7659039670293ce1ea428dad042511d9d75f9da6.

* Set target controller on Necrotic Plague and add check in canChooseTarget

* Add test for Tibalt + Ephemerate interaction

* Tests improved

Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-02-22 23:06:43 +04:00
Oleg Agafonov
b94af941df Fixed test 2021-02-22 22:01:13 +04:00
Oleg Agafonov
4050577d6b Tests: added tests for Moritte of the Frost (related to #7546); 2021-02-22 21:55:17 +04:00
Oleg Agafonov
2accab79c5 * Spark Double - fixed duplicated counters on copying of another Spark Double (#7553); 2021-02-22 21:22:31 +04:00
Oleg Agafonov
f6c0f4c712 * Geode Golem - fixed duplicated commander tax on damage trigger (#7593); 2021-02-22 16:11:13 +04:00
Oleg Agafonov
a377999f57 * Desertion - fixed rollback error on fizzled counter spell (#7613); 2021-02-22 08:51:07 +04:00
Oleg Agafonov
4f7631f0f0 * Haldan, Avid Arcanist - fixed rollback error on usage without partner; 2021-02-22 08:03:27 +04:00
Oleg Agafonov
b6cb5cef9c Refactor: removed default comment headers 2021-02-21 08:15:16 +04:00
Oleg Agafonov
2dfde7f41a Refactor: correct predicate packages 2021-02-21 08:00:21 +04:00
Oleg Agafonov
d343511d73 * Elsha of the Infinite - fixed that it gives flash ability to cards in the hand instead library's top card (closes #7605); 2021-02-21 07:43:29 +04:00
Evan Kranzler
b968637e20 [KHM] fixed Rune of Might giving flying instead of trample through an equipment 2021-02-20 21:41:31 -05:00
Oleg Agafonov
48e9cc3e07 PlayTheTopCard improves: added correct usage check, fixed outdated rule texts, Bolas's Citadel simplified (related to #7605); 2021-02-21 05:48:09 +04:00
Daniel Bomar
238ab4fcc8
Fixed clones not triggering death ability of Old-Growth Troll (fixes #7601) 2021-02-19 15:49:25 -06:00
Evan Kranzler
a8bda04daf [GTC] updated implementation of Bane Alley Broker 2021-02-19 14:47:47 -05:00
Evan Kranzler
22ac79c325 [STX] fixed second mode on Lorehold Command 2021-02-19 09:41:36 -05:00
Evan Kranzler
09d3cee8fc [STX] Implemented Lorehold Command 2021-02-19 09:38:59 -05:00
Evan Kranzler
eec6b4986d [STX] Implemented Witherbloom Command 2021-02-19 09:21:03 -05:00
Evan Kranzler
223c576359 [STX] Implemented Quandrix Command 2021-02-19 09:08:14 -05:00
Evan Kranzler
4db47adc19 [LRW] added back previously failing test for Aquitect's Will 2021-02-19 08:29:38 -05:00
Daniel Bomar
20968c299c
Tibalt, Cosmic Impostor - Fixed misspelled card name 2021-02-18 22:27:26 -06:00
jeffwadsworth
38b2f492a2 - Fixed #7597 2021-02-18 22:22:39 -06:00
Evan Kranzler
93e556d784 fixed a test failure 2021-02-18 20:40:03 -05:00
Evan Kranzler
12cee3f798 [STX] Implemented Silverquill Command 2021-02-18 20:38:01 -05:00
Evan Kranzler
47333c20c9 [STX] Implemented Prismari Command 2021-02-18 19:45:45 -05:00
Evan Kranzler
98c6b39550 [STX] added set 2021-02-18 19:37:47 -05:00
Evan Kranzler
2d85f4cfa0 [SLD] updated reprints 2021-02-18 19:28:00 -05:00
Evan Kranzler
6cb8072352 [KHM] fixed Battle for Bretagard chapter III (fixes #7599) 2021-02-18 17:12:55 -05:00
Evan Kranzler
440adfa18b fixed The Ozolith test (it wasn't actually failing) 2021-02-18 13:29:06 -05:00
Evan Kranzler
9426da5ad3 [LRW] added test for Aquitect's Will (partially fails) (#7597) 2021-02-18 09:16:30 -05:00
Alexander Novotny
d167808dc8
[C20] Fixed Haldan, Avid Arcanist's ability applying to all spells (magefree/mage#7585) (#7589) 2021-02-16 19:03:11 -06:00
Evan Kranzler
593d25d6be [M19] fixed Satyr Enchanter trigger being optional (fixes #7587) 2021-02-15 20:49:52 -05:00
Evan Kranzler
bb696b4210 fixed implementation of cards which trigger on unblocked attackers 2021-02-15 19:04:17 -05:00
Evan Kranzler
a6255402e3 updated language for various user choices 2021-02-15 10:19:43 -05:00
Evan Kranzler
e2e7df6af2 [ZNE] added Zendikar Rising Expeditions (closes #7578) 2021-02-15 09:21:12 -05:00
Jeff
eb242443fc - Lurrus of the Dream-Den will now only allow casting of cards from the controller's graveyard during the controller's turn. 2021-02-14 21:24:49 -06:00
jeffwadsworth
da03e7c50b - Fixed #7541 2021-02-14 01:02:58 -06:00
Oleg Agafonov
7f6482221a * Bronzehide Lion - fixed rollback error on usage (fixes #7564); 2021-02-13 22:37:31 +04:00
Evan Kranzler
073ec1cdb9 changed collation to strings to allow non-int collector numbers 2021-02-13 09:03:52 -05:00
jeffwadsworth
82f40f04ae - Fixed #7561 2021-02-12 22:58:39 -06:00
Evan Kranzler
8a16eda062
Implement new way to generate boosters using box mapping info (WIP) (#7529)
* [THB] added initial common/uncommon collation mechanism

* [THB] added rare/mythic and lands to pack generation

* fixed some card names

* broke out collation into its own separate classes

* built collation into ExpansionSet

* added note about collation information

* [KHM] added collation info

* updated collation to use collector number rather than name

* added shuffle to set constructor

* added some notes on collation methods
2021-02-12 17:35:28 -05:00
Oleg Agafonov
10e557b873 * Performance: memory usage optimization for deck editor (part 2 of removed bloated usage of ManaCosts -> ManaColor objects, see #7515); 2021-02-12 22:12:18 +04:00
Evan Kranzler
c3d55ea12a [KHM] fixed Ascent of the Worthy chapter 3 and added note to chapters 1 and 2 2021-02-12 09:07:42 -05:00
Evan Kranzler
9485cce9e3 [SLU] added new drops 2021-02-12 08:57:12 -05:00
Evan Kranzler
9a37a351ee [SLD] added new drops 2021-02-12 08:54:44 -05:00
Evan Kranzler
6b25dac969 [KHM] fixed Surtland Flinger not sacrificing the chosen creature (fixes #7554) 2021-02-12 08:48:03 -05:00
jeffwadsworth
78bae348e8 - Fixed #7544, #7536, #6798 2021-02-11 09:36:45 -06:00
Evan Kranzler
4d20cb19cf [CMR] fixed Gor Muldrak, Amphinologist not working correctly when a player controls no creatures (fixes #7545) 2021-02-10 16:07:07 -05:00
Evan Kranzler
d96d40b953 [CMR] fixed Colfenor, the Last Yew not being able to target correctly 2021-02-09 20:39:50 -05:00
Evan Kranzler
4f9bbd4a73 [KHM] fixed Axgard Armory not revealing on search 2021-02-09 20:35:44 -05:00
jeffwadsworth
0ac85d93db - Fixed #7535 2021-02-09 15:40:33 -06:00
jeffwadsworth
7f30e83d70 - Fixed #7534 2021-02-09 14:30:51 -06:00
Evan Kranzler
f80de1d868 [MIR] fixed Sealed Fate card type 2021-02-09 12:54:23 -05:00