18ths
e68a20c5fb
fixed and refactored balance effect ( #6595 )
...
* fixed and refactored balance effect
* inversed logic in balance effect - now players choose cards to keep instead to sacrifice/discard
2020-06-12 01:19:45 +04:00
Evan Kranzler
36b31d097e
reinstated new mill wording
2020-06-10 22:38:59 -04:00
LevelX2
94c8b7a558
* Some comment formatting.
2020-06-10 22:37:47 +02:00
LevelX2
1e36b39434
- Reworked SourceOnBattlefieldControlUnchangedCondition checking now the LOST_CONTROL event which solves the problem with the old code to not be able to detect all controller changes of layered changeController effects when applied later.
...
- Simplified and fixed some problems of the handling of the "Until end of your next turn" duration.
- Fixed that some continous effects changed controller but shouldn't dependant from their duration type. Controller chnage will now done duration type dependant.
(that change fixes #6581 in a more general way undoing the effect specific changes of 2e8ece1dbd
).
2020-06-10 22:28:23 +02:00
LevelX2
25802dc105
* Updated some failing tests with old text after fix of 5a17b9665e
.
2020-06-10 22:08:51 +02:00
LevelX2
5c65ee31d9
* Mirari - Fixed that the triggering spell was not copied ( fixes #6338 ).
2020-06-10 10:17:55 +02:00
Oleg Agafonov
a75d08283f
* Split cards - added spliced effects support for fused spells, no more double splice pays ( #6493 , #6549 );
2020-06-10 09:58:21 +04:00
Oleg Agafonov
b38ac2f575
* Split cards - added cost modification effects support for fused spells ( #227 , #2242 , #6603 , #6549 );
2020-06-10 08:28:18 +04:00
LevelX2
eb846c0499
* Added ID name instead of only the name to the replacement effect selector list. Otherwise you can't identify the related source if you have multiple sources with the same name (related #6298 ).
2020-06-09 16:37:42 +02:00
LevelX2
9483bf2ba3
* Added test for #6344 . Problem not reproducable ( closes #6344 ).
2020-06-09 12:48:28 +02:00
johnmeat
3119e7e78c
Fixed Unlicensed Disintegration damage part ( #6614 )
...
* Damage to creature's controller abilities -- fixed that damage part can be skipped if that creature died/destroyed (example: Unlicensed Disintegration, see #6614 )
Co-authored-by: johnm <johnm@WINDOWS-QR5QIIL.lan>
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2020-06-09 05:51:58 +04:00
LevelX2
0bdbd36d2d
* Added test from #6349 .
2020-06-08 17:16:12 +02:00
Evan Kranzler
64625654f4
fixed another test failure
2020-06-07 19:37:41 -04:00
Evan Kranzler
3b125def9c
one more test fix
2020-06-07 15:17:28 -04:00
Evan Kranzler
a6a9160139
fixed a fix
2020-06-07 15:08:22 -04:00
Evan Kranzler
47ccb6d07b
fixed some test failures
2020-06-07 14:57:56 -04:00
Oleg Agafonov
ecac9295ec
Additional card fixed for named abilities support, also added face down spells support (see #6569 );
2020-06-05 01:13:17 +04:00
Oleg Agafonov
4b77cb0fa8
* Name card abilities - fixed that it can't find split cards or fused spells with entered name (part of #6603 , #6549 );
2020-06-05 00:06:57 +04:00
Oleg Agafonov
e95ae2675b
Fixed different ZCC in split card's parts (flashback fix, see 95075cf33e
);
...
Improve moveToZone code and fixed some cards with wrong commands queue (e.g. directly removes card from zone and then calls moveToZone again);
2020-06-04 23:47:50 +04:00
LevelX2
7594c4144c
* Ignoring failing test again.
2020-06-04 12:25:16 +02:00
LevelX2
d4dbf33d19
* Some minor code changes.
2020-06-04 10:57:36 +02:00
Oleg Agafonov
95075cf33e
Additional fix flashback and split cards (see cce467a5ec
)
2020-06-04 11:34:59 +04:00
Oleg Agafonov
cce467a5ec
Additional fix and simplified for playable abilities (see comments b94344341b
)
2020-06-04 03:21:18 +04:00
LevelX2
bd40d90286
Merge pull request #6590 from 18ths/world_rule_range_of_influence
...
fixed world rule with range of influence
2020-06-03 22:39:56 +02:00
LevelX2
75d0926f4b
* Some minor changes.
2020-06-03 18:06:03 +02:00
LevelX2
238152d6c4
Merge origin/master
2020-06-03 15:08:42 +02:00
LevelX2
07386cce8d
* Shifting Shadows - Fixed not proper handling of gained triggered abilities during step resolution of Shifting Shadows effect ( fixes #6571 ).
2020-06-03 15:07:52 +02:00
Oleg Agafonov
b94344341b
Improved playable abilities and split cards:
...
* Now human player uses same code for playable abilities search as test framework (old version used different code, so it could not work in one of the modes);
* Split cards - improves playable highlights;
* Split cards - fixed that it doesn't work with dynamic added abilities like flashback (#6327 , #6470 , #6549 );
2020-06-03 12:44:58 +04:00
Oleg Agafonov
121dc3501e
* Split cards - fixed not working combo with suspend/delay abilities ( #946 , #6549 );
2020-06-01 09:41:48 +04:00
Oleg Agafonov
e7684e4bba
Test framework improves:
...
* added command to check graveyard count command;
* added wrong cast/activate command auto-checks in strict mode;
2020-06-01 09:37:17 +04:00
18ths
d5c46816be
fixed world rule with range of influence
2020-05-30 21:52:22 +02:00
LevelX2
3333cf3287
* Added test for #6581 .
2020-05-29 16:59:56 +02:00
LevelX2
32ce1d85e9
* Fix of some problems of zone change related triggered abilities that had not been correctly implemented ( fixes #6586 ).
2020-05-29 14:41:24 +02:00
Oleg Agafonov
d63a3e88ce
Ability refactor: fixed broken effects timestamp in some use cases
2020-05-28 23:07:36 +04:00
Oleg Agafonov
f3f1c29926
Ability refactor: face down;
2020-05-28 23:02:20 +04:00
Oleg Agafonov
eea808d2d6
Ability refactor: source improves, deprecated code removed;
2020-05-28 22:38:31 +04:00
Oleg Agafonov
8af43dc13a
Ability refactor: new code to search abilities in cards and permanents;
2020-05-28 22:34:27 +04:00
LevelX2
e1c96efa1e
* Fixed a problem with selecting cards from other players hand, failing because canTarget check with wrong player id. Changed/simplified canTarget method of TargetCardInHand to solve that problem. ( #6532 Gruesome Discovery and Distended Mindbender and probably other changed made with 75577cdbe9
).
2020-05-27 13:59:16 +02:00
LevelX2
3aefbfb360
* Fixed problems with win / lose restrictions in relation to empty draw condition ( fixes #1681 #6553 ).
2020-05-26 16:38:01 +02:00
LevelX2
d2b8928e60
* Fixed a bug that the win method for a player did not handle the range correctly and did erroneously end the game while still multiple players alive (related to #6553 ).
2020-05-25 18:09:28 +02:00
Oleg Agafonov
abda99e203
Fixed that fused cards allows to cast from graveyard (see prev commit 63dbf5f40b
);
2020-05-24 09:21:49 +04:00
Oleg Agafonov
63dbf5f40b
* Split cards improves:
...
* Fixed that fused spells can't be played from non hand zone;
* Fixed double choose spell dialog (#5506 , #6549 );
2020-05-19 01:30:46 +04:00
Oleg Agafonov
0c2e08f54e
* UI: choose spell to cast dialog - added card name for spell abilities (split, adventure, additional spell, etc, see #6549 );
2020-05-18 06:46:39 +04:00
emerald000
a904b7c890
Fix StubPlayer handling of London mulligans and fix related tests.
2020-05-05 23:15:45 -04:00
Evan Kranzler
75577cdbe9
Added new method for discarding cards to handle batch triggers (ready for review) ( #6489 )
...
* added new discard method
* started refactoring to use new discard method
* refactored A through I
* fixed some issues
* separated balance effect into its own class
* refactored J through R
* refactored S through Z
* applied requested changes
2020-05-03 14:35:26 -04:00
SpeedProg
724287360c
Multiplayer test and fix for Angel of Serenity leaves battlefied trigger when controlled by other then owner and owner leaves game
2020-05-03 11:20:48 +02:00
Evan Kranzler
4e8d423bca
added more Ashling the Pilgrim tests
2020-04-28 19:09:05 -04:00
Evan Kranzler
4d1f37d0fe
reworked implementation of Ashling the Pilgrim and similar cards, added a test
2020-04-27 18:33:57 -04:00
Evan Kranzler
7f32ea0be2
Updated implementation of Hexproof abilities ( #6451 )
...
* updated implementation of hexproof abilities
* added hexproof from color test
* updated generic in AbilityPredicate
2020-04-23 20:01:13 -04:00
Evan Kranzler
214765ddd8
added a test for The Ozolith
2020-04-21 18:58:58 -04:00