Mike Simons
8d08f005af
Fix various hints and warnings on many set & block classes (via IntelliJ IDEA linting):
...
- replacing hard coded strings of set codes with reference to 'mage.sets.<set>.getInstance().getCode()' allows for set class names to no longer show as unreferenced & adds for more consistence between other block units
- various protected variables were able to be changed to private to clean up additional warnings
- some JavaDoc comments were generating warnings due to missing documentation
- removed some unused imports and unused variables
- there were multiple conditional logic checks for 'rarity != Rarity.LAND' within an if block where the outer condition was 'if rarity == Rarity.COMMON' rendering the inner condition always true and thus redundant
- a few ExpansionSet.buildDate parameters wer using octal values (eg. '03' instead of '3') which triggered some warnings
- added a booster generation test for WarOfTheSparks to make sure every booster contains a planeswalker
- added a booster generation test for ModernHorizons to make sure every booster contains a snow land
- booster generation test for Battlbond set referenced the Coldsnap set class instead of Battlebond
2019-07-18 23:28:48 -04:00
Mike Simons
bbd1390397
Update CoreSet2020 to include planeswalker deck reprinted cards missing from set
2019-07-15 01:00:26 -04:00
Ingmar Goudt
eb0cfc94f8
change some size() comparisons, to isEmpty()
2019-07-14 20:53:23 +02:00
Ingmar Goudt
5ba206111a
add missing Override annotations
2019-07-14 20:28:48 +02:00
Ingmar Goudt
3fa2deaa64
Merge branch 'master' of https://github.com/magefree/mage
2019-07-14 10:16:35 +02:00
Ingmar Goudt
4391038b6d
fix closing <i> tag
2019-07-14 10:16:30 +02:00
Ingmar Goudt
bcb9011476
fix boolean evaluation for ThunderkinAwakener
2019-07-14 10:16:19 +02:00
Oleg Agafonov
528ba66e16
Commander abilities - fixed rules text for alternative spells;
2019-07-14 01:21:55 +04:00
Oleg Agafonov
9db80a0cf3
* Commander abilities - added support of cards with alternative spells like overload;
2019-07-14 01:06:07 +04:00
Oleg Agafonov
cb2730e0d5
Strict version required (empty hand bug in old versions)
2019-07-13 19:56:56 +04:00
Oleg Agafonov
683f0fd3fe
Prepare hotfix
2019-07-13 18:47:57 +04:00
Oleg Agafonov
d6d67b78db
* Added London mulligan as default mulligan type for all games (except Canadian Highlander);
2019-07-13 18:46:41 +04:00
Oleg Agafonov
16c37d0806
* Thousand-Year Storm - added logs and card hint info about storm count value;
2019-07-13 17:59:35 +04:00
Oleg Agafonov
abbbb5dafd
* London mulligan - fixed wrong cards number in logs;
2019-07-13 12:48:26 +04:00
Oleg Agafonov
0f2eb4dd58
* Oathbreaker 1 vs 1 - fixed that starting player draws a card like multiplayer games;
2019-07-13 12:29:24 +04:00
Oleg Agafonov
6316f40914
* Knowledge Pool - fixed that it allows to cast just exiled card instead another ( #4947 );
2019-07-13 11:35:57 +04:00
Oleg Agafonov
8c40a1d1a7
* Commander abilities - fixed that it increases commander tax after cast/play from non-command zone (as example: after Remand effect);
2019-07-13 10:47:02 +04:00
Oleg Agafonov
2197d8ee4a
* Praetor's Grasp - fixed that it freeze the game after cast;
2019-07-12 21:49:00 +04:00
Oleg Agafonov
9a08ccda95
Extra tests for AI;
2019-07-12 19:57:23 +04:00
Oleg Agafonov
5cf95d3ed1
Test framework: fixed that add counters command adds wrong amount of counters;
2019-07-12 19:41:06 +04:00
Oleg Agafonov
02b1e86f20
Extra tests for AI;
2019-07-12 19:09:26 +04:00
Oleg Agafonov
e02d8a079b
AI: added support to attack/kill any opponent in multiplayer, not only first one;
2019-07-12 18:51:42 +04:00
Oleg Agafonov
ae7623e118
AI: fixed that AI never use alpha strike to kill opponent (doesn't use "all in" attack, #4486 );
2019-07-12 18:36:32 +04:00
Oleg Agafonov
be281ff402
Test framework: added AI support for attack/block phases, added attack/block skip commands;
2019-07-12 13:54:24 +04:00
Oleg Agafonov
7871b95d81
* UI: fixed not working skip stack button;
2019-07-11 21:48:12 +04:00
Ingmar Goudt
91a01a78bc
remove local variable
2019-07-11 15:59:51 +02:00
Ingmar Goudt
61ece61c15
remove assignation as parameter
2019-07-11 15:54:33 +02:00
Ingmar Goudt
3163bfa310
move default case down
2019-07-11 15:45:22 +02:00
Ingmar Goudt
b704618f32
small complexity rewrite
2019-07-11 15:44:46 +02:00
Oleg Agafonov
d9ace1b66f
* Chandra, Acolyte of Flame - fixed that -2 ability cost as -3 ( #5891 );
2019-07-10 03:36:01 +04:00
Ingmar Goudt
464e9c67c4
remove nullcheck as this happens in the method itself
2019-07-09 22:30:40 +02:00
Ingmar Goudt
34444f5616
fix text of Enslaved Horror
2019-07-09 22:01:58 +02:00
Ingmar Goudt
4d6f047af8
Chandra Acolyte 0 ability for planeswalkers only
2019-07-09 22:00:32 +02:00
Ingmar Goudt
178da75e4d
Sonar fixes
2019-07-09 21:57:55 +02:00
Evan Kranzler
1621704b12
updated Modular text
2019-07-08 16:51:03 -04:00
Evan Kranzler
2c49a72fa7
updated Dichotomancy text
2019-07-08 16:50:00 -04:00
Evan Kranzler
4bb01faa15
updated Brutal Expulsion text
2019-07-08 16:48:54 -04:00
Evan Kranzler
0795dfee54
updated Cryptoplasm text
2019-07-08 16:47:50 -04:00
Evan Kranzler
62d2426267
updated Treasure token text
2019-07-08 16:46:11 -04:00
Evan Kranzler
745b75d603
fixed Sarkhan the Masterless's second ability removing supertypes
2019-07-08 16:40:36 -04:00
Evan Kranzler
b5e65ba34a
updated Commander ban list
2019-07-08 16:35:07 -04:00
Evan Kranzler
50fe6db4f9
updated Modern ban list
2019-07-08 16:33:38 -04:00
Oleg Agafonov
769756a548
Prepare hotfix
2019-07-08 08:41:42 +04:00
Oleg Agafonov
aa1ebd7303
Merge pull request #5888 from jgray1206/boneclad_necromancer_fix
...
added boneclad necromancer unit tests + fix for issue #5875
2019-07-08 06:39:58 +02:00
Oleg Agafonov
79d40754ed
* Library of Leng - fixed that it triggers on discarded cards from cost part instead only effect part ( #3047 );
2019-07-08 08:31:55 +04:00
Oleg Agafonov
d6c99437f3
* Marauding Raptor - fixed that it deals damage to yourself;
2019-07-08 07:51:08 +04:00
Oleg Agafonov
2d387801a2
* Ajani's Chosen - fixed error in combo with Estrid, the Masked's token ( #5285 );
2019-07-08 07:38:09 +04:00
John Gray
1d0da973ac
added boneclad necromancer unit tests + fix for issue #5875
2019-07-07 22:48:51 -04:00
Oleg Agafonov
0d6be669de
Merge pull request #5881 from jgray1206/vizier_fix
...
add vizier of the menagerie unit tests + fix for issue #5816
2019-07-07 03:34:24 +02:00
Oleg Agafonov
aad5099a45
Merge pull request #5884 from jgray1206/chandras_embercat_fix
...
fixed chandras embercat issue #5880 + added unit tests for it
2019-07-07 03:31:38 +02:00