Mike Simons
8d08f005af
Fix various hints and warnings on many set & block classes (via IntelliJ IDEA linting):
...
- replacing hard coded strings of set codes with reference to 'mage.sets.<set>.getInstance().getCode()' allows for set class names to no longer show as unreferenced & adds for more consistence between other block units
- various protected variables were able to be changed to private to clean up additional warnings
- some JavaDoc comments were generating warnings due to missing documentation
- removed some unused imports and unused variables
- there were multiple conditional logic checks for 'rarity != Rarity.LAND' within an if block where the outer condition was 'if rarity == Rarity.COMMON' rendering the inner condition always true and thus redundant
- a few ExpansionSet.buildDate parameters wer using octal values (eg. '03' instead of '3') which triggered some warnings
- added a booster generation test for WarOfTheSparks to make sure every booster contains a planeswalker
- added a booster generation test for ModernHorizons to make sure every booster contains a snow land
- booster generation test for Battlbond set referenced the Coldsnap set class instead of Battlebond
2019-07-18 23:28:48 -04:00
Mike Simons
bbd1390397
Update CoreSet2020 to include planeswalker deck reprinted cards missing from set
2019-07-15 01:00:26 -04:00
Ingmar Goudt
eb0cfc94f8
change some size() comparisons, to isEmpty()
2019-07-14 20:53:23 +02:00
Ingmar Goudt
3fa2deaa64
Merge branch 'master' of https://github.com/magefree/mage
2019-07-14 10:16:35 +02:00
Ingmar Goudt
4391038b6d
fix closing <i> tag
2019-07-14 10:16:30 +02:00
Ingmar Goudt
bcb9011476
fix boolean evaluation for ThunderkinAwakener
2019-07-14 10:16:19 +02:00
Oleg Agafonov
16c37d0806
* Thousand-Year Storm - added logs and card hint info about storm count value;
2019-07-13 17:59:35 +04:00
Oleg Agafonov
6316f40914
* Knowledge Pool - fixed that it allows to cast just exiled card instead another ( #4947 );
2019-07-13 11:35:57 +04:00
Oleg Agafonov
2197d8ee4a
* Praetor's Grasp - fixed that it freeze the game after cast;
2019-07-12 21:49:00 +04:00
Ingmar Goudt
91a01a78bc
remove local variable
2019-07-11 15:59:51 +02:00
Oleg Agafonov
d9ace1b66f
* Chandra, Acolyte of Flame - fixed that -2 ability cost as -3 ( #5891 );
2019-07-10 03:36:01 +04:00
Ingmar Goudt
464e9c67c4
remove nullcheck as this happens in the method itself
2019-07-09 22:30:40 +02:00
Ingmar Goudt
34444f5616
fix text of Enslaved Horror
2019-07-09 22:01:58 +02:00
Ingmar Goudt
4d6f047af8
Chandra Acolyte 0 ability for planeswalkers only
2019-07-09 22:00:32 +02:00
Ingmar Goudt
178da75e4d
Sonar fixes
2019-07-09 21:57:55 +02:00
Evan Kranzler
2c49a72fa7
updated Dichotomancy text
2019-07-08 16:50:00 -04:00
Evan Kranzler
4bb01faa15
updated Brutal Expulsion text
2019-07-08 16:48:54 -04:00
Evan Kranzler
0795dfee54
updated Cryptoplasm text
2019-07-08 16:47:50 -04:00
Evan Kranzler
745b75d603
fixed Sarkhan the Masterless's second ability removing supertypes
2019-07-08 16:40:36 -04:00
Oleg Agafonov
aa1ebd7303
Merge pull request #5888 from jgray1206/boneclad_necromancer_fix
...
added boneclad necromancer unit tests + fix for issue #5875
2019-07-08 06:39:58 +02:00
Oleg Agafonov
79d40754ed
* Library of Leng - fixed that it triggers on discarded cards from cost part instead only effect part ( #3047 );
2019-07-08 08:31:55 +04:00
Oleg Agafonov
d6c99437f3
* Marauding Raptor - fixed that it deals damage to yourself;
2019-07-08 07:51:08 +04:00
Oleg Agafonov
2d387801a2
* Ajani's Chosen - fixed error in combo with Estrid, the Masked's token ( #5285 );
2019-07-08 07:38:09 +04:00
John Gray
1d0da973ac
added boneclad necromancer unit tests + fix for issue #5875
2019-07-07 22:48:51 -04:00
John Gray
f564c522a3
added chandras embercat unit tests + fix for issue #5880
2019-07-06 11:30:26 -04:00
Oleg Agafonov
bce01ce053
Sonar's fixes
2019-07-06 13:09:27 +04:00
Oleg Agafonov
f572ace420
* Veil of Summer - fixed that it doesn't count blue spells;
2019-07-06 12:38:54 +04:00
Oleg Agafonov
f166724562
Fixed type cast
2019-07-06 12:36:28 +04:00
Oleg Agafonov
bef45a829c
* Xenagos, the Reveler - added mana amount dialog instead R/G choose one by one;
2019-07-06 12:10:17 +04:00
Oleg Agafonov
0ebf1d146e
* Masterful Replication - fixed that it doesn't create copies of artifacts;
2019-07-06 11:39:40 +04:00
Oleg Agafonov
2611f9acca
* Soulherder - fixed that it can target yourself instead another;
2019-07-06 11:34:10 +04:00
Oleg Agafonov
251bd41fe9
* Flood of Tears - fixed not working ability ( #5877 );
2019-07-05 15:48:41 +04:00
Oleg Agafonov
e195bddf09
* Grenzo, Havoc Raiser - added triggered player info in logs and choose mode dialog ( #4116 , #5282 );
2019-07-05 15:37:17 +04:00
Oleg Agafonov
39edc3feef
Fixed texts
2019-07-05 15:03:24 +04:00
Oleg Agafonov
39757033c5
* Besmirch - fixed missing goad effect;
2019-07-05 14:16:57 +04:00
Oleg Agafonov
b0e2536243
* Leyline of Combustion - fixed that it triggers on controller targets;
2019-07-05 13:31:05 +04:00
Oleg Agafonov
d80295058c
* Lure of Prey - fixed that it restrict to cast any spells in game instead yourself;
2019-07-04 22:12:45 +04:00
Oleg Agafonov
830f71cd32
* Finale of Promise - added dialog to select cards order to cast;
2019-07-04 18:21:58 +04:00
Oleg Agafonov
e6680d062a
* Images: fixed wrong forest/island images in GK2 set;
2019-07-02 13:50:29 +04:00
Evan Kranzler
4b0458866b
fixed Chandra's Embercat mana not casting Chandra planeswalkers
2019-07-01 19:53:29 -04:00
Oleg Agafonov
7f9e2595f7
* Chandra, Acolyte of Flame - fixed that elemental tokens don't sacrificed ( #5872 );
2019-07-01 12:06:31 +04:00
Oleg Agafonov
64cd15bdcf
Fix typo
2019-07-01 12:00:39 +04:00
Oleg Agafonov
699329f522
* Woodland Champion - fixed that it doesn't trigger on tokens put ( #5871 );
2019-07-01 12:00:10 +04:00
Oleg Agafonov
df4fd1373e
* Brought Back - fixed that it return permanents untapped instead tapped;
2019-07-01 09:22:45 +04:00
Oleg Agafonov
ec93f50bab
[M20] fixed wrong texts
2019-06-30 22:46:37 +04:00
Oleg Agafonov
1dab4b23e3
[M20] fixed Vivien Natures Avenger with wrong targets amount and loyalty cost;
2019-06-30 22:33:48 +04:00
Oleg Agafonov
720c9849cb
[M20] fixed wrong texts
2019-06-30 22:32:50 +04:00
Oleg Agafonov
628b668ad3
[M20] fixed wrong texts
2019-06-30 22:13:31 +04:00
Oleg Agafonov
a6a67ec255
[M20] fixed Noxious Grasp with missing gain life ability
2019-06-30 22:12:50 +04:00
Oleg Agafonov
37f053f78d
[M20] fixed wrong texts
2019-06-30 21:54:21 +04:00
