Evan Kranzler
405a3b405e
[40K] Implemented Tervigon
2022-09-15 08:12:22 -04:00
Evan Kranzler
a31644789c
[DMU] various text fixes
2022-09-14 18:29:34 -04:00
Evan Kranzler
d165072ac9
[DMU] Implement Defiler cycle (Ready for review) ( #9460 )
...
* [DMU] Implemented Defiler of Faith
* [DMU] Implemented Defiler of Dreams
* [DMU] Implemented Defiler of Flesh
* [DMU] Implemented Defiler of Instinct
* [DMU] Implemented Defiler of Vigor
* create PermanentPredicate
* initial attempt at Defiler ability
* some nonfunctional recommended changes
* a few more requested changes
* change arguments to ObjectColor from String
* fix a dumb mistake
* add test
* a few requested changes
2022-09-14 15:16:56 -04:00
Alex W. Jackson
efa7b485b0
Remove unneeded parameter from StackObjectCopyApplier.getNextNewTargetType (all users were using an Iterator or a fixed return value)
2022-09-14 03:23:21 -04:00
Alex W. Jackson
c401b35b63
Fix #9524
2022-09-14 03:08:23 -04:00
Alex W. Jackson
c3ce7898de
[DMU] Implement Silver Scrutiny and fix #7326 ( #9508 )
2022-09-13 20:15:04 -04:00
Evan Kranzler
0d4cf5a20a
[40K] Implemented The Swarmlord
2022-09-13 18:55:19 -04:00
Evan Kranzler
9b70a0ee6f
[40K] Implemented Old One Eye
2022-09-13 08:44:43 -04:00
Evan Kranzler
668410dd21
[40K] Implemented Broodlord
2022-09-13 08:30:33 -04:00
Evan Kranzler
d313bc7ad6
[40K] Implemented Imotekh, the Stormlord
2022-09-13 06:55:12 -04:00
Evan Kranzler
515828eede
[40K] Implemented Deathleaper, Terror Weapon
2022-09-13 06:40:15 -04:00
Evan Kranzler
5e26b7eacd
[40K] Implemented Inquisitor Greyfax
2022-09-13 06:34:05 -04:00
PurpleCrowbar
51fb4df5a0
[DMC] Implement Rasputin, the Oneiromancer ( #9515 )
2022-09-12 18:34:03 -04:00
Alex W. Jackson
c84d9d2168
Don't erase a permanent's attacking/blocking info when it leaves the battlefield. Kithkin Mourncaller and Kardur Doomscourge no longer need their own special TriggeredAbility class
2022-09-12 10:43:21 -04:00
Alex W. Jackson
7c2f76b46b
Remove custom multitarget handling from ReturnToHandTargetEffect (use EachTargetPointer instead)
2022-09-12 08:54:45 -04:00
Alex W. Jackson
dc33531792
Fix #4368
2022-09-12 06:56:07 -04:00
PurpleCrowbar
46cc674a8e
[DMC] Implement Sivitri, Dragon Master ( #9506 )
...
* [DMC] Implement Sivitri, Dragon Master
* Generalised CantAttackYouUnlessPayAllEffect
2022-09-11 23:18:25 -04:00
Daniel Bomar
90496c56f4
[DMU] Implemented Tyrannical Pitlord ( #9498 )
2022-09-10 19:54:46 -04:00
PurpleCrowbar
6c60b342a0
[DMC] Implement Jedit Ojanen, Mercenary ( #9497 )
2022-09-10 15:59:48 -04:00
Alex W. Jackson
c0aeb44e5b
[TOR] Implemented Carrion Rats and Carrion Wurm
2022-09-10 03:27:41 -04:00
Alex W. Jackson
a2bcf7074e
Fix #9331 , #8086
2022-09-09 22:42:03 -04:00
Alex W. Jackson
5bfbeff87d
Fix Render Silent and remove some unnecessary custom effects I noticed via the previous commit
2022-09-09 15:41:37 -04:00
Alex Vasile
092f3c3fe1
Simplified effects by removing unnecessary getText instances. ( #9374 )
2022-09-09 12:02:22 -04:00
Alex W. Jackson
076c55f1ea
Fix several card abilities incorrectly implemented as intervening-if abilities when they weren't
2022-09-09 04:47:07 -04:00
PurpleCrowbar
173b3dbb4f
[DMC] Implement Greensleeves, Maro-Sorcerer ( #9487 )
2022-09-08 23:26:43 -04:00
Alex W. Jackson
d5e56f523d
Add new EventType CREATURE_BLOCKS, which fires once per blocker (rather than once per blocker per attacker). Updated some abilities and cards to use it (still incomplete). Fixes #4285
2022-09-08 21:41:15 -04:00
Oleg Agafonov
da6fd76c6a
Fixed typo
2022-09-09 01:00:48 +04:00
Daniel Bomar
48df6902e1
[40K] Fixed Abaddon the Despoiler and enabled test ( fixes #9490 )
2022-09-08 11:35:42 -05:00
Alex W. Jackson
2f93647196
Fix IllegalArgumentException on Volcano Hellion echo trigger
2022-09-07 23:15:18 -04:00
Alex W. Jackson
a6c5209a2a
Combat.getAttackers and Combat.getBlockers now return a Set instead of a List, so that two-headed blockers aren't included twice
2022-09-07 22:36:05 -04:00
Jeff Wadsworth
4aee1b714c
- Fixed #9481
2022-09-07 13:13:09 -05:00
Alex W. Jackson
e310ede837
Replace many custom effects with ExileUntilSourceLeavesEffect
2022-09-06 06:50:01 -04:00
Daniel Bomar
a5621cf247
[DMU] Implemented Anointed Peacekeeper ( #9478 )
2022-09-05 21:49:10 -04:00
Evan Kranzler
c745bce734
[DMU] Implemented Shanna, Purifying Blade
2022-09-05 20:24:46 -04:00
Alex W. Jackson
b5b4b38cc6
Fix ShuffleIntoLibraryTargetEffect to support multiple target cards with possibly different owners
2022-09-05 19:44:09 -04:00
Evan Kranzler
30aafb7672
[DMU] Implemented The Phasing of Zhalfir
2022-09-05 16:56:53 -04:00
Evan Kranzler
b9bbb4d1b3
[DMU] Implemented Karn, Living Legacy
2022-09-05 16:56:52 -04:00
Evan Kranzler
02968c9cc1
[DMU] Implemented Sphinx of Clear Skies ( #9474 )
...
* create common class for effects similar to Fact or Fiction
* [DMU] Implemented Sphinx of Clear Skies
* change text generation to staticText
2022-09-05 16:14:16 -04:00
Alex Vasile
138fa46824
Fixed text generation for LoseLifeOpponentsEffect
2022-09-05 14:26:36 -04:00
Alex Vasile
c16ead128b
[NCC] Address comments for Lethal Scheme
2022-09-04 13:26:26 -04:00
Alex W. Jackson
e3b8a813e5
Remove custom multitarget handling from DestroyTargetEffect (use EachTargetPointer instead)
2022-09-04 07:04:46 -04:00
Alex W. Jackson
addfd5166e
Add new methods to Target and TargetPointer to help generate card rules text. Currently only used by ExileUntilSourceLeavesEffect
2022-09-04 05:15:12 -04:00
Alex W. Jackson
c6e1ce6697
Remove custom multitarget handling from ExileTargetEffect (use EachTargetPointer instead)
2022-09-03 22:59:19 -04:00
Alex W. Jackson
fbccdd3088
Add missing files from last commit
2022-09-03 06:04:31 -04:00
Alex W. Jackson
ce610be087
[ONS] Implement Crown of Ascension, Crown of Suspicion and Crown of Vigor
2022-09-03 05:46:59 -04:00
Alex Vasile
07a142c9e8
Refactor: Add proper support for modifying and querying base P/T ( #9409 )
2022-09-01 19:57:30 -04:00
Evan Kranzler
af0fa56c10
[DMC] Implemented Baru Wurmspeaker
2022-08-30 21:31:20 -04:00
Evan Kranzler
b14d7d24bb
[DMU] Implemented Yotia Declares War
2022-08-30 20:50:26 -04:00
Evan Kranzler
d83cea8000
[DMU] Compleated Weatherlight
2022-08-30 20:36:10 -04:00
Alex W. Jackson
c26c2f3785
[DMC] Implemented General Marhault Elsdragon
2022-08-30 12:21:27 -04:00
Alex W. Jackson
e0ade383f2
Fix #9441
2022-08-30 11:40:30 -04:00
Evan Kranzler
06d7b508dc
[DMU] Implemented Academy Loremaster
2022-08-29 20:09:16 -04:00
Evan Kranzler
2e94364b2a
[DMU] Implemented Urborg Lhurgoyf
2022-08-29 20:02:30 -04:00
Evan Kranzler
a7b7f1bbe3
[DMU] Implemented Twinferno ( #9437 )
...
* create common class for copying the next spell cast
* [DMU] Implemented Twinferno
* add filter to CopyNextSpellDelayedTriggeredAbility
2022-08-29 18:51:22 -04:00
Evan Kranzler
697586a552
[DMU] Implement Enlist ability ( #9431 )
...
* implement enlist ability
* remove skips for enlist
* [DMU] Implemented Guardian of New Benalia
* add test for enlist
2022-08-29 18:51:13 -04:00
Evan Kranzler
3929cb25a8
[DMU] Implemented Radha's Firebrand
2022-08-28 10:24:31 -04:00
Evan Kranzler
90bd0dbf63
Implement Read Ahead mechanic ( #9407 )
...
* implement Read Ahead mechanic
* [DMU] Implemented The World Spell
* [DMU] Implemented The Elder Dragon War
* added read ahead test
* fix verify failure
* small change to test
* fix read ahead text
2022-08-27 14:53:39 -04:00
PurpleCrowbar
d04ea3a88b
[CC2] Added set
2022-08-26 03:58:39 +01:00
Daniel Bomar
7ba500ebe5
[DMU] Implemented Stronghold Arena
2022-08-23 14:56:50 -05:00
Daniel Bomar
3ce05b06c7
[DMU] Implemented Lagomos, Hand of Hatred
2022-08-23 12:01:08 -05:00
Daniel Bomar
356091c750
Merge pull request #9402 from weirddan455/raven-man
...
[DMU] Implemented The Raven Man
2022-08-23 10:09:36 -05:00
Alex Vasile
0a96201b6a
Simplified Mirri and Crawlspace by making their identical effects a common effect that is shared between them
2022-08-22 21:39:28 -04:00
Daniel Bomar
7f439e23ab
[DMU] Implemented Tori D'Avenant, Fury Rider
2022-08-22 18:24:07 -05:00
Evan Kranzler
17e673ddcf
fix verify error, remove skip
2022-08-22 19:00:27 -04:00
Evan Kranzler
6b09fc68ef
[DMU] Implemented Molten Monstrosity
2022-08-22 15:31:01 -04:00
Daniel Bomar
0d705fdea6
[DMU] Implemented The Raven Man
2022-08-22 11:42:18 -05:00
Alex W. Jackson
54896b3564
Fix #9357 ( #9359 )
2022-08-22 12:38:08 -04:00
Daniel Bomar
aea8c82728
[DMU] Implemented Phoenix Chick ( #9397 )
...
* [DMU] Implemented Phoenix Chick
* ReturnSourceFromGraveyardToBattlefieldWithCounterEffect - Fix constructor
* Revert back to using setText() to set staticText
* Make setText() return a String
2022-08-22 10:36:48 -05:00
Evan Kranzler
867c2569c8
[DMU] Implement Yavimaya Steelcrusher (dummy enlist ability)
2022-08-22 10:24:37 -04:00
PurpleCrowbar
eb62b921f0
Fixed Icingdeath, Frost Tongue not triggering on attack. Closes #9380
2022-08-22 02:32:49 +01:00
Daniel Bomar
39a6ce42e5
[DMU] Implemented Jhoira, Ageless Innovator
2022-08-21 15:27:35 -05:00
Daniel Bomar
e341023d23
[DMU] Compleated Ajani, Sleeper Agent
2022-08-21 13:41:48 -05:00
Daniel Bomar
c140b073ad
Merge pull request #9386 from weirddan455/braids
...
[DMU] Implemented Braids, Arisen Nightmare
2022-08-20 17:04:55 -05:00
Daniel Bomar
0f9a293762
Add/Refactor cards to use SharesCardTypePredicate
2022-08-20 12:37:50 -05:00
Alex Vasile
3c0951c350
Enabled assertAllCommandsUsed by default and fixed remaining tests
2022-08-20 07:36:32 -04:00
Evan Kranzler
a43eb00c1c
[DMU] Implemented Archangel of Wrath ( #9385 )
...
* [DMU] Implemented Archangel of Wrath
* fix kicker cost
* small change to text generation
2022-08-19 18:19:00 -04:00
Evan Kranzler
5e656b8da5
[DMU] Implemented Impede Momentum ( #9383 )
2022-08-18 20:38:54 -04:00
Evan Kranzler
55caa5e4eb
[DMU] Implemented Sheoldred, the Apocalypse
2022-08-18 19:05:30 -04:00
arketec
56d5ad3dbc
[NCC] Implement The Beamtown Bullies ( #9378 )
2022-08-17 21:01:49 -04:00
Evan Kranzler
6cfefeea95
[DMU] Implemented all currently previewed cards ( #9304 )
2022-08-14 21:02:16 -04:00
Alex Vasile
19a896df57
Refactoring and cleaning up based on previous commit
2022-08-12 21:33:20 -04:00
Alex Vasile
c0c5c63284
Fixed "One mana of any color" abilities from allowing you to make {C}. Closes #9351 .
2022-08-12 21:33:02 -04:00
sprangg
7554a2b6b5
Make Add Land dialog no longer add a random mix of regular and snow-covered basic lands ( #9353 )
...
The Add Land dialog now only adds regular basic lands and never snow-covered ones, unless you specifically select a set that only contains snow basics (e.g. MH1) Sets that only contain snow basics are not selectable when adding lands to a Limited deck.
2022-08-10 20:11:01 -04:00
Alex Vasile
ebdb6b53a4
Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage ( #9343 )
2022-08-08 23:28:46 -04:00
PurpleCrowbar
188e6dd8c1
Added default image set codes for several tokens
2022-08-06 21:54:15 +01:00
PurpleCrowbar
7a8dd704cf
[NCC] Implement Kros, Defense Contractor ( #9362 )
2022-08-06 15:28:37 -04:00
Daniel Bomar
d42f9f1eca
[NCC] Implemented Turf War ( #9341 )
2022-08-05 18:19:46 -04:00
DeepCrimson
9f22664bf1
Refactor: Delete Unused MageLoseGameAction ( #9306 )
2022-08-03 14:52:54 -04:00
Alex W. Jackson
7233061ae3
Remove lockedIn parameter from BoostTargetEffect. Fixes #9329 ( #9334 )
2022-08-02 02:40:59 -04:00
sprangg
1a3d5923de
Make draftbots never pick basic lands over any other card ( #9342 )
...
Co-authored-by: sprangg <a@b.c>
2022-08-02 02:38:27 -04:00
Alex Vasile
cbbfe5906a
Added comments that need to be addressed for card draw.
2022-07-31 22:50:00 -04:00
sprangg
17deba2df3
Clipboard .mtga deck importing & fixes to .mtga and .dck importers ( #9321 )
2022-07-31 22:42:32 -04:00
Jeff Wadsworth
90e888fe13
- Fixed #9326
2022-07-27 08:59:31 -05:00
Alex Vasile
c34c6a59df
Test for Copied Gilded Drake reverting control when killed ( #9198 )
2022-07-27 08:05:10 -04:00
DeepCrimson
5d11bab6dd
Refactor: Remove unused subscribe method from CardRepository ( #9243 )
2022-07-27 08:02:59 -04:00
Alex W. Jackson
516ac042a2
Fix BecomesBlockedAttachedTriggeredAbility ( #9325 )
2022-07-27 00:42:32 -04:00
Alex Vasile
4b511775db
Further optimization of BecomesAllBasicsControlledEffect by making static the basic mana abilities used for checking
2022-07-26 10:12:32 -04:00
PurpleCrowbar
e67f6df0d6
[CMD] Fixed Ruhan of the Fomori and cards with similar effects. Closes #9096
2022-07-26 01:08:32 +01:00
PurpleCrowbar
cc6936387e
[NEO] Fixes Kaito Shizuki's emblem not triggering. Closes #9290
2022-07-25 02:17:27 +01:00
DeepCrimson
1f6170570b
Refactor: Document and clean-up getSpellOrLKIStack ( #9293 )
2022-07-24 16:15:56 -04:00
DeepCrimson
97b34e3129
Refactor: Remove Redundant Variable Assignment in getPlayableObjects ( #9309 )
2022-07-22 23:07:51 -04:00
DeepCrimson
4e139c9878
Refactor: Use primitive integer type ( #9310 )
2022-07-22 23:05:13 -04:00
PurpleCrowbar
474aeb560a
Added 2X2 token images
2022-07-22 23:46:15 +01:00
Alex Vasile
513085bbcc
Fixed Banishing Light-type effects to not exile creatures if the source permanent is not on the battlefield when the effect resolves. Closes #8899 .
2022-07-17 21:08:09 -04:00
Alex Vasile
9715021a35
Fixed GoadAllEffect from affecting creatures that ETB after it resolves. Closes #9227 .
2022-07-17 19:41:45 -04:00
Alex Vasile
8c22db650a
[CLB] Fixed connive fizzling on stack when permanent that connived leaves the battlefield. Closes #9252 .
2022-07-17 18:24:35 -04:00
Alex Vasile
8878dc5cc7
Added failing ignore test for #7655
2022-07-17 13:23:58 -04:00
Alex Vasile
2aa17d6153
Autotarget disabled for search effects. Closes #9254 .
2022-07-12 21:23:04 -04:00
Alex Vasile
df39503a0b
Reduce CPU cost of BecomesAllBasicsControlledEffect. ( #9263 )
2022-07-12 21:16:55 -04:00
Alex W. Jackson
79234b4059
Fix various 'deals damage to a creature' abilities triggering on damage to planeswalkers
2022-07-09 20:37:06 -04:00
Alex Vasile
7ca7e10d80
Fix NPE in tryToAutoChoose when auto-choose is set to "Most"
2022-07-09 18:02:32 -04:00
Alex W. Jackson
a94c837ad0
Fix casting of Disturb cards with Auras on the back ( #8600 )
2022-07-08 23:37:52 -04:00
Alex Vasile
b473300680
More robust searching and importing of MDFCs, Split, Adventure cards, etc. ( #8948 )
2022-07-08 22:19:54 -04:00
Alex Vasile
484e6c20f1
Fixes to casting calculations ( #9049 )
2022-07-08 22:00:19 -04:00
Alex Vasile
96f6fbefc8
GUI: Autochoose targets if choice can be made ( #9206 )
2022-07-08 21:58:42 -04:00
Alex Vasile
5e7f145e3d
Fix message for choose target dialog for distributing +1/+1 counters ( #9202 )
2022-07-08 21:42:42 -04:00
Alex Vasile
69f9331d87
[AFC] Fix OneOrMoreDiceRolledTriggeredAbility to not trigger from Chaos Dragon ( #9201 )
2022-07-08 21:40:05 -04:00
DeepCrimson
545b7c143d
Refactor: Fix spelling ( #9238 )
2022-07-08 21:39:08 -04:00
Alex Vasile
f6ff32e38b
[AER] Inspiring Statuary display fix ( #9214 )
2022-07-08 21:37:31 -04:00
DeepCrimson
ea6cbcc962
Refactor: Fix fileName param ( #9240 )
2022-07-08 21:36:50 -04:00
DeepCrimson
f507a6605c
Refactor: Remove Unused triggerId variable ( #9237 )
2022-07-08 21:31:50 -04:00
DeepCrimson
f20210037b
Refactor: Delete Unused Methods cardExists ( #9244 )
2022-07-08 21:30:37 -04:00
DeepCrimson
05648f8c0c
Refactor: Delete unused getLastBuild ( #9245 )
2022-07-08 21:20:18 -04:00
DeepCrimson
702cfcaa86
Refactor: clean up getAllSetNames ( #9246 )
2022-07-08 21:19:59 -04:00
DeepCrimson
5c5cb46de6
Refactor: remove unused import ( #9239 )
2022-07-07 08:47:13 -04:00
Alex Vasile
a8a16968d3
[AKH] Fix game slowdown from Cascading Cataracts. Closes #7649 . ( #9068 )
2022-07-04 22:20:54 -04:00
Alex Vasile
dca2ae546e
[CLB] Fix Incorrect Volo Behavior ( #9190 )
2022-07-04 22:17:33 -04:00
Alex Vasile
78f3547644
Added common interface to conditional effects ( #9208 )
2022-07-04 20:28:54 -04:00
Alex Vasile
5c54eccffd
Revert "Condense mana strings shown to player. Fix #8945."
...
(condenseManaCostString does not respect mana symbol order)
This reverts commit 08fd93f073
2022-07-04 15:42:51 -04:00
Alex Vasile
08fd93f073
Condense mana strings shown to player. Fix #8945 .
2022-07-04 15:09:09 -04:00
Alex Vasile
1e4c64aacd
Fix Goad + Planeswalker interaction. Fix #9148
2022-07-04 14:46:51 -04:00
Alex Vasile
a7a51b4117
Refactor: Simplified Xorn and Jolene implementation
2022-07-04 10:07:12 -04:00
Alex Vasile
b52576fcf9
Stop permanents getting counters when phased out ( #9194 )
2022-07-04 09:33:30 -04:00
sprangg
7bed65e8ec
Fix Redirection effects ending early ( #9191 )
2022-07-02 13:33:02 -04:00
Alex Vasile
6077deb1a3
Text fixes. Closes #6533 .
2022-07-01 18:37:13 -04:00
Alex Vasile
df18950f15
Refactor: Fix reminder text on EquipAbility.
2022-07-01 17:44:02 -04:00
DeepCrimson
4cd262c45d
Refactor: Remove unused getManaAbilities method ( #9169 )
2022-07-01 17:11:18 -04:00
Alex Vasile
75c8876746
[AFR] Fix Classes leveling up even if phased out. Closes #8549 .
2022-07-01 14:32:02 -04:00
Alex Vasile
448577a0fe
[HOU] Added indicators DesertControlledOrGraveyardHint
2022-06-30 20:43:34 -04:00
Evan Kranzler
deb29c0659
replaced instances of Optional::of with Optional::ofNullable ( fixes #9183 )
2022-06-29 18:32:15 -04:00
Daniel Bomar
c6cc9bd83f
[NCC] Implemented Dogged Detective
2022-06-29 11:55:30 -05:00
Jeff Wadsworth
009f53844a
- Fixed #9177
2022-06-28 15:22:20 -05:00
Jeff Wadsworth
da10b6397c
- Fixed #9161
2022-06-28 10:26:12 -05:00
DeepCrimson
7bb851e0a5
Refactor: Fix spelling of 'controller' ( #9163 )
2022-06-26 22:58:06 -04:00
Alex Vasile
0e38392722
Fixed typo in ControlACommanderCondition
2022-06-25 11:35:38 -04:00
Alex Vasile
62a8983b48
[CLB] Fixed CommanderInPlayCondition, now only triggers for OWN commander. Closes #9125 .
2022-06-25 11:17:06 -04:00
Jeff Wadsworth
48a96e5e8f
- Fixed #8916
2022-06-24 15:31:35 -05:00
PurpleCrowbar
227ae8c2e2
Assigned emblem images
2022-06-24 18:05:35 +01:00
PurpleCrowbar
494fc39dba
Added "available image set codes" functionality to emblems ( #9150 )
...
* Added pulling image from list of available image set codes functionality to emblems
* Provided available image set codes for Daretti, Scrap Savant emblem
* Fixed typo in a comment
2022-06-24 10:32:07 +04:00
Alex Vasile
5aae6bf735
[CLB] Fix Undercity Dungeon +1/+1 counter amount and Stash next room bugs. Closes #9123 .
2022-06-22 14:40:32 -04:00
Jeff Wadsworth
e7205391ba
- Fixed #9128
2022-06-20 11:53:02 -05:00
Oleg Agafonov
90fedddc92
Merge pull request #9113 from DeepCrimson/rawWhere
...
Refactor: Fix Raw use of parameterized class 'Where'
2022-06-17 08:41:51 +04:00
Oleg Agafonov
6bf9f45cd5
Merge pull request #9116 from DeepCrimson/removeUnusedParamFromContainsControlled
...
Refactor: Remove unused sourceID param from `containsControlled` method
2022-06-17 08:41:25 +04:00
Oleg Agafonov
4e20c4c475
Merge pull request #9117 from DeepCrimson/removeUnusedParamFromContainsMethod
...
Refactor: Remove unused `sourceID` param from `contains` method
2022-06-17 08:40:57 +04:00
Oleg Agafonov
08740b1b04
Merge pull request #9120 from DeepCrimson/manaCostImpl
...
Refactor: Fix remaining raw unparameterized usages of ManaCostImpl
2022-06-17 08:35:38 +04:00
DeepCrimson
ae88cc2f66
Refactor: Delete commented out code blocks in GameImpl.java ( #9108 )
...
Co-authored-by: DeepCrimson <deepcrimson@users.noreplyl.github.com>
2022-06-17 08:27:51 +04:00
Oleg Agafonov
5c1fe5075f
[CLB] fixed verify tests
2022-06-17 08:20:22 +04:00
DeepCrimson
4546623fb6
Refactor: Fix spelling of DENY_PERMISSION_TO_ROLLBACK_TURN ( #9114 )
2022-06-16 22:16:03 -04:00
DeepCrimson
882afbf8b5
Fix remaining raw unparameterized usages of ManaCostImpl
2022-06-16 14:53:44 -07:00
DeepCrimson
6cf3af1d94
Refactor: Improve docstring for getPermanent and containsPermanent methods in Battlefield.java ( #9115 )
2022-06-16 14:25:47 -04:00
DeepCrimson
3192a191a4
Refactor: Remove unused sourceID param from contains method
2022-06-15 21:34:25 -07:00
DeepCrimson
788e42629d
Refactor:Remove unused sourceID param from containsControlled method
2022-06-15 21:24:54 -07:00
DeepCrimson
b1f254bdc3
Refactor: Fix Raw use of parameterized class 'Where'
2022-06-15 20:29:59 -07:00
Evan Kranzler
f2e27148cb
[CLB] various text fixes
2022-06-13 21:50:50 -04:00
DeepCrimson
5d09315387
Refactor: Fix typo in GameImpl.java ( #9105 )
2022-06-13 08:24:37 -04:00
DeepCrimson
3ae5f4979d
Refactor: Remove redundant boxing/unboxing to parse int primitives ( #9065 )
2022-06-12 12:46:59 -04:00
PurpleCrowbar
e421f4757e
Fixed CLB shapeshifter tokens' images
2022-06-11 22:42:43 +01:00
PurpleCrowbar
cc78e3fae5
Fixed goblin token images
2022-06-09 00:31:10 +01:00
PurpleCrowbar
4456fd45d7
Removed ANA as an available token image source (no token images)
2022-06-09 00:17:31 +01:00
PurpleCrowbar
8316e6a813
Removed 5DN as an available token image source (no token images)
2022-06-09 00:15:35 +01:00
PurpleCrowbar
c3e20a3f0c
Removed 4ED as an available token image source (no token images)
2022-06-09 00:05:45 +01:00
PurpleCrowbar
323191b2d0
Fixed pegasus token images
2022-06-09 00:01:32 +01:00
PurpleCrowbar
c6e8583d63
Removed TSP as an available token image source (no token images)
2022-06-08 23:58:13 +01:00
PurpleCrowbar
dd95a5dd3b
Removed TMP as an available token image source (no token images)
2022-06-08 23:50:44 +01:00
PurpleCrowbar
49764df243
Removed MIR as an available token image source (no token images)
2022-06-08 23:40:00 +01:00
PurpleCrowbar
2255b1e409
Removed GPT as an available token image source (no token images)
2022-06-08 23:35:17 +01:00
PurpleCrowbar
d37f59f647
Removed EXO as an available token image source (no token images)
2022-06-08 23:32:23 +01:00
PurpleCrowbar
2ed55094a7
Removed CMD as an available token image source (no token images)
2022-06-08 23:31:12 +01:00
PurpleCrowbar
6faf3cdc48
Removed ARC as an available token image source (no token images)
2022-06-08 23:13:35 +01:00
PurpleCrowbar
4a2167627e
Removed duplicate trample haste elemental token class
2022-06-08 22:55:44 +01:00
PurpleCrowbar
0429b6083c
Fixed build failure
2022-06-08 16:06:34 +01:00
PurpleCrowbar
0f9eec934d
Fixed elemental shaman token
2022-06-08 14:52:23 +01:00
PurpleCrowbar
89f9ef78e8
Added LRW token images
2022-06-08 14:52:09 +01:00
PurpleCrowbar
8407e23d3f
Removed duplicate haste elemental token class
2022-06-08 00:42:41 +01:00
Evan Kranzler
3d0e8c3404
text fixes for blink effects
2022-06-07 08:56:43 -04:00
Evan Kranzler
81c8d4e28f
[CLB] various text fixes
2022-06-07 08:39:27 -04:00
PurpleCrowbar
e418ab04be
Removed duplicate minotaur token class. Closes #8947
2022-06-07 01:58:39 +01:00
PurpleCrowbar
16bb0ebfc1
Removed duplicate hellion token class
2022-06-07 01:49:10 +01:00
PurpleCrowbar
4dde9592c8
Fixed colorless spirit token image issues. Closes #9005
2022-06-07 01:30:23 +01:00
PurpleCrowbar
d6414a5ac4
RNA spirit token image fix
2022-06-07 01:17:45 +01:00
Evan Kranzler
1899fa0def
[CLB] Implemented Balor
2022-06-06 19:49:42 -04:00
Evan Kranzler
a6f977c0e4
[CLB] Implemented Psionic Ritual
2022-06-06 19:11:13 -04:00
Evan Kranzler
c600bfcd6b
[CLB] Implemented Myrkul, Lord of Bones
2022-06-06 19:05:07 -04:00
PurpleCrowbar
80e8e27b42
CLB ogre token image fix
2022-06-06 23:37:05 +01:00
PurpleCrowbar
901bb80885
Added CLB token images
2022-06-06 19:57:01 +01:00
PurpleCrowbar
7e523e655a
Merge branch 'master' of https://github.com/magefree/mage into latesttokenpics
2022-06-06 17:05:52 +01:00
PurpleCrowbar
f96436b2b2
Added GN2 token images
2022-06-06 17:01:58 +01:00
PurpleCrowbar
18b515ba5c
Added GK2 token images
2022-06-06 16:33:49 +01:00
PurpleCrowbar
74756be1bc
Added GK1 token images
2022-06-06 16:19:52 +01:00
PurpleCrowbar
5a6f42e80c
Fixed GRN goblin token image not displaying
2022-06-06 15:30:25 +01:00
PurpleCrowbar
f4399e669a
Added GS1 token images
2022-06-06 15:24:02 +01:00
PurpleCrowbar
e3d64451ed
Removed duplicate Kher Keep Kobold token class
2022-06-06 15:10:00 +01:00
PurpleCrowbar
b277b87654
Added A25 token images
2022-06-06 15:02:15 +01:00
Alex Vasile
7ebe0844a2
Refactor: Make copy constructor of ManaCostsImpl private. Added missing field to it
2022-06-06 09:55:03 -04:00
PurpleCrowbar
84553db7e0
Added DDT token images
2022-06-06 14:12:00 +01:00
PurpleCrowbar
f6cdc8daee
Added E01 token images
2022-06-06 14:06:18 +01:00
PurpleCrowbar
8e08b70348
Added DDS token images
2022-06-06 14:00:10 +01:00
Evan Kranzler
694d0debe4
[CLB] Implemented Volo, Itinerant Scholar
2022-06-06 08:57:10 -04:00
PurpleCrowbar
070374d816
Removed ONS as a token image source as it has no related token images
2022-06-06 13:50:15 +01:00
PurpleCrowbar
a699431e0b
Removed duplicate ooze token class
2022-06-06 13:44:13 +01:00
PurpleCrowbar
31e6a5a06f
Added MM3 token images
2022-06-06 13:35:19 +01:00
PurpleCrowbar
c63bd729bd
Added DDR token images
2022-06-06 02:04:07 +01:00
PurpleCrowbar
7793a75dc7
Added CN2 token images
2022-06-06 01:55:16 +01:00
PurpleCrowbar
a3d3c29c93
Added V16 token images
2022-06-06 01:42:40 +01:00
PurpleCrowbar
3357fb84bb
EMA zombie token image fix
2022-06-06 01:38:10 +01:00
PurpleCrowbar
0cac2f6d21
Added EMA token images
2022-06-06 01:33:08 +01:00
PurpleCrowbar
0ce189fe2e
Added DDQ token images
2022-06-06 01:20:06 +01:00
PurpleCrowbar
e8eb0c9dba
Added FRF token images
2022-06-06 00:37:15 +01:00
PurpleCrowbar
d2e752bc22
Added DVD token images
2022-06-06 00:30:15 +01:00
PurpleCrowbar
150a7897c4
Added GVL token images
2022-06-06 00:26:03 +01:00
PurpleCrowbar
a2a10ae1a3
Added EVG token images
2022-06-06 00:20:18 +01:00
Evan Kranzler
8bc4061e9b
[CLB] Implemented Passionate Archaeologist
2022-06-05 17:27:43 -04:00
Evan Kranzler
cd847932c2
[CLB] Implemented Wrathful Red Dragon
2022-06-05 17:18:57 -04:00
PurpleCrowbar
ea96f253c1
Added CNS token images
2022-06-05 20:15:42 +01:00
PurpleCrowbar
2b43af4d7e
Added MD1 token images
2022-06-05 19:50:13 +01:00
PurpleCrowbar
2739dcad4e
Added DDM token images
2022-06-05 19:21:20 +01:00
PurpleCrowbar
85ebbb516b
Added BNG token images
2022-06-05 19:15:54 +01:00
PurpleCrowbar
4f684443ee
Added EVE token images
2022-06-05 19:01:37 +01:00
Evan Kranzler
b745df3362
[CLB] fixed initiative damage trigger causing rollback errors ( #9010 )
2022-06-05 10:52:27 -04:00
PurpleCrowbar
bde2791624
Removed duplicate black and green worm token class
2022-06-05 14:01:48 +01:00
PurpleCrowbar
3fc84d9ba4
Removed duplicate dragon egg dragon token class
2022-06-05 13:48:53 +01:00
PurpleCrowbar
cb6e6b234f
Removed duplicate enchantment bird token class
2022-06-05 13:40:55 +01:00
PurpleCrowbar
2074a02920
Removed duplicate 3/3 angel token class
2022-06-05 13:17:27 +01:00
PurpleCrowbar
6f7f085fa3
Merge pull request #9066 from PurpleCrowbar/moretokenpics
...
A very large amount of token images
2022-06-05 12:39:44 +01:00
Evan Kranzler
56e04087cc
[CLB] Implemented Sigil of Myrkul
2022-06-04 17:38:15 -04:00
PurpleCrowbar
9ae95982e3
Added THS token images
2022-06-04 21:31:34 +01:00
PurpleCrowbar
e8fd84580c
Added DGM token images
2022-06-04 21:09:49 +01:00
PurpleCrowbar
2ccf911fc4
Added GTC token images
2022-06-04 20:59:19 +01:00
PurpleCrowbar
d4de0e8729
Added RTR token images
2022-06-04 19:44:10 +01:00
PurpleCrowbar
dce8c43d6f
Added AVR token images
2022-06-04 19:33:25 +01:00
PurpleCrowbar
21904d991c
Added DDI token images
2022-06-04 19:23:47 +01:00
PurpleCrowbar
81984ceac0
Added DKA token images
2022-06-04 19:18:12 +01:00
PurpleCrowbar
b9d3980ea0
Added ISD token images
2022-06-04 19:14:04 +01:00
PurpleCrowbar
e065e77f7c
Added NPH token images
2022-06-04 18:55:58 +01:00
PurpleCrowbar
4ea204ed05
Added DDG token images
2022-06-04 18:44:04 +01:00
PurpleCrowbar
bbbcde3561
Added MBS token images
2022-06-04 18:41:03 +01:00
PurpleCrowbar
dfa1981a9e
Added DDD token images
2022-06-04 18:25:23 +01:00
PurpleCrowbar
98b5cffd4e
Added DDF token images
2022-06-04 18:15:07 +01:00
PurpleCrowbar
2ee43c261e
Added ROE token images
2022-06-04 18:09:48 +01:00
PurpleCrowbar
c617e13675
Added WWK token images
2022-06-04 17:58:24 +01:00
PurpleCrowbar
5ab454ea63
Added ZEN token images
2022-06-04 17:51:50 +01:00
PurpleCrowbar
c813603647
Added 10E token images
2022-06-04 17:15:34 +01:00
PurpleCrowbar
4ba695e741
Added DD1 token images
2022-06-04 16:53:11 +01:00
PurpleCrowbar
a35e31ae56
Added MOR token images
2022-06-04 16:46:57 +01:00
PurpleCrowbar
bb3065afd9
Added ALA token images
2022-06-04 16:31:05 +01:00
PurpleCrowbar
98f0ff8871
Added DDC token images
2022-06-04 15:53:39 +01:00
PurpleCrowbar
d138833029
Added M11 token images
2022-06-04 15:27:03 +01:00
Evan Kranzler
e3301a6485
[CLB] Implemented Trailblazer's Torch
2022-06-04 10:10:33 -04:00
Evan Kranzler
23ed717c8c
[CLB] Implemented Majestic Genesis
2022-06-04 09:57:47 -04:00
Evan Kranzler
e9044d69e9
[CLB] various text fixes
2022-06-03 19:44:29 -04:00
Hidde vb
a9d1a92abc
Fix Tundra Kavu (for #9030 ) and Death or Glory ( #9055 )
2022-06-03 15:34:52 -04:00
PurpleCrowbar
9a1ce358e7
Merge pull request #9053 from PurpleCrowbar/moretokensets
...
More token images
2022-06-03 13:48:07 +01:00
Evan Kranzler
aa5a2b1c29
[ELD] various text fixes
2022-06-03 08:26:04 -04:00
Evan Kranzler
0b5c42dffa
[CLB] Implemented Fraying Line
2022-06-02 21:32:17 -04:00
Evan Kranzler
72d7b8794e
[CLB] Implemented Sivriss, Nightmare Speaker
2022-06-02 21:02:19 -04:00
Evan Kranzler
1a6a17fa0f
[CLB] Implemented Descent into Avernus
2022-06-02 08:25:43 -04:00
Evan Kranzler
07a8cc6bc9
[CLB] Implemented Vexing Puzzlebox
2022-06-02 07:57:16 -04:00
Evan Kranzler
921865a8f9
[CLB] Implemented Scaled Nurturer
2022-06-01 20:22:02 -04:00
PurpleCrowbar
aacec6a89f
Added support for and assigned PCA token images
2022-06-02 00:31:52 +01:00
PurpleCrowbar
8a4482ae93
Added support for and assigned CMA token images
2022-06-01 23:43:53 +01:00
PurpleCrowbar
a8309f38f7
Token images for a couple of sets ( #9047 )
...
* Added support for and assigned IMA token images
* Added support for and assigned CM2 token images
* Fixed M19 DragonEggDragonToken not displaying in game
2022-06-02 00:55:17 +04:00
Alex Vasile
e679574a15
Fixes for Mana.enough and Mana.needed. For #8153 ( #8663 )
...
Fixes to Mana.enough:
mana of any color (ManaType.Any) was being used to pay for colourless mana.
Fixes for Mana.needed:
mana of any color (ManaType.Any) was being used to pay for colourless mana.
calculation for generic mana remaining was using min(0, available) instead of max(0, available) meaning that leftover mana of other types was never used to pay for any leftover generic costs.
Other:
Added tests for both .needed and .enough.
Moved tests some tests from ManaUtilTest to ManaTest
Simplified Mana.subtractCosts by calling Mana.substract first to make use of common functionality.
Added more documentation
Added tests for both .needed
Added more tests for .enough to cover the changes with colourless mana.
2022-06-01 08:13:37 -06:00
Evan Kranzler
2bf4139a31
[CLB] Implemented Black Market Connections
2022-06-01 09:32:11 -04:00
Evan Kranzler
2f640f2b05
[CLB] Implemented Guildsworn Prowler
2022-05-31 19:33:05 -04:00
Evan Kranzler
80c9c33b78
fixed issues with cards that goad multiple creatures at once ( fixes #9007 , fixes #8958 )
2022-05-31 18:11:15 -04:00
Evan Kranzler
e22648a385
[CLB] Implemented Zellix, Sanity Flayer
2022-05-31 18:06:29 -04:00
Oleg Agafonov
da6e5260ec
Merge pull request #9045 from PurpleCrowbar/imagefixes
...
Specific token image bug fixes
2022-05-31 23:55:07 +04:00
PurpleCrowbar
9a02f6cb90
Fixed C20 Locust God insects' images not displaying
2022-05-31 20:28:48 +01:00
PurpleCrowbar
6c02923c15
Fixed M20 emblem images not showing in game
2022-05-31 20:22:49 +01:00
Evan Kranzler
eee9fb9f25
[CLB] Implemented Contraband Livestock
2022-05-31 09:19:33 -04:00
Evan Kranzler
b48a023a94
[CLB] Implemented Bothersome Quasit
2022-05-31 08:48:49 -04:00
Evan Kranzler
027bd439b4
[CLB] fixed Moonshae Pixie text generation
2022-05-31 07:34:32 -04:00
Evan Kranzler
ecbfc4edc4
removed locked in parameter from BoostAllEffect
2022-05-30 22:20:50 -04:00
Evan Kranzler
ca7de23eb5
[CLB] Implemented Nimblewright Schematic
2022-05-30 11:20:46 -04:00
Evan Kranzler
3350c5d8d8
[CLB] Implemented Javelin of Lightning
2022-05-30 11:20:44 -04:00
DeepCrimson
a5b7fce429
Renamed param 'sourceId' to 'source' in payOrRollback method ( #9014 )
2022-05-30 09:06:58 -06:00
PurpleCrowbar
9ed04cc3c5
Removed duplicate djinn monk token class, for #8996 ( #9029 )
2022-05-30 09:05:17 -06:00
DeepCrimson
853cf591aa
Remove redundant variable controllerOfFirstTarget ( #9039 )
2022-05-30 07:54:13 -06:00
Evan Kranzler
1c665caa00
[CLB] Implemented Bronze Walrus
2022-05-29 18:48:37 -04:00
Alex Vasile
63aaf44f93
[CLB] Fix initiativeId not being set when a player first takes the initiative. Added documentation to related functions. For #9010 .
2022-05-29 12:30:09 -06:00
Alex Vasile
fdbca7048a
[CLB] Fix Forge section of Undercity not giving 2 +1/+1 counters. For #9010 .
2022-05-29 12:01:24 -06:00
PurpleCrowbar
cee6bc3cfe
Token images and fixes for some sets ( #9027 )
...
* Fixed CMR's phyrexian horror token not displaying in game
* Added support for and assigned MED token images
* Added support for and assigned BBD token images
* Added support for and assigned DDU token images
* Fixed some M19 tokens not displaying correctly
2022-05-29 09:08:09 +04:00
PurpleCrowbar
c667458198
Added NCC Token Images ( #9026 )
...
* Removed BOK as a token image source as it has no token images
* Fixed zombie tokens from C20 not showing in game
* Fixed alphabetically misplaced C21 token in card viewer
* Added support for and assigned NCC token images
2022-05-29 02:27:50 +04:00
DeepCrimson
9084180937
Fix 'chosen' spelling ( #9021 )
2022-05-27 21:45:07 -06:00
PurpleCrowbar
74a16d179f
Removed duplicate squid token class for #8996 ( #9020 )
2022-05-27 20:38:15 -06:00
Alex Vasile
7643ff5597
- Fixed AddManaInAnyCombinationEffect and DynamicManaEffect to not let you click Choose until you've selected the correct amount.
...
- Added an extra constructor to Mana using ColoredManaSymbols and a count so that a for loop isn't needed in AddManaInAnyCombinationEffect.
2022-05-27 17:16:43 -06:00
Evan Kranzler
1cf297a15c
[CLB] Implemented Altar of Bhaal
2022-05-27 06:30:37 -04:00
Oleg Agafonov
94dc91d8e1
Fixed miss code for reversed turn order (see Aeon Engine, #8804 )
2022-05-27 09:35:30 +04:00
PurpleCrowbar
f003c93cb2
Added / fixed token images for several commander sets ( #9000 )
...
* Stopped OGW tokens which don't have images being used as image sources
* Removed C13 as a token image source as it has no related token images
* Added support for and assigned C14 token images
* Added support for and assigned C15 token images
* Added support for and assigned C16 token images
* Added support for and assigned C17 token images
* Fixed C18 token images
* Fixed C19 token images
2022-05-26 20:34:45 +04:00
Alex Vasile
561a5a3d0e
Fixed error I introduced in canTarget()
2022-05-25 23:18:01 -06:00
