Evan Kranzler
19ec3e399e
fixed text on wish effects
2021-03-12 15:05:37 -05:00
Evan Kranzler
9c56a98dc9
Refactor implementation of spell copies for cards like Twinning Staff as well as refactor handling of target changing (WIP) ( #7662 )
...
* refactored createCopyOnStack to be void
* added new interface for modifying copied spellsspells
* update implementation of Fork to use new applier
* reworked epic effect
* add applier to spell copy code
* updated implementation of Beamsplitter Mage
* updated cards which copy for each possible target
* added support for additional copies having targets changed
* fixed/ignored failing tests
* updated target changing to prevent unnecessary choosing
* added test for Twinning Staff
* updated implementation of spell copy applier
* added new method for choosing order of copies on stack
* fixed test failures
* [TSR] various text fixes
* fixed a test failure
* [SLD] fixed Rick, Steadfast Leader only counting Human creatures
* updated test framework to handle skips without affecting starting player choice
* fixed another test failure
* updated copy messaging for consistency
* added copy messaging to stack abilities
2021-03-12 12:47:49 -05:00
Evan Kranzler
b51915f6e8
[SLD] fixed Rick, Steadfast Leader only counting Human creatures
2021-03-09 20:29:49 -05:00
Evan Kranzler
93c9b2770a
fixed a test failure
2021-03-09 20:27:05 -05:00
Evan Kranzler
1dfde6d622
[TSR] various text fixes
2021-03-09 20:01:32 -05:00
Evan Kranzler
2c168856c5
[2XM] added booster collation including foils
2021-03-08 10:18:55 -05:00
Evan Kranzler
a1ab427654
[SLD] fixed Rick, Steadfast Leader boosting non-Human creatures
2021-03-07 18:31:23 -05:00
Oleg Agafonov
0ab8d0d16f
Fixed NPE
2021-03-07 23:45:50 +04:00
Oleg Agafonov
53a2021a12
* Caller of the Hunt - fixed rollback error on usage, added AI support for the card;
2021-03-07 23:41:52 +04:00
Oleg Agafonov
2906f86324
Test framework: simplified AI logic and tests, added usage comments. Devs recommendations:
...
* in card's code use player.isComputer instead player.isHuman (it help to split Human/AI logic and test both by unit tests);
* usage example: AI hint to skip or auto-calculate choices instead call of real choose dialogs;
* unit tests for Human logic: call normal commands;
* unit tests for AI logic: call aiXXX commands;
2021-03-07 23:38:10 +04:00
Oleg Agafonov
00c7b3753c
* Bronzehide Lion - fixed rollback error on usage ( fixes #7564 );
2021-03-07 18:36:02 +04:00
Oleg Agafonov
6e661e6d97
* Halvar, God of Battle - fixed rollback error on attached permanent die;
2021-03-07 18:28:19 +04:00
Oleg Agafonov
0e916b6e29
Dev: added additional info to some classes for easy debug;
2021-03-07 17:16:54 +04:00
Oleg Agafonov
bde6222ea6
* The First Sliver - fixed too long rules text;
2021-03-07 03:12:20 +04:00
Oleg Agafonov
ccc85c1acb
[TSR] added tokens
2021-03-07 03:08:17 +04:00
Oleg Agafonov
7e72ba95bc
Fixed typos
2021-03-07 03:08:17 +04:00
Oleg Agafonov
d3b787b9a6
[TSR] added images download
2021-03-07 03:08:17 +04:00
Evan Kranzler
f54145ad42
[LRW] reworked abilities which trigger off of clashing
2021-03-06 14:49:55 -05:00
Evan Kranzler
02f04e541c
a few small text fixes
2021-03-06 14:35:01 -05:00
Oleg Agafonov
b36f915d74
* Copy spell - improved support, now all copied spells are independent (bug example: Seasons Past fizzled after copy resolve, see #7634 , 10f8022043);
2021-03-06 19:32:17 +04:00
Evan Kranzler
8704b9cb9b
[VIS] fixed Vision Charm effect duration ( fixes #7652 )
2021-03-06 07:56:42 -05:00
Evan Kranzler
6894ad96bc
[TSR] various text fixes
2021-03-05 19:10:29 -05:00
Evan Kranzler
bb2e0922ab
[TSR] fixed a test failure
2021-03-05 18:34:28 -05:00
Evan Kranzler
425c1eda26
[TSR] added set
2021-03-05 18:17:01 -05:00
Evan Kranzler
b55e3d52c6
[AKH] fixed Throne of the God-Pharaoh text ( fixes #7647 )
2021-03-05 17:26:40 -05:00
Evan Kranzler
622d13484f
fixed some outdated token text
2021-03-05 10:54:15 -05:00
Oleg Agafonov
712cf4576d
* Gain abilities - fixed that objects can get only one instance of triggered ability instead multiple (example: 2+ cascades from copies of Imoti, Celebrant of Bounty, f52753ad61);
2021-03-05 16:22:46 +04:00
Oleg Agafonov
4e79c83784
Test framework: fixed missing range info for added cards (some ETB effects were broken on "put to battlefield" command usage);
2021-03-05 15:12:47 +04:00
Oleg Agafonov
654c0be1ac
Additional fixes for 4a3679285e ( #7645 )
2021-03-04 23:49:00 +04:00
Evan Kranzler
b1da4d4d79
[MOR] fixed Knowledge Exploitation not working ( fixes #7646 )
2021-03-04 14:20:33 -05:00
Daniel Bomar
4a3679285e
Fixed Crucible of Worlds allowing lands to be played from opponent's graveyard ( fixes #7645 )
2021-03-04 12:55:49 -06:00
Evan Kranzler
87c272bf06
[KHM] fixed Battle for Bretagard allowing controller to copy tokens they don't control ( fixes #7642 )
2021-03-03 22:14:42 -05:00
Evan Kranzler
afcdc0f23a
simplified and consolidated werewolf triggered abilities
2021-03-03 22:13:16 -05:00
Evan Kranzler
378d596e3c
[ULG] reimplemented Damping Engine, fixed text
2021-03-03 20:49:39 -05:00
Evan Kranzler
29be124725
refactored card.moveToExile for M-N
...
reworked Mindreaver
2021-03-03 10:04:15 -05:00
Evan Kranzler
4c3de17006
refactored card.moveToExile for I-J
...
reworked Inverter of Truth and Luminate Primordial
2021-03-03 09:22:29 -05:00
Evan Kranzler
28c0bd55e8
added test for Muraganda Petroglyphs/Tarmogoyf/Muraganda Petroglyphs
2021-03-03 09:06:39 -05:00
Evan Kranzler
b9d5e34f8b
[USG] fixed text and implementation of Wizard Mentor
2021-03-02 14:59:09 -05:00
Evan Kranzler
3b5147f6ee
updated some methods to support collections of card subclasses
2021-03-02 09:41:39 -05:00
Evan Kranzler
c552234e9c
refactored card.moveToExile usage for G-H
...
heavily reworked Haunting Echoes and Hypnox
2021-03-01 18:03:00 -05:00
Daniel Bomar
10f8022043
ReturnToLibrarySpellEffect - Do not apply to spell copies ( fixes #7634 )
2021-03-01 16:40:40 -06:00
Evan Kranzler
f52753ad61
[CMR] fixed multiple copies of Imoti, Celebrant of Bounty only giving cascade once
2021-03-01 08:45:42 -05:00
Evan Kranzler
852aa562d2
[LRW] fixed Vigor applying to opponent's creatures
2021-02-28 21:03:46 -05:00
Evan Kranzler
9567b19b01
refactored card.moveToExile usages E-F
2021-02-28 17:09:37 -05:00
Evan Kranzler
4a09654743
refactored card.moveToExile usages A through D
...
heavily reworked Dark Impostor and Dimensional Breach
2021-02-28 17:06:13 -05:00
Evan Kranzler
129a477f56
reworked some abilities which use card.moveToExile
2021-02-28 17:06:13 -05:00
Oleg Agafonov
098796f86e
* Commander: fixed that non hand abilities are castable from command zone (example: Escape, Jumpstart, see #7632 );
2021-03-01 01:14:00 +04:00
Daniel Bomar
f739eedc46
Fixed Escape being castable from command zone ( fixes #7632 )
2021-02-28 14:20:44 -06:00
Evan Kranzler
6091c7eae3
fixed trample and deathtouch not working when deathtouch is gained by an outside source ( fixes #7633 )
2021-02-28 09:34:09 -05:00
Evan Kranzler
2daf1945e7
[RTR] reworked Nivmagus Elemental and added test
2021-02-27 15:35:04 -05:00
