Commit graph

2084 commits

Author SHA1 Message Date
Quercitron
22de85aee1 Cards that are cast using alternative cost effects keep their previous targets (#5189) - Add unit test. 2018-08-10 02:53:38 +03:00
tamaroth
566caedd61 Add a test for a triggered ability of Tuvasa the Sunlit
The test makes sure that a triggered ability of Tuvasa is triggered only once and 
draws only one card when more than one enchantment spells are cast by the 
controller of Tuvasa during a single turn.
2018-08-08 12:04:52 +02:00
Chatziargyriou Eleftheria
197020b162
Merge branch 'master' into Battlebond_Boos 2018-07-31 17:02:11 +03:00
dilnu
988b64866c Fix a bug with Animar's cost reduction effect. 2018-07-29 11:22:41 -04:00
Samuel Sandeen
e5c1dfc4b7
Refactor ControlledCreaturesDealCombatDamagePlayerTriggeredAbility. (#5163)
It now triggers once for each player damaged.

Fixes https://github.com/magefree/mage/issues/5162
2018-07-29 08:16:07 -04:00
Samuel Sandeen
14520097a5
Fix issues with the ChosenSubtypePredicate and clone effects. (#5164)
Update ChosenSubtypePredicate to be an ObjectPlayer predicate. This fixes how cards that use it act when cloned.

Fixes https://github.com/magefree/mage/issues/5136
2018-07-29 07:44:19 -04:00
Samuel Sandeen
a164dad83f
Fix issues with Clone and Metallic Mimic (#5160)
Fix bugs with Metallic Mimic and Adaptive Automaton and clone effects.

Metallic Mimic and Adaptive Automaton were both using the technically correct EnterEventType specifier for their as enters the battlefield abilities. Despite it being technically correct this meant that their ability didn't trigger if they were cloned.

Additionally EnterAttributeAddChosenSubtypeEffect changed the subtype of the base object which meant that clones entered in with the chosen subtype of the original.
2018-07-29 07:40:48 -04:00
Samuel Sandeen
3875f42bac
Refactor addCounters to fix bugs in edge cases. (#5154)
Add code to check the controller of abilities on the stack instead of the controller of their source card or object.

This fixes https://github.com/magefree/mage/issues/5152
2018-07-29 07:31:59 -04:00
Evan Kranzler
c2c7aff4f7 fixed the formatting on some ability words 2018-07-28 15:01:20 -04:00
Quercitron
79120e7484 Make color distribution in booster more uniform 2018-07-25 02:46:31 +03:00
LevelX2
014a46ae72 * Unexpectedly Absent - Fixed that the target permanent was put to the wrong position in library. 2018-07-16 17:43:01 +02:00
igoudt
877a355a7d rewrite some code to streams 2018-07-15 20:50:26 +02:00
LevelX2
7fa21ae9c2 Added some missing player methods. 2018-07-14 17:43:26 +02:00
LevelX2
a3c4c2365d
Merge pull request #5119 from NoahGleason/M19-oracle-changes
M19 oracle changes
2018-07-14 10:39:50 +02:00
igoudt
d6450eed94 change enum comparison 2018-07-08 13:11:39 +02:00
Quercitron
36c004122a Fix dual lands generation in the Core Set 2019 boosters 2018-07-08 01:19:49 +03:00
Noah Gleason
8ee7965580
Fix tests 2018-07-07 11:52:38 -04:00
igoudt
9f06046f22 add isOwned and isControlled methods. remove some null-checks, remove some unnecessary casts 2018-07-04 14:24:11 +02:00
Evan Kranzler
4a233a701a skip one more test 2018-06-25 21:49:30 -04:00
Evan Kranzler
ae9b5a75e8 skip failing tests until they're fixed 2018-06-25 21:40:04 -04:00
LevelX2
fdddbbbbe6 * Some rework/fixes/optimizations of calculation of available mana. 2018-06-24 01:23:49 +02:00
Chatziargyriou Eleftheria
a1a7b1c59b
Add test for Battlebond
Test Battlebond's partner mechanic
2018-06-22 18:57:44 +03:00
LevelX2
cd8e038679 * Changes for netMana null handling #5023. 2018-06-21 16:27:05 +02:00
Evan Kranzler
d9dfef24ce updated "can't be countered" text 2018-06-20 11:21:06 -04:00
LevelX2
74b126c940 * Tinder Wall - Fixed it's damage dealing ability always fizzles (fixes #5005). 2018-06-19 17:35:53 +02:00
Oleg Agafonov
de9046f426 Fixed broken tests 2018-06-11 04:21:28 +04:00
Oleg Agafonov
21276a1d7a Test framework: added realtime checks for mana pool amount 2018-06-11 04:20:21 +04:00
LevelX2
99864ccf5b * Fixed a problem that tapped for mana event was sent twice (fixes problem of 2 created spirits for Forbidden Orchard). 2018-06-10 10:28:00 +02:00
LevelX2
717308ba12 * Fixed that commanders of players were not removed if a player left a game. Fixed a problem that continuous effects of objects of players that left the game were not removed immediately. 2018-06-09 14:10:48 +02:00
LevelX2
4ceffd17ef * Sasaya's Essence - Fixed not correctly working mana production. 2018-06-09 12:04:22 +02:00
LevelX2
006af33625 Two minor fixes. 2018-06-09 12:01:33 +02:00
Evan Kranzler
3659a2dc0b Implemented Journey for the Elixir 2018-06-08 13:22:23 -04:00
LevelX2
c745e654f9 * Fixed test that sometimes failed on onfortunate mana tapping done by computer player. 2018-06-07 17:59:09 +02:00
Evan Kranzler
c4a0d9f916 replaced apostrophes 2018-06-06 22:39:16 -04:00
LevelX2
78c288358b Added some tests. 2018-06-06 17:34:51 +02:00
LevelX2
87e60f407b Added some tests. 2018-06-06 17:30:03 +02:00
LevelX2
ae8fa6aa10 Added test to check for creatures not entering tapped but they should #5012. 2018-06-06 17:00:33 +02:00
LevelX2
d18338edd5 Added test to check for creatures not entering tapped but they should #5012. 2018-06-06 16:59:32 +02:00
LevelX2
df341bd0d6 * Fixed some mana handling problems of conditionalMana (GemstoneCavern) and possible exception of ChromeMox.Fixed some tests. 2018-06-05 23:59:39 +02:00
Evan Kranzler
8bdb6665d9 Temporarily ignoring a test that hasn't been fixed yet 2018-06-05 15:15:14 -04:00
LevelX2
2e72503b8c * Fix of condtitional mana effect (not completed yet). 2018-06-05 18:12:31 +02:00
Michael Simons
0bf78830de Changes to try and better handle X mana costs with minimum X values with AI decisions #4906 2018-06-03 22:44:06 -04:00
LevelX2
397a6ccfc4 * Grafted Exoskeleton - Fixed that if it left the battlefield it doesn't sacrifice its creature (fixes #4997). 2018-06-03 23:51:09 +02:00
LevelX2
b17858d910 Some fixes to "Remove license headers" (#4998). 2018-06-03 10:18:30 +02:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files 2018-06-02 17:59:49 +02:00
LevelX2
b6f7efe5e9 * Fixed a problem with Dash not giving Haste to the creature beginning with the second use of Dash (fixes #4985). 2018-05-30 16:51:59 +02:00
LevelX2
27ced167fb * Added logic to add permitting object to play/cast events. 2018-05-27 23:47:57 +02:00
LevelX2
b28bf51c02 * Reworked some more card movement handling (#4866). 2018-05-26 22:39:20 +02:00
Evan Kranzler
07886811f0 Merge branch 'master' of https://github.com/magefree/mage 2018-05-25 19:37:56 -04:00
Evan Kranzler
ac6c68180a Replaced more mana pool errata 2018-05-25 19:37:54 -04:00
LevelX2
fcc6174e5e Some null exceptions checking and fixed some other minor problems. 2018-05-26 01:22:28 +02:00
LevelX2
3972695428 * Some changes to improve mana use of AI. 2018-05-21 11:50:49 +02:00
L_J
994771049c
PlayerStub declareBlocker fix 2018-05-19 08:43:42 +00:00
L_J
bd2a2eebf4
TestPlayer declareBlocker fix 2018-05-19 08:42:07 +00:00
LevelX2
08b9f61749 Removed wrong import in TestPlayer.java. 2018-05-15 14:31:37 +02:00
Oleg Agafonov
ec4bee43d2 * Daxos's Torment - fixed that it can't get Vampire type from Mephidross Vampire; 2018-05-14 02:42:57 +04:00
Oleg Agafonov
4851ba9e84 Test framework: added commands for real time checks/assertions:
* new checks: color, subtype, ability, PT, permanent and hand count;
 * more info in #4936;
2018-05-14 02:31:19 +04:00
LevelX2
21e5591e29 * Some rework of handling of mana effects. 2018-05-13 22:52:14 +02:00
LevelX2
74f05d438f * Fixed that cast conditions of legendary sorceries were checked correctly if you cast a card owned by another player e.g. from exile (fixes #4921). 2018-05-10 08:55:10 +02:00
LevelX2
dcd3e7c039 * Some more fixed/reworked card movement handling. 2018-05-08 23:46:34 +02:00
LevelX2
df987049c0 * Fixed some card movement (fixes #4910). 2018-05-08 18:01:15 +02:00
LevelX2
8afd51fa04 Merge origin/master 2018-05-07 00:45:05 +02:00
LevelX2
bb15176a84 * Fixed token ability (id handling) and token cardType (reset was not correctly done) handling (this fixed problems with copying Planeswalker with Helm of the Host). 2018-05-07 00:44:32 +02:00
Oleg Agafonov
72314a9512 * Fixed 8 cards with "becomes creature attached" effect that it adds colors instead replace it;
* Affected cards: Awaken the Ancient, Corrupted Zendikon, Crusher Zendikon, Deep Freeze, Guardian Zendikon, Living Terrain, Vastwood Zendikon, Wind Zendikon;
2018-05-06 19:07:45 +04:00
Oleg Agafonov
858f210a83 Test framework: added assert color; 2018-05-06 18:57:06 +04:00
Evan Kranzler
7edcec0dc1 fixed ability word text formatting 2018-05-05 14:05:04 -04:00
LevelX2
cddd81123b Some changes related to #4893. 2018-05-03 01:33:21 +02:00
Oleg Agafonov
c24ba742f6 Fixed equal or == errors -- 23 cards and more (see #4407) 2018-04-28 21:24:48 +04:00
LevelX2
7b2ff38225 * Grasp of Fate - Fixed rule text. Fixed that exiled permanents did not return to battlefeild if the Grasp left the battlefield because its owner lost or left the game. 2018-04-24 17:50:35 +02:00
LevelX2
6ebd715e17 * Some minor clean ups. 2018-04-24 11:38:25 +02:00
LevelX2
6bd8f52b66 * Fixed a problem of becomes ColorTargetEffect that causes objects to not always reset to original color. 2018-04-24 11:35:33 +02:00
Oleg Agafonov
dc5908e7f1 Return some ignored tests after massive texts replacements, added new tests for "any target" spells (see prev commit); 2018-04-22 17:54:43 +04:00
Oleg Agafonov
23becf1775 Texts update: to target creature or player => to any target 2018-04-22 08:15:40 +04:00
Oleg Agafonov
6850364fd3 Return some ignored tests after massive texts replacements; 2018-04-22 05:24:08 +04:00
Oleg Agafonov
4e12b06bc7 Fixed not working opponent or planeswalker filter (count all permanents instead planeswalkers); 2018-04-22 04:58:24 +04:00
Evan Kranzler
7deb521a65 more mana pool errata 2018-04-21 18:36:22 -04:00
Evan Kranzler
5c73158708 one more skip 2018-04-20 20:28:50 -04:00
Evan Kranzler
b738141070 skipping some more tests, the issue is with the testing framework and not the game engine 2018-04-20 20:20:23 -04:00
Evan Kranzler
16c081dbf5 fix all the tests 2018-04-20 20:10:26 -04:00
Evan Kranzler
ec3007d141 a few more changes to help with tests 2018-04-20 18:51:15 -04:00
Evan Kranzler
e51b63aea8 a few changes to help with tests 2018-04-20 18:02:33 -04:00
Evan Kranzler
d290c7f26b updated TargetPlayerOrPlaneswalker to be a subclass of TargetPlayerOrPermanent (as well as the respective filters) 2018-04-20 13:34:35 -04:00
Evan Kranzler
92bf8b77de fixed a few tests 2018-04-20 12:58:04 -04:00
Evan Kranzler
5fe607e852 updated targeting for cards that damage 2018-04-19 11:45:20 -04:00
Evan Kranzler
3c2a8ee17d refactored Player.setLife() to include source, some more changes 2018-04-18 21:14:05 -04:00
Evan Kranzler
3798f34c38 refactored Player.gainLife() to include source 2018-04-18 20:30:59 -04:00
Evan Kranzler
ebc6362279 fixed some tests 2018-04-16 19:21:30 -04:00
Oleg Agafonov
a837a4f0f0 Fixed broken tests after mana texts changes 2018-04-16 01:35:37 +04:00
Evan Kranzler
50b5377a8e fixed mana pool errata 2018-04-15 14:30:01 -04:00
Evan Kranzler
41c9b08107 some more fixes 2018-04-15 14:13:44 -04:00
Evan Kranzler
ef33472ee5 fixed some tests and text 2018-04-15 13:50:48 -04:00
Evan Kranzler
df06e9cbf6 temporarily disabled the color-change test(a fix may take a while) and fixed some errors in the Dominaria file 2018-04-14 19:17:57 -04:00
LevelX2
8523d85fb7 * Added a test if color change is reset correctly if target moved zones later (not fixed yet). 2018-04-13 15:25:30 +02:00
LevelX2
03f5b8c2da * Vindictive Lich - Fixed that it did only execute the first effect (fixes #4742). 2018-04-10 23:17:19 +02:00
LevelX2
9b0d130603 * Added tests for #4740. 2018-04-10 11:19:41 +02:00
spjspj
04f6fb5ae0 Beginning of implementation of Planechase.
10 or so initial planes that (mostly) have been tested, no phenomenons as yet and no modifying yet of chaos rolls.  Also no support for a user to be able to set if it is planechase (able to do so via the cheat button).
2018-04-09 20:16:50 +10:00
igoudt
49ee8f9856 add 3 DOM cards, added a token, updated card text 2018-04-08 02:16:52 +02:00
Oleg Agafonov
f6b8d0fea6
Merge pull request #4707 from delftswa2018/feature/SOLID-fix-in-Token-classes
SOLID violation fix in token classes
2018-04-04 18:31:52 +04:00
Marc Zwart
3e32287f00 fixed Token/TokenImpl imports and references 2018-04-03 14:05:41 +02:00
Marc Zwart
d4d8a04694 Extracted Token interface and renamed Token implementation to TokenImpl + renamed tests 2018-04-03 14:04:08 +02:00
LevelX2
1e2e53073c * Deep Analysis - Fixed that its flashback costs did not work with mana casting cost modification effects (fixes #4677). 2018-04-02 15:30:57 +02:00
igoudt
00f91391e9 Homarid Drake, reprints, and rewriting his or her to their 2018-03-22 16:52:26 +01:00
LevelX2
4afdcc860a * Alhammarret, High Arbiter - Fixed not working ability that prevents spell casting (fixes #4561). 2018-03-18 23:38:24 +01:00
LevelX2
d29707bdea * Morph - Fixed that turning creatures face up didn't restore their subtypes (fixes #4566). 2018-03-18 19:37:25 +01:00
LevelX2
b073ce1c42 * Added to all toUpperCase/toLowerCase calls the Locale.ENGLISH to prevent problems with some languages (e.g. Turkish). Removed some unused import statements. (#4634). 2018-03-18 18:18:54 +01:00
igoudt
bd4b5f6300 add Jhoira Weatherlight Captain + tests 2018-03-18 11:55:50 +01:00
igoudt
ddf568679f added 3 Dominari cards, benalish marshal, charge, knight of grace, added a new condition and a new ability 2018-03-18 00:22:03 +01:00
LevelX2
442130beb6 Some minor changes. 2018-03-17 23:40:36 +01:00
igoudt
1405bc87ae unit test shapestealer #2 2018-03-16 18:49:25 +01:00
igoudt
d982e215d6 added shape stealer unittest 2018-03-16 18:47:20 +01:00
LevelX2
b035d85f98 * Fixed a problem that triggered abilities that face down permanents got from other sourced did not trigger (fixes #4571). 2018-03-16 15:06:15 +01:00
LevelX2
8b8b3752e8 * It That Betrays - Fixed that target handling of second triggered ability did not work correct (fixes #4568). 2018-03-16 13:13:25 +01:00
igoudt
5ba017a19b Merge branch 'master' of https://github.com/magefree/mage 2018-03-15 09:34:26 +01:00
igoudt
c3e080141b test for #4618 2018-03-15 09:34:13 +01:00
Jeff
55164eda28 - Fixed Defiant Vanguard. It works with Cloudshift type effects now also. @4572 2018-03-14 17:57:04 -05:00
LevelX2
dac8f2dfe8 Fixed a bug of AI not handling pass action correctly so the AI got passive. Added AI possibility to act after blockers are declared (eg boost for blocking or blocked creatures). 2018-03-10 19:59:59 +01:00
LevelX2
17afa3b3c1 * Added a test. 2018-03-09 15:51:31 +01:00
LevelX2
8c8b4ce019 * Added a check if life of players is going down during infinite loop check. Is so no Draw check message is shown (fixes #4557). 2018-02-28 17:24:42 +01:00
LevelX2
5f98cb685e * Hushwing Gryff - Fixed that log message was sent out too often (fixes #4548). 2018-02-26 16:17:16 +01:00
LevelX2
ba483dd87a * Added a test for the new Blood Moon rule (set to @Ignored) because new rule is not implemented. 2018-02-25 21:59:06 +01:00
LevelX2
2fceafda93 * Fixed a bug that mana in the mana pool could not be used to pay mana costs that could only be payed with "you may spend mana as thought" effects (fixes #2581). 2018-02-25 21:53:47 +01:00
LevelX2
3d372e7100 * Fixed bug of Defiant Vanguard not destroying aby creatures from blocking. Added test. 2018-02-24 12:23:50 +01:00
Oleg Agafonov
5b0e71021d Fixed compile error on getFixedTarget and failed test on new lower names 2018-02-23 16:16:47 +04:00
LevelX2
c5cbdcf68f * Fixed some target pointer handling (fixes #4540). 2018-02-20 17:57:23 +01:00
LevelX2
89b6aeacd6 * Added a test related to #4539. 2018-02-20 16:16:26 +01:00
LevelX2
71ed488c1e * Some deck format tests changed/added. 2018-02-18 18:31:10 +01:00
LevelX2
d80d588963 * Reworked flashback ability (fixes #4482 #3324 #215 #3435 #3883 #3337 #2183 #2447). 2018-02-18 02:52:16 +01:00
LevelX2
fe2eec6553 * Fixed a problem with Animate Dead and bringing creatures with triggered abilities into play that had no targets. It was related to manipulating spellAbility and not copying spellAbility correctly during states copies. (related to #4428). 2018-02-17 11:54:57 +01:00
LevelX2
d10d6361ac * Some minor chnages. 2018-02-14 22:57:57 +01:00
LevelX2
6e4b4a7b69 * Added test for issue #4428 (Animate Dead). 2018-02-13 10:33:08 +01:00
LevelX2
4e4d466549 * Added a test. 2018-02-12 16:56:25 +01:00
LevelX2
6aed62cf02 * Bestow - Fixed a problem that if the target of a bestow enchantment aura got illegal, the bestow permanent did not chnage back to be a creature. 2018-02-12 16:28:44 +01:00
LevelX2
a85fa82de0 * Bestow - Fixed a problem that if the target of a bestow enchantment aura got illegal, the bestow permanent did not chnage back to be a creature. 2018-02-12 15:49:16 +01:00
LevelX2
f0f407457e * Subtypes of tokens were not set back correctly after a subtype changing effect did end (e.g. Arcane Adaptation). 2018-02-12 14:45:05 +01:00
LevelX2
a5f24dfa07 Added tests for scavenge keyword. 2018-02-07 15:36:08 +01:00
LevelX2
557ac244d3 * Fixed that Sift Through Sands failed randomly (fixes #4463). 2018-02-07 11:00:51 +01:00
LevelX2
88d4e2b965 * Bushido - Fixed that it triggerd wrongly for each blocker instead of only once if blocked. 2018-02-04 21:13:07 +01:00
LevelX2
0044c9df78 Added converge test with artifact mana sources. 2018-02-04 20:33:37 +01:00
LevelX2
b752eacfaa * Optimized handling and call of player.choose choice to prevent problems if a player disconnects or left a game (#4263). 2018-02-04 17:51:12 +01:00
LevelX2
4dd196f373 * Fixed some problems with getting cards at random from collection that could cause loops. 2018-02-04 12:27:08 +01:00
LevelX2
55b66315af * Some formatting. 2018-02-03 10:49:08 +01:00
Oleg Agafonov
b114eaa828 Tests: added ai vs ai load testing 2018-01-28 15:12:00 +04:00
Oleg Agafonov
9268281c4b Tests: fixed random gen deck 2018-01-27 15:49:24 +04:00
Oleg Agafonov
78ff3c3714 Tests: added game start mode to load testing 2018-01-27 14:52:34 +04:00
Oleg Agafonov
85d8d665aa Tests: rewrite load tests for server stability and performance testing (see #4448) 2018-01-27 14:02:24 +04:00
Oleg Agafonov
ba4fee11f6 Fixed weird errors with server lost of player priority on lagged games (see #4448) 2018-01-27 13:59:38 +04:00
Achilles
6c59c2e4fd - Added extra test for Starfield of Nyx. 2018-01-16 17:48:26 -06:00
Achilles
6da1112a89 - Code by Noxx to address the Blood Moon/Urborgtoy layering issue. Layer test updated. 2018-01-15 18:47:42 -06:00
Achilles
7ade17595d - Aftermath keyword works again. Added test for Aftermath keyword. 2018-01-12 23:58:38 -06:00
Oleg Agafonov
af113d4ed1 Fixed cards that broken whole server (see #4402) 2018-01-12 21:23:49 +04:00