Commit graph

1747 commits

Author SHA1 Message Date
magenoxx
784a4b8089 #3153: fixed flashback test by specifying correct target order 2017-04-18 17:33:58 +03:00
LevelX2
fb6bd25d85 * Soulstinger - Fixed a bug that a -1/-1 counter was put on target even if Soulstinger had no counters on it. 2017-04-17 20:11:01 +02:00
Derek Monturo
c1bc3b0bc2 ut for #3132 confirming issue with dread return 2017-04-17 11:51:52 -04:00
Derek Monturo
15fba941ef fixes #3124 and unit test for #3125 duplicating issue 2017-04-17 11:11:48 -04:00
LevelX2
ef4cf90a0f Release 1.4.23V0 2017-04-17 10:53:59 +02:00
Mark Langen
6912e45310 Merge branch 'master' of https://github.com/magefree/mage 2017-04-08 20:03:57 -06:00
Mark Langen
f96a1532bf Add Approach of the Second Sun [AKH] + test 2017-04-08 20:03:23 -06:00
drmDev
b7c903fc55 #3075 ut does not confirm bug with behind scenes 2017-04-08 13:16:35 -04:00
Mark Langen
40870f22c2 Added a bunch of spoiled cards for 4/5
* Added Colossapede
* Added Cut // Ribbons
* Added Insult // Injury (+test)
* Added Mouth // Feed
* Added Pouncing Cheetah
* Added Scarab Feast
* Added Rags // Riches (+test)
2017-04-05 22:41:56 -06:00
Mark Langen
a2e8cedd02 Merge branch 'master' into akh-card-frame 2017-04-04 18:36:37 -06:00
Mark Langen
7a6b8a1540 Final Aftermath implementation stuff
* Fixed PlayerImpl::getPlayable() to support aftermath (Needs PLAY_FROM_NOT_OWN_HAND_ZONE at the granularity of each card half rather than the whole card)
* Added tests for Dusk // Dawn to make sure there are no regressions on Aftermath.
2017-04-04 18:28:30 -06:00
ingmargoudt
ff6d1541c3 clientcallbacks to enums 2017-04-04 21:52:15 +02:00
Derek Monturo
eec4c07726 #3048 unit test for vexing devil redirect planeswalker interaction. unable to duplicate issue 2017-04-04 10:50:14 -04:00
LevelX2
45818f3a51 * Celestial Dawn - Fixed that it was not possible to pay colorless costs with non white mana. 2017-04-04 15:32:39 +02:00
Mark Langen
a96a7f89f5 Work in progress changes for Amonket Aftermath ability.
* Card Rendering has support for Aftermath Split card frames
* Card Rendering has support for Split cards
* Aftermath ability work in progress
2017-04-03 04:15:25 -06:00
ingmargoudt
211d433ea9 playertype, enum singleton 2017-04-02 22:09:20 +02:00
Derek M
b19170f34f Merge pull request #3045 from SickBoyWi/master
Implemented Soul Burn card for the two sets it's a part of: Ice Age a…
2017-04-02 12:17:32 -04:00
LevelX2
097a8ce0dd Some rework to end turn logic and removing of stack objects (related to #2977). 2017-04-02 15:18:50 +02:00
LevelX2
15c1c7f8c0 * Fixed a problem with flashback ability and variable non mana costs (related to #2436). 2017-04-02 10:11:25 +02:00
ingmargoudt
594ffa2754 rewrote some streams and optionals 2017-04-01 22:45:40 +02:00
LevelX2
d0bf77cedf * Fixed a problem with replacement effects that add counters were applied more than once to the same EnteresTheBattlefield event (fixes #2872). 2017-04-01 17:43:17 +02:00
Johnny.Hastings@gmail.com
2be3f20320 Implemented Soul Burn card for the two sets it's a part of: Ice Age and Invasion. 2017-03-31 18:33:17 -05:00
LevelX2
94f77675ec * Reverted NykthosDevotion test commented out lines. 2017-04-01 00:53:47 +02:00
ingmargoudt
884ae83791 Merge pull request #3042 from ingmargoudt/card_functions
move static function to CardImpl, and other api fixes
2017-03-31 18:52:37 +02:00
Derek Monturo
1b9585ead7 #2872 added UT confirming bug for hangerback walker interaction 2017-03-31 11:00:08 -04:00
drmDev
f79ed5469d #3002 updated UT for firecat 2017-03-30 21:56:59 -04:00
ingmargoudt
6f8f10fcc3 move static function to CardImpl, and other api fixes 2017-03-30 20:09:47 +02:00
drmDev
cbf5f38d84 #3039 confirmed nykthos bug by UT 2017-03-29 19:57:17 -04:00
fireshoes
55b433ae36 [AKH] Added 3/27 spoilers to mtg-cards-data.txt. Implemented several of the new cards. 2017-03-28 22:25:29 -05:00
Derek M
b68bfdf4c2 Merge pull request #3032 from ingmargoudt/type_api
Type api
2017-03-28 22:48:02 -04:00
Derek Monturo
31d238df5d #2984 UT confirming bug 2017-03-28 12:57:45 -04:00
Derek Monturo
3810f3ad2d #3002 UT confirming bug with firecat blitz 2017-03-28 11:08:57 -04:00
drmDev
c25361202a minor fixes - remove inconsistent test, make isperia ability non-optional 2017-03-27 23:36:06 -04:00
drmDev
29b03fb3ed Closes #3030 UT for child of alara unable to duplicate 2017-03-27 22:41:08 -04:00
ingmargoudt
0879298e92 refactor cards to use supertype enum 2017-03-27 21:56:33 +02:00
Achilles
ed37c5db8d - Removed a test case from ReturnToHandEffectsTest that was inconsistent with the game engine. I tested the scenario and it worked fine. 2017-03-26 16:56:02 -05:00
Derek M
1a9c5fa469 Merge pull request #3014 from drmDev/bug/sphereCosts
fixes #3012 manaCosts not null check and way to retrieve it
2017-03-24 08:06:30 -04:00
drmDev
be62b11d2f #3005 halimar tidecaller unit test. unable to duplicate issue. 2017-03-23 23:52:02 -04:00
drmDev
94c8d7f387 #3017 unit tests for declaration in stone. cannot duplicate issue 2017-03-23 23:38:03 -04:00
drmDev
097d60f5fc fixes #3012 manaCosts not null check and way to retrieve it 2017-03-23 10:25:21 -04:00
Derek M
cf831eea28 Merge pull request #3007 from kubikrubikvkube/master
Enums should be compared with == but not equals()
2017-03-22 16:17:07 -04:00
Derek M
9c3aab3284 Merge pull request #3009 from Alexsandr0x/Citadel-of-Pain
Citadel of Pain
2017-03-22 16:16:21 -04:00
Alexsandro
0d0bba7f57 Fiz turns to pass in unit test 2017-03-22 13:14:15 -03:00
Alexsandro
bfb2b07ba6 Create unit tests 2017-03-22 13:09:49 -03:00
vraskulin
d3214c65e4 Merge remote-tracking branch 'fork/master' 2017-03-22 14:51:31 +03:00
vraskulin
d93061c0bc Equals should be compared with == but not equals() 2017-03-22 14:50:50 +03:00
vraskulin
f37c823aa8 String + string concatenation can be replaced by string + char concetenation 2017-03-20 14:00:18 +03:00
drmDev
fb37dcd5f1 #2995 unable to duplicate by unit tests 2017-03-19 22:09:29 -04:00
LevelX2
bc81f7974a Merge pull request #2992 from ingmargoudt/optionals
rewrites to optionals
2017-03-19 23:27:09 +01:00
drmDev
311e41abd2 refactored exiletokensAtEndStep 2017-03-19 17:54:07 -04:00
ingmargoudt
ff6c6405aa rewrites to optionals 2017-03-19 19:48:32 +01:00
drmDev
c109fc8a0e Implemented card Lightning Coils and test for it 2017-03-19 12:23:58 -04:00
drmDev
0d1c846cd5 #2989 cannot duplicate medomai issue with UT 2017-03-19 10:44:59 -04:00
drmDev
286eca3116 closes #2625 unable to duplicate with UT 2017-03-18 14:44:38 -04:00
drmDev
0e5ba16ac1 #2983 confirmed bug with skyfire kirin 2017-03-18 09:32:28 -04:00
drmDev
212385e876 #2841 UT unable to duplicate 2017-03-17 21:30:29 -04:00
drmDev
329ac6d980 #2970 UT unable to duplicate issue 2017-03-17 21:09:06 -04:00
drmDev
4aaea107a0 #2409 cannot duplicate with UT 2017-03-17 17:59:32 -04:00
Derek Monturo
35b8e55f0f initial test setup 2017-03-17 17:59:32 -04:00
LevelX2
68d398c6fb Merge pull request #2968 from ingmargoudt/singleton-as-enum
rewrote singleton to enum where applicable
2017-03-16 17:02:31 +01:00
LevelX2
63e9ca9266 Merge pull request #2969 from Alexsandr0x/Machinate
Implement Machinate + unitTests
2017-03-16 17:00:18 +01:00
Alexsandro
17bccde39d Implement Machinate + unitTests 2017-03-14 17:22:16 -03:00
ingmargoudt
234cfe9519 rewrote singleton to enum where applicable 2017-03-14 16:32:47 +01:00
LevelX2
9d8a8a33f1 Xmage 1.4.22V0 2017-03-11 13:38:55 +01:00
LevelX2
c042d50ec7 Fixed a bug that fizzling spell copies let also wrongly fizzle the original spell on the stack the copy was made from. 2017-03-11 12:00:05 +01:00
LevelX2
7843187bc7 Merge pull request #2958 from JRHerlehy/master
Implement Bloodbond March
2017-03-11 09:41:41 +01:00
Justin Herlehy
3e60eb7780 Implement Bloodbond March 2017-03-11 00:01:51 -08:00
Nathaniel Brandes
900d68f77d Fix CMC for flashbacked cards.
This should fix Conflagate/Chalice of the Void interaction.
2017-03-09 23:32:42 -08:00
Nathaniel Brandes
d7d700f66a Some clarification around loyalty. Added unit test. 2017-03-09 02:30:52 -08:00
Nathaniel Brandes
dd0c89db1d Fix Dack Fayden Emblem.
The emblem's effect was referencing the permanent directly.
This meant that if the permanent left and came back, the control effect
would start working again.
2017-03-09 02:24:34 -08:00
Justin Herlehy
9dd1e60f2d Implement Clutch of Undeath
Implement Clutch of Undeath and add test to ensure functionality.
2017-03-09 01:48:34 -08:00
Justin Herlehy
1a2724c9b2 Revert: Fix planeswalker loyalty counters.
This change was incorrect.

Gatherer Ruling:
10/1/2005: Planeswalkers will enter the battlefield with double the normal amount of loyalty counters. However, if you activate an ability whose cost has you put loyalty counters on a planeswalker, the number you put on isn’t doubled. This is because those counters are put on as a cost, not as an effect.
2017-03-09 01:14:10 -08:00
Nathaniel Brandes
52fa369024 Fix planeswalker loyalty counters.
They should be added like normal counters, firing events that can be
intercepted by cards like doubling season.
2017-03-08 23:57:11 -08:00
Nathaniel Brandes
ce1f4a3bf8 Phyrexian mana now correctly a payment choice.
Per rule 601.2b, it is not determined at the pay costs step,
but at the "choice" step, long before costs are determined.

This fixes trinisphere interactions and should be consistent with the
rules.
2017-03-08 20:03:28 -08:00
Jeff
209e2d13c1 - Fix for Spellskite in situations where it was also a target. Fixed the test for Spellskite. 2017-03-08 12:05:36 -06:00
Achilles
f5d13944a6 - Test for Auratouched Mage. The tests worked fine in the game, but the test suite can't handle it yet. 2017-03-07 20:52:13 -06:00
Derek M
2ff68c2fb3 Merge pull request #2944 from Alexsandr0x/sakashima-bug
SpellStutter Sprite - Sakashima Impostor Bug
2017-03-07 16:10:06 -05:00
Alexsandro
b83bc9d68a Assert if Sakashima copied SpellStutter by S/T 2017-03-06 21:11:09 -03:00
Derek Monturo
3b6ffe9382 #2157 Linvala tests on activated abilities 2017-03-06 17:02:23 -05:00
Derek Monturo
e28dd5aef7 minor added another assert 2017-03-06 16:34:52 -05:00
Derek Monturo
f93524a0f7 #2135 added test for clever impersonator copying an aura 2017-03-06 16:32:40 -05:00
Alexsandro
d98e43ded2 Create test class to validate error 2017-03-06 16:15:17 -03:00
Alexsandro
6fb344a306 Create test class to validate error 2017-03-06 16:15:02 -03:00
Derek Monturo
c53c0d2e9e #2832 test for Athreos not triggering on Cartel sac ability 2017-03-06 14:12:38 -05:00
drmDev
2aa1ee2471 minor mod 2017-03-05 12:17:17 -05:00
drmDev
594e22a245 tests for GrandArbiter cost reduction and increase based on reported bug. unconfirmed 2017-03-05 12:16:12 -05:00
drmDev
c8e41bc002 Phyrexian Purge impl and tests 2017-03-05 10:37:05 -05:00
drmDev
4bfa956368 more tests for Nacatl must be blocked 2017-03-05 07:54:55 -05:00
ingmargoudt
b5e8c88153 remove all contains(cardtype.XX) references, instead use the default interface method 2017-03-05 09:14:33 +01:00
Nathaniel Brandes
1d3ebb749d Fix omniscience effect for colorless mana.
Also unified the tests for omniscience into a single file, and
put the effect into a single class so that Tamiyo and Omniscience
can share implementations.
2017-03-04 23:04:11 -08:00
drmDev
6d20c7a996 added test for Nacatl War-Pride 2017-03-04 18:54:29 -05:00
ingmargoudt
5a57731968 added new helper methods to test for CardType, to get rid of the contains(CardType.XXX) everywhere, put the logic of that in one place and use the interface call 2017-03-04 00:16:36 +01:00
ingmargoudt
372584f7ad changed cardtype from list to enumset 2017-03-03 17:04:32 +01:00
vraskulin
11dc1e10f1 Few lambda's and removed explicit type from creating lists and hashmaps 2017-02-28 13:46:57 +03:00
vraskulin
0a3c95dde5 Inner classes should be static. It reduces memory usage and gives perfomance boost + DeckImporter rollback 2017-02-28 12:40:12 +03:00
doncarton
5eaaa67d1e Nulls to optional. Also there was bug with AetherChaser "you may pay" was not set to optional 2017-02-26 15:15:54 +03:00
Goesta
e9d103b70e Fixed BouncingACrewedVehicle test 2017-02-22 23:25:15 +01:00
ingmargoudt
a98df9a28e fix javadoc 2017-02-19 09:13:19 +01:00
ingmargoudt
9ea690797f the card should still be exiled.
added a method to test exile count per player
added a test for chandrapyromaster
2017-02-19 09:09:43 +01:00
LevelX2
899046cf16 * Gratuitous Violence - FIxed that if the damage of a creature with lifelink was doubeled only the non doubled amount was added to life. 2017-02-18 01:26:02 +01:00